From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> To: robdclark@gmail.com Cc: dmitry.baryshkov@linaro.org, sean@poorly.run, airlied@linux.ie, daniel@ffwll.ch, maxime@cerno.tech, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, kernel@collabora.com, konrad.dybcio@somainline.org, marijn.suijten@somainline.org, jami.kettunen@somainline.org, martin.botka@somainline.org, AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Subject: [PATCH v3 0/2] drm/msm: Fix dsi/bridge probe Date: Wed, 1 Dec 2021 11:52:08 +0100 [thread overview] Message-ID: <20211201105210.24970-1-angelogioacchino.delregno@collabora.com> (raw) Context, from patch 2/2: Since commit 8f59ee9a570c ("drm/msm/dsi: Adjust probe order"), the DSI host gets initialized earlier, but this caused unability to probe the entire stack of components because they all depend on interrupts coming from the main `mdss` node (mdp5, or dpu1). Changes in v3: - Removed a forgotten (and wrong) kfree() call. Series v2: After a very nice conversation with Dmitry, it turned out that my first approach to solve this issue wasn't great: even though it appeared to actually work, it was introducing a number of issues, one of which was critical as it was not removing down the DRM device when it's supposed to. Instead of actually fixing that patch, I went for "simplifying" the approach by not initializing the entire MDSS, but just the interrupt controller, which still untangles the infinite probe deferrals, but actually doesn't even touch most of the already present logic in place. AngeloGioacchino Del Regno (2): drm/msm: Allocate msm_drm_private early and pass it as driver data drm/msm: Initialize MDSS irq domain at probe time drivers/gpu/drm/msm/adreno/adreno_device.c | 16 ++--- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 4 +- drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c | 50 ++++++++++------ drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 3 +- drivers/gpu/drm/msm/disp/mdp5/mdp5_mdss.c | 58 ++++++++++++------ drivers/gpu/drm/msm/dp/dp_display.c | 10 +--- drivers/gpu/drm/msm/dsi/dsi.c | 6 +- drivers/gpu/drm/msm/edp/edp.c | 6 +- drivers/gpu/drm/msm/hdmi/hdmi.c | 7 +-- drivers/gpu/drm/msm/msm_drv.c | 68 +++++++++++++--------- drivers/gpu/drm/msm/msm_kms.h | 3 + 11 files changed, 133 insertions(+), 98 deletions(-) -- 2.33.1
WARNING: multiple messages have this Message-ID (diff)
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> To: robdclark@gmail.com Cc: freedreno@lists.freedesktop.org, airlied@linux.ie, linux-arm-msm@vger.kernel.org, konrad.dybcio@somainline.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, jami.kettunen@somainline.org, martin.botka@somainline.org, maxime@cerno.tech, dmitry.baryshkov@linaro.org, marijn.suijten@somainline.org, kernel@collabora.com, sean@poorly.run, AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Subject: [PATCH v3 0/2] drm/msm: Fix dsi/bridge probe Date: Wed, 1 Dec 2021 11:52:08 +0100 [thread overview] Message-ID: <20211201105210.24970-1-angelogioacchino.delregno@collabora.com> (raw) Context, from patch 2/2: Since commit 8f59ee9a570c ("drm/msm/dsi: Adjust probe order"), the DSI host gets initialized earlier, but this caused unability to probe the entire stack of components because they all depend on interrupts coming from the main `mdss` node (mdp5, or dpu1). Changes in v3: - Removed a forgotten (and wrong) kfree() call. Series v2: After a very nice conversation with Dmitry, it turned out that my first approach to solve this issue wasn't great: even though it appeared to actually work, it was introducing a number of issues, one of which was critical as it was not removing down the DRM device when it's supposed to. Instead of actually fixing that patch, I went for "simplifying" the approach by not initializing the entire MDSS, but just the interrupt controller, which still untangles the infinite probe deferrals, but actually doesn't even touch most of the already present logic in place. AngeloGioacchino Del Regno (2): drm/msm: Allocate msm_drm_private early and pass it as driver data drm/msm: Initialize MDSS irq domain at probe time drivers/gpu/drm/msm/adreno/adreno_device.c | 16 ++--- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 4 +- drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c | 50 ++++++++++------ drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 3 +- drivers/gpu/drm/msm/disp/mdp5/mdp5_mdss.c | 58 ++++++++++++------ drivers/gpu/drm/msm/dp/dp_display.c | 10 +--- drivers/gpu/drm/msm/dsi/dsi.c | 6 +- drivers/gpu/drm/msm/edp/edp.c | 6 +- drivers/gpu/drm/msm/hdmi/hdmi.c | 7 +-- drivers/gpu/drm/msm/msm_drv.c | 68 +++++++++++++--------- drivers/gpu/drm/msm/msm_kms.h | 3 + 11 files changed, 133 insertions(+), 98 deletions(-) -- 2.33.1
next reply other threads:[~2021-12-01 10:52 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-12-01 10:52 AngeloGioacchino Del Regno [this message] 2021-12-01 10:52 ` [PATCH v3 0/2] drm/msm: Fix dsi/bridge probe AngeloGioacchino Del Regno 2021-12-01 10:52 ` [PATCH v3 1/2] drm/msm: Allocate msm_drm_private early and pass it as driver data AngeloGioacchino Del Regno 2021-12-01 10:52 ` AngeloGioacchino Del Regno 2021-12-01 10:52 ` [PATCH v3 2/2] drm/msm: Initialize MDSS irq domain at probe time AngeloGioacchino Del Regno 2021-12-01 10:52 ` AngeloGioacchino Del Regno 2021-12-01 20:20 ` [PATCH] " Dmitry Baryshkov 2021-12-01 20:20 ` Dmitry Baryshkov 2021-12-03 10:43 ` AngeloGioacchino Del Regno 2021-12-03 10:43 ` AngeloGioacchino Del Regno 2021-12-03 13:14 ` Dmitry Baryshkov 2021-12-03 13:14 ` Dmitry Baryshkov 2021-12-03 13:17 ` AngeloGioacchino Del Regno 2021-12-03 13:17 ` AngeloGioacchino Del Regno
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20211201105210.24970-1-angelogioacchino.delregno@collabora.com \ --to=angelogioacchino.delregno@collabora.com \ --cc=airlied@linux.ie \ --cc=daniel@ffwll.ch \ --cc=dmitry.baryshkov@linaro.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=freedreno@lists.freedesktop.org \ --cc=jami.kettunen@somainline.org \ --cc=kernel@collabora.com \ --cc=konrad.dybcio@somainline.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=marijn.suijten@somainline.org \ --cc=martin.botka@somainline.org \ --cc=maxime@cerno.tech \ --cc=robdclark@gmail.com \ --cc=sean@poorly.run \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.