Re: [PATCH 12/14] drm: bridge: icn6211: Add I2C configuration support

From: kernel test robot <lkp@intel.com>
To: Marek Vasut <marex@denx.de>, dri-devel@lists.freedesktop.org
Cc: Marek Vasut <marex@denx.de>,
	kbuild-all@lists.01.org, Robert Foss <robert.foss@linaro.org>,
	Jagan Teki <jagan@amarulasolutions.com>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [PATCH 12/14] drm: bridge: icn6211: Add I2C configuration support
Date: Fri, 14 Jan 2022 18:24:29 +0800	[thread overview]
Message-ID: <202201141818.0EmBjuCm-lkp@intel.com> (raw)
In-Reply-To: <20220114034838.546267-12-marex@denx.de>

Hi Marek,

I love your patch! Perhaps something to improve:

[auto build test WARNING on drm/drm-next]
[also build test WARNING on drm-intel/for-linux-next drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next v5.16 next-20220114]
[cannot apply to drm-tip/drm-tip airlied/drm-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Marek-Vasut/drm-bridge-icn6211-Fix-register-layout/20220114-115112
base:   git://anongit.freedesktop.org/drm/drm drm-next
config: h8300-buildonly-randconfig-r001-20220113 (https://download.01.org/0day-ci/archive/20220114/202201141818.0EmBjuCm-lkp@intel.com/config)
compiler: h8300-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/730ece8a3c97460eaf81603bc246cd631d1f7461
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Marek-Vasut/drm-bridge-icn6211-Fix-register-layout/20220114-115112
        git checkout 730ece8a3c97460eaf81603bc246cd631d1f7461
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=h8300 SHELL=/bin/bash drivers/gpu/drm/bridge/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/gpu/drm/bridge/chipone-icn6211.c: In function 'chipone_attach':
>> drivers/gpu/drm/bridge/chipone-icn6211.c:454:28: warning: variable 'abridge' set but not used [-Wunused-but-set-variable]
     454 |         struct drm_bridge *abridge = bridge;
         |                            ^~~~~~~

vim +/abridge +454 drivers/gpu/drm/bridge/chipone-icn6211.c

   450	
   451	static int chipone_attach(struct drm_bridge *bridge, enum drm_bridge_attach_flags flags)
   452	{
   453		struct chipone *icn = bridge_to_chipone(bridge);
 > 454		struct drm_bridge *abridge = bridge;
   455		int ret;
   456	
   457		if (icn->interface_i2c) {
   458			ret = chipone_dsi_setup(icn);
   459			if (ret)
   460				return ret;
   461	
   462			abridge = &icn->bridge;
   463		}
   464	
   465		return drm_bridge_attach(bridge->encoder, icn->panel_bridge,
   466					 bridge, flags);
   467	}
   468	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org