From: David Summers <beagleboard-8lkWs+DogrrqRUWtDFdff/XRex20P6io@public.gmane.org> To: Stefan Wahren <stefan.wahren-eS4NqCHxEME@public.gmane.org>, heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org Cc: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Subject: Re: [PATCH 2/3] ARM: dts: rk3288 Tinker Board (S) add wi-fi Date: Mon, 18 Feb 2019 20:26:02 +0000 [thread overview] Message-ID: <3e9a387c-2ebc-c762-6222-90efc851e4ed@davidjohnsummers.uk> (raw) In-Reply-To: <1528638260.343699.1550436208775-uEpKuDZ350hmhno068Nerg@public.gmane.org> On 17/02/2019 20:43, Stefan Wahren wrote: > Hi David, > >> David Summers <beagleboard-8lkWs+DogrrqRUWtDFdff/XRex20P6io@public.gmane.org> hat am 17. Februar 2019 um 13:15 geschrieben: >> >> >> + >> + sdio_pwrseq: sdio-pwrseq { >> + compatible = "mmc-pwrseq-simple"; >> + clocks = <&rk808 RK808_CLKOUT1>; >> + clock-names = "ext_clock"; >> + pinctrl-names = "default"; >> + pinctrl-0 = <&wifi_enable>; > As i wrote at the Arch board it would be nice to keep the Asus comment here: > > /* > * On the module itself this is one of these (depending > * on the actual card populated): > * - SDIO_RESET_L_WL_REG_ON > * - PDN (power down when low) > */ > Sorry Stefan, I'm with Robin on this one. Three reasons: 1) When you look at where ASUS added these comments: https://github.com/TinkerBoard/debian_kernel/commit/6a3128ade33f758887048578ada61a4b7ab8e678 They has only added RK_PD4 = 28 So at best to only applies to that change. 2) If you look at datasheet: http://files.pine64.org/doc/datasheet/pine64/RTL8723BS.pdf http://cit.odessa.ua/media/pdf/Intel-Compute-Stick/FN-Link_F23BDSM25-W1.pdf Then neither of the two pins are mentioned, and the comment is not helpful 3) Should dts have comments in? Over time I'm got to like git, and that you click on blame. That is what showed in post one that the comment only applied to one pin. To me blame point to the patch - and that usually gives more details. Its why I explain that we don't know what these two pins are attached to - this doesn't sound good, but actually its all we know. So it explains things. So I now think that dts should have very few comments in, and only where they *really* add something. In this case we don't know what the comment means .. >> + reset-gpios = <&gpio4 RK_PD3 GPIO_ACTIVE_LOW>, <&gpio4 RK_PD4 GPIO_ACTIVE_LOW>; >> + }; >> }; >> >> &cpu0 { >> @@ -337,8 +345,8 @@ >> >> &io_domains { >> status = "okay"; >> - > Please drop this whitespace change Most {} in dts don't have white space line in - only between {} {}. So a white space line in the middle of a single {} is unusual. I can't see what its needed for, or what it makes clearer. So to me removing makes it more in line with everything else. If people are unhappy though I'll add the white line back in again. >> sdcard-supply = <&vccio_sd>; >> + wifi-supply = <&vcc_18>; >> }; >> >> &pinctrl { >> @@ -417,6 +425,12 @@ >> rockchip,pins = <7 8 RK_FUNC_GPIO &pcfg_pull_none>; >> }; >> }; >> + >> + sdio { >> + wifi_enable: wifi-enable { >> + rockchip,pins = <4 RK_PD3 RK_FUNC_GPIO &pcfg_pull_none>, <4 RK_PD4 RK_FUNC_GPIO &pcfg_pull_none>; > Please make a line break after the first pin definition Yes that makes sense David
WARNING: multiple messages have this Message-ID (diff)
From: David Summers <beagleboard@davidjohnsummers.uk> To: Stefan Wahren <stefan.wahren@i2se.com>, heiko@sntech.de, robh+dt@kernel.org, mark.rutland@arm.com Cc: linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org Subject: Re: [PATCH 2/3] ARM: dts: rk3288 Tinker Board (S) add wi-fi Date: Mon, 18 Feb 2019 20:26:02 +0000 [thread overview] Message-ID: <3e9a387c-2ebc-c762-6222-90efc851e4ed@davidjohnsummers.uk> (raw) In-Reply-To: <1528638260.343699.1550436208775@email.ionos.de> On 17/02/2019 20:43, Stefan Wahren wrote: > Hi David, > >> David Summers <beagleboard@davidjohnsummers.uk> hat am 17. Februar 2019 um 13:15 geschrieben: >> >> >> + >> + sdio_pwrseq: sdio-pwrseq { >> + compatible = "mmc-pwrseq-simple"; >> + clocks = <&rk808 RK808_CLKOUT1>; >> + clock-names = "ext_clock"; >> + pinctrl-names = "default"; >> + pinctrl-0 = <&wifi_enable>; > As i wrote at the Arch board it would be nice to keep the Asus comment here: > > /* > * On the module itself this is one of these (depending > * on the actual card populated): > * - SDIO_RESET_L_WL_REG_ON > * - PDN (power down when low) > */ > Sorry Stefan, I'm with Robin on this one. Three reasons: 1) When you look at where ASUS added these comments: https://github.com/TinkerBoard/debian_kernel/commit/6a3128ade33f758887048578ada61a4b7ab8e678 They has only added RK_PD4 = 28 So at best to only applies to that change. 2) If you look at datasheet: http://files.pine64.org/doc/datasheet/pine64/RTL8723BS.pdf http://cit.odessa.ua/media/pdf/Intel-Compute-Stick/FN-Link_F23BDSM25-W1.pdf Then neither of the two pins are mentioned, and the comment is not helpful 3) Should dts have comments in? Over time I'm got to like git, and that you click on blame. That is what showed in post one that the comment only applied to one pin. To me blame point to the patch - and that usually gives more details. Its why I explain that we don't know what these two pins are attached to - this doesn't sound good, but actually its all we know. So it explains things. So I now think that dts should have very few comments in, and only where they *really* add something. In this case we don't know what the comment means .. >> + reset-gpios = <&gpio4 RK_PD3 GPIO_ACTIVE_LOW>, <&gpio4 RK_PD4 GPIO_ACTIVE_LOW>; >> + }; >> }; >> >> &cpu0 { >> @@ -337,8 +345,8 @@ >> >> &io_domains { >> status = "okay"; >> - > Please drop this whitespace change Most {} in dts don't have white space line in - only between {} {}. So a white space line in the middle of a single {} is unusual. I can't see what its needed for, or what it makes clearer. So to me removing makes it more in line with everything else. If people are unhappy though I'll add the white line back in again. >> sdcard-supply = <&vccio_sd>; >> + wifi-supply = <&vcc_18>; >> }; >> >> &pinctrl { >> @@ -417,6 +425,12 @@ >> rockchip,pins = <7 8 RK_FUNC_GPIO &pcfg_pull_none>; >> }; >> }; >> + >> + sdio { >> + wifi_enable: wifi-enable { >> + rockchip,pins = <4 RK_PD3 RK_FUNC_GPIO &pcfg_pull_none>, <4 RK_PD4 RK_FUNC_GPIO &pcfg_pull_none>; > Please make a line break after the first pin definition Yes that makes sense David _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-02-18 20:26 UTC|newest] Thread overview: 116+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-02-17 12:15 [PATCH 0/3] ARM: dts: rk3288 Tinker Board (S) updates David Summers 2019-02-17 12:15 ` David Summers 2019-02-17 12:15 ` [PATCH 1/3] ARM: dts: rk3288 Tinker Board (S) sdcard changes David Summers 2019-02-17 12:15 ` David Summers 2019-02-17 14:00 ` Robin Murphy 2019-02-17 14:00 ` Robin Murphy 2019-02-17 15:19 ` David Summers 2019-02-17 15:19 ` David Summers 2019-02-18 11:54 ` Robin Murphy 2019-02-18 11:54 ` Robin Murphy 2019-02-19 20:13 ` David Summers 2019-02-19 20:13 ` David Summers [not found] ` <20190217121513.22965-2-beagleboard-8lkWs+DogrrqRUWtDFdff/XRex20P6io@public.gmane.org> 2019-02-17 20:29 ` Stefan Wahren 2019-02-17 20:29 ` Stefan Wahren [not found] ` <1660942499.343639.1550435365757-uEpKuDZ350hmhno068Nerg@public.gmane.org> 2019-02-18 20:08 ` David Summers 2019-02-18 20:08 ` David Summers 2019-02-22 18:47 ` [PATCH 1/3 v2] ARM: dts: rk3288-tinker.dtsi: Fix SD card detection David Summers [not found] ` <20190222184708.32004-1-beagleboard-8lkWs+DogrrqRUWtDFdff/XRex20P6io@public.gmane.org> 2019-02-24 19:26 ` Jonas Karlman 2019-02-24 19:26 ` Jonas Karlman [not found] ` <AM3PR03MB096656098C6CB4712C73C095AC790-XQTXrJX/giFAc9da7WRX18eAHadYHfrlvxpqHgZTriW3zl9H0oFU5g@public.gmane.org> 2019-02-24 19:35 ` David Summers [not found] ` <5387a001-1036-bb5c-e781-18e87ca6e7bd-8lkWs+DogrrqRUWtDFdff/XRex20P6io@public.gmane.org> 2019-02-24 19:56 ` Jonas Karlman [not found] ` <AM3PR03MB09663F32FC40000E42C1A722AC790-XQTXrJX/giFAc9da7WRX18eAHadYHfrlvxpqHgZTriW3zl9H0oFU5g@public.gmane.org> 2019-02-24 20:10 ` David Summers [not found] ` <e1f1a93e-505b-bf53-a253-5c1ddaeaebf8-8lkWs+DogrrqRUWtDFdff/XRex20P6io@public.gmane.org> 2019-02-24 22:54 ` Heiko Stübner 2019-02-24 22:54 ` Heiko Stübner 2019-02-25 8:59 ` Jonas Karlman 2019-02-25 21:00 ` David Summers [not found] ` <31863095-94b5-5fec-0293-b30172426b93-8lkWs+DogrrqRUWtDFdff/XRex20P6io@public.gmane.org> 2019-02-25 21:14 ` Doug Anderson 2019-02-25 17:13 ` Doug Anderson [not found] ` <CAD=FV=UkQ7pEan4aGezvQZZjBc0gDJ1R7YRbN1Lbv9HBVQRgHQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2019-02-25 21:11 ` David Summers [not found] ` <9e90c5dd-7b1e-9e53-81ac-fb3b515215ca-8lkWs+DogrrqRUWtDFdff/XRex20P6io@public.gmane.org> 2019-02-25 21:18 ` Doug Anderson [not found] ` <CAD=FV=XEPKpDVLdpCVB9eMzJNE8C5Pr=fRgRmJXgxzrDFJ39mQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2019-02-25 22:20 ` Heiko Stübner 2019-02-26 14:46 ` Robin Murphy [not found] ` <108411d8-9607-d92d-e546-d0c85bcabc51-5wv7dgnIgG8@public.gmane.org> 2019-02-26 16:43 ` Doug Anderson [not found] ` <CAD=FV=X0rRPkEim1sHS9EqDCLiWPO7e5Vu-0gAcX7YZ_omeKPw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2019-02-27 13:48 ` Robin Murphy 2019-03-03 11:08 ` David Summers 2019-02-17 12:15 ` [PATCH 2/3] ARM: dts: rk3288 Tinker Board (S) add wi-fi David Summers 2019-02-17 12:15 ` David Summers [not found] ` <20190217121513.22965-3-beagleboard-8lkWs+DogrrqRUWtDFdff/XRex20P6io@public.gmane.org> 2019-02-17 14:32 ` Tony McKahan 2019-02-17 14:32 ` Tony McKahan 2019-02-17 15:55 ` David Summers [not found] ` <4ef63671-f58d-3b16-9055-09e69314a0e6-8lkWs+DogrrqRUWtDFdff/XRex20P6io@public.gmane.org> 2019-02-17 17:32 ` Tony McKahan 2019-02-17 17:32 ` Tony McKahan 2019-02-17 21:19 ` Stefan Wahren 2019-02-17 21:19 ` Stefan Wahren [not found] ` <CAERgokmpHQb2czJdx++qFoogFRmkvXZm=4BNOsVuCz-ZvgTEaw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2019-02-17 19:03 ` David Summers 2019-02-17 19:03 ` David Summers 2019-02-17 20:43 ` Stefan Wahren 2019-02-17 20:43 ` Stefan Wahren 2019-02-18 12:30 ` Robin Murphy 2019-02-18 12:30 ` Robin Murphy [not found] ` <1528638260.343699.1550436208775-uEpKuDZ350hmhno068Nerg@public.gmane.org> 2019-02-18 20:26 ` David Summers [this message] 2019-02-18 20:26 ` David Summers 2019-02-18 21:48 ` Stefan Wahren 2019-02-18 21:48 ` Stefan Wahren 2019-03-03 19:40 ` David Summers 2019-03-03 19:40 ` David Summers [not found] ` <9df2e318-a459-bded-2971-90a6722e1a4f-8lkWs+DogrrqRUWtDFdff/XRex20P6io@public.gmane.org> 2019-03-03 22:12 ` Tony McKahan 2019-03-03 22:12 ` Tony McKahan 2019-02-17 12:15 ` [PATCH 3/3] ARM: dts: rk3288 Tinker Board (S) add bluetooth David Summers 2019-02-17 12:15 ` David Summers [not found] ` <20190217121513.22965-4-beagleboard-8lkWs+DogrrqRUWtDFdff/XRex20P6io@public.gmane.org> 2019-02-17 13:31 ` Tony McKahan 2019-02-17 13:31 ` Tony McKahan 2019-02-17 21:05 ` Stefan Wahren 2019-02-17 21:05 ` Stefan Wahren 2019-02-18 20:47 ` David Summers 2019-02-18 21:40 ` Stefan Wahren 2019-03-03 20:15 ` David Summers 2019-03-03 20:15 ` David Summers 2019-02-23 19:42 ` [PATCH 0/3] ARM: dts: rk3288 Tinker Board (S) updates David Summers 2019-02-23 19:42 ` David Summers 2019-03-09 15:36 ` [PATCH v3 1/3] arm: dts: rk3288-tinker.dtsi: Fix SD card detection David Summers 2019-03-09 15:36 ` David Summers 2019-03-09 15:39 ` David Summers 2019-03-09 15:39 ` David Summers [not found] ` <20190309153923.22806-1-beagleboard-8lkWs+DogrrqRUWtDFdff/XRex20P6io@public.gmane.org> 2019-03-09 15:39 ` [PATCH v3 2/3] arm: dts: rk3288-tinker.dtsi: Enable WiFi David Summers 2019-03-09 15:39 ` David Summers 2019-03-11 22:18 ` Robin Murphy 2019-03-11 22:18 ` Robin Murphy [not found] ` <383c9884-4885-34e1-9ef7-96e936bb211d-5wv7dgnIgG8@public.gmane.org> 2019-03-12 20:41 ` David Summers 2019-03-12 20:41 ` David Summers [not found] ` <c91db9a2-4283-0ea5-949e-ed190a7a8083-8lkWs+DogrrqRUWtDFdff/XRex20P6io@public.gmane.org> 2019-03-12 20:55 ` Heiko Stübner 2019-03-12 20:55 ` Heiko Stübner [not found] ` <20190309153923.22806-2-beagleboard-8lkWs+DogrrqRUWtDFdff/XRex20P6io@public.gmane.org> 2019-03-12 14:18 ` Heiko Stuebner 2019-03-12 14:18 ` Heiko Stuebner 2019-03-12 14:21 ` Stefan Wahren 2019-03-12 14:21 ` Stefan Wahren 2019-03-13 10:50 ` Heiko Stübner 2019-03-13 10:50 ` Heiko Stübner 2019-03-09 15:39 ` [PATCH v3 3/3] arm: dts: rk3288-tinker.dtsi: Add outline Bluetooth support David Summers 2019-03-09 15:39 ` David Summers 2019-03-09 15:39 ` David Summers 2019-03-11 16:41 ` Marcel Holtmann 2019-03-11 16:41 ` Marcel Holtmann 2019-03-11 16:41 ` Marcel Holtmann 2019-03-11 20:48 ` David Summers 2019-03-11 20:48 ` David Summers 2019-03-11 20:48 ` David Summers [not found] ` <20190309153923.22806-3-beagleboard-8lkWs+DogrrqRUWtDFdff/XRex20P6io@public.gmane.org> 2019-03-13 10:56 ` Heiko Stübner 2019-03-13 10:56 ` Heiko Stübner 2019-03-13 10:56 ` Heiko Stübner 2019-03-13 19:57 ` David Summers 2019-03-13 20:02 ` David Summers 2019-03-13 20:02 ` David Summers 2019-03-12 14:08 ` [PATCH v3 1/3] arm: dts: rk3288-tinker.dtsi: Fix SD card detection Heiko Stuebner 2019-03-12 14:08 ` Heiko Stuebner 2019-03-12 14:17 ` Robin Murphy 2019-03-12 14:17 ` Robin Murphy 2019-03-12 14:22 ` Heiko Stuebner 2019-03-12 14:22 ` Heiko Stuebner 2019-03-12 20:34 ` David Summers [not found] ` <4a1ad220-103d-543e-56d1-3c6d6ad906ec-8lkWs+DogrrqRUWtDFdff/XRex20P6io@public.gmane.org> 2019-03-12 20:52 ` Heiko Stübner 2019-03-12 20:52 ` Heiko Stübner 2019-03-12 21:04 ` Jonas Karlman 2019-03-12 21:04 ` Jonas Karlman 2019-03-13 10:40 ` Heiko Stübner 2019-03-13 10:40 ` Heiko Stübner
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=3e9a387c-2ebc-c762-6222-90efc851e4ed@davidjohnsummers.uk \ --to=beagleboard-8lkws+dogrrqruwtdfdff/xrex20p6io@public.gmane.org \ --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org \ --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \ --cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \ --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \ --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \ --cc=stefan.wahren-eS4NqCHxEME@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.