From: "Heiko Stübner" <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org> To: David Summers <beagleboard-8lkWs+DogrrqRUWtDFdff/XRex20P6io@public.gmane.org> Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, Jonas Karlman <jonas-uIzNG4q0ceqzQB+pC5nmwQ@public.gmane.org>, linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, jh80.chung-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org Subject: Re: [PATCH v3 1/3] arm: dts: rk3288-tinker.dtsi: Fix SD card detection Date: Tue, 12 Mar 2019 21:52:38 +0100 [thread overview] Message-ID: <4202578.jOHf0ez5fE@diego> (raw) In-Reply-To: <4a1ad220-103d-543e-56d1-3c6d6ad906ec-8lkWs+DogrrqRUWtDFdff/XRex20P6io@public.gmane.org> Hi David, Am Dienstag, 12. März 2019, 21:34:00 CET schrieb David Summers: > On 12/03/2019 14:22, Heiko Stuebner wrote: > > Hi Jonas, > > > > Am Samstag, 9. März 2019, 16:39:21 CET schrieb David Summers: > >> The Problem: > >> > >> On ASUS Tinker Board S, when booting from the eMMC, and there is card > >> in the sd slot, there are constant errors. > >> > >> Also when warm reboot, uboot can not access the sd slot > >> > >> Cause: > >> > >> Identified by Robin Murphy @ ARM. The Card Detect on rk3288 > >> devices is pulled up by vccio-sd; so when the regulator powers this > >> off, card detect gives spurious errors. A second problem, is during > >> power down, vccio-sd apprears to be powered down. This causes a > >> problem when warm rebooting from the sd card. This was identified by > >> Jonas Karlman. > >> > >> History: > >> > >> A common fault on these rk3288 board, which impliment the reference > >> design. > >> > >> When this arose before: > >> > >> http://lists.infradead.org/pipermail/linux-arm-kernel/2014-August/281153. > >> html > >> > >> And Ulf and Jaehoon clearly said this was a broken card detect design, > >> which should be solved via polling > >> > >> Solution: > >> > >> Hence broken-cd is set as a property. This cures the errors. The > >> powering down of vccio-sd during reboot is cured by adding > >> regulator-boot-on. > >> > >> This solutions has been fairly widely reviewed and tested. > >> > >> Signed-off-by: David Summers <beagleboard-8lkWs+DogrrqRUWtDFdff/XRex20P6io@public.gmane.org> > >> Reviewed by: Robin Murphy <robin.murphy-5wv7dgnIgG8@public.gmane.org> > >> Reviewed by: Jonas Karlman <jonas-uIzNG4q0ceqzQB+pC5nmwQ@public.gmane.org> > > > > in v2, you gave a > > Tested-by: Jonas Karlman <jonas-uIzNG4q0ceqzQB+pC5nmwQ@public.gmane.org> > > it seems, which somehow transformed into a reviewed-by in v3. > > > > V3 did change a bit in its approach - for the better, but do you approve > > of adding that Reviewed-by above (and maybe also providing a Tested-by > > for the new approach)? > > > > Thanks > > Heiko > > Hi all, > > Yes apologies for these signed-off lines etc wrong. Its still a learning > experiment for me! > > Both Robin and Jonas added a lot to Patch, as explained in the write up. > Robin came up with the cause of the fault, and Jonas noticed a second > fault. So the question is to give these two their due. I think what they > both added was important. > > Thanks Robin for the official "Reviewed-by". > > Jonas tested the second version, which kept power on vccio-sd all the > time, whereas v1 and v3 cured the problem with broken-cd. So although > both fixed the problem, they way performed is different. So don't think > I can say Jonas Tested-by v3. We'll just give Jonas a bit more time to reply then :-) . > As for the tested by "TheSaint @ ArchLinux Arm", he actually tested just > above every single version of the patch, and a whole lot more before it > was sent in - he is our ASUS Tinker Board user on arch. He doesn't > really want his email in the open, but if push comes to shove he'll > allow it. Question is do you need this for the Patch to pass? No, that is not necessary. I'll just drop the line when applying. In general for a tag to mean something we need the Name, but any tags other than Signed-off-by are optional anyway. > Heiko, I'm happy to change the sign off etc, and resent the patch (as > v4). But would be the same patch. Think the question is what is best for > you. Don't want to send unneeded email ... anyway let me know (private > email?) and I'll do whatever is best for you. No, re-sending just to correct tags is not necessary in _my_ case as I generally just fix up the relevant lines myself when applying. Just keep in mind, other maintainers may handle this differently :-) . > P.S. Eventually I'll get better at these patches , alas the day job > keeps me too busy - and I forget the rules :( Really no problem, it's always a learning experience. So don't worry too much :-) . Heiko
WARNING: multiple messages have this Message-ID (diff)
From: "Heiko Stübner" <heiko@sntech.de> To: David Summers <beagleboard@davidjohnsummers.uk> Cc: devicetree@vger.kernel.org, ulf.hansson@linaro.org, Jonas Karlman <jonas@kwiboo.se>, linux-mmc@vger.kernel.org, jh80.chung@samsung.com, linux-rockchip@lists.infradead.org, robh+dt@kernel.org, frowand.list@gmail.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 1/3] arm: dts: rk3288-tinker.dtsi: Fix SD card detection Date: Tue, 12 Mar 2019 21:52:38 +0100 [thread overview] Message-ID: <4202578.jOHf0ez5fE@diego> (raw) In-Reply-To: <4a1ad220-103d-543e-56d1-3c6d6ad906ec@davidjohnsummers.uk> Hi David, Am Dienstag, 12. März 2019, 21:34:00 CET schrieb David Summers: > On 12/03/2019 14:22, Heiko Stuebner wrote: > > Hi Jonas, > > > > Am Samstag, 9. März 2019, 16:39:21 CET schrieb David Summers: > >> The Problem: > >> > >> On ASUS Tinker Board S, when booting from the eMMC, and there is card > >> in the sd slot, there are constant errors. > >> > >> Also when warm reboot, uboot can not access the sd slot > >> > >> Cause: > >> > >> Identified by Robin Murphy @ ARM. The Card Detect on rk3288 > >> devices is pulled up by vccio-sd; so when the regulator powers this > >> off, card detect gives spurious errors. A second problem, is during > >> power down, vccio-sd apprears to be powered down. This causes a > >> problem when warm rebooting from the sd card. This was identified by > >> Jonas Karlman. > >> > >> History: > >> > >> A common fault on these rk3288 board, which impliment the reference > >> design. > >> > >> When this arose before: > >> > >> http://lists.infradead.org/pipermail/linux-arm-kernel/2014-August/281153. > >> html > >> > >> And Ulf and Jaehoon clearly said this was a broken card detect design, > >> which should be solved via polling > >> > >> Solution: > >> > >> Hence broken-cd is set as a property. This cures the errors. The > >> powering down of vccio-sd during reboot is cured by adding > >> regulator-boot-on. > >> > >> This solutions has been fairly widely reviewed and tested. > >> > >> Signed-off-by: David Summers <beagleboard@davidjohnsummers.uk> > >> Reviewed by: Robin Murphy <robin.murphy@arm.com> > >> Reviewed by: Jonas Karlman <jonas@kwiboo.se> > > > > in v2, you gave a > > Tested-by: Jonas Karlman <jonas@kwiboo.se> > > it seems, which somehow transformed into a reviewed-by in v3. > > > > V3 did change a bit in its approach - for the better, but do you approve > > of adding that Reviewed-by above (and maybe also providing a Tested-by > > for the new approach)? > > > > Thanks > > Heiko > > Hi all, > > Yes apologies for these signed-off lines etc wrong. Its still a learning > experiment for me! > > Both Robin and Jonas added a lot to Patch, as explained in the write up. > Robin came up with the cause of the fault, and Jonas noticed a second > fault. So the question is to give these two their due. I think what they > both added was important. > > Thanks Robin for the official "Reviewed-by". > > Jonas tested the second version, which kept power on vccio-sd all the > time, whereas v1 and v3 cured the problem with broken-cd. So although > both fixed the problem, they way performed is different. So don't think > I can say Jonas Tested-by v3. We'll just give Jonas a bit more time to reply then :-) . > As for the tested by "TheSaint @ ArchLinux Arm", he actually tested just > above every single version of the patch, and a whole lot more before it > was sent in - he is our ASUS Tinker Board user on arch. He doesn't > really want his email in the open, but if push comes to shove he'll > allow it. Question is do you need this for the Patch to pass? No, that is not necessary. I'll just drop the line when applying. In general for a tag to mean something we need the Name, but any tags other than Signed-off-by are optional anyway. > Heiko, I'm happy to change the sign off etc, and resent the patch (as > v4). But would be the same patch. Think the question is what is best for > you. Don't want to send unneeded email ... anyway let me know (private > email?) and I'll do whatever is best for you. No, re-sending just to correct tags is not necessary in _my_ case as I generally just fix up the relevant lines myself when applying. Just keep in mind, other maintainers may handle this differently :-) . > P.S. Eventually I'll get better at these patches , alas the day job > keeps me too busy - and I forget the rules :( Really no problem, it's always a learning experience. So don't worry too much :-) . Heiko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-03-12 20:52 UTC|newest] Thread overview: 116+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-02-17 12:15 [PATCH 0/3] ARM: dts: rk3288 Tinker Board (S) updates David Summers 2019-02-17 12:15 ` David Summers 2019-02-17 12:15 ` [PATCH 1/3] ARM: dts: rk3288 Tinker Board (S) sdcard changes David Summers 2019-02-17 12:15 ` David Summers 2019-02-17 14:00 ` Robin Murphy 2019-02-17 14:00 ` Robin Murphy 2019-02-17 15:19 ` David Summers 2019-02-17 15:19 ` David Summers 2019-02-18 11:54 ` Robin Murphy 2019-02-18 11:54 ` Robin Murphy 2019-02-19 20:13 ` David Summers 2019-02-19 20:13 ` David Summers [not found] ` <20190217121513.22965-2-beagleboard-8lkWs+DogrrqRUWtDFdff/XRex20P6io@public.gmane.org> 2019-02-17 20:29 ` Stefan Wahren 2019-02-17 20:29 ` Stefan Wahren [not found] ` <1660942499.343639.1550435365757-uEpKuDZ350hmhno068Nerg@public.gmane.org> 2019-02-18 20:08 ` David Summers 2019-02-18 20:08 ` David Summers 2019-02-22 18:47 ` [PATCH 1/3 v2] ARM: dts: rk3288-tinker.dtsi: Fix SD card detection David Summers [not found] ` <20190222184708.32004-1-beagleboard-8lkWs+DogrrqRUWtDFdff/XRex20P6io@public.gmane.org> 2019-02-24 19:26 ` Jonas Karlman 2019-02-24 19:26 ` Jonas Karlman [not found] ` <AM3PR03MB096656098C6CB4712C73C095AC790-XQTXrJX/giFAc9da7WRX18eAHadYHfrlvxpqHgZTriW3zl9H0oFU5g@public.gmane.org> 2019-02-24 19:35 ` David Summers [not found] ` <5387a001-1036-bb5c-e781-18e87ca6e7bd-8lkWs+DogrrqRUWtDFdff/XRex20P6io@public.gmane.org> 2019-02-24 19:56 ` Jonas Karlman [not found] ` <AM3PR03MB09663F32FC40000E42C1A722AC790-XQTXrJX/giFAc9da7WRX18eAHadYHfrlvxpqHgZTriW3zl9H0oFU5g@public.gmane.org> 2019-02-24 20:10 ` David Summers [not found] ` <e1f1a93e-505b-bf53-a253-5c1ddaeaebf8-8lkWs+DogrrqRUWtDFdff/XRex20P6io@public.gmane.org> 2019-02-24 22:54 ` Heiko Stübner 2019-02-24 22:54 ` Heiko Stübner 2019-02-25 8:59 ` Jonas Karlman 2019-02-25 21:00 ` David Summers [not found] ` <31863095-94b5-5fec-0293-b30172426b93-8lkWs+DogrrqRUWtDFdff/XRex20P6io@public.gmane.org> 2019-02-25 21:14 ` Doug Anderson 2019-02-25 17:13 ` Doug Anderson [not found] ` <CAD=FV=UkQ7pEan4aGezvQZZjBc0gDJ1R7YRbN1Lbv9HBVQRgHQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2019-02-25 21:11 ` David Summers [not found] ` <9e90c5dd-7b1e-9e53-81ac-fb3b515215ca-8lkWs+DogrrqRUWtDFdff/XRex20P6io@public.gmane.org> 2019-02-25 21:18 ` Doug Anderson [not found] ` <CAD=FV=XEPKpDVLdpCVB9eMzJNE8C5Pr=fRgRmJXgxzrDFJ39mQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2019-02-25 22:20 ` Heiko Stübner 2019-02-26 14:46 ` Robin Murphy [not found] ` <108411d8-9607-d92d-e546-d0c85bcabc51-5wv7dgnIgG8@public.gmane.org> 2019-02-26 16:43 ` Doug Anderson [not found] ` <CAD=FV=X0rRPkEim1sHS9EqDCLiWPO7e5Vu-0gAcX7YZ_omeKPw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2019-02-27 13:48 ` Robin Murphy 2019-03-03 11:08 ` David Summers 2019-02-17 12:15 ` [PATCH 2/3] ARM: dts: rk3288 Tinker Board (S) add wi-fi David Summers 2019-02-17 12:15 ` David Summers [not found] ` <20190217121513.22965-3-beagleboard-8lkWs+DogrrqRUWtDFdff/XRex20P6io@public.gmane.org> 2019-02-17 14:32 ` Tony McKahan 2019-02-17 14:32 ` Tony McKahan 2019-02-17 15:55 ` David Summers [not found] ` <4ef63671-f58d-3b16-9055-09e69314a0e6-8lkWs+DogrrqRUWtDFdff/XRex20P6io@public.gmane.org> 2019-02-17 17:32 ` Tony McKahan 2019-02-17 17:32 ` Tony McKahan 2019-02-17 21:19 ` Stefan Wahren 2019-02-17 21:19 ` Stefan Wahren [not found] ` <CAERgokmpHQb2czJdx++qFoogFRmkvXZm=4BNOsVuCz-ZvgTEaw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2019-02-17 19:03 ` David Summers 2019-02-17 19:03 ` David Summers 2019-02-17 20:43 ` Stefan Wahren 2019-02-17 20:43 ` Stefan Wahren 2019-02-18 12:30 ` Robin Murphy 2019-02-18 12:30 ` Robin Murphy [not found] ` <1528638260.343699.1550436208775-uEpKuDZ350hmhno068Nerg@public.gmane.org> 2019-02-18 20:26 ` David Summers 2019-02-18 20:26 ` David Summers 2019-02-18 21:48 ` Stefan Wahren 2019-02-18 21:48 ` Stefan Wahren 2019-03-03 19:40 ` David Summers 2019-03-03 19:40 ` David Summers [not found] ` <9df2e318-a459-bded-2971-90a6722e1a4f-8lkWs+DogrrqRUWtDFdff/XRex20P6io@public.gmane.org> 2019-03-03 22:12 ` Tony McKahan 2019-03-03 22:12 ` Tony McKahan 2019-02-17 12:15 ` [PATCH 3/3] ARM: dts: rk3288 Tinker Board (S) add bluetooth David Summers 2019-02-17 12:15 ` David Summers [not found] ` <20190217121513.22965-4-beagleboard-8lkWs+DogrrqRUWtDFdff/XRex20P6io@public.gmane.org> 2019-02-17 13:31 ` Tony McKahan 2019-02-17 13:31 ` Tony McKahan 2019-02-17 21:05 ` Stefan Wahren 2019-02-17 21:05 ` Stefan Wahren 2019-02-18 20:47 ` David Summers 2019-02-18 21:40 ` Stefan Wahren 2019-03-03 20:15 ` David Summers 2019-03-03 20:15 ` David Summers 2019-02-23 19:42 ` [PATCH 0/3] ARM: dts: rk3288 Tinker Board (S) updates David Summers 2019-02-23 19:42 ` David Summers 2019-03-09 15:36 ` [PATCH v3 1/3] arm: dts: rk3288-tinker.dtsi: Fix SD card detection David Summers 2019-03-09 15:36 ` David Summers 2019-03-09 15:39 ` David Summers 2019-03-09 15:39 ` David Summers [not found] ` <20190309153923.22806-1-beagleboard-8lkWs+DogrrqRUWtDFdff/XRex20P6io@public.gmane.org> 2019-03-09 15:39 ` [PATCH v3 2/3] arm: dts: rk3288-tinker.dtsi: Enable WiFi David Summers 2019-03-09 15:39 ` David Summers 2019-03-11 22:18 ` Robin Murphy 2019-03-11 22:18 ` Robin Murphy [not found] ` <383c9884-4885-34e1-9ef7-96e936bb211d-5wv7dgnIgG8@public.gmane.org> 2019-03-12 20:41 ` David Summers 2019-03-12 20:41 ` David Summers [not found] ` <c91db9a2-4283-0ea5-949e-ed190a7a8083-8lkWs+DogrrqRUWtDFdff/XRex20P6io@public.gmane.org> 2019-03-12 20:55 ` Heiko Stübner 2019-03-12 20:55 ` Heiko Stübner [not found] ` <20190309153923.22806-2-beagleboard-8lkWs+DogrrqRUWtDFdff/XRex20P6io@public.gmane.org> 2019-03-12 14:18 ` Heiko Stuebner 2019-03-12 14:18 ` Heiko Stuebner 2019-03-12 14:21 ` Stefan Wahren 2019-03-12 14:21 ` Stefan Wahren 2019-03-13 10:50 ` Heiko Stübner 2019-03-13 10:50 ` Heiko Stübner 2019-03-09 15:39 ` [PATCH v3 3/3] arm: dts: rk3288-tinker.dtsi: Add outline Bluetooth support David Summers 2019-03-09 15:39 ` David Summers 2019-03-09 15:39 ` David Summers 2019-03-11 16:41 ` Marcel Holtmann 2019-03-11 16:41 ` Marcel Holtmann 2019-03-11 16:41 ` Marcel Holtmann 2019-03-11 20:48 ` David Summers 2019-03-11 20:48 ` David Summers 2019-03-11 20:48 ` David Summers [not found] ` <20190309153923.22806-3-beagleboard-8lkWs+DogrrqRUWtDFdff/XRex20P6io@public.gmane.org> 2019-03-13 10:56 ` Heiko Stübner 2019-03-13 10:56 ` Heiko Stübner 2019-03-13 10:56 ` Heiko Stübner 2019-03-13 19:57 ` David Summers 2019-03-13 20:02 ` David Summers 2019-03-13 20:02 ` David Summers 2019-03-12 14:08 ` [PATCH v3 1/3] arm: dts: rk3288-tinker.dtsi: Fix SD card detection Heiko Stuebner 2019-03-12 14:08 ` Heiko Stuebner 2019-03-12 14:17 ` Robin Murphy 2019-03-12 14:17 ` Robin Murphy 2019-03-12 14:22 ` Heiko Stuebner 2019-03-12 14:22 ` Heiko Stuebner 2019-03-12 20:34 ` David Summers [not found] ` <4a1ad220-103d-543e-56d1-3c6d6ad906ec-8lkWs+DogrrqRUWtDFdff/XRex20P6io@public.gmane.org> 2019-03-12 20:52 ` Heiko Stübner [this message] 2019-03-12 20:52 ` Heiko Stübner 2019-03-12 21:04 ` Jonas Karlman 2019-03-12 21:04 ` Jonas Karlman 2019-03-13 10:40 ` Heiko Stübner 2019-03-13 10:40 ` Heiko Stübner
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=4202578.jOHf0ez5fE@diego \ --to=heiko-4mtyjxux2i+zqb+pc5nmwq@public.gmane.org \ --cc=beagleboard-8lkWs+DogrrqRUWtDFdff/XRex20P6io@public.gmane.org \ --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \ --cc=jh80.chung-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \ --cc=jonas-uIzNG4q0ceqzQB+pC5nmwQ@public.gmane.org \ --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \ --cc=linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \ --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \ --cc=ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.