All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rafal Prylowski <prylowski@metasoft.pl>
To: H Hartley Sweeten <hartleys@visionengravers.com>
Cc: "linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
	"bzolnier@gmail.com" <bzolnier@gmail.com>,
	"rmallon@gmail.com" <rmallon@gmail.com>,
	Sergei Shtylyov <sshtylyov@mvista.com>,
	"joao.ramos@inov.pt" <joao.ramos@inov.pt>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 3/3] ep93xx: Add IDE support to edb93xx boards
Date: Fri, 30 Mar 2012 10:32:25 +0200	[thread overview]
Message-ID: <4F756F99.8090301@metasoft.pl> (raw)
In-Reply-To: <ADE657CA350FB648AAC2C43247A983F00206970255C3@AUSP01VMBX24.collaborationhost.net>

On 2012-03-29 18:32, H Hartley Sweeten wrote:
>> +static int __init edb93xx_has_ide(void)
>> +{
>> +	/*
>> +	 * Although EDB9312 and EDB9315 do have IDE capability, they have
>> +	 * INTRQ line wired as pull-up, which makes using IDE interface
>> +	 * problematic.
>> +	 */
>> +	return machine_is_edb9315a();
> 
> Allow the driver to be loaded on the EDB9312 and EDB9315 but leave the comment.
> If a use of these boards wishes to use the IDE they could remove the pull-up and add
> a pull-down to their board.

Ok. Will do that.

WARNING: multiple messages have this Message-ID (diff)
From: prylowski@metasoft.pl (Rafal Prylowski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] ep93xx: Add IDE support to edb93xx boards
Date: Fri, 30 Mar 2012 10:32:25 +0200	[thread overview]
Message-ID: <4F756F99.8090301@metasoft.pl> (raw)
In-Reply-To: <ADE657CA350FB648AAC2C43247A983F00206970255C3@AUSP01VMBX24.collaborationhost.net>

On 2012-03-29 18:32, H Hartley Sweeten wrote:
>> +static int __init edb93xx_has_ide(void)
>> +{
>> +	/*
>> +	 * Although EDB9312 and EDB9315 do have IDE capability, they have
>> +	 * INTRQ line wired as pull-up, which makes using IDE interface
>> +	 * problematic.
>> +	 */
>> +	return machine_is_edb9315a();
> 
> Allow the driver to be loaded on the EDB9312 and EDB9315 but leave the comment.
> If a use of these boards wishes to use the IDE they could remove the pull-up and add
> a pull-down to their board.

Ok. Will do that.

  reply	other threads:[~2012-03-30  8:32 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-29  8:10 [PATCH 0/3] Add PATA host controller support for Cirrus Logic EP93xx CPU Rafal Prylowski
2012-03-29  8:10 ` Rafal Prylowski
2012-03-29  8:17 ` [PATCH 1/3] PATA host controller driver for ep93xx Rafal Prylowski
2012-03-29  8:17   ` Rafal Prylowski
2012-03-29 17:25   ` H Hartley Sweeten
2012-03-29 17:25     ` H Hartley Sweeten
2012-03-30  8:13     ` Rafal Prylowski
2012-03-30  8:13       ` Rafal Prylowski
2012-03-29 22:21   ` Ryan Mallon
2012-03-29 22:21     ` Ryan Mallon
2012-03-30 10:13     ` Rafal Prylowski
2012-03-30 10:13       ` Rafal Prylowski
2012-03-29 22:24   ` Ryan Mallon
2012-03-29 22:24     ` Ryan Mallon
2012-03-30  8:19     ` Rafal Prylowski
2012-03-30  8:19       ` Rafal Prylowski
2012-03-30 20:18   ` Arnd Bergmann
2012-03-30 20:18     ` Arnd Bergmann
2012-04-02  7:52     ` Rafal Prylowski
2012-04-02  7:52       ` Rafal Prylowski
2012-04-02  8:08       ` Arnd Bergmann
2012-04-02  8:08         ` Arnd Bergmann
2012-04-02  9:28         ` Rafal Prylowski
2012-04-02  9:28           ` Rafal Prylowski
2012-04-02 10:24           ` Arnd Bergmann
2012-04-02 10:24             ` Arnd Bergmann
2012-04-03  1:50       ` Ryan Mallon
2012-04-03  1:50         ` Ryan Mallon
2012-04-03  7:41         ` Arnd Bergmann
2012-04-03  7:41           ` Arnd Bergmann
2012-03-29  8:19 ` [PATCH 2/3] ep93xx: IDE driver platform support code Rafal Prylowski
2012-03-29  8:19   ` Rafal Prylowski
2012-03-29 16:26   ` H Hartley Sweeten
2012-03-29 16:26     ` H Hartley Sweeten
2012-03-30  8:29     ` Rafal Prylowski
2012-03-30  8:29       ` Rafal Prylowski
2012-03-29  8:20 ` [PATCH 3/3] ep93xx: Add IDE support to edb93xx boards Rafal Prylowski
2012-03-29  8:20   ` Rafal Prylowski
2012-03-29 16:32   ` H Hartley Sweeten
2012-03-29 16:32     ` H Hartley Sweeten
2012-03-30  8:32     ` Rafal Prylowski [this message]
2012-03-30  8:32       ` Rafal Prylowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F756F99.8090301@metasoft.pl \
    --to=prylowski@metasoft.pl \
    --cc=bzolnier@gmail.com \
    --cc=hartleys@visionengravers.com \
    --cc=joao.ramos@inov.pt \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=rmallon@gmail.com \
    --cc=sshtylyov@mvista.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.