From: H Hartley Sweeten <hartleys@visionengravers.com> To: Rafal Prylowski <prylowski@metasoft.pl>, "linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org> Cc: "bzolnier@gmail.com" <bzolnier@gmail.com>, "ryan@bluewatersys.com" <ryan@bluewatersys.com>, "sshtylyov@ru.montavista.com" <sshtylyov@ru.montavista.com>, "joao.ramos@inov.pt" <joao.ramos@inov.pt>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org> Subject: RE: [PATCH 2/3] ep93xx: IDE driver platform support code Date: Thu, 29 Mar 2012 11:26:41 -0500 [thread overview] Message-ID: <ADE657CA350FB648AAC2C43247A983F00206970255B6@AUSP01VMBX24.collaborationhost.net> (raw) In-Reply-To: <4F741B07.7040107@metasoft.pl> On Thursday, March 29, 2012 1:19 AM, Rafal Prylowski wrote: > Signed-off-by: Rafal Prylowski <prylowski@metasoft.pl> > Cc: H Hartley Sweeten <hsweeten@visionengravers.com> > Cc: Ryan Mallon <ryan@bluewatersys.com> > > --- > arch/arm/mach-ep93xx/core.c | 36 +++++++++++++++++ > arch/arm/mach-ep93xx/include/mach/platform.h | 1 > arch/arm/mach-ep93xx/soc.h | 1 > 3 files changed, 38 insertions(+) > > Index: linux-2.6/arch/arm/mach-ep93xx/soc.h > =================================================================== > --- linux-2.6.orig/arch/arm/mach-ep93xx/soc.h > +++ linux-2.6/arch/arm/mach-ep93xx/soc.h > @@ -69,6 +69,7 @@ > > #define EP93XX_BOOT_ROM_BASE EP93XX_AHB_IOMEM(0x00090000) > > +#define EP93XX_IDE_PHYS_BASE EP93XX_AHB_PHYS(0x000a0000) > #define EP93XX_IDE_BASE EP93XX_AHB_IOMEM(0x000a0000) > > #define EP93XX_VIC1_BASE EP93XX_AHB_IOMEM(0x000b0000) > Index: linux-2.6/arch/arm/mach-ep93xx/core.c > =================================================================== > --- linux-2.6.orig/arch/arm/mach-ep93xx/core.c > +++ linux-2.6/arch/arm/mach-ep93xx/core.c > @@ -868,6 +868,42 @@ static struct platform_device ep93xx_wdt > .resource = ep93xx_wdt_resources, > }; > > +/************************************************************************* > + * EP93xx IDE > + *************************************************************************/ > +static struct resource ep93xx_ide_resources[] = { > + [0] = { > + .start = EP93XX_IDE_PHYS_BASE, > + .end = EP93XX_IDE_PHYS_BASE + 0xffff, > + .flags = IORESOURCE_MEM, > + }, > + [1] = { > + .start = IRQ_EP93XX_EXT3, > + .end = IRQ_EP93XX_EXT3, > + .flags = IORESOURCE_IRQ, > + }, > +}; Please use the DEFINE_RES_* macros. Also, the last register in the IDE interface is at offset 0x34, so something like this: static struct resource ep93xx_ide_resources[] = { DEFINE_RES_MEM(EP93XX_IDE_PHYS_BASE, 0x38), DEFINE_RES_IRQ(IRQ_EP93XX_EXT3), }; > +static struct platform_device ep93xx_ide_device = { > + .name = "ep93xx-ide", > + .id = -1, > + .dev = { > + .dma_mask = &ep93xx_ide_device.dev.coherent_dma_mask, > + .coherent_dma_mask = DMA_BIT_MASK(32), > + }, > + .num_resources = ARRAY_SIZE(ep93xx_ide_resources), > + .resource = ep93xx_ide_resources, > +}; > + > +void __init ep93xx_register_ide(void) > +{ > + /* GPIO ports E, G and H used by IDE */ > + ep93xx_devcfg_clear_bits(EP93XX_SYSCON_DEVCFG_EONIDE | > + EP93XX_SYSCON_DEVCFG_GONIDE | > + EP93XX_SYSCON_DEVCFG_HONIDE); > + platform_device_register(&ep93xx_ide_device); > +} Please create ep93xx_ide_acquire_gpio and ep93xx_ide_acquire_gpio functions to set/clear the necessary SYSCON bits during the probe/remove of the ide driver. This should also address your concern mentioned in PATCH 0/3 about making sure the pin muxing is correct when the driver is loaded. The *_acquire_gpio function should also gpio_request the pins before setting the SYSCON bits. That way if any of the pins are unavailable the driver will not load. Make sure to gpio_free the pins in the *_release_gpio function. Look at how the keypad is handled for an example. > + > void __init ep93xx_init_devices(void) > { > /* Disallow access to MaverickCrunch initially */ > Index: linux-2.6/arch/arm/mach-ep93xx/include/mach/platform.h > =================================================================== > --- linux-2.6.orig/arch/arm/mach-ep93xx/include/mach/platform.h > +++ linux-2.6/arch/arm/mach-ep93xx/include/mach/platform.h > @@ -48,6 +48,7 @@ void ep93xx_register_i2s(void); > int ep93xx_i2s_acquire(void); > void ep93xx_i2s_release(void); > void ep93xx_register_ac97(void); > +void ep93xx_register_ide(void); > > void ep93xx_init_devices(void); > extern struct sys_timer ep93xx_timer; Regards, Hartley
WARNING: multiple messages have this Message-ID (diff)
From: hartleys@visionengravers.com (H Hartley Sweeten) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 2/3] ep93xx: IDE driver platform support code Date: Thu, 29 Mar 2012 11:26:41 -0500 [thread overview] Message-ID: <ADE657CA350FB648AAC2C43247A983F00206970255B6@AUSP01VMBX24.collaborationhost.net> (raw) In-Reply-To: <4F741B07.7040107@metasoft.pl> On Thursday, March 29, 2012 1:19 AM, Rafal Prylowski wrote: > Signed-off-by: Rafal Prylowski <prylowski@metasoft.pl> > Cc: H Hartley Sweeten <hsweeten@visionengravers.com> > Cc: Ryan Mallon <ryan@bluewatersys.com> > > --- > arch/arm/mach-ep93xx/core.c | 36 +++++++++++++++++ > arch/arm/mach-ep93xx/include/mach/platform.h | 1 > arch/arm/mach-ep93xx/soc.h | 1 > 3 files changed, 38 insertions(+) > > Index: linux-2.6/arch/arm/mach-ep93xx/soc.h > =================================================================== > --- linux-2.6.orig/arch/arm/mach-ep93xx/soc.h > +++ linux-2.6/arch/arm/mach-ep93xx/soc.h > @@ -69,6 +69,7 @@ > > #define EP93XX_BOOT_ROM_BASE EP93XX_AHB_IOMEM(0x00090000) > > +#define EP93XX_IDE_PHYS_BASE EP93XX_AHB_PHYS(0x000a0000) > #define EP93XX_IDE_BASE EP93XX_AHB_IOMEM(0x000a0000) > > #define EP93XX_VIC1_BASE EP93XX_AHB_IOMEM(0x000b0000) > Index: linux-2.6/arch/arm/mach-ep93xx/core.c > =================================================================== > --- linux-2.6.orig/arch/arm/mach-ep93xx/core.c > +++ linux-2.6/arch/arm/mach-ep93xx/core.c > @@ -868,6 +868,42 @@ static struct platform_device ep93xx_wdt > .resource = ep93xx_wdt_resources, > }; > > +/************************************************************************* > + * EP93xx IDE > + *************************************************************************/ > +static struct resource ep93xx_ide_resources[] = { > + [0] = { > + .start = EP93XX_IDE_PHYS_BASE, > + .end = EP93XX_IDE_PHYS_BASE + 0xffff, > + .flags = IORESOURCE_MEM, > + }, > + [1] = { > + .start = IRQ_EP93XX_EXT3, > + .end = IRQ_EP93XX_EXT3, > + .flags = IORESOURCE_IRQ, > + }, > +}; Please use the DEFINE_RES_* macros. Also, the last register in the IDE interface is at offset 0x34, so something like this: static struct resource ep93xx_ide_resources[] = { DEFINE_RES_MEM(EP93XX_IDE_PHYS_BASE, 0x38), DEFINE_RES_IRQ(IRQ_EP93XX_EXT3), }; > +static struct platform_device ep93xx_ide_device = { > + .name = "ep93xx-ide", > + .id = -1, > + .dev = { > + .dma_mask = &ep93xx_ide_device.dev.coherent_dma_mask, > + .coherent_dma_mask = DMA_BIT_MASK(32), > + }, > + .num_resources = ARRAY_SIZE(ep93xx_ide_resources), > + .resource = ep93xx_ide_resources, > +}; > + > +void __init ep93xx_register_ide(void) > +{ > + /* GPIO ports E, G and H used by IDE */ > + ep93xx_devcfg_clear_bits(EP93XX_SYSCON_DEVCFG_EONIDE | > + EP93XX_SYSCON_DEVCFG_GONIDE | > + EP93XX_SYSCON_DEVCFG_HONIDE); > + platform_device_register(&ep93xx_ide_device); > +} Please create ep93xx_ide_acquire_gpio and ep93xx_ide_acquire_gpio functions to set/clear the necessary SYSCON bits during the probe/remove of the ide driver. This should also address your concern mentioned in PATCH 0/3 about making sure the pin muxing is correct when the driver is loaded. The *_acquire_gpio function should also gpio_request the pins before setting the SYSCON bits. That way if any of the pins are unavailable the driver will not load. Make sure to gpio_free the pins in the *_release_gpio function. Look at how the keypad is handled for an example. > + > void __init ep93xx_init_devices(void) > { > /* Disallow access to MaverickCrunch initially */ > Index: linux-2.6/arch/arm/mach-ep93xx/include/mach/platform.h > =================================================================== > --- linux-2.6.orig/arch/arm/mach-ep93xx/include/mach/platform.h > +++ linux-2.6/arch/arm/mach-ep93xx/include/mach/platform.h > @@ -48,6 +48,7 @@ void ep93xx_register_i2s(void); > int ep93xx_i2s_acquire(void); > void ep93xx_i2s_release(void); > void ep93xx_register_ac97(void); > +void ep93xx_register_ide(void); > > void ep93xx_init_devices(void); > extern struct sys_timer ep93xx_timer; Regards, Hartley
next prev parent reply other threads:[~2012-03-29 16:26 UTC|newest] Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-03-29 8:10 [PATCH 0/3] Add PATA host controller support for Cirrus Logic EP93xx CPU Rafal Prylowski 2012-03-29 8:10 ` Rafal Prylowski 2012-03-29 8:17 ` [PATCH 1/3] PATA host controller driver for ep93xx Rafal Prylowski 2012-03-29 8:17 ` Rafal Prylowski 2012-03-29 17:25 ` H Hartley Sweeten 2012-03-29 17:25 ` H Hartley Sweeten 2012-03-30 8:13 ` Rafal Prylowski 2012-03-30 8:13 ` Rafal Prylowski 2012-03-29 22:21 ` Ryan Mallon 2012-03-29 22:21 ` Ryan Mallon 2012-03-30 10:13 ` Rafal Prylowski 2012-03-30 10:13 ` Rafal Prylowski 2012-03-29 22:24 ` Ryan Mallon 2012-03-29 22:24 ` Ryan Mallon 2012-03-30 8:19 ` Rafal Prylowski 2012-03-30 8:19 ` Rafal Prylowski 2012-03-30 20:18 ` Arnd Bergmann 2012-03-30 20:18 ` Arnd Bergmann 2012-04-02 7:52 ` Rafal Prylowski 2012-04-02 7:52 ` Rafal Prylowski 2012-04-02 8:08 ` Arnd Bergmann 2012-04-02 8:08 ` Arnd Bergmann 2012-04-02 9:28 ` Rafal Prylowski 2012-04-02 9:28 ` Rafal Prylowski 2012-04-02 10:24 ` Arnd Bergmann 2012-04-02 10:24 ` Arnd Bergmann 2012-04-03 1:50 ` Ryan Mallon 2012-04-03 1:50 ` Ryan Mallon 2012-04-03 7:41 ` Arnd Bergmann 2012-04-03 7:41 ` Arnd Bergmann 2012-03-29 8:19 ` [PATCH 2/3] ep93xx: IDE driver platform support code Rafal Prylowski 2012-03-29 8:19 ` Rafal Prylowski 2012-03-29 16:26 ` H Hartley Sweeten [this message] 2012-03-29 16:26 ` H Hartley Sweeten 2012-03-30 8:29 ` Rafal Prylowski 2012-03-30 8:29 ` Rafal Prylowski 2012-03-29 8:20 ` [PATCH 3/3] ep93xx: Add IDE support to edb93xx boards Rafal Prylowski 2012-03-29 8:20 ` Rafal Prylowski 2012-03-29 16:32 ` H Hartley Sweeten 2012-03-29 16:32 ` H Hartley Sweeten 2012-03-30 8:32 ` Rafal Prylowski 2012-03-30 8:32 ` Rafal Prylowski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=ADE657CA350FB648AAC2C43247A983F00206970255B6@AUSP01VMBX24.collaborationhost.net \ --to=hartleys@visionengravers.com \ --cc=bzolnier@gmail.com \ --cc=joao.ramos@inov.pt \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-ide@vger.kernel.org \ --cc=prylowski@metasoft.pl \ --cc=ryan@bluewatersys.com \ --cc=sshtylyov@ru.montavista.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.