From: Ard Biesheuvel <ard.biesheuvel@linaro.org> To: Matt Fleming <matt@codeblueprint.co.uk> Cc: "H. Peter Anvin" <hpa@zytor.com>, Andy Lutomirski <luto@amacapital.net>, Ingo Molnar <mingo@kernel.org>, Thomas Gleixner <tglx@linutronix.de>, Matt Fleming <matt.fleming@intel.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-efi@vger.kernel.org" <linux-efi@vger.kernel.org>, "Lee, Chun-Yi" <jlee@suse.com>, Borislav Petkov <bp@suse.de>, Leif Lindholm <leif.lindholm@linaro.org>, Peter Jones <pjones@redhat.com>, James Bottomley <JBottomley@odin.com>, Matthew Garrett <mjg59@srcf.ucam.org>, Dave Young <dyoung@redhat.com>, stable <stable@vger.kernel.org>, Linus Torvalds <torvalds@linux-foundation.org>, Borislav Petkov <bp@alien8.de>, Andy Lutomirski <luto@kernel.org>, Denys Vlasenko <dvlasenk@redhat.com>, Brian Gerst <brgerst@gmail.com>, Andrew Morton <akpm@linux-foundation.org> Subject: Re: [PATCH 1/2] x86/efi: Map EFI memmap entries in-order at runtime Date: Sat, 26 Sep 2015 13:09:17 -0700 [thread overview] Message-ID: <BFDFFBC6-C6CA-4035-8E29-C7220533A787@linaro.org> (raw) In-Reply-To: <20150926195755.GC3144@codeblueprint.co.uk> > On 26 sep. 2015, at 12:57, Matt Fleming <matt@codeblueprint.co.uk> wrote: > >> On Sat, 26 Sep, at 12:49:26PM, H. Peter Anvin wrote: >> >> It is still a hack unless all relative offsets are preserved. That >> is actually simpler, even: no sorting necessary. > > Unless I'm missing something, preserving relative offsets is exactly > what we do today, modulo PMD_SIZE gaps. > I think what Peter means is preserving the relative offsets inside the entire 1:1 space. This is not at all what we do currently, and i don't think it is generally feasible on 32-bit (since the physical range may conflict with the virtual kernel mappings) However, on 64 bit (both arm and x86), this boils down to not calling setVA() in the first place, which i'm all in favor of. -- Ard. > -- > Matt Fleming, Intel Open Source Technology Center
WARNING: multiple messages have this Message-ID (diff)
From: Ard Biesheuvel <ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> To: Matt Fleming <matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org> Cc: "H. Peter Anvin" <hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>, Andy Lutomirski <luto-kltTT9wpgjJwATOyAt5JVQ@public.gmane.org>, Ingo Molnar <mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>, Matt Fleming <matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>, "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, "linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, "Lee, Chun-Yi" <jlee-IBi9RG/b67k@public.gmane.org>, Borislav Petkov <bp-l3A5Bk7waGM@public.gmane.org>, Leif Lindholm <leif.lindholm-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>, Peter Jones <pjones-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>, James Bottomley <JBottomley-wo1vFcy6AUs@public.gmane.org>, Matthew Garrett <mjg59-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org>, Dave Young <dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>, stable <stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, Linus Torvalds <torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>, Borislav Petkov <bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org>, Andy Lutomirski <luto-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, Denys Vlasenko <dvlasenk-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>, Brian Gerst <brgerst-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, Andrew Morton <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org> Subject: Re: [PATCH 1/2] x86/efi: Map EFI memmap entries in-order at runtime Date: Sat, 26 Sep 2015 13:09:17 -0700 [thread overview] Message-ID: <BFDFFBC6-C6CA-4035-8E29-C7220533A787@linaro.org> (raw) In-Reply-To: <20150926195755.GC3144-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org> > On 26 sep. 2015, at 12:57, Matt Fleming <matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org> wrote: > >> On Sat, 26 Sep, at 12:49:26PM, H. Peter Anvin wrote: >> >> It is still a hack unless all relative offsets are preserved. That >> is actually simpler, even: no sorting necessary. > > Unless I'm missing something, preserving relative offsets is exactly > what we do today, modulo PMD_SIZE gaps. > I think what Peter means is preserving the relative offsets inside the entire 1:1 space. This is not at all what we do currently, and i don't think it is generally feasible on 32-bit (since the physical range may conflict with the virtual kernel mappings) However, on 64 bit (both arm and x86), this boils down to not calling setVA() in the first place, which i'm all in favor of. -- Ard. > -- > Matt Fleming, Intel Open Source Technology Center
next prev parent reply other threads:[~2015-09-26 20:09 UTC|newest] Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-09-25 22:02 [GIT PULL 0/2] EFI urgent fixes Matt Fleming 2015-09-25 22:02 ` Matt Fleming 2015-09-25 22:02 ` [PATCH 1/2] x86/efi: Map EFI memmap entries in-order at runtime Matt Fleming 2015-09-25 22:02 ` Matt Fleming 2015-09-26 5:56 ` Ingo Molnar 2015-09-26 5:56 ` Ingo Molnar 2015-09-26 6:44 ` Ard Biesheuvel 2015-09-26 6:44 ` Ard Biesheuvel 2015-09-26 13:43 ` Matt Fleming 2015-09-27 7:03 ` Ingo Molnar 2015-09-27 7:03 ` Ingo Molnar 2015-09-28 6:49 ` Ard Biesheuvel 2015-09-28 8:22 ` Ingo Molnar 2015-09-28 8:22 ` Ingo Molnar 2015-09-28 9:51 ` Ard Biesheuvel 2015-09-28 9:51 ` Ard Biesheuvel 2015-09-29 9:12 ` Ingo Molnar 2015-09-29 10:41 ` Ard Biesheuvel 2015-09-29 14:18 ` Matt Fleming 2015-09-29 14:18 ` Matt Fleming 2015-09-29 13:52 ` Matt Fleming 2015-09-29 13:52 ` Matt Fleming 2015-09-26 17:01 ` Andy Lutomirski 2015-09-26 17:01 ` Andy Lutomirski 2015-09-26 17:20 ` H. Peter Anvin 2015-09-26 18:15 ` Ard Biesheuvel 2015-09-26 18:15 ` Ard Biesheuvel 2015-09-26 19:49 ` H. Peter Anvin 2015-09-26 19:57 ` Matt Fleming 2015-09-26 20:09 ` Ard Biesheuvel [this message] 2015-09-26 20:09 ` Ard Biesheuvel 2015-09-26 20:19 ` H. Peter Anvin 2015-09-27 16:30 ` Andy Lutomirski 2015-09-27 18:06 ` Matthew Garrett 2015-09-27 18:06 ` Matthew Garrett 2015-09-28 6:16 ` Ingo Molnar 2015-09-28 6:16 ` Ingo Molnar 2015-09-28 6:41 ` Matthew Garrett 2015-09-29 21:58 ` Laszlo Ersek 2015-09-29 21:58 ` Laszlo Ersek 2015-09-30 9:30 ` Ard Biesheuvel 2015-09-30 16:43 ` Andy Lutomirski 2015-09-30 16:43 ` Andy Lutomirski 2015-09-30 17:24 ` James Bottomley 2015-09-30 17:24 ` James Bottomley 2015-09-30 17:24 ` James Bottomley 2015-09-30 0:54 ` H. Peter Anvin 2015-09-30 0:54 ` H. Peter Anvin 2015-09-26 19:55 ` Matt Fleming 2015-09-26 19:55 ` Matt Fleming 2015-09-27 6:50 ` Ingo Molnar 2015-10-01 12:48 ` [tip:core/urgent] x86/efi: Fix boot crash by mapping EFI memmap entries bottom-up at runtime, instead of top-down tip-bot for Matt Fleming 2015-10-02 9:44 ` Matt Fleming 2015-09-25 22:02 ` [PATCH 2/2] arm64/efi: Don't pad between EFI_MEMORY_RUNTIME regions Matt Fleming 2015-09-25 22:02 ` Matt Fleming 2015-09-26 6:01 ` Ingo Molnar 2015-09-26 6:01 ` Ingo Molnar 2015-09-26 7:08 ` Ard Biesheuvel 2015-09-26 7:08 ` Ard Biesheuvel 2015-09-27 7:06 ` Ingo Molnar 2015-09-27 7:06 ` Ingo Molnar 2015-09-27 10:40 ` Borislav Petkov 2015-09-28 6:20 ` Ingo Molnar 2015-09-29 9:31 ` Dave Young 2015-09-29 10:24 ` Borislav Petkov 2015-09-29 14:36 ` Matt Fleming 2015-09-29 14:36 ` Matt Fleming 2015-09-30 0:56 ` H. Peter Anvin 2015-09-30 0:56 ` H. Peter Anvin 2015-09-30 8:33 ` Borislav Petkov 2015-09-30 8:33 ` Borislav Petkov 2015-09-30 1:03 ` H. Peter Anvin 2015-09-30 1:16 ` Andy Lutomirski 2015-09-30 1:19 ` H. Peter Anvin 2015-09-30 4:24 ` Ard Biesheuvel 2015-09-30 4:24 ` Ard Biesheuvel 2015-10-01 10:44 ` Ingo Molnar 2015-10-01 12:49 ` [tip:core/urgent] arm64/efi: Fix boot crash by not padding " tip-bot for Ard Biesheuvel
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=BFDFFBC6-C6CA-4035-8E29-C7220533A787@linaro.org \ --to=ard.biesheuvel@linaro.org \ --cc=JBottomley@odin.com \ --cc=akpm@linux-foundation.org \ --cc=bp@alien8.de \ --cc=bp@suse.de \ --cc=brgerst@gmail.com \ --cc=dvlasenk@redhat.com \ --cc=dyoung@redhat.com \ --cc=hpa@zytor.com \ --cc=jlee@suse.com \ --cc=leif.lindholm@linaro.org \ --cc=linux-efi@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=luto@amacapital.net \ --cc=luto@kernel.org \ --cc=matt.fleming@intel.com \ --cc=matt@codeblueprint.co.uk \ --cc=mingo@kernel.org \ --cc=mjg59@srcf.ucam.org \ --cc=pjones@redhat.com \ --cc=stable@vger.kernel.org \ --cc=tglx@linutronix.de \ --cc=torvalds@linux-foundation.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.