From: Ard Biesheuvel <ard.biesheuvel@linaro.org> To: "H. Peter Anvin" <hpa@zytor.com> Cc: Andy Lutomirski <luto@amacapital.net>, Ingo Molnar <mingo@kernel.org>, Matt Fleming <matt@codeblueprint.co.uk>, Thomas Gleixner <tglx@linutronix.de>, Matt Fleming <matt.fleming@intel.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-efi@vger.kernel.org" <linux-efi@vger.kernel.org>, "Lee, Chun-Yi" <jlee@suse.com>, Borislav Petkov <bp@suse.de>, Leif Lindholm <leif.lindholm@linaro.org>, Peter Jones <pjones@redhat.com>, James Bottomley <JBottomley@odin.com>, Matthew Garrett <mjg59@srcf.ucam.org>, Dave Young <dyoung@redhat.com>, stable <stable@vger.kernel.org>, Linus Torvalds <torvalds@linux-foundation.org>, Borislav Petkov <bp@alien8.de>, Andy Lutomirski <luto@kernel.org>, Denys Vlasenko <dvlasenk@redhat.com>, Brian Gerst <brgerst@gmail.com>, Andrew Morton <akpm@linux-foundation.org> Subject: Re: [PATCH 1/2] x86/efi: Map EFI memmap entries in-order at runtime Date: Sat, 26 Sep 2015 11:15:57 -0700 [thread overview] Message-ID: <CAKv+Gu8i4KuXYQZA5noTomj6-chZcuuDEQubOJznyP1DR=+VTw@mail.gmail.com> (raw) In-Reply-To: <E40EBF14-FD9E-49C0-A7FB-951958F72F79@zytor.com> On 26 September 2015 at 10:20, H. Peter Anvin <hpa@zytor.com> wrote: > I think it "works" because the affected BIOSes don't put spaces between the chunks. I have discussed this with Matt. > Forgive the ASCII art but perhaps an illustration might help: before the 2.5 feature, PE/COFF runtime images were remapped as illustrated here: PA VA +---------------+ +---------------+ | | | | | PE/COFF .text | | EFI | | | | Runtime | +- - - - - - - -+ => | Services |----+ | | | Code | | : : | PE/COFF .data | | | | : : | | | | | +---------------+ +---------------+ +---------------+ | | | | | | | | | EFI | : : : : | | Runtime | : : : : +--->| Services | | | | | | Code | +---------------+ +---------------+ | | | | | | | | | PE/COFF .text | | EFI | +---------------+ | | | Runtime | : gap : +- - - - - - - -+ => | Services |---+ +---------------+ | | | Code | | | | | PE/COFF .data | | | | | EFI | | | | | | | Runtime | +---------------+ +---------------+ +---->| Services | | | | | | Code | : : : : | | : : : : | | : : : : +---------------+ : : : : : : Since the affected symbol references only exist between PE/COFF .text and PE/COFF .data, there is never a problem since each is PE/COFF image is mapped as a single region. However, with the new feature enabled, this no longer holds: PA VA +---------------+ +---------------+ | | | | | PE/COFF .text | | RtServices |----+ | | | Code | | +- - - - - - - -+ => +---------------+ | +---------------+ | | | RtServices | +--->| RtServices | | PE/COFF .data | | Data | | Code | | | | |----+ +---------------+ +---------------+ +---------------+ | : gap : | | | | | +---------------+ : : : : +--->| RtServices | : : : : | Data | | | | | +---------------+ +---------------+ +---------------+ : gap : | | | | +---------------+ | PE/COFF .text | | RtServices |-------->| RtServices | | | | Code | | Code | +- - - - - - - -+ => +---------------+ +---------------+ | | | RtServices | : gap : | PE/COFF .data | | Data |---+ +---------------+ | | | | | | RtServices | +---------------+ +---------------+ +---->| Data | | | | | | | : : : : +---------------+ : : : : : : : : : : : : The illustration uses gaps, but obviously, this applies equally to inverting the mapping order, since the PE/COFF .text and .data sections will end up out of order. -- Ard. > On September 26, 2015 10:01:14 AM PDT, Andy Lutomirski <luto@amacapital.net> wrote: >>On Fri, Sep 25, 2015 at 10:56 PM, Ingo Molnar <mingo@kernel.org> wrote: >>> >>> So this commit worries me. >>> >>> This bug is a good find, and the fix is obviously needed and urgent, >>but I'm not >>> sure about the implementation at all. (I've Cc:-ed a few more x86 low >>level >>> gents.) >>> >>> * Matt Fleming <matt@codeblueprint.co.uk> wrote: >>>> + /* >>>> + * Starting in UEFI v2.5 the EFI_PROPERTIES_TABLE >>>> + * config table feature requires us to map all entries >>>> + * in the same order as they appear in the EFI memory >>>> + * map. That is to say, entry N must have a lower >>>> + * virtual address than entry N+1. This is because the >>>> + * firmware toolchain leaves relative references in >>>> + * the code/data sections, which are split and become >>>> + * separate EFI memory regions. Mapping things >>>> + * out-of-order leads to the firmware accessing >>>> + * unmapped addresses. >>>> + * >> >>I'm clearly missing something. What is EFI doing that it doesn't care >>how big the gap between sections is but it still requires them to be >>in order? It's not as though x86_64 has an addressing mode that >>allows only non-negative offsets. >> >>--Andy > > -- > Sent from my Android device with K-9 Mail. Please excuse my brevity.
WARNING: multiple messages have this Message-ID (diff)
From: Ard Biesheuvel <ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> To: "H. Peter Anvin" <hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org> Cc: Andy Lutomirski <luto-kltTT9wpgjJwATOyAt5JVQ@public.gmane.org>, Ingo Molnar <mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, Matt Fleming <matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>, Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>, Matt Fleming <matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>, "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, "linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, "Lee, Chun-Yi" <jlee-IBi9RG/b67k@public.gmane.org>, Borislav Petkov <bp-l3A5Bk7waGM@public.gmane.org>, Leif Lindholm <leif.lindholm-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>, Peter Jones <pjones-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>, James Bottomley <JBottomley-wo1vFcy6AUs@public.gmane.org>, Matthew Garrett <mjg59-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org>, Dave Young <dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>, stable <stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, Linus Torvalds <torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>, Borislav Petkov <bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org>, Andy Lutomirski <luto-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, Denys Vlasenko <dvlasenk-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>, Brian Gerst <brgerst-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, Andrew Morton <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org> Subject: Re: [PATCH 1/2] x86/efi: Map EFI memmap entries in-order at runtime Date: Sat, 26 Sep 2015 11:15:57 -0700 [thread overview] Message-ID: <CAKv+Gu8i4KuXYQZA5noTomj6-chZcuuDEQubOJznyP1DR=+VTw@mail.gmail.com> (raw) In-Reply-To: <E40EBF14-FD9E-49C0-A7FB-951958F72F79-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org> On 26 September 2015 at 10:20, H. Peter Anvin <hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org> wrote: > I think it "works" because the affected BIOSes don't put spaces between the chunks. I have discussed this with Matt. > Forgive the ASCII art but perhaps an illustration might help: before the 2.5 feature, PE/COFF runtime images were remapped as illustrated here: PA VA +---------------+ +---------------+ | | | | | PE/COFF .text | | EFI | | | | Runtime | +- - - - - - - -+ => | Services |----+ | | | Code | | : : | PE/COFF .data | | | | : : | | | | | +---------------+ +---------------+ +---------------+ | | | | | | | | | EFI | : : : : | | Runtime | : : : : +--->| Services | | | | | | Code | +---------------+ +---------------+ | | | | | | | | | PE/COFF .text | | EFI | +---------------+ | | | Runtime | : gap : +- - - - - - - -+ => | Services |---+ +---------------+ | | | Code | | | | | PE/COFF .data | | | | | EFI | | | | | | | Runtime | +---------------+ +---------------+ +---->| Services | | | | | | Code | : : : : | | : : : : | | : : : : +---------------+ : : : : : : Since the affected symbol references only exist between PE/COFF .text and PE/COFF .data, there is never a problem since each is PE/COFF image is mapped as a single region. However, with the new feature enabled, this no longer holds: PA VA +---------------+ +---------------+ | | | | | PE/COFF .text | | RtServices |----+ | | | Code | | +- - - - - - - -+ => +---------------+ | +---------------+ | | | RtServices | +--->| RtServices | | PE/COFF .data | | Data | | Code | | | | |----+ +---------------+ +---------------+ +---------------+ | : gap : | | | | | +---------------+ : : : : +--->| RtServices | : : : : | Data | | | | | +---------------+ +---------------+ +---------------+ : gap : | | | | +---------------+ | PE/COFF .text | | RtServices |-------->| RtServices | | | | Code | | Code | +- - - - - - - -+ => +---------------+ +---------------+ | | | RtServices | : gap : | PE/COFF .data | | Data |---+ +---------------+ | | | | | | RtServices | +---------------+ +---------------+ +---->| Data | | | | | | | : : : : +---------------+ : : : : : : : : : : : : The illustration uses gaps, but obviously, this applies equally to inverting the mapping order, since the PE/COFF .text and .data sections will end up out of order. -- Ard. > On September 26, 2015 10:01:14 AM PDT, Andy Lutomirski <luto-kltTT9wpgjJwATOyAt5JVQ@public.gmane.org> wrote: >>On Fri, Sep 25, 2015 at 10:56 PM, Ingo Molnar <mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote: >>> >>> So this commit worries me. >>> >>> This bug is a good find, and the fix is obviously needed and urgent, >>but I'm not >>> sure about the implementation at all. (I've Cc:-ed a few more x86 low >>level >>> gents.) >>> >>> * Matt Fleming <matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org> wrote: >>>> + /* >>>> + * Starting in UEFI v2.5 the EFI_PROPERTIES_TABLE >>>> + * config table feature requires us to map all entries >>>> + * in the same order as they appear in the EFI memory >>>> + * map. That is to say, entry N must have a lower >>>> + * virtual address than entry N+1. This is because the >>>> + * firmware toolchain leaves relative references in >>>> + * the code/data sections, which are split and become >>>> + * separate EFI memory regions. Mapping things >>>> + * out-of-order leads to the firmware accessing >>>> + * unmapped addresses. >>>> + * >> >>I'm clearly missing something. What is EFI doing that it doesn't care >>how big the gap between sections is but it still requires them to be >>in order? It's not as though x86_64 has an addressing mode that >>allows only non-negative offsets. >> >>--Andy > > -- > Sent from my Android device with K-9 Mail. Please excuse my brevity.
next prev parent reply other threads:[~2015-09-26 18:16 UTC|newest] Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-09-25 22:02 [GIT PULL 0/2] EFI urgent fixes Matt Fleming 2015-09-25 22:02 ` Matt Fleming 2015-09-25 22:02 ` [PATCH 1/2] x86/efi: Map EFI memmap entries in-order at runtime Matt Fleming 2015-09-25 22:02 ` Matt Fleming 2015-09-26 5:56 ` Ingo Molnar 2015-09-26 5:56 ` Ingo Molnar 2015-09-26 6:44 ` Ard Biesheuvel 2015-09-26 6:44 ` Ard Biesheuvel 2015-09-26 13:43 ` Matt Fleming 2015-09-27 7:03 ` Ingo Molnar 2015-09-27 7:03 ` Ingo Molnar 2015-09-28 6:49 ` Ard Biesheuvel 2015-09-28 8:22 ` Ingo Molnar 2015-09-28 8:22 ` Ingo Molnar 2015-09-28 9:51 ` Ard Biesheuvel 2015-09-28 9:51 ` Ard Biesheuvel 2015-09-29 9:12 ` Ingo Molnar 2015-09-29 10:41 ` Ard Biesheuvel 2015-09-29 14:18 ` Matt Fleming 2015-09-29 14:18 ` Matt Fleming 2015-09-29 13:52 ` Matt Fleming 2015-09-29 13:52 ` Matt Fleming 2015-09-26 17:01 ` Andy Lutomirski 2015-09-26 17:01 ` Andy Lutomirski 2015-09-26 17:20 ` H. Peter Anvin 2015-09-26 18:15 ` Ard Biesheuvel [this message] 2015-09-26 18:15 ` Ard Biesheuvel 2015-09-26 19:49 ` H. Peter Anvin 2015-09-26 19:57 ` Matt Fleming 2015-09-26 20:09 ` Ard Biesheuvel 2015-09-26 20:09 ` Ard Biesheuvel 2015-09-26 20:19 ` H. Peter Anvin 2015-09-27 16:30 ` Andy Lutomirski 2015-09-27 18:06 ` Matthew Garrett 2015-09-27 18:06 ` Matthew Garrett 2015-09-28 6:16 ` Ingo Molnar 2015-09-28 6:16 ` Ingo Molnar 2015-09-28 6:41 ` Matthew Garrett 2015-09-29 21:58 ` Laszlo Ersek 2015-09-29 21:58 ` Laszlo Ersek 2015-09-30 9:30 ` Ard Biesheuvel 2015-09-30 16:43 ` Andy Lutomirski 2015-09-30 16:43 ` Andy Lutomirski 2015-09-30 17:24 ` James Bottomley 2015-09-30 17:24 ` James Bottomley 2015-09-30 17:24 ` James Bottomley 2015-09-30 0:54 ` H. Peter Anvin 2015-09-30 0:54 ` H. Peter Anvin 2015-09-26 19:55 ` Matt Fleming 2015-09-26 19:55 ` Matt Fleming 2015-09-27 6:50 ` Ingo Molnar 2015-10-01 12:48 ` [tip:core/urgent] x86/efi: Fix boot crash by mapping EFI memmap entries bottom-up at runtime, instead of top-down tip-bot for Matt Fleming 2015-10-02 9:44 ` Matt Fleming 2015-09-25 22:02 ` [PATCH 2/2] arm64/efi: Don't pad between EFI_MEMORY_RUNTIME regions Matt Fleming 2015-09-25 22:02 ` Matt Fleming 2015-09-26 6:01 ` Ingo Molnar 2015-09-26 6:01 ` Ingo Molnar 2015-09-26 7:08 ` Ard Biesheuvel 2015-09-26 7:08 ` Ard Biesheuvel 2015-09-27 7:06 ` Ingo Molnar 2015-09-27 7:06 ` Ingo Molnar 2015-09-27 10:40 ` Borislav Petkov 2015-09-28 6:20 ` Ingo Molnar 2015-09-29 9:31 ` Dave Young 2015-09-29 10:24 ` Borislav Petkov 2015-09-29 14:36 ` Matt Fleming 2015-09-29 14:36 ` Matt Fleming 2015-09-30 0:56 ` H. Peter Anvin 2015-09-30 0:56 ` H. Peter Anvin 2015-09-30 8:33 ` Borislav Petkov 2015-09-30 8:33 ` Borislav Petkov 2015-09-30 1:03 ` H. Peter Anvin 2015-09-30 1:16 ` Andy Lutomirski 2015-09-30 1:19 ` H. Peter Anvin 2015-09-30 4:24 ` Ard Biesheuvel 2015-09-30 4:24 ` Ard Biesheuvel 2015-10-01 10:44 ` Ingo Molnar 2015-10-01 12:49 ` [tip:core/urgent] arm64/efi: Fix boot crash by not padding " tip-bot for Ard Biesheuvel
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAKv+Gu8i4KuXYQZA5noTomj6-chZcuuDEQubOJznyP1DR=+VTw@mail.gmail.com' \ --to=ard.biesheuvel@linaro.org \ --cc=JBottomley@odin.com \ --cc=akpm@linux-foundation.org \ --cc=bp@alien8.de \ --cc=bp@suse.de \ --cc=brgerst@gmail.com \ --cc=dvlasenk@redhat.com \ --cc=dyoung@redhat.com \ --cc=hpa@zytor.com \ --cc=jlee@suse.com \ --cc=leif.lindholm@linaro.org \ --cc=linux-efi@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=luto@amacapital.net \ --cc=luto@kernel.org \ --cc=matt.fleming@intel.com \ --cc=matt@codeblueprint.co.uk \ --cc=mingo@kernel.org \ --cc=mjg59@srcf.ucam.org \ --cc=pjones@redhat.com \ --cc=stable@vger.kernel.org \ --cc=tglx@linutronix.de \ --cc=torvalds@linux-foundation.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.