From: Suzuki K Poulose <suzuki.poulose@arm.com> To: Rob Herring <robh@kernel.org>, Anshuman Khandual <anshuman.khandual@arm.com> Cc: mathieu.poirier@linaro.org, coresight@lists.linaro.org, Linu Cherian <lcherian@marvell.com>, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, mike.leach@linaro.org, devicetree@vger.kernel.org Subject: Re: [PATCH V2 11/11] dts: bindings: Document device tree bindings for Arm TRBE Date: Thu, 14 Jan 2021 10:17:08 +0000 [thread overview] Message-ID: <b35f87bf-554f-444c-8b8e-9d62cf12d8f7@arm.com> (raw) In-Reply-To: <1610552704.268262.2506183.nullmailer@robh.at.kernel.org> Hi Rob On 1/13/21 3:45 PM, Rob Herring wrote: > On Wed, 13 Jan 2021 09:48:18 +0530, Anshuman Khandual wrote: >> From: Suzuki K Poulose <suzuki.poulose@arm.com> >> >> Document the device tree bindings for Trace Buffer Extension (TRBE). >> >> Cc: Anshuman Khandual <anshuman.khandual@arm.com> >> Cc: Mathieu Poirier <mathieu.poirier@linaro.org> >> Cc: Rob Herring <robh@kernel.org> >> Cc: devicetree@vger.kernel.org >> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com> >> Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com> >> --- >> Documentation/devicetree/bindings/arm/trbe.yaml | 46 +++++++++++++++++++++++++ >> 1 file changed, 46 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/arm/trbe.yaml >> > > My bot found errors running 'make dt_binding_check' on your patch: > > yamllint warnings/errors: > ./Documentation/devicetree/bindings/arm/trbe.yaml:39:2: [warning] wrong indentation: expected 2 but found 1 (indentation) > > dtschema/dtc warnings/errors: Thanks for that. I guess Anshuman can fix this up, with the following patch: diff --git a/Documentation/devicetree/bindings/arm/trbe.yaml b/Documentation/devicetree/bindings/arm/trbe.yaml index 2258595c40dd..24951e02fa58 100644 --- a/Documentation/devicetree/bindings/arm/trbe.yaml +++ b/Documentation/devicetree/bindings/arm/trbe.yaml @@ -36,7 +36,7 @@ additionalProperties: false examples: - - | + - | #include <dt-bindings/interrupt-controller/arm-gic.h> trbe { > > See https://patchwork.ozlabs.org/patch/1425605 > > This check can fail if there are any dependencies. The base for a patch > series is generally the most recent rc1. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: I did see the warning, but I thought I fixed it. Sorry about that. Cheers Suzuki
WARNING: multiple messages have this Message-ID (diff)
From: Suzuki K Poulose <suzuki.poulose@arm.com> To: Rob Herring <robh@kernel.org>, Anshuman Khandual <anshuman.khandual@arm.com> Cc: devicetree@vger.kernel.org, mathieu.poirier@linaro.org, coresight@lists.linaro.org, linux-kernel@vger.kernel.org, Linu Cherian <lcherian@marvell.com>, linux-arm-kernel@lists.infradead.org, mike.leach@linaro.org Subject: Re: [PATCH V2 11/11] dts: bindings: Document device tree bindings for Arm TRBE Date: Thu, 14 Jan 2021 10:17:08 +0000 [thread overview] Message-ID: <b35f87bf-554f-444c-8b8e-9d62cf12d8f7@arm.com> (raw) In-Reply-To: <1610552704.268262.2506183.nullmailer@robh.at.kernel.org> Hi Rob On 1/13/21 3:45 PM, Rob Herring wrote: > On Wed, 13 Jan 2021 09:48:18 +0530, Anshuman Khandual wrote: >> From: Suzuki K Poulose <suzuki.poulose@arm.com> >> >> Document the device tree bindings for Trace Buffer Extension (TRBE). >> >> Cc: Anshuman Khandual <anshuman.khandual@arm.com> >> Cc: Mathieu Poirier <mathieu.poirier@linaro.org> >> Cc: Rob Herring <robh@kernel.org> >> Cc: devicetree@vger.kernel.org >> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com> >> Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com> >> --- >> Documentation/devicetree/bindings/arm/trbe.yaml | 46 +++++++++++++++++++++++++ >> 1 file changed, 46 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/arm/trbe.yaml >> > > My bot found errors running 'make dt_binding_check' on your patch: > > yamllint warnings/errors: > ./Documentation/devicetree/bindings/arm/trbe.yaml:39:2: [warning] wrong indentation: expected 2 but found 1 (indentation) > > dtschema/dtc warnings/errors: Thanks for that. I guess Anshuman can fix this up, with the following patch: diff --git a/Documentation/devicetree/bindings/arm/trbe.yaml b/Documentation/devicetree/bindings/arm/trbe.yaml index 2258595c40dd..24951e02fa58 100644 --- a/Documentation/devicetree/bindings/arm/trbe.yaml +++ b/Documentation/devicetree/bindings/arm/trbe.yaml @@ -36,7 +36,7 @@ additionalProperties: false examples: - - | + - | #include <dt-bindings/interrupt-controller/arm-gic.h> trbe { > > See https://patchwork.ozlabs.org/patch/1425605 > > This check can fail if there are any dependencies. The base for a patch > series is generally the most recent rc1. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: I did see the warning, but I thought I fixed it. Sorry about that. Cheers Suzuki _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-01-14 10:18 UTC|newest] Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-01-13 4:18 [PATCH V2 00/11] arm64: coresight: Enable ETE and TRBE Anshuman Khandual 2021-01-13 4:18 ` Anshuman Khandual 2021-01-13 4:18 ` [PATCH V2 01/11] coresight: etm-perf: Allow an event to use different sinks Anshuman Khandual 2021-01-13 4:18 ` Anshuman Khandual 2021-01-13 4:18 ` [PATCH V2 02/11] coresight: Do not scan for graph if none is present Anshuman Khandual 2021-01-13 4:18 ` Anshuman Khandual 2021-01-13 4:18 ` [PATCH V2 03/11] coresight: etm4x: Add support for PE OS lock Anshuman Khandual 2021-01-13 4:18 ` Anshuman Khandual 2021-01-13 4:18 ` [PATCH V2 04/11] coresight: ete: Add support for ETE sysreg access Anshuman Khandual 2021-01-13 4:18 ` Anshuman Khandual 2021-01-13 4:18 ` [PATCH V2 05/11] coresight: ete: Add support for ETE tracing Anshuman Khandual 2021-01-13 4:18 ` Anshuman Khandual 2021-01-13 4:18 ` [PATCH V2 06/11] dts: bindings: Document device tree bindings for ETE Anshuman Khandual 2021-01-13 4:18 ` Anshuman Khandual 2021-01-25 19:22 ` Rob Herring 2021-01-25 19:22 ` Rob Herring 2021-01-25 22:20 ` Suzuki K Poulose 2021-01-25 22:20 ` Suzuki K Poulose 2021-01-25 23:28 ` Suzuki K Poulose 2021-01-25 23:28 ` Suzuki K Poulose 2021-01-13 4:18 ` [PATCH V2 07/11] arm64: Add TRBE definitions Anshuman Khandual 2021-01-13 4:18 ` Anshuman Khandual 2021-01-13 9:21 ` Suzuki K Poulose 2021-01-13 9:21 ` Suzuki K Poulose 2021-01-15 1:52 ` Anshuman Khandual 2021-01-15 1:52 ` Anshuman Khandual 2021-02-22 13:55 ` Catalin Marinas 2021-02-22 13:55 ` Catalin Marinas 2021-02-22 13:59 ` Catalin Marinas 2021-02-22 13:59 ` Catalin Marinas 2021-01-13 4:18 ` [PATCH V2 08/11] coresight: core: Add support for dedicated percpu sinks Anshuman Khandual 2021-01-13 4:18 ` Anshuman Khandual 2021-01-13 9:43 ` Suzuki K Poulose 2021-01-13 9:43 ` Suzuki K Poulose 2021-01-15 2:36 ` Anshuman Khandual 2021-01-15 2:36 ` Anshuman Khandual 2021-01-15 12:31 ` Suzuki K Poulose 2021-01-15 12:31 ` Suzuki K Poulose 2021-01-13 4:18 ` [PATCH V2 09/11] coresight: etm-perf: Truncate the perf record if handle has no space Anshuman Khandual 2021-01-13 4:18 ` Anshuman Khandual 2021-01-13 9:48 ` Suzuki K Poulose 2021-01-13 9:48 ` Suzuki K Poulose 2021-01-13 4:18 ` [PATCH V2 10/11] coresight: sink: Add TRBE driver Anshuman Khandual 2021-01-13 4:18 ` Anshuman Khandual 2021-01-13 15:28 ` Suzuki K Poulose 2021-01-13 15:28 ` Suzuki K Poulose 2021-01-15 5:29 ` Anshuman Khandual 2021-01-15 5:29 ` Anshuman Khandual 2021-01-15 12:43 ` Suzuki K Poulose 2021-01-15 12:43 ` Suzuki K Poulose 2021-01-17 12:10 ` Anshuman Khandual 2021-01-17 12:10 ` Anshuman Khandual 2021-01-13 4:18 ` [PATCH V2 11/11] dts: bindings: Document device tree bindings for Arm TRBE Anshuman Khandual 2021-01-13 4:18 ` Anshuman Khandual 2021-01-13 15:45 ` Rob Herring 2021-01-13 15:45 ` Rob Herring 2021-01-14 10:17 ` Suzuki K Poulose [this message] 2021-01-14 10:17 ` Suzuki K Poulose 2021-01-14 14:07 ` Rob Herring 2021-01-14 14:07 ` Rob Herring 2021-01-14 14:47 ` Suzuki K Poulose 2021-01-14 14:47 ` Suzuki K Poulose
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=b35f87bf-554f-444c-8b8e-9d62cf12d8f7@arm.com \ --to=suzuki.poulose@arm.com \ --cc=anshuman.khandual@arm.com \ --cc=coresight@lists.linaro.org \ --cc=devicetree@vger.kernel.org \ --cc=lcherian@marvell.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mathieu.poirier@linaro.org \ --cc=mike.leach@linaro.org \ --cc=robh@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.