From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
alsa-devel@alsa-project.org
Cc: linux-usb@vger.kernel.org, tglx@linutronix.de,
Takashi Iwai <tiwai@suse.com>, Jaroslav Kysela <perex@perex.cz>
Subject: [4/9] ALSA: usb-audio: use usb_fill_int_urb()
Date: Wed, 20 Jun 2018 11:23:12 +0300 [thread overview]
Message-ID: <ce8ffb2b-35e8-1108-9065-81f4d3cb4d8d@cogentembedded.com> (raw)
Hello!
On 6/20/2018 12:55 AM, Sebastian Andrzej Siewior wrote:
> Using usb_fill_int_urb() helps to find code which initializes an
> URB. A grep for members of the struct (like ->complete) reveal lots
> of other things, too.
>
> data_ep_set_params() additionally sets urb->transfer_buffer_length which
> was not the case earlier.
> data_ep_set_params() and data_ep_set_params()
These 2 are the same function?
> ensure that syncinterval is
> within the allowed range on HS/SS. The interval value seems to come from
> snd_usb_parse_datainterval() which is bInterval - 1 and only in the rage 1 … 4.
> So in order to keep the magic wokring I pass datainterval + 1.
Working.
> Cc: Jaroslav Kysela <perex@perex.cz>
> Cc: Takashi Iwai <tiwai@suse.com>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
[...]
MBR, Sergei
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
alsa-devel@alsa-project.org
Cc: tglx@linutronix.de, linux-usb@vger.kernel.org,
Takashi Iwai <tiwai@suse.com>
Subject: Re: [PATCH 4/9] ALSA: usb-audio: use usb_fill_int_urb()
Date: Wed, 20 Jun 2018 11:23:12 +0300 [thread overview]
Message-ID: <ce8ffb2b-35e8-1108-9065-81f4d3cb4d8d@cogentembedded.com> (raw)
In-Reply-To: <20180619215521.13688-5-bigeasy@linutronix.de>
Hello!
On 6/20/2018 12:55 AM, Sebastian Andrzej Siewior wrote:
> Using usb_fill_int_urb() helps to find code which initializes an
> URB. A grep for members of the struct (like ->complete) reveal lots
> of other things, too.
>
> data_ep_set_params() additionally sets urb->transfer_buffer_length which
> was not the case earlier.
> data_ep_set_params() and data_ep_set_params()
These 2 are the same function?
> ensure that syncinterval is
> within the allowed range on HS/SS. The interval value seems to come from
> snd_usb_parse_datainterval() which is bInterval - 1 and only in the rage 1 … 4.
> So in order to keep the magic wokring I pass datainterval + 1.
Working.
> Cc: Jaroslav Kysela <perex@perex.cz>
> Cc: Takashi Iwai <tiwai@suse.com>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
[...]
MBR, Sergei
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next reply other threads:[~2018-06-20 8:23 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-20 8:23 Sergei Shtylyov [this message]
2018-06-20 8:23 ` [PATCH 4/9] ALSA: usb-audio: use usb_fill_int_urb() Sergei Shtylyov
-- strict thread matches above, loose matches on Subject: below --
2018-06-22 10:14 [6/9] ALSA: usb: caiaq: " Sebastian Andrzej Siewior
2018-06-22 10:14 ` [PATCH 6/9] " Sebastian Andrzej Siewior
2018-06-22 10:01 [6/9] " Daniel Mack
2018-06-22 10:01 ` [PATCH 6/9] " Daniel Mack
2018-06-22 8:49 [6/9] " Takashi Iwai
2018-06-22 8:49 ` [PATCH 6/9] " Takashi Iwai
2018-06-21 21:16 [6/9] " Sebastian Andrzej Siewior
2018-06-21 21:16 ` [PATCH 6/9] " Sebastian Andrzej Siewior
2018-06-21 20:19 [6/9] " Daniel Mack
2018-06-21 20:19 ` [PATCH 6/9] " Daniel Mack
2018-06-21 20:18 [5/9] ALSA: usb: caiaq: audio: use irqsave() in USB's complete callback Daniel Mack
2018-06-21 20:18 ` [PATCH 5/9] " Daniel Mack
2018-06-20 16:20 [8/9] ALSA: usx2y: usbusx2yaudio: use usb_fill_int_urb() Takashi Iwai
2018-06-20 16:20 ` [PATCH 8/9] " Takashi Iwai
2018-06-20 15:47 [8/9] " Sebastian Andrzej Siewior
2018-06-20 15:47 ` [PATCH 8/9] " Sebastian Andrzej Siewior
2018-06-20 15:38 [8/9] " Sebastian Andrzej Siewior
2018-06-20 15:38 ` [PATCH 8/9] " Sebastian Andrzej Siewior
2018-06-20 14:52 [8/9] " Takashi Iwai
2018-06-20 14:52 ` [PATCH 8/9] " Takashi Iwai
2018-06-20 14:39 [8/9] " Sebastian Andrzej Siewior
2018-06-20 14:39 ` [PATCH 8/9] " Sebastian Andrzej Siewior
2018-06-20 14:00 [4/9,v2] ALSA: usb-audio: " Takashi Iwai
2018-06-20 14:00 ` [PATCH 4/9 v2] " Takashi Iwai
2018-06-20 13:56 [4/9,v2] " Takashi Iwai
2018-06-20 13:56 ` [PATCH 4/9 v2] " Takashi Iwai
2018-06-20 13:52 [4/9,v2] " Sebastian Andrzej Siewior
2018-06-20 13:52 ` [PATCH 4/9 v2] " Sebastian Andrzej Siewior
2018-06-20 13:21 [4/9,v2] " Takashi Iwai
2018-06-20 13:21 ` [PATCH 4/9 v2] " Takashi Iwai
2018-06-20 12:51 [8/9] ALSA: usx2y: usbusx2yaudio: " Takashi Iwai
2018-06-20 12:51 ` [PATCH 8/9] " Takashi Iwai
2018-06-20 9:38 [4/9,v2] ALSA: usb-audio: " Sebastian Andrzej Siewior
2018-06-20 9:38 ` [PATCH 4/9 v2] " Sebastian Andrzej Siewior
2018-06-19 21:55 [9/9] ALSA: usx2y: usx2yhwdeppcm: " Sebastian Andrzej Siewior
2018-06-19 21:55 ` [PATCH 9/9] " Sebastian Andrzej Siewior
2018-06-19 21:55 [8/9] ALSA: usx2y: usbusx2yaudio: " Sebastian Andrzej Siewior
2018-06-19 21:55 ` [PATCH 8/9] " Sebastian Andrzej Siewior
2018-06-19 21:55 [7/9] ALSA: usb-midi: use irqsave() in USB's complete callback Sebastian Andrzej Siewior
2018-06-19 21:55 ` [PATCH 7/9] " Sebastian Andrzej Siewior
2018-06-19 21:55 [6/9] ALSA: usb: caiaq: use usb_fill_int_urb() Sebastian Andrzej Siewior
2018-06-19 21:55 ` [PATCH 6/9] " Sebastian Andrzej Siewior
2018-06-19 21:55 [5/9] ALSA: usb: caiaq: audio: use irqsave() in USB's complete callback Sebastian Andrzej Siewior
2018-06-19 21:55 ` [PATCH 5/9] " Sebastian Andrzej Siewior
2018-06-19 21:55 [4/9] ALSA: usb-audio: use usb_fill_int_urb() Sebastian Andrzej Siewior
2018-06-19 21:55 ` [PATCH 4/9] " Sebastian Andrzej Siewior
2018-06-19 21:55 [3/9] ALSA: ua101: " Sebastian Andrzej Siewior
2018-06-19 21:55 ` [PATCH 3/9] " Sebastian Andrzej Siewior
2018-06-19 21:55 [2/9] ALSA: line6: " Sebastian Andrzej Siewior
2018-06-19 21:55 ` [PATCH 2/9] " Sebastian Andrzej Siewior
2018-06-19 21:55 [1/9] ALSA: 6fire: " Sebastian Andrzej Siewior
2018-06-19 21:55 ` [PATCH 1/9] " Sebastian Andrzej Siewior
2018-06-19 21:55 ALSA: use irqsave() in URB completion + usb_fill_int_urb Sebastian Andrzej Siewior
2018-06-20 12:55 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce8ffb2b-35e8-1108-9065-81f4d3cb4d8d@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=alsa-devel@alsa-project.org \
--cc=bigeasy@linutronix.de \
--cc=linux-usb@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tglx@linutronix.de \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.