From: Sebastian Andrzej Siewior <bigeasy@linutronix.de> To: Daniel Mack <daniel@zonque.org> Cc: alsa-devel@alsa-project.org, linux-usb@vger.kernel.org, tglx@linutronix.de, Takashi Iwai <tiwai@suse.com>, Jaroslav Kysela <perex@perex.cz> Subject: [6/9] ALSA: usb: caiaq: use usb_fill_int_urb() Date: Fri, 22 Jun 2018 12:14:29 +0200 [thread overview] Message-ID: <20180622101428.wcdnlexsbcvltqpu@linutronix.de> (raw) On 2018-06-22 12:01:13 [+0200], Daniel Mack wrote: > Hmm, there is no such thing as usb_fill_iso_urb() in my tree, are you going > to add that? Yes. > The only part that needs attention is the interval parameter, which is > passed to usb_fill_int_urb() as 1 now, and hence urb->interval will also be > 1, just like the open-coded version before. Unless I miss anything, your > conversion should work, but I haven't tested it yet. It should work in most cases. The point is that the argument expects bInterval (from the endpoint) which has a different encoding on FS vs HS/SS for INTR endpoints but not for ISOC endpoints and I got this wrong initially. > But I agree the function name is misleading, so we should probably get a > usb_fill_iso_urb() and use it where appropriate. AFAICS, it will be > identical to usb_fill_bulk_urb(), as the endpoint type is encoded in the > pipe. Maybe it's worth adding a check? What check? it should be identical to INTR without the speed check (always the HS version should be used). I need to check if it makes sense to extend the parameters to cover ->number_of_packets and so on. Any way, I plan to first RFC the function, land it upstream and then convert the users. > Thanks, > Daniel Sebastian --- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de> To: Daniel Mack <daniel@zonque.org> Cc: alsa-devel@alsa-project.org, linux-usb@vger.kernel.org, tglx@linutronix.de, Takashi Iwai <tiwai@suse.com> Subject: Re: [PATCH 6/9] ALSA: usb: caiaq: use usb_fill_int_urb() Date: Fri, 22 Jun 2018 12:14:29 +0200 [thread overview] Message-ID: <20180622101428.wcdnlexsbcvltqpu@linutronix.de> (raw) In-Reply-To: <156bfc42-650f-1ac0-73d5-085556ae318c@zonque.org> On 2018-06-22 12:01:13 [+0200], Daniel Mack wrote: > Hmm, there is no such thing as usb_fill_iso_urb() in my tree, are you going > to add that? Yes. > The only part that needs attention is the interval parameter, which is > passed to usb_fill_int_urb() as 1 now, and hence urb->interval will also be > 1, just like the open-coded version before. Unless I miss anything, your > conversion should work, but I haven't tested it yet. It should work in most cases. The point is that the argument expects bInterval (from the endpoint) which has a different encoding on FS vs HS/SS for INTR endpoints but not for ISOC endpoints and I got this wrong initially. > But I agree the function name is misleading, so we should probably get a > usb_fill_iso_urb() and use it where appropriate. AFAICS, it will be > identical to usb_fill_bulk_urb(), as the endpoint type is encoded in the > pipe. Maybe it's worth adding a check? What check? it should be identical to INTR without the speed check (always the HS version should be used). I need to check if it makes sense to extend the parameters to cover ->number_of_packets and so on. Any way, I plan to first RFC the function, land it upstream and then convert the users. > Thanks, > Daniel Sebastian
next reply other threads:[~2018-06-22 10:14 UTC|newest] Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-06-22 10:14 Sebastian Andrzej Siewior [this message] 2018-06-22 10:14 ` [PATCH 6/9] ALSA: usb: caiaq: use usb_fill_int_urb() Sebastian Andrzej Siewior -- strict thread matches above, loose matches on Subject: below -- 2018-06-22 10:01 [6/9] " Daniel Mack 2018-06-22 10:01 ` [PATCH 6/9] " Daniel Mack 2018-06-22 8:49 [6/9] " Takashi Iwai 2018-06-22 8:49 ` [PATCH 6/9] " Takashi Iwai 2018-06-21 21:16 [6/9] " Sebastian Andrzej Siewior 2018-06-21 21:16 ` [PATCH 6/9] " Sebastian Andrzej Siewior 2018-06-21 20:19 [6/9] " Daniel Mack 2018-06-21 20:19 ` [PATCH 6/9] " Daniel Mack 2018-06-21 20:18 [5/9] ALSA: usb: caiaq: audio: use irqsave() in USB's complete callback Daniel Mack 2018-06-21 20:18 ` [PATCH 5/9] " Daniel Mack 2018-06-20 16:20 [8/9] ALSA: usx2y: usbusx2yaudio: use usb_fill_int_urb() Takashi Iwai 2018-06-20 16:20 ` [PATCH 8/9] " Takashi Iwai 2018-06-20 15:47 [8/9] " Sebastian Andrzej Siewior 2018-06-20 15:47 ` [PATCH 8/9] " Sebastian Andrzej Siewior 2018-06-20 15:38 [8/9] " Sebastian Andrzej Siewior 2018-06-20 15:38 ` [PATCH 8/9] " Sebastian Andrzej Siewior 2018-06-20 14:52 [8/9] " Takashi Iwai 2018-06-20 14:52 ` [PATCH 8/9] " Takashi Iwai 2018-06-20 14:39 [8/9] " Sebastian Andrzej Siewior 2018-06-20 14:39 ` [PATCH 8/9] " Sebastian Andrzej Siewior 2018-06-20 14:00 [4/9,v2] ALSA: usb-audio: " Takashi Iwai 2018-06-20 14:00 ` [PATCH 4/9 v2] " Takashi Iwai 2018-06-20 13:56 [4/9,v2] " Takashi Iwai 2018-06-20 13:56 ` [PATCH 4/9 v2] " Takashi Iwai 2018-06-20 13:52 [4/9,v2] " Sebastian Andrzej Siewior 2018-06-20 13:52 ` [PATCH 4/9 v2] " Sebastian Andrzej Siewior 2018-06-20 13:21 [4/9,v2] " Takashi Iwai 2018-06-20 13:21 ` [PATCH 4/9 v2] " Takashi Iwai 2018-06-20 12:51 [8/9] ALSA: usx2y: usbusx2yaudio: " Takashi Iwai 2018-06-20 12:51 ` [PATCH 8/9] " Takashi Iwai 2018-06-20 9:38 [4/9,v2] ALSA: usb-audio: " Sebastian Andrzej Siewior 2018-06-20 9:38 ` [PATCH 4/9 v2] " Sebastian Andrzej Siewior 2018-06-20 8:23 [4/9] " Sergei Shtylyov 2018-06-20 8:23 ` [PATCH 4/9] " Sergei Shtylyov 2018-06-19 21:55 [9/9] ALSA: usx2y: usx2yhwdeppcm: " Sebastian Andrzej Siewior 2018-06-19 21:55 ` [PATCH 9/9] " Sebastian Andrzej Siewior 2018-06-19 21:55 [8/9] ALSA: usx2y: usbusx2yaudio: " Sebastian Andrzej Siewior 2018-06-19 21:55 ` [PATCH 8/9] " Sebastian Andrzej Siewior 2018-06-19 21:55 [7/9] ALSA: usb-midi: use irqsave() in USB's complete callback Sebastian Andrzej Siewior 2018-06-19 21:55 ` [PATCH 7/9] " Sebastian Andrzej Siewior 2018-06-19 21:55 [6/9] ALSA: usb: caiaq: use usb_fill_int_urb() Sebastian Andrzej Siewior 2018-06-19 21:55 ` [PATCH 6/9] " Sebastian Andrzej Siewior 2018-06-19 21:55 [5/9] ALSA: usb: caiaq: audio: use irqsave() in USB's complete callback Sebastian Andrzej Siewior 2018-06-19 21:55 ` [PATCH 5/9] " Sebastian Andrzej Siewior 2018-06-19 21:55 [4/9] ALSA: usb-audio: use usb_fill_int_urb() Sebastian Andrzej Siewior 2018-06-19 21:55 ` [PATCH 4/9] " Sebastian Andrzej Siewior 2018-06-19 21:55 [3/9] ALSA: ua101: " Sebastian Andrzej Siewior 2018-06-19 21:55 ` [PATCH 3/9] " Sebastian Andrzej Siewior 2018-06-19 21:55 [2/9] ALSA: line6: " Sebastian Andrzej Siewior 2018-06-19 21:55 ` [PATCH 2/9] " Sebastian Andrzej Siewior 2018-06-19 21:55 [1/9] ALSA: 6fire: " Sebastian Andrzej Siewior 2018-06-19 21:55 ` [PATCH 1/9] " Sebastian Andrzej Siewior 2018-06-19 21:55 ALSA: use irqsave() in URB completion + usb_fill_int_urb Sebastian Andrzej Siewior 2018-06-20 12:55 ` Takashi Iwai
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180622101428.wcdnlexsbcvltqpu@linutronix.de \ --to=bigeasy@linutronix.de \ --cc=alsa-devel@alsa-project.org \ --cc=daniel@zonque.org \ --cc=linux-usb@vger.kernel.org \ --cc=perex@perex.cz \ --cc=tglx@linutronix.de \ --cc=tiwai@suse.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.