From: Takashi Iwai <tiwai@suse.de>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Daniel Mack <daniel@zonque.org>,
alsa-devel@alsa-project.org, linux-usb@vger.kernel.org,
tglx@linutronix.de
Subject: [6/9] ALSA: usb: caiaq: use usb_fill_int_urb()
Date: Fri, 22 Jun 2018 10:49:02 +0200 [thread overview]
Message-ID: <s5hpo0ji4u9.wl-tiwai@suse.de> (raw)
On Thu, 21 Jun 2018 23:16:39 +0200,
Sebastian Andrzej Siewior wrote:
>
> On 2018-06-21 22:19:32 [+0200], Daniel Mack wrote:
> > On Tuesday, June 19, 2018 11:55 PM, Sebastian Andrzej Siewior wrote:
> > > Using usb_fill_int_urb() helps to find code which initializes an
> > > URB. A grep for members of the struct (like ->complete) reveal lots
> > > of other things, too.
> >
> > Acked-by: Daniel Mack <zonque@gmail.com>
>
> nope, please don't.
> Takashi, please ignore the usb_fill_.* patches. I will be doing another
> spin with usb_fill_iso_urb() instead.
This sounds like a better approach, indeed.
thanks,
Takashi
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: alsa-devel@alsa-project.org, linux-usb@vger.kernel.org,
tglx@linutronix.de, Daniel Mack <daniel@zonque.org>
Subject: Re: [PATCH 6/9] ALSA: usb: caiaq: use usb_fill_int_urb()
Date: Fri, 22 Jun 2018 10:49:02 +0200 [thread overview]
Message-ID: <s5hpo0ji4u9.wl-tiwai@suse.de> (raw)
In-Reply-To: <20180621211639.a7vym5mikaejvlgw@linutronix.de>
On Thu, 21 Jun 2018 23:16:39 +0200,
Sebastian Andrzej Siewior wrote:
>
> On 2018-06-21 22:19:32 [+0200], Daniel Mack wrote:
> > On Tuesday, June 19, 2018 11:55 PM, Sebastian Andrzej Siewior wrote:
> > > Using usb_fill_int_urb() helps to find code which initializes an
> > > URB. A grep for members of the struct (like ->complete) reveal lots
> > > of other things, too.
> >
> > Acked-by: Daniel Mack <zonque@gmail.com>
>
> nope, please don't.
> Takashi, please ignore the usb_fill_.* patches. I will be doing another
> spin with usb_fill_iso_urb() instead.
This sounds like a better approach, indeed.
thanks,
Takashi
next reply other threads:[~2018-06-22 8:49 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-22 8:49 Takashi Iwai [this message]
2018-06-22 8:49 ` [PATCH 6/9] ALSA: usb: caiaq: use usb_fill_int_urb() Takashi Iwai
-- strict thread matches above, loose matches on Subject: below --
2018-06-22 10:14 [6/9] " Sebastian Andrzej Siewior
2018-06-22 10:14 ` [PATCH 6/9] " Sebastian Andrzej Siewior
2018-06-22 10:01 [6/9] " Daniel Mack
2018-06-22 10:01 ` [PATCH 6/9] " Daniel Mack
2018-06-21 21:16 [6/9] " Sebastian Andrzej Siewior
2018-06-21 21:16 ` [PATCH 6/9] " Sebastian Andrzej Siewior
2018-06-21 20:19 [6/9] " Daniel Mack
2018-06-21 20:19 ` [PATCH 6/9] " Daniel Mack
2018-06-21 20:18 [5/9] ALSA: usb: caiaq: audio: use irqsave() in USB's complete callback Daniel Mack
2018-06-21 20:18 ` [PATCH 5/9] " Daniel Mack
2018-06-20 16:20 [8/9] ALSA: usx2y: usbusx2yaudio: use usb_fill_int_urb() Takashi Iwai
2018-06-20 16:20 ` [PATCH 8/9] " Takashi Iwai
2018-06-20 15:47 [8/9] " Sebastian Andrzej Siewior
2018-06-20 15:47 ` [PATCH 8/9] " Sebastian Andrzej Siewior
2018-06-20 15:38 [8/9] " Sebastian Andrzej Siewior
2018-06-20 15:38 ` [PATCH 8/9] " Sebastian Andrzej Siewior
2018-06-20 14:52 [8/9] " Takashi Iwai
2018-06-20 14:52 ` [PATCH 8/9] " Takashi Iwai
2018-06-20 14:39 [8/9] " Sebastian Andrzej Siewior
2018-06-20 14:39 ` [PATCH 8/9] " Sebastian Andrzej Siewior
2018-06-20 14:00 [4/9,v2] ALSA: usb-audio: " Takashi Iwai
2018-06-20 14:00 ` [PATCH 4/9 v2] " Takashi Iwai
2018-06-20 13:56 [4/9,v2] " Takashi Iwai
2018-06-20 13:56 ` [PATCH 4/9 v2] " Takashi Iwai
2018-06-20 13:52 [4/9,v2] " Sebastian Andrzej Siewior
2018-06-20 13:52 ` [PATCH 4/9 v2] " Sebastian Andrzej Siewior
2018-06-20 13:21 [4/9,v2] " Takashi Iwai
2018-06-20 13:21 ` [PATCH 4/9 v2] " Takashi Iwai
2018-06-20 12:51 [8/9] ALSA: usx2y: usbusx2yaudio: " Takashi Iwai
2018-06-20 12:51 ` [PATCH 8/9] " Takashi Iwai
2018-06-20 9:38 [4/9,v2] ALSA: usb-audio: " Sebastian Andrzej Siewior
2018-06-20 9:38 ` [PATCH 4/9 v2] " Sebastian Andrzej Siewior
2018-06-20 8:23 [4/9] " Sergei Shtylyov
2018-06-20 8:23 ` [PATCH 4/9] " Sergei Shtylyov
2018-06-19 21:55 [9/9] ALSA: usx2y: usx2yhwdeppcm: " Sebastian Andrzej Siewior
2018-06-19 21:55 ` [PATCH 9/9] " Sebastian Andrzej Siewior
2018-06-19 21:55 [8/9] ALSA: usx2y: usbusx2yaudio: " Sebastian Andrzej Siewior
2018-06-19 21:55 ` [PATCH 8/9] " Sebastian Andrzej Siewior
2018-06-19 21:55 [7/9] ALSA: usb-midi: use irqsave() in USB's complete callback Sebastian Andrzej Siewior
2018-06-19 21:55 ` [PATCH 7/9] " Sebastian Andrzej Siewior
2018-06-19 21:55 [6/9] ALSA: usb: caiaq: use usb_fill_int_urb() Sebastian Andrzej Siewior
2018-06-19 21:55 ` [PATCH 6/9] " Sebastian Andrzej Siewior
2018-06-19 21:55 [5/9] ALSA: usb: caiaq: audio: use irqsave() in USB's complete callback Sebastian Andrzej Siewior
2018-06-19 21:55 ` [PATCH 5/9] " Sebastian Andrzej Siewior
2018-06-19 21:55 [4/9] ALSA: usb-audio: use usb_fill_int_urb() Sebastian Andrzej Siewior
2018-06-19 21:55 ` [PATCH 4/9] " Sebastian Andrzej Siewior
2018-06-19 21:55 [3/9] ALSA: ua101: " Sebastian Andrzej Siewior
2018-06-19 21:55 ` [PATCH 3/9] " Sebastian Andrzej Siewior
2018-06-19 21:55 [2/9] ALSA: line6: " Sebastian Andrzej Siewior
2018-06-19 21:55 ` [PATCH 2/9] " Sebastian Andrzej Siewior
2018-06-19 21:55 [1/9] ALSA: 6fire: " Sebastian Andrzej Siewior
2018-06-19 21:55 ` [PATCH 1/9] " Sebastian Andrzej Siewior
2018-06-19 21:55 ALSA: use irqsave() in URB completion + usb_fill_int_urb Sebastian Andrzej Siewior
2018-06-20 12:55 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hpo0ji4u9.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=bigeasy@linutronix.de \
--cc=daniel@zonque.org \
--cc=linux-usb@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.