From: John Garry <john.garry@huawei.com>
To: Mark Brown <broonie@kernel.org>
Cc: <marek.vasut@gmail.com>, <tudor.ambarus@microchip.com>,
<linuxarm@huawei.com>, <linux-kernel@vger.kernel.org>,
<linux-mtd@lists.infradead.org>, <linux-spi@vger.kernel.org>,
<xuejiancheng@hisilicon.com>, <fengsheng5@huawei.com>,
<chenxiang66@hisilicon.com>
Subject: Re: [PATCH v2 2/3] spi: Add HiSilicon v3xx SPI NOR flash controller driver
Date: Fri, 10 Jan 2020 11:55:37 +0000 [thread overview]
Message-ID: <df67b562-7d82-19f6-7581-680190a7772d@huawei.com> (raw)
In-Reply-To: <20200109212842.GK3702@sirena.org.uk>
On 09/01/2020 21:28, Mark Brown wrote:
> On Thu, Jan 09, 2020 at 03:54:00PM +0000, John Garry wrote:
>
>> From checking acpi_spi_add_resource() or anywhere else, I cannot see how
>> SPI_RX_DUAL or the others are set for spi_device.mode. What am I missing?
>> Are these just not supported yet for ACPI? Or should the spi-nor code not be
>> relying on this since we should be able to get this info from the SPI NOR
>> part?
>
Hi Mark,
> I'm not aware of any work on integrating this sort of stuff into ACPI
> platforms so I think it's just not yet supported in ACPI. I'm not
> really sure what would be idiomatic for ACPI, figuring it out from what
> the part supports might well be idiomatic there though I don't know how
> common it is for people not to wire up all the data lines even if both
> controller and device support wider transfers.
OK, so I guess that is why we require the width property from the FW and
can't blindly rely on SFDP.
I've got a horrible
> feeling that the idiomatic thing is a combination of that and a bunch of
> per-device quirks. There may be a spec I'm not aware of though I'd be a
> bit surprised.
>
I'm not sure on that. I don't see anything in the ACPI spec.
I will note that PRP0001+"jedec,spi-nor" compatible DSD seems to be the
defacto method to describe the SPI NOR-compat part for ACPI - that's
what I'm using. We could add properties there, but that seems improper.
I'll continue to look....
Thanks,
John
WARNING: multiple messages have this Message-ID (diff)
From: John Garry <john.garry-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
To: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: <marek.vasut-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
<tudor.ambarus-UWL1GkI3JZL3oGB3hsPCZA@public.gmane.org>,
<linuxarm-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>,
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
<linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
<linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
<xuejiancheng-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org>,
<fengsheng5-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>,
<chenxiang66-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org>
Subject: Re: [PATCH v2 2/3] spi: Add HiSilicon v3xx SPI NOR flash controller driver
Date: Fri, 10 Jan 2020 11:55:37 +0000 [thread overview]
Message-ID: <df67b562-7d82-19f6-7581-680190a7772d@huawei.com> (raw)
In-Reply-To: <20200109212842.GK3702-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
On 09/01/2020 21:28, Mark Brown wrote:
> On Thu, Jan 09, 2020 at 03:54:00PM +0000, John Garry wrote:
>
>> From checking acpi_spi_add_resource() or anywhere else, I cannot see how
>> SPI_RX_DUAL or the others are set for spi_device.mode. What am I missing?
>> Are these just not supported yet for ACPI? Or should the spi-nor code not be
>> relying on this since we should be able to get this info from the SPI NOR
>> part?
>
Hi Mark,
> I'm not aware of any work on integrating this sort of stuff into ACPI
> platforms so I think it's just not yet supported in ACPI. I'm not
> really sure what would be idiomatic for ACPI, figuring it out from what
> the part supports might well be idiomatic there though I don't know how
> common it is for people not to wire up all the data lines even if both
> controller and device support wider transfers.
OK, so I guess that is why we require the width property from the FW and
can't blindly rely on SFDP.
I've got a horrible
> feeling that the idiomatic thing is a combination of that and a bunch of
> per-device quirks. There may be a spec I'm not aware of though I'd be a
> bit surprised.
>
I'm not sure on that. I don't see anything in the ACPI spec.
I will note that PRP0001+"jedec,spi-nor" compatible DSD seems to be the
defacto method to describe the SPI NOR-compat part for ACPI - that's
what I'm using. We could add properties there, but that seems improper.
I'll continue to look....
Thanks,
John
WARNING: multiple messages have this Message-ID (diff)
From: John Garry <john.garry@huawei.com>
To: Mark Brown <broonie@kernel.org>
Cc: tudor.ambarus@microchip.com, linux-kernel@vger.kernel.org,
chenxiang66@hisilicon.com, linuxarm@huawei.com,
linux-spi@vger.kernel.org, marek.vasut@gmail.com,
linux-mtd@lists.infradead.org, xuejiancheng@hisilicon.com,
fengsheng5@huawei.com
Subject: Re: [PATCH v2 2/3] spi: Add HiSilicon v3xx SPI NOR flash controller driver
Date: Fri, 10 Jan 2020 11:55:37 +0000 [thread overview]
Message-ID: <df67b562-7d82-19f6-7581-680190a7772d@huawei.com> (raw)
In-Reply-To: <20200109212842.GK3702@sirena.org.uk>
On 09/01/2020 21:28, Mark Brown wrote:
> On Thu, Jan 09, 2020 at 03:54:00PM +0000, John Garry wrote:
>
>> From checking acpi_spi_add_resource() or anywhere else, I cannot see how
>> SPI_RX_DUAL or the others are set for spi_device.mode. What am I missing?
>> Are these just not supported yet for ACPI? Or should the spi-nor code not be
>> relying on this since we should be able to get this info from the SPI NOR
>> part?
>
Hi Mark,
> I'm not aware of any work on integrating this sort of stuff into ACPI
> platforms so I think it's just not yet supported in ACPI. I'm not
> really sure what would be idiomatic for ACPI, figuring it out from what
> the part supports might well be idiomatic there though I don't know how
> common it is for people not to wire up all the data lines even if both
> controller and device support wider transfers.
OK, so I guess that is why we require the width property from the FW and
can't blindly rely on SFDP.
I've got a horrible
> feeling that the idiomatic thing is a combination of that and a bunch of
> per-device quirks. There may be a spec I'm not aware of though I'd be a
> bit surprised.
>
I'm not sure on that. I don't see anything in the ACPI spec.
I will note that PRP0001+"jedec,spi-nor" compatible DSD seems to be the
defacto method to describe the SPI NOR-compat part for ACPI - that's
what I'm using. We could add properties there, but that seems improper.
I'll continue to look....
Thanks,
John
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2020-01-10 11:55 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-09 14:08 [PATCH v2 0/3] HiSilicon v3xx SFC driver John Garry
2019-12-09 14:08 ` John Garry
2019-12-09 14:08 ` [PATCH v2 1/3] mtd: spi-nor: hisi-sfc: Try to provide some clarity on which SFC we are John Garry
2019-12-09 14:08 ` John Garry
2020-01-16 11:03 ` Tudor.Ambarus
2020-01-16 11:03 ` Tudor.Ambarus
2019-12-09 14:08 ` [PATCH v2 2/3] spi: Add HiSilicon v3xx SPI NOR flash controller driver John Garry
2019-12-09 14:08 ` John Garry
2020-01-09 15:54 ` John Garry
2020-01-09 15:54 ` John Garry
2020-01-09 21:28 ` Mark Brown
2020-01-09 21:28 ` Mark Brown
2020-01-10 11:55 ` John Garry [this message]
2020-01-10 11:55 ` John Garry
2020-01-10 11:55 ` John Garry
2020-01-10 14:07 ` Mark Brown
2020-01-10 14:07 ` Mark Brown
2020-01-10 14:07 ` Mark Brown
2020-01-10 14:58 ` John Garry
2020-01-10 14:58 ` John Garry
2020-01-10 15:12 ` Mark Brown
2020-01-10 15:12 ` Mark Brown
2020-01-10 16:09 ` John Garry
2020-01-10 16:09 ` John Garry
2020-01-10 19:31 ` Andy Shevchenko
2020-01-10 19:31 ` Andy Shevchenko
2020-01-10 19:31 ` Andy Shevchenko
2020-01-13 10:09 ` John Garry
2020-01-13 10:09 ` John Garry
2020-01-13 11:42 ` Mark Brown
2020-01-13 11:42 ` Mark Brown
2020-01-13 13:01 ` John Garry
2020-01-13 13:01 ` John Garry
2020-01-13 14:06 ` Mark Brown
2020-01-13 14:06 ` Mark Brown
2020-01-13 14:17 ` Andy Shevchenko
2020-01-13 14:17 ` Andy Shevchenko
2020-01-13 14:17 ` Andy Shevchenko
2020-01-13 14:27 ` Mark Brown
2020-01-13 14:27 ` Mark Brown
2020-01-13 14:27 ` Mark Brown
2020-01-13 14:34 ` Andy Shevchenko
2020-01-13 14:34 ` Andy Shevchenko
2020-01-13 14:34 ` Andy Shevchenko
2020-01-31 10:08 ` John Garry
2020-01-31 10:08 ` John Garry
2020-01-31 11:39 ` Andy Shevchenko
2020-01-31 11:39 ` Andy Shevchenko
2020-01-31 11:39 ` Andy Shevchenko
2020-01-31 12:03 ` John Garry
2020-01-31 12:03 ` John Garry
2020-01-31 12:03 ` John Garry
2020-01-31 15:46 ` Andy Shevchenko
2020-01-31 15:46 ` Andy Shevchenko
2020-01-31 15:46 ` Andy Shevchenko
2020-01-31 16:26 ` John Garry
2020-01-31 16:26 ` John Garry
2020-01-31 16:26 ` John Garry
2020-02-01 11:34 ` Mark Brown
2020-02-01 11:34 ` Mark Brown
2020-02-01 11:32 ` Mark Brown
2020-02-01 11:32 ` Mark Brown
2020-01-10 19:59 ` Applied "spi: Add HiSilicon v3xx SPI NOR flash controller driver" to the spi tree Mark Brown
2020-01-10 19:59 ` Mark Brown
2020-01-10 19:59 ` Mark Brown
2019-12-09 14:08 ` [PATCH v2 3/3] MAINTAINERS: Add a maintainer for the HiSilicon v3xx SFC driver John Garry
2019-12-09 14:08 ` John Garry
2020-01-10 19:59 ` Applied "MAINTAINERS: Add a maintainer for the HiSilicon v3xx SFC driver" to the spi tree Mark Brown
2020-01-10 19:59 ` Mark Brown
2020-01-10 19:59 ` Mark Brown
2019-12-16 14:52 ` [PATCH v2 0/3] HiSilicon v3xx SFC driver John Garry
2019-12-16 14:52 ` John Garry
2019-12-16 14:56 ` Mark Brown
2019-12-16 14:56 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df67b562-7d82-19f6-7581-680190a7772d@huawei.com \
--to=john.garry@huawei.com \
--cc=broonie@kernel.org \
--cc=chenxiang66@hisilicon.com \
--cc=fengsheng5@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=marek.vasut@gmail.com \
--cc=tudor.ambarus@microchip.com \
--cc=xuejiancheng@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.