From: Conor Dooley <conor@kernel.org>
To: Andy Chiu <andy.chiu@sifive.com>
Cc: linux-riscv@lists.infradead.org, palmer@dabbelt.com,
anup@brainfault.org, atishp@atishpatra.org,
kvm-riscv@lists.infradead.org, kvm@vger.kernel.org,
vineetg@rivosinc.com, greentime.hu@sifive.com,
guoren@linux.alibaba.com,
"Paul Walmsley" <paul.walmsley@sifive.com>,
"Albert Ou" <aou@eecs.berkeley.edu>,
"Andrew Jones" <ajones@ventanamicro.com>,
"Heiko Stuebner" <heiko.stuebner@vrull.eu>,
"Conor Dooley" <conor.dooley@microchip.com>,
"Lad Prabhakar" <prabhakar.mahadev-lad.rj@bp.renesas.com>,
"Jisheng Zhang" <jszhang@kernel.org>,
"Liao Chang" <liaochang1@huawei.com>,
"Vincent Chen" <vincent.chen@sifive.com>,
"Guo Ren" <guoren@kernel.org>, "Björn Töpel" <bjorn@rivosinc.com>,
"Xianting Tian" <xianting.tian@linux.alibaba.com>,
"Mattias Nissler" <mnissler@rivosinc.com>
Subject: Re: [PATCH -next v21 11/27] riscv: Allocate user's vector context in the first-use trap
Date: Mon, 5 Jun 2023 17:04:08 +0100 [thread overview]
Message-ID: <20230605-creme-smugly-e7592c870dda@spud> (raw)
In-Reply-To: <20230605110724.21391-12-andy.chiu@sifive.com>
[-- Attachment #1.1: Type: text/plain, Size: 1109 bytes --]
On Mon, Jun 05, 2023 at 11:07:08AM +0000, Andy Chiu wrote:
> Vector unit is disabled by default for all user processes. Thus, a
> process will take a trap (illegal instruction) into kernel at the first
> time when it uses Vector. Only after then, the kernel allocates V
> context and starts take care of the context for that user process.
>
> Suggested-by: Richard Henderson <richard.henderson@linaro.org>
> Link: https://lore.kernel.org/r/3923eeee-e4dc-0911-40bf-84c34aee962d@linaro.org
> Signed-off-by: Andy Chiu <andy.chiu@sifive.com>
> ---
> Changelog v21:
> - Remove has_vector() and use ELF_HWCAP instead. The V bit in the hwcap,
> if preesents, implies has_vector() returning true. So we can drop
> has_vector() test here safely, because we also don't handle !V but
> has_vector() cases.
I think you could probably have carried my R-b from v20, but I realise I
did not reply to you - sorry about that.
The removal of the has_vector() check seems to tally with the
conversation we had on v20, so
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Cheers,
Conor.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2023-06-05 16:04 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-05 11:06 [PATCH -next v21 00/27] riscv: Add vector ISA support Andy Chiu
2023-06-05 11:06 ` [PATCH -next v21 01/27] riscv: Rename __switch_to_aux() -> fpu Andy Chiu
2023-06-05 11:06 ` [PATCH -next v21 02/27] riscv: Extending cpufeature.c to detect V-extension Andy Chiu
2023-06-05 11:07 ` [PATCH -next v21 03/27] riscv: hwprobe: Add support for probing V in RISCV_HWPROBE_KEY_IMA_EXT_0 Andy Chiu
2023-06-08 12:36 ` Heiko Stübner
2023-06-28 0:30 ` Stefan O'Rear
2023-06-28 1:56 ` Palmer Dabbelt
2023-06-28 4:53 ` Stefan O'Rear
2023-06-05 11:07 ` [PATCH -next v21 04/27] riscv: Add new csr defines related to vector extension Andy Chiu
2023-06-05 11:07 ` [PATCH -next v21 05/27] riscv: Clear vector regfile on bootup Andy Chiu
2023-06-05 11:07 ` [PATCH -next v21 06/27] riscv: Disable Vector Instructions for kernel itself Andy Chiu
2023-06-05 11:07 ` [PATCH -next v21 07/27] riscv: Introduce Vector enable/disable helpers Andy Chiu
2023-06-05 11:07 ` [PATCH -next v21 08/27] riscv: Introduce riscv_v_vsize to record size of Vector context Andy Chiu
2023-06-05 11:07 ` [PATCH -next v21 09/27] riscv: Introduce struct/helpers to save/restore per-task Vector state Andy Chiu
2023-06-12 14:32 ` Rémi Denis-Courmont
2023-06-13 14:19 ` Andy Chiu
2023-06-05 11:07 ` [PATCH -next v21 10/27] riscv: Add task switch support for vector Andy Chiu
2023-06-05 11:07 ` [PATCH -next v21 11/27] riscv: Allocate user's vector context in the first-use trap Andy Chiu
2023-06-05 16:04 ` Conor Dooley [this message]
2023-06-08 13:58 ` Heiko Stübner
2023-06-05 11:07 ` [PATCH -next v21 12/27] riscv: Add ptrace vector support Andy Chiu
2023-06-05 11:07 ` [PATCH -next v21 13/27] riscv: signal: check fp-reserved words unconditionally Andy Chiu
2023-06-05 11:07 ` [PATCH -next v21 14/27] riscv: signal: Add sigcontext save/restore for vector Andy Chiu
2023-10-08 9:19 ` Aurelien Jarno
2023-10-08 16:23 ` Andy Chiu
2023-10-09 17:08 ` Aurelien Jarno
2023-06-05 11:07 ` [PATCH -next v21 15/27] riscv: signal: Report signal frame size to userspace via auxv Andy Chiu
2023-06-05 11:07 ` [PATCH -next v21 16/27] riscv: signal: validate altstack to reflect Vector Andy Chiu
2023-06-05 11:07 ` [PATCH -next v21 17/27] riscv: prevent stack corruption by reserving task_pt_regs(p) early Andy Chiu
2023-06-05 11:07 ` [PATCH -next v21 18/27] riscv: kvm: Add V extension to KVM ISA Andy Chiu
2023-06-05 11:07 ` [PATCH -next v21 19/27] riscv: KVM: Add vector lazy save/restore support Andy Chiu
2023-06-05 11:07 ` [PATCH -next v21 20/27] riscv: hwcap: change ELF_HWCAP to a function Andy Chiu
2023-06-05 16:24 ` Conor Dooley
2023-06-12 14:36 ` Rémi Denis-Courmont
2023-06-12 15:30 ` Conor Dooley
2023-06-05 11:07 ` [PATCH -next v21 21/27] riscv: Add prctl controls for userspace vector management Andy Chiu
2023-06-05 11:07 ` [PATCH -next v21 22/27] riscv: Add sysctl to set the default vector rule for new processes Andy Chiu
2023-06-05 11:07 ` [PATCH -next v21 23/27] riscv: detect assembler support for .option arch Andy Chiu
2023-06-05 15:48 ` Nathan Chancellor
2023-06-05 16:25 ` Conor Dooley
2024-01-21 1:13 ` Eric Biggers
2024-01-21 2:55 ` Palmer Dabbelt
2024-01-21 14:32 ` Andy Chiu
2024-01-21 18:10 ` Eric Biggers
2024-01-22 22:29 ` Nathan Chancellor
2024-01-24 21:58 ` Eric Biggers
2023-06-05 11:07 ` [PATCH -next v21 24/27] riscv: Enable Vector code to be built Andy Chiu
2023-06-05 11:07 ` [PATCH -next v21 25/27] riscv: Add documentation for Vector Andy Chiu
2023-06-12 14:40 ` Rémi Denis-Courmont
2023-06-05 11:07 ` [PATCH -next v21 26/27] selftests: Test RISC-V Vector prctl interface Andy Chiu
2023-06-05 11:07 ` [PATCH -next v21 27/27] selftests: add .gitignore file for RISC-V hwprobe Andy Chiu
2023-06-09 14:00 ` [PATCH -next v21 00/27] riscv: Add vector ISA support Palmer Dabbelt
2023-06-09 14:50 ` patchwork-bot+linux-riscv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230605-creme-smugly-e7592c870dda@spud \
--to=conor@kernel.org \
--cc=ajones@ventanamicro.com \
--cc=andy.chiu@sifive.com \
--cc=anup@brainfault.org \
--cc=aou@eecs.berkeley.edu \
--cc=atishp@atishpatra.org \
--cc=bjorn@rivosinc.com \
--cc=conor.dooley@microchip.com \
--cc=greentime.hu@sifive.com \
--cc=guoren@kernel.org \
--cc=guoren@linux.alibaba.com \
--cc=heiko.stuebner@vrull.eu \
--cc=jszhang@kernel.org \
--cc=kvm-riscv@lists.infradead.org \
--cc=kvm@vger.kernel.org \
--cc=liaochang1@huawei.com \
--cc=linux-riscv@lists.infradead.org \
--cc=mnissler@rivosinc.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=vincent.chen@sifive.com \
--cc=vineetg@rivosinc.com \
--cc=xianting.tian@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).