From: William Qiu <william.qiu@starfivetech.com>
To: Mark Brown <broonie@kernel.org>
Cc: <devicetree@vger.kernel.org>, <linux-spi@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-riscv@lists.infradead.org>,
"Rob Herring" <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
"Emil Renner Berthing" <kernel@esmil.dk>,
Ziv Xu <ziv.xu@starfivetech.com>
Subject: Re: [PATCH v1 2/3] spi: cadence-quadspi: Add clock configuration for StarFive JH7110 QSPI
Date: Tue, 30 May 2023 10:05:38 +0800 [thread overview]
Message-ID: <86555925-b8dd-29a8-60cd-5c2ff2c1432a@starfivetech.com> (raw)
In-Reply-To: <042c560d-1f36-8e97-3796-7423245592f4@starfivetech.com>
On 2023/5/29 14:44, William Qiu wrote:
>
>
> On 2023/5/26 23:36, Mark Brown wrote:
>> On Fri, May 26, 2023 at 02:25:28PM +0800, William Qiu wrote:
>>
>>> if (of_device_is_compatible(pdev->dev.of_node, "starfive,jh7110-qspi")) {
>>> + qspi_ahb = devm_clk_get(dev, "qspi-ahb");
>>> + if (IS_ERR(qspi_ahb)) {
>>> + dev_err(dev, "Cannot claim QSPI_AHB clock.\n");
>>> + ret = PTR_ERR(qspi_ahb);
>>> + return ret;
>>> + }
>>> +
>>> + ret = clk_prepare_enable(qspi_ahb);
>>> + if (ret) {
>>> + dev_err(dev, "Cannot enable QSPI AHB clock.\n");
>>> + goto probe_clk_failed;
>>> + }
>>
>> Nothing ever disables or unprepares this clock as far as I can tell?
>> Perhaps also consider using the clk_bulk_ APIs.
>
> I will add in next version.
>
> Thanks for taking time to review this patch series and give useful
> suggestions.
>
> Best regards,
> William
Hi Mark,
Now I want to replace the original devm_clk_get API in the
driver with devm_clk_bulk_get_all API, which can achieve compatibility,
but it seems that it is not good for other ip with only one clock, so I
want to ask about that can I replace it? Or define that inside jh7110?
Best regards,
William
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2023-05-30 2:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-26 6:25 [PATCH v1 0/3] Add initialization of clock for StarFive JH7110 SoC William Qiu
2023-05-26 6:25 ` [PATCH v1 1/3] dt-bindings: qspi: cdns,qspi-nor: Add clocks " William Qiu
2023-05-26 15:33 ` Mark Brown
2023-05-29 6:44 ` William Qiu
2023-05-30 10:02 ` Mark Brown
2023-05-31 2:24 ` William Qiu
2023-05-26 6:25 ` [PATCH v1 2/3] spi: cadence-quadspi: Add clock configuration for StarFive JH7110 QSPI William Qiu
2023-05-26 15:36 ` Mark Brown
2023-05-29 6:44 ` William Qiu
2023-05-30 2:05 ` William Qiu [this message]
2023-05-30 10:33 ` Mark Brown
2023-05-31 6:19 ` William Qiu
2023-05-31 13:20 ` Mark Brown
2023-06-01 1:52 ` William Qiu
2023-05-26 6:25 ` [PATCH v1 3/3] riscv: dts: starfive: Add QSPI controller node for StarFive JH7110 SoC William Qiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86555925-b8dd-29a8-60cd-5c2ff2c1432a@starfivetech.com \
--to=william.qiu@starfivetech.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@esmil.dk \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=ziv.xu@starfivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).