From: Jens Axboe <axboe@kernel.dk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "Pali Rohár" <pali@kernel.org>,
"Christoph Hellwig" <hch@infradead.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: Linux 6.2-rc1
Date: Thu, 5 Jan 2023 12:40:25 -0700 [thread overview]
Message-ID: <1933bddd-42d7-d92b-974f-f26c46c01547@kernel.dk> (raw)
In-Reply-To: <CAHk-=wiKUWm3VoYHK-oKixc9nF5Qdwp598MPSoh=jdxKAU1bOw@mail.gmail.com>
On 1/5/23 12:06 PM, Linus Torvalds wrote:
> On Thu, Jan 5, 2023 at 9:45 AM Jens Axboe <axboe@kernel.dk> wrote:
>>
>> Not quite sure what that refers to, as I'm pretty sure I did all of that
>> work. But maybe Linus can refresh my memory here :-)
>
> I was definitely there, part of making it actually work for *every*
> block device.
>
> Long long ago, it used to be limited to the sg_io() interface, and
> only worked for SCSI devices.
>
> So you couldn't actually burn CD's with the regular IDE/ATA CD ROM
> drivers directly, but had to use a shim driver, kind of like pktcdvd.
> Except I think it was just /dev/cdrom.
>
> See
>
> https://git.kernel.org/pub/scm/linux/kernel/git/tglx/history.git/commit/?id=90df68e70b
>
> for some of it (exposing SG_IO to all the block ioctls), and the "make
> it more usable" parts that made it do sane permission checking in
>
> https://git.kernel.org/pub/scm/linux/kernel/git/tglx/history.git/commit/?id=a75aaa84276
>
> and the commits preceding it for that part of the work.
>
> But yes, you were very much involved too.
I knew that'd get you digging into the archives ;-)
Fair point, I was mostly thinking of the block infrastructure for doing
non-fs commands.
>> As mentioned, I don't think this kind of code belongs in the kernel. sr
>> or cdrom could easily be modified to support the necessary bits to
>> handle a writeable open, but the grunt of the pktcdvd code deals with
>> retrieving and writing out bigger chunks of data. And that part really
>> does belong in userspace imho.
>
> Well, it's the UDF write support that is the issue.. I didn't even
> realize people did that.
>
> You'd presumably have to re-do it as a FUSE thing.
Or even implement it in UDF itself somehow. But yes, ideally we'd punt all
of this data gathering to userspace and just leave the trivial init/stop
atapi/scsi commands to cdrom/sr.
--
Jens Axboe
next prev parent reply other threads:[~2023-01-05 19:42 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-25 22:07 Linux 6.2-rc1 Linus Torvalds
2022-12-26 19:52 ` Guenter Roeck
2022-12-26 20:56 ` Linus Torvalds
2022-12-26 21:03 ` Kees Cook
2022-12-26 22:10 ` Guenter Roeck
2022-12-27 0:29 ` Guenter Roeck
2022-12-27 1:32 ` Kees Cook
2022-12-27 5:52 ` Guenter Roeck
2022-12-28 3:40 ` Kees Cook
2022-12-28 14:44 ` Guenter Roeck
2023-01-07 0:06 ` Jaegeuk Kim
2022-12-26 22:41 ` Vlastimil Babka
2022-12-26 21:10 ` Max Filippov
2022-12-26 22:08 ` Guenter Roeck
2022-12-27 8:29 ` Build regressions/improvements in v6.2-rc1 Geert Uytterhoeven
2022-12-27 8:35 ` Geert Uytterhoeven
2023-01-01 1:33 ` Rob Landley
2023-01-01 12:24 ` Geert Uytterhoeven
2023-01-04 6:32 ` Michael Ellerman
2023-01-06 15:10 ` John Paul Adrian Glaubitz
2023-01-06 15:17 ` Geert Uytterhoeven
2023-01-06 15:18 ` Geert Uytterhoeven
2023-01-17 16:42 ` Calculating array sizes in C - was: " John Paul Adrian Glaubitz
2023-01-17 17:01 ` Geert Uytterhoeven
2023-01-17 17:06 ` John Paul Adrian Glaubitz
2023-01-17 20:05 ` Geert Uytterhoeven
2023-01-17 20:37 ` John Paul Adrian Glaubitz
2023-01-19 22:11 ` Michael.Karcher
2023-01-20 3:31 ` Rob Landley
2023-01-20 10:53 ` Segher Boessenkool
2023-01-20 18:29 ` Michael.Karcher
2023-01-20 8:49 ` John Paul Adrian Glaubitz
2023-01-20 19:29 ` Michael Karcher
2023-01-21 21:26 ` John Paul Adrian Glaubitz
2023-01-06 15:39 ` Alex Deucher
2023-01-04 19:01 ` Linux 6.2-rc1 Pali Rohár
2023-01-04 19:25 ` Linus Torvalds
2023-01-04 20:56 ` Pali Rohár
2023-01-04 21:27 ` Pali Rohár
2023-01-04 21:32 ` Linus Torvalds
2023-01-04 21:43 ` Jens Axboe
2023-01-05 11:25 ` Greg Kroah-Hartman
2023-01-05 15:26 ` Jens Axboe
2023-01-05 17:42 ` Pali Rohár
2023-01-05 17:45 ` Jens Axboe
2023-01-05 19:06 ` Linus Torvalds
2023-01-05 19:22 ` Pali Rohár
2023-01-05 19:40 ` Jens Axboe [this message]
2023-01-05 20:03 ` Linus Torvalds
2023-01-05 20:33 ` Jens Axboe
2023-01-06 16:58 ` Pali Rohár
2023-01-06 17:04 ` Jens Axboe
2023-01-28 19:34 ` pktcdvd Pali Rohár
2023-01-28 19:43 ` pktcdvd Linus Torvalds
2023-01-29 21:53 ` pktcdvd Jens Axboe
2023-01-29 21:55 ` pktcdvd Jens Axboe
2023-01-29 22:21 ` pktcdvd Pali Rohár
2023-01-29 22:34 ` pktcdvd Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1933bddd-42d7-d92b-974f-f26c46c01547@kernel.dk \
--to=axboe@kernel.dk \
--cc=gregkh@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pali@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).