From: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org, linux-wireless@vger.kernel.org,
linux-mips@vger.kernel.org, linux-sh@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linuxppc-dev@lists.ozlabs.org, kasan-dev@googlegroups.com,
linux-xtensa@linux-xtensa.org,
Michael Karcher <kernel@mkarcher.dialup.fu-berlin.de>
Subject: Calculating array sizes in C - was: Re: Build regressions/improvements in v6.2-rc1
Date: Tue, 17 Jan 2023 17:42:37 +0100 [thread overview]
Message-ID: <3800eaa8-a4da-b2f0-da31-6627176cb92e@physik.fu-berlin.de> (raw)
In-Reply-To: <CAMuHMdXNJveXHeS=g-aHbnxtyACxq1wCeaTg8LbpYqJTCqk86g@mail.gmail.com>
Hi Geert!
On 1/6/23 16:17, Geert Uytterhoeven wrote:
>> I'm not seeing this one, but I am getting this one instead:
>>
>> In file included from ./arch/sh/include/asm/hw_irq.h:6,
>> from ./include/linux/irq.h:596,
>> from ./include/asm-generic/hardirq.h:17,
>> from ./arch/sh/include/asm/hardirq.h:9,
>> from ./include/linux/hardirq.h:11,
>> from ./include/linux/interrupt.h:11,
>> from ./include/linux/serial_core.h:13,
>> from ./include/linux/serial_sci.h:6,
>> from arch/sh/kernel/cpu/sh2/setup-sh7619.c:11:
>> ./include/linux/sh_intc.h:100:63: error: division 'sizeof (void *) / sizeof (void)' does not compute the number of array elements [-Werror=sizeof-pointer-div]
>> 100 | #define _INTC_ARRAY(a) a, __same_type(a, NULL) ? 0 : sizeof(a)/sizeof(*a)
>> | ^
>> ./include/linux/sh_intc.h:105:31: note: in expansion of macro '_INTC_ARRAY'
>> 105 | _INTC_ARRAY(vectors), _INTC_ARRAY(groups), \
>> | ^~~~~~~~~~~
>
> The easiest fix for the latter is to disable CONFIG_WERROR.
> Unfortunately I don't know a simple solution to get rid of the warning.
I did some research and it seems that what the macro _INT_ARRAY() does with "sizeof(a)/sizeof(*a)"
is a commonly used way to calculate array sizes and the kernel has even its own macro for that
called ARRAY_SIZE() which Linus asks people to use here [1].
So, I replaced _INTC_ARRAY() with ARRAY_SIZE() (see below), however the kernel's own ARRAY_SIZE()
macro triggers the same compiler warning. I'm CC'ing Michael Karcher who has more knowledge on
writing proper C code than me and maybe an idea how to fix this warning.
Thanks,
Adrian
> [1] https://lkml.org/lkml/2015/9/3/428
diff --git a/include/linux/sh_intc.h b/include/linux/sh_intc.h
index c255273b0281..07a187686a84 100644
--- a/include/linux/sh_intc.h
+++ b/include/linux/sh_intc.h
@@ -97,14 +97,12 @@ struct intc_hw_desc {
unsigned int nr_subgroups;
};
-#define _INTC_ARRAY(a) a, __same_type(a, NULL) ? 0 : sizeof(a)/sizeof(*a)
-
#define INTC_HW_DESC(vectors, groups, mask_regs, \
prio_regs, sense_regs, ack_regs) \
{ \
- _INTC_ARRAY(vectors), _INTC_ARRAY(groups), \
- _INTC_ARRAY(mask_regs), _INTC_ARRAY(prio_regs), \
- _INTC_ARRAY(sense_regs), _INTC_ARRAY(ack_regs), \
+ ARRAY_SIZE(vectors), ARRAY_SIZE(groups), \
+ ARRAY_SIZE(mask_regs), ARRAY_SIZE(prio_regs), \
+ ARRAY_SIZE(sense_regs), ARRAY_SIZE(ack_regs), \
}
struct intc_desc {
--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer
`. `' Physicist
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
next prev parent reply other threads:[~2023-01-17 16:43 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-25 22:07 Linux 6.2-rc1 Linus Torvalds
2022-12-26 19:52 ` Guenter Roeck
2022-12-26 20:56 ` Linus Torvalds
2022-12-26 21:03 ` Kees Cook
2022-12-26 22:10 ` Guenter Roeck
2022-12-27 0:29 ` Guenter Roeck
2022-12-27 1:32 ` Kees Cook
2022-12-27 5:52 ` Guenter Roeck
2022-12-28 3:40 ` Kees Cook
2022-12-28 14:44 ` Guenter Roeck
2023-01-07 0:06 ` Jaegeuk Kim
2022-12-26 22:41 ` Vlastimil Babka
2022-12-26 21:10 ` Max Filippov
2022-12-26 22:08 ` Guenter Roeck
2022-12-27 8:29 ` Build regressions/improvements in v6.2-rc1 Geert Uytterhoeven
2022-12-27 8:35 ` Geert Uytterhoeven
2023-01-01 1:33 ` Rob Landley
2023-01-01 12:24 ` Geert Uytterhoeven
2023-01-04 6:32 ` Michael Ellerman
2023-01-06 15:10 ` John Paul Adrian Glaubitz
2023-01-06 15:17 ` Geert Uytterhoeven
2023-01-06 15:18 ` Geert Uytterhoeven
2023-01-17 16:42 ` John Paul Adrian Glaubitz [this message]
2023-01-17 17:01 ` Calculating array sizes in C - was: " Geert Uytterhoeven
2023-01-17 17:06 ` John Paul Adrian Glaubitz
2023-01-17 20:05 ` Geert Uytterhoeven
2023-01-17 20:37 ` John Paul Adrian Glaubitz
2023-01-19 22:11 ` Michael.Karcher
2023-01-20 3:31 ` Rob Landley
2023-01-20 10:53 ` Segher Boessenkool
2023-01-20 18:29 ` Michael.Karcher
2023-01-20 8:49 ` John Paul Adrian Glaubitz
2023-01-20 19:29 ` Michael Karcher
2023-01-21 21:26 ` John Paul Adrian Glaubitz
2023-01-06 15:39 ` Alex Deucher
2023-01-04 19:01 ` Linux 6.2-rc1 Pali Rohár
2023-01-04 19:25 ` Linus Torvalds
2023-01-04 20:56 ` Pali Rohár
2023-01-04 21:27 ` Pali Rohár
2023-01-04 21:32 ` Linus Torvalds
2023-01-04 21:43 ` Jens Axboe
2023-01-05 11:25 ` Greg Kroah-Hartman
2023-01-05 15:26 ` Jens Axboe
2023-01-05 17:42 ` Pali Rohár
2023-01-05 17:45 ` Jens Axboe
2023-01-05 19:06 ` Linus Torvalds
2023-01-05 19:22 ` Pali Rohár
2023-01-05 19:40 ` Jens Axboe
2023-01-05 20:03 ` Linus Torvalds
2023-01-05 20:33 ` Jens Axboe
2023-01-06 16:58 ` Pali Rohár
2023-01-06 17:04 ` Jens Axboe
2023-01-28 19:34 ` pktcdvd Pali Rohár
2023-01-28 19:43 ` pktcdvd Linus Torvalds
2023-01-29 21:53 ` pktcdvd Jens Axboe
2023-01-29 21:55 ` pktcdvd Jens Axboe
2023-01-29 22:21 ` pktcdvd Pali Rohár
2023-01-29 22:34 ` pktcdvd Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3800eaa8-a4da-b2f0-da31-6627176cb92e@physik.fu-berlin.de \
--to=glaubitz@physik.fu-berlin.de \
--cc=amd-gfx@lists.freedesktop.org \
--cc=geert@linux-m68k.org \
--cc=kasan-dev@googlegroups.com \
--cc=kernel@mkarcher.dialup.fu-berlin.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linux-xtensa@linux-xtensa.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).