From: Jens Axboe <axboe@kernel.dk>
To: "Pali Rohár" <pali@kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Christoph Hellwig <hch@infradead.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: pktcdvd
Date: Sun, 29 Jan 2023 15:34:04 -0700 [thread overview]
Message-ID: <1dea09ad-73b8-8f9f-c0d1-5637413349b5@kernel.dk> (raw)
In-Reply-To: <20230129222121.tjfxgzfqvwj3sotp@pali>
On 1/29/23 3:21 PM, Pali Rohár wrote:
> On Sunday 29 January 2023 14:55:27 Jens Axboe wrote:
>> This does not look like a new issue (eg related to this series), and
>> this is exactly one of the reasons we wanted to get rid of this code -
>> basically nobody tests it, as nobody has the ability to. That means it's
>> very time consuming to debug issues with it.
>
> I understand. I could try to look at it. The main issue for me is that I
> have not looked at this low level block device kernel area and I do not
> understand what is the code around doing...
I'll be happy to answer questions if you want to dive in... Looking at
the oops, it's clear that a bio arrived (or was split) that didn't end
up on a packet size alignment. We didn't error on the full size
alignment, so the total size of the write is a multiple of the packet
size. The bio_split() is pretty straightforward, so perhaps the starting
sector wasn't a multiple of the packet size to begin with?
>> What is the newest kernel you've run the pktcdvd driver on?
>
> 4.19 from Debian 10. I'm not sure if I used newer version as most stuff
> is still on Debian 10 as I have not find a time to do upgrade of
> everything.
Ok, yeah that's pretty old...
--
Jens Axboe
prev parent reply other threads:[~2023-01-29 22:34 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-25 22:07 Linux 6.2-rc1 Linus Torvalds
2022-12-26 19:52 ` Guenter Roeck
2022-12-26 20:56 ` Linus Torvalds
2022-12-26 21:03 ` Kees Cook
2022-12-26 22:10 ` Guenter Roeck
2022-12-27 0:29 ` Guenter Roeck
2022-12-27 1:32 ` Kees Cook
2022-12-27 5:52 ` Guenter Roeck
2022-12-28 3:40 ` Kees Cook
2022-12-28 14:44 ` Guenter Roeck
2023-01-07 0:06 ` Jaegeuk Kim
2022-12-26 22:41 ` Vlastimil Babka
2022-12-26 21:10 ` Max Filippov
2022-12-26 22:08 ` Guenter Roeck
2022-12-27 8:29 ` Build regressions/improvements in v6.2-rc1 Geert Uytterhoeven
2022-12-27 8:35 ` Geert Uytterhoeven
2023-01-01 1:33 ` Rob Landley
2023-01-01 12:24 ` Geert Uytterhoeven
2023-01-04 6:32 ` Michael Ellerman
2023-01-06 15:10 ` John Paul Adrian Glaubitz
2023-01-06 15:17 ` Geert Uytterhoeven
2023-01-06 15:18 ` Geert Uytterhoeven
2023-01-17 16:42 ` Calculating array sizes in C - was: " John Paul Adrian Glaubitz
2023-01-17 17:01 ` Geert Uytterhoeven
2023-01-17 17:06 ` John Paul Adrian Glaubitz
2023-01-17 20:05 ` Geert Uytterhoeven
2023-01-17 20:37 ` John Paul Adrian Glaubitz
2023-01-19 22:11 ` Michael.Karcher
2023-01-20 3:31 ` Rob Landley
2023-01-20 10:53 ` Segher Boessenkool
2023-01-20 18:29 ` Michael.Karcher
2023-01-20 8:49 ` John Paul Adrian Glaubitz
2023-01-20 19:29 ` Michael Karcher
2023-01-21 21:26 ` John Paul Adrian Glaubitz
2023-01-06 15:39 ` Alex Deucher
2023-01-04 19:01 ` Linux 6.2-rc1 Pali Rohár
2023-01-04 19:25 ` Linus Torvalds
2023-01-04 20:56 ` Pali Rohár
2023-01-04 21:27 ` Pali Rohár
2023-01-04 21:32 ` Linus Torvalds
2023-01-04 21:43 ` Jens Axboe
2023-01-05 11:25 ` Greg Kroah-Hartman
2023-01-05 15:26 ` Jens Axboe
2023-01-05 17:42 ` Pali Rohár
2023-01-05 17:45 ` Jens Axboe
2023-01-05 19:06 ` Linus Torvalds
2023-01-05 19:22 ` Pali Rohár
2023-01-05 19:40 ` Jens Axboe
2023-01-05 20:03 ` Linus Torvalds
2023-01-05 20:33 ` Jens Axboe
2023-01-06 16:58 ` Pali Rohár
2023-01-06 17:04 ` Jens Axboe
2023-01-28 19:34 ` pktcdvd Pali Rohár
2023-01-28 19:43 ` pktcdvd Linus Torvalds
2023-01-29 21:53 ` pktcdvd Jens Axboe
2023-01-29 21:55 ` pktcdvd Jens Axboe
2023-01-29 22:21 ` pktcdvd Pali Rohár
2023-01-29 22:34 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1dea09ad-73b8-8f9f-c0d1-5637413349b5@kernel.dk \
--to=axboe@kernel.dk \
--cc=gregkh@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pali@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).