From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Chris Packham <chris.packham@alliedtelesis.co.nz>,
huziji@marvell.com, ulf.hansson@linaro.org, robh+dt@kernel.org,
davem@davemloft.net, kuba@kernel.org, linus.walleij@linaro.org,
catalin.marinas@arm.com, will@kernel.org, andrew@lunn.ch,
gregory.clement@bootlin.com, sebastian.hesselbarth@gmail.com,
adrian.hunter@intel.com, thomas.petazzoni@bootlin.com,
kostap@marvell.com, robert.marko@sartura.hr
Cc: linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/8] dt-bindings: pinctrl: mvebu: Document bindings for AC5
Date: Tue, 15 Mar 2022 11:46:59 +0100 [thread overview]
Message-ID: <4e6df448-5562-8f50-6f46-91acb279bc1a@canonical.com> (raw)
In-Reply-To: <20220314213143.2404162-2-chris.packham@alliedtelesis.co.nz>
On 14/03/2022 22:31, Chris Packham wrote:
> Add JSON schema for marvell,ac5-pinctrl present on the Marvell 98DX2530
> SoC.
>
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
> ---
>
> Notes:
> Changes in v2:
> - Remove syscon and simple-mfd compatibles
>
> .../bindings/pinctrl/marvell,ac5-pinctrl.yaml | 70 +++++++++++++++++++
> 1 file changed, 70 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/pinctrl/marvell,ac5-pinctrl.yaml
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/marvell,ac5-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/marvell,ac5-pinctrl.yaml
> new file mode 100644
> index 000000000000..65af1d5f5fe0
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pinctrl/marvell,ac5-pinctrl.yaml
> @@ -0,0 +1,70 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/pinctrl/marvell,ac5-pinctrl.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Marvell AC5 pin controller
> +
> +maintainers:
> + - Chris Packham <chris.packham@alliedtelesis.co.nz>
> +
> +description:
> + Bindings for Marvell's AC5 memory-mapped pin controller.
> +
> +properties:
> + compatible:
> + const: marvell,ac5-pinctrl
> +
> +patternProperties:
> + '-pins$':
> + type: object
> + $ref: pinmux-node.yaml#
> +
> + properties:
> + marvell,function:
> + $ref: "/schemas/types.yaml#/definitions/string"
> + description:
> + Indicates the function to select.
> + enum: [ gpio, i2c0, i2c1, nand, sdio, spi0, spi1, uart0, uart1, uart2, uart3 ]
> +
> + marvell,pins:
> + $ref: /schemas/types.yaml#/definitions/string-array
> + description:
> + Array of MPP pins to be used for the given function.
> + minItems: 1
> + items:
> + enum: [ mpp0, mpp1, mpp2, mpp3, mpp4, mpp5, mpp6, mpp7, mpp8, mpp9,
> + mpp10, mpp11, mpp12, mpp13, mpp14, mpp15, mpp16, mpp17, mpp18, mpp19,
> + mpp20, mpp21, mpp22, mpp23, mpp24, mpp25, mpp26, mpp27, mpp28, mpp29,
> + mpp30, mpp31, mpp32, mpp33, mpp34, mpp35, mpp36, mpp37, mpp38, mpp39,
> + mpp40, mpp41, mpp42, mpp43, mpp44, mpp45 ]
> +
> +allOf:
> + - $ref: "pinctrl.yaml#"
> +
> +required:
> + - compatible
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + system-controller@80020100 {
> + compatible = "syscon", "simple-mfd";
> + reg = <0x80020000 0x20>;
This is unusual. Usually the pinctrl should be a device @80020100, not
child of syscon node. Why do you need it? In v1 you mentioned that
vendor sources do like this, but it's not correct to copy wrong DTS. :)
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-03-15 10:49 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-14 21:31 [PATCH v2 0/8] arm64: mvebu: Support for Marvell 98DX2530 (and variants) Chris Packham
2022-03-14 21:31 ` [PATCH v2 1/8] dt-bindings: pinctrl: mvebu: Document bindings for AC5 Chris Packham
2022-03-15 0:07 ` Andrew Lunn
2022-03-15 0:22 ` Chris Packham
2022-03-15 0:27 ` Andrew Lunn
2022-03-23 18:34 ` Rob Herring
2022-03-15 10:46 ` Krzysztof Kozlowski [this message]
2022-03-15 21:12 ` Chris Packham
2022-03-16 8:16 ` Krzysztof Kozlowski
2022-03-16 20:21 ` Chris Packham
2022-03-17 7:26 ` Krzysztof Kozlowski
2022-03-17 14:14 ` Andrew Lunn
2022-03-17 15:16 ` Krzysztof Kozlowski
2022-03-14 21:31 ` [PATCH v2 2/8] dt-bindings: net: mvneta: Add marvell,armada-ac5-neta Chris Packham
2022-03-15 0:10 ` Andrew Lunn
2022-03-14 21:31 ` [PATCH v2 3/8] dt-bindings: mmc: xenon: add AC5 compatible string Chris Packham
2022-03-15 0:14 ` Andrew Lunn
2022-03-14 21:31 ` [PATCH v2 4/8] pinctrl: mvebu: pinctrl driver for 98DX2530 SoC Chris Packham
2022-03-15 0:16 ` Andrew Lunn
2022-03-15 10:49 ` Krzysztof Kozlowski
2022-03-15 14:33 ` Andrew Lunn
2022-03-15 14:39 ` Krzysztof Kozlowski
2022-03-14 21:31 ` [PATCH v2 5/8] net: mvneta: Add support for 98DX2530 Ethernet port Chris Packham
2022-03-15 0:12 ` Andrew Lunn
2022-03-15 0:27 ` Chris Packham
2022-03-14 21:31 ` [PATCH v2 6/8] mmc: xenon: add AC5 compatible string Chris Packham
2022-03-15 0:14 ` Andrew Lunn
2022-03-14 21:31 ` [PATCH v2 7/8] arm64: dts: marvell: Add Armada 98DX2530 SoC and RD-AC5X board Chris Packham
2022-03-15 0:24 ` Andrew Lunn
2022-03-15 2:11 ` Chris Packham
2022-03-15 14:28 ` Andrew Lunn
2022-03-16 11:49 ` Marc Zyngier
2022-03-14 21:31 ` [PATCH v2 8/8] arm64: marvell: enable the 98DX2530 pinctrl driver Chris Packham
2022-03-15 0:25 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e6df448-5562-8f50-6f46-91acb279bc1a@canonical.com \
--to=krzysztof.kozlowski@canonical.com \
--cc=adrian.hunter@intel.com \
--cc=andrew@lunn.ch \
--cc=catalin.marinas@arm.com \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=gregory.clement@bootlin.com \
--cc=huziji@marvell.com \
--cc=kostap@marvell.com \
--cc=kuba@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=robert.marko@sartura.hr \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=ulf.hansson@linaro.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).