Re: [RFC PATCH CTF 2/3] Clarify monotonicity requirement on timestamp begin

[Mathieu Desnoyers via lttng-dev <lttng-dev@lists.lttng.org>]

----- On Apr 28, 2020, at 2:42 PM, Philippe Proulx pproulx@efficios.com wrote:

> ----- Original Message -----
>> From: "Mathieu Desnoyers" <mathieu.desnoyers@efficios.com>
>> To: "gbastien+lttng" <gbastien+lttng@versatic.net>, "Matthew Khouzam"
>> <matthew.khouzam@ericsson.com>,
>> diamon-discuss@linuxfoundation.org, pproulx@efficios.com, "Jeremie Galarneau"
>> <jgalar@efficios.com>
>> Cc: "lttng-dev" <lttng-dev@lists.lttng.org>, "Mathieu Desnoyers"
>> <mathieu.desnoyers@efficios.com>
>> Sent: Thursday, 23 April, 2020 16:52:25
>> Subject: [RFC PATCH CTF 2/3] Clarify monotonicity requirement on timestamp begin
> 
>> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
>> ---
>> common-trace-format-specification.md | 10 ++++++----
>> 1 file changed, 6 insertions(+), 4 deletions(-)
>> 
>> diff --git a/common-trace-format-specification.md
>> b/common-trace-format-specification.md
>> index f5fea51..53b70f4 100644
>> --- a/common-trace-format-specification.md
>> +++ b/common-trace-format-specification.md
>> @@ -836,10 +836,12 @@ TSDL metadata):
>>     range between these timestamps should include all event timestamps
>>     assigned to events contained within the packet. The timestamp at the
>>     beginning of an event packet is guaranteed to be below or equal the
>> -    timestamp at the end of that event packet. The timestamp at the end
>> -    of an event packet is guaranteed to be below or equal the
>> -    timestamps at the end of any following packet within the same stream.
>> -    See [Clocks](#spec8) for more detail.
>> +    timestamp at the end of that event packet. The timestamp at the
>> +    beginning of an event packet is guaranteed to be above or equal the
> 
> "greater than or equal to"

done

> 
>> +    timestamps at the beginning of any prior packet within the same
>> +    stream. The timestamp at the end of an event packet is guaranteed to
>> +    be below or equal the timestamps at the end of any following packet
> 
> "less than or equal to"

done,

Thanks!

Mathieu

> 
> Phil
> 
>> +    within the same stream. See [Clocks](#spec8) for more detail.
>>   * **Events discarded count**. Snapshot of a per-stream
>>     free-running counter, counting the number of events discarded that
>>     were supposed to be written in the stream after the last event in
>> --
> > 2.11.0

-- 
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com