From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Edward Cree <ecree@solarflare.com>
Cc: netfilter-devel@vger.kernel.org, davem@davemloft.net,
netdev@vger.kernel.org, jakub.kicinski@netronome.com,
jiri@resnulli.us, vladbu@mellanox.com
Subject: Re: [PATCH net-next 1/2] net: flow_offload: mangle 128-bit packet field with one action
Date: Tue, 20 Aug 2019 19:33:44 +0200 [thread overview]
Message-ID: <20190820173344.3nrzfjboyztz3lji@salvia> (raw)
In-Reply-To: <c8a00a98-74eb-9f8d-660f-c2ea159dec91@solarflare.com>
On Tue, Aug 20, 2019 at 05:00:26PM +0100, Edward Cree wrote:
> On 20/08/2019 15:44, Pablo Neira Ayuso wrote:
> > It looks to me this limitation is coming from tc pedit.
> >
> > Four actions to mangle an IPv6 address consume more memory when making
> > the translation, and if you expect a lot of rules.
>
> Your change means that now every pedit uses four hw entries, even if it
> was only meant to be a 32-bit mangle.
It makes no sense to me that matching an IPv6 address takes _one_
action, while mangling an IPv6 address takes _four_ actions.
A consistent model for drivers is good to have.
I can update tc pedit to generate one single action for offset
consecutive packet editions, if that is the concern, I'll send a v2.
next prev parent reply other threads:[~2019-08-20 17:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-20 10:52 [PATCH net-next 1/2] net: flow_offload: mangle 128-bit packet field with one action Pablo Neira Ayuso
2019-08-20 10:52 ` [PATCH net-next 2/2] netfilter: nft_payload: packet mangling offload support Pablo Neira Ayuso
2019-08-20 14:15 ` [PATCH net-next 1/2] net: flow_offload: mangle 128-bit packet field with one action Edward Cree
2019-08-20 14:44 ` Pablo Neira Ayuso
2019-08-20 16:00 ` Edward Cree
2019-08-20 17:33 ` Pablo Neira Ayuso [this message]
2019-08-20 18:15 ` Edward Cree
2019-08-20 18:35 ` Pablo Neira Ayuso
2019-08-21 15:05 ` Edward Cree
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190820173344.3nrzfjboyztz3lji@salvia \
--to=pablo@netfilter.org \
--cc=davem@davemloft.net \
--cc=ecree@solarflare.com \
--cc=jakub.kicinski@netronome.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=vladbu@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).