From: Edward Cree <ecree@solarflare.com>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: <netfilter-devel@vger.kernel.org>, <davem@davemloft.net>,
<netdev@vger.kernel.org>, <jakub.kicinski@netronome.com>,
<jiri@resnulli.us>, <vladbu@mellanox.com>
Subject: Re: [PATCH net-next 1/2] net: flow_offload: mangle 128-bit packet field with one action
Date: Tue, 20 Aug 2019 17:00:26 +0100 [thread overview]
Message-ID: <c8a00a98-74eb-9f8d-660f-c2ea159dec91@solarflare.com> (raw)
In-Reply-To: <20190820144453.ckme6oj2c4hmofhu@salvia>
On 20/08/2019 15:44, Pablo Neira Ayuso wrote:
> It looks to me this limitation is coming from tc pedit.
>
> Four actions to mangle an IPv6 address consume more memory when making
> the translation, and if you expect a lot of rules.
Your change means that now every pedit uses four hw entries, even if it
was only meant to be a 32-bit mangle. Host memory used to keep track of
the pedit actions is cheap, hw entries in pedit tables are not. Nor is
driver implementation complexity.
NAK.
next prev parent reply other threads:[~2019-08-20 16:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-20 10:52 [PATCH net-next 1/2] net: flow_offload: mangle 128-bit packet field with one action Pablo Neira Ayuso
2019-08-20 10:52 ` [PATCH net-next 2/2] netfilter: nft_payload: packet mangling offload support Pablo Neira Ayuso
2019-08-20 14:15 ` [PATCH net-next 1/2] net: flow_offload: mangle 128-bit packet field with one action Edward Cree
2019-08-20 14:44 ` Pablo Neira Ayuso
2019-08-20 16:00 ` Edward Cree [this message]
2019-08-20 17:33 ` Pablo Neira Ayuso
2019-08-20 18:15 ` Edward Cree
2019-08-20 18:35 ` Pablo Neira Ayuso
2019-08-21 15:05 ` Edward Cree
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c8a00a98-74eb-9f8d-660f-c2ea159dec91@solarflare.com \
--to=ecree@solarflare.com \
--cc=davem@davemloft.net \
--cc=jakub.kicinski@netronome.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=vladbu@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).