From: Edward Cree <ecree@solarflare.com>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: <netfilter-devel@vger.kernel.org>, <davem@davemloft.net>,
<netdev@vger.kernel.org>, <jakub.kicinski@netronome.com>,
<jiri@resnulli.us>, <vladbu@mellanox.com>
Subject: Re: [PATCH net-next 1/2] net: flow_offload: mangle 128-bit packet field with one action
Date: Tue, 20 Aug 2019 19:15:10 +0100 [thread overview]
Message-ID: <f4cf8a97-3322-d982-6068-d4c0ce997b1c@solarflare.com> (raw)
In-Reply-To: <20190820173344.3nrzfjboyztz3lji@salvia>
On 20/08/2019 18:33, Pablo Neira Ayuso wrote:
> I can update tc pedit to generate one single action for offset
> consecutive packet editions, if that is the concern, I'll send a v2.
IMHO the fix belongs in TC userland (i.e. iproute2), to turn a single action on the commandline for an ipv6 addr into four pedit actions before the kernel ever sees it.
Similarly if nftables wants to use this it should generate four separate pedit actions, probably in the kernel netfilter code as (I assume) your uAPI talks in terms of named fields rather than the u32ish offsets and masks of tc pedit.
The TC (well, flow_offload now I suppose) API should be kept narrow, not widened for things that can already be expressed adequately. Your array of words inside a pedit action looks like a kind of loop unrolling but for data structures, which doesn't look sensible to me.
-Ed
next prev parent reply other threads:[~2019-08-20 18:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-20 10:52 [PATCH net-next 1/2] net: flow_offload: mangle 128-bit packet field with one action Pablo Neira Ayuso
2019-08-20 10:52 ` [PATCH net-next 2/2] netfilter: nft_payload: packet mangling offload support Pablo Neira Ayuso
2019-08-20 14:15 ` [PATCH net-next 1/2] net: flow_offload: mangle 128-bit packet field with one action Edward Cree
2019-08-20 14:44 ` Pablo Neira Ayuso
2019-08-20 16:00 ` Edward Cree
2019-08-20 17:33 ` Pablo Neira Ayuso
2019-08-20 18:15 ` Edward Cree [this message]
2019-08-20 18:35 ` Pablo Neira Ayuso
2019-08-21 15:05 ` Edward Cree
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4cf8a97-3322-d982-6068-d4c0ce997b1c@solarflare.com \
--to=ecree@solarflare.com \
--cc=davem@davemloft.net \
--cc=jakub.kicinski@netronome.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=vladbu@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).