From: Edward Cree <ecree@solarflare.com>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: <netfilter-devel@vger.kernel.org>, <davem@davemloft.net>,
<netdev@vger.kernel.org>, <jakub.kicinski@netronome.com>,
<jiri@resnulli.us>, <vladbu@mellanox.com>
Subject: Re: [PATCH net-next 1/2] net: flow_offload: mangle 128-bit packet field with one action
Date: Wed, 21 Aug 2019 16:05:49 +0100 [thread overview]
Message-ID: <5f7f561d-36b5-2611-e051-4a1549e35f09@solarflare.com> (raw)
In-Reply-To: <20190820183533.ykh7mnurpmegxb27@salvia>
On 20/08/2019 19:35, Pablo Neira Ayuso wrote:
> With one action that says "mangle an IPv6 at offset ip6 daddr field"
> the driver has more global view on what is going on, rather than
> having four actions to mangle four 32-bit words at some offset.
But the action doesn't say that, it still says "mangle four 32-bit
words", it's just that they're now contiguous. The driver doesn't
know whether that's an IPv6 address or just a bunch of fields that
happened to be next to one another.
(Besides, the driver can't rely on that 'global view', because if
the actions did come from the TC uAPI, they're still going to be
single u32 mangles.)
> If this patch adds some loops here is because I did not want to make
> too smart changes on the drivers.
The thing is, the drivers are already looping over TC actions, so they
already naturally support multiple pedits. You don't gain any
expressiveness by combining them into batches of four, meanwhile you
make the API less orthogonal and more laborious to implement.
> Please, allow for incremental updates on the flow_offload API to get
> it better now. Later we'll have way more drivers it will become harder
> to update this.
I'm not opposed to making the API better. I just don't believe that
this patch series achieves that.
prev parent reply other threads:[~2019-08-21 15:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-20 10:52 [PATCH net-next 1/2] net: flow_offload: mangle 128-bit packet field with one action Pablo Neira Ayuso
2019-08-20 10:52 ` [PATCH net-next 2/2] netfilter: nft_payload: packet mangling offload support Pablo Neira Ayuso
2019-08-20 14:15 ` [PATCH net-next 1/2] net: flow_offload: mangle 128-bit packet field with one action Edward Cree
2019-08-20 14:44 ` Pablo Neira Ayuso
2019-08-20 16:00 ` Edward Cree
2019-08-20 17:33 ` Pablo Neira Ayuso
2019-08-20 18:15 ` Edward Cree
2019-08-20 18:35 ` Pablo Neira Ayuso
2019-08-21 15:05 ` Edward Cree [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f7f561d-36b5-2611-e051-4a1549e35f09@solarflare.com \
--to=ecree@solarflare.com \
--cc=davem@davemloft.net \
--cc=jakub.kicinski@netronome.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=vladbu@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).