From: Greg Kurz <groug@kaod.org>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: lvivier@redhat.com, aik@ozlabs.ru,
Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
qemu-devel@nongnu.org, qemu-ppc@nongnu.org, clg@kaod.org,
paulus@samba.org, philmd@redhat.com
Subject: Re: [PATCH v2 01/10] ppc: Drop PPC_EMULATE_32BITS_HYPV stub
Date: Tue, 7 Jan 2020 18:05:39 +0100 [thread overview]
Message-ID: <20200107180539.57ba0781@bahia.lan> (raw)
In-Reply-To: <20200107044827.471355-2-david@gibson.dropbear.id.au>
On Tue, 7 Jan 2020 15:48:18 +1100
David Gibson <david@gibson.dropbear.id.au> wrote:
> The only effect of the PPC_EMULATE_32BITS_HYPV define is to change how
> MSR_HVB is defined. This appears to be something to handle hypervisor mode
> for 32-bit CPUs, but there's really no other code to handle this. The
> MSR_THV bit, which it uses is implemented for no cpus we model.
>
> It's unlikely anyone is going to implement this any time soon, so just drop
> it.
>
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
> ---
> target/ppc/cpu.h | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/target/ppc/cpu.h b/target/ppc/cpu.h
> index 103bfe9dc2..2de9e2fa2b 100644
> --- a/target/ppc/cpu.h
> +++ b/target/ppc/cpu.h
> @@ -26,8 +26,6 @@
> #include "exec/cpu-defs.h"
> #include "cpu-qom.h"
>
> -/* #define PPC_EMULATE_32BITS_HYPV */
> -
> #define TCG_GUEST_DEFAULT_MO 0
>
> #define TARGET_PAGE_BITS_64K 16
> @@ -450,14 +448,9 @@ typedef struct ppc_v3_pate_t {
> #define MSR_HVB (1ULL << MSR_SHV)
> #define msr_hv msr_shv
> #else
> -#if defined(PPC_EMULATE_32BITS_HYPV)
> -#define MSR_HVB (1ULL << MSR_THV)
> -#define msr_hv msr_thv
> -#else
These lines come from commit a4f30719a8cd, which also introduced msr_thv
and msr_shv to differentiate the 32 and 64 bits HV mode. Maybe you can go
one step further: drop msr_thv and msr_shv and revert to msr_hv only, like
before a4f30719a8cd ?
> #define MSR_HVB (0ULL)
> #define msr_hv (0)
> #endif
> -#endif
>
> /* DSISR */
> #define DSISR_NOPTE 0x40000000
next prev parent reply other threads:[~2020-01-07 17:07 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-07 4:48 [PATCH v2 00/10] target/ppc: Correct some errors with real mode handling David Gibson
2020-01-07 4:48 ` [PATCH v2 01/10] ppc: Drop PPC_EMULATE_32BITS_HYPV stub David Gibson
2020-01-07 12:52 ` Cédric Le Goater
2020-01-07 17:05 ` Greg Kurz [this message]
2020-01-07 4:48 ` [PATCH v2 02/10] ppc: Remove stub of PPC970 HID4 implementation David Gibson
2020-01-07 12:51 ` Cédric Le Goater
2020-01-07 17:32 ` Greg Kurz
2020-01-07 17:36 ` Greg Kurz
2020-01-07 18:05 ` BALATON Zoltan
2020-01-08 1:09 ` David Gibson
2020-01-08 8:29 ` Thomas Huth
2020-01-08 1:08 ` David Gibson
2020-01-08 8:11 ` Greg Kurz
2020-01-08 2:17 ` Paul Mackerras
2020-01-08 13:35 ` Greg Kurz
2020-01-07 4:48 ` [PATCH v2 03/10] target/ppc: Correct handling of real mode accesses with vhyp on hash MMU David Gibson
2020-01-14 10:22 ` Cédric Le Goater
2020-01-07 4:48 ` [PATCH v2 04/10] target/ppc: Introduce ppc_hash64_use_vrma() helper David Gibson
2020-01-07 13:24 ` Cédric Le Goater
2020-01-07 4:48 ` [PATCH v2 05/10] spapr, ppc: Remove VPM0/RMLS hacks for POWER9 David Gibson
2020-01-07 14:35 ` Cédric Le Goater
2020-01-09 7:33 ` Alexey Kardashevskiy
2020-01-13 3:38 ` David Gibson
2020-01-07 4:48 ` [PATCH v2 06/10] target/ppc: Remove RMOR register from POWER9 & POWER10 David Gibson
2020-01-07 13:39 ` Cédric Le Goater
2020-01-07 4:48 ` [PATCH v2 07/10] target/ppc: Use class fields to simplify LPCR masking David Gibson
2020-01-07 13:41 ` Cédric Le Goater
2020-01-07 4:48 ` [PATCH v2 08/10] target/ppc: Streamline calculation of RMA limit from LPCR[RMLS] David Gibson
2020-01-07 13:43 ` Cédric Le Goater
2020-01-07 4:48 ` [PATCH v2 09/10] target/ppc: Correct RMLS table David Gibson
2020-01-07 14:21 ` Cédric Le Goater
2020-01-08 1:06 ` David Gibson
2020-01-08 8:29 ` Cédric Le Goater
2020-01-09 7:46 ` Alexey Kardashevskiy
2020-01-13 3:46 ` David Gibson
2020-01-08 8:28 ` Cédric Le Goater
2020-01-07 4:48 ` [PATCH v2 10/10] target/ppc: Only calculate RMLS derived RMA limit on demand David Gibson
2020-01-08 8:31 ` Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200107180539.57ba0781@bahia.lan \
--to=groug@kaod.org \
--cc=aik@ozlabs.ru \
--cc=clg@kaod.org \
--cc=david@gibson.dropbear.id.au \
--cc=lvivier@redhat.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=paulus@samba.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).