From: Krzysztof Kozlowski <krzk@kernel.org> To: Alice Guo <alice.guo@nxp.com> Cc: robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, linux-imx@nxp.com, peng.fan@nxp.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v4 3/4] arm64: dts: imx8m: add NVMEM provider and consumer to read soc unique ID Date: Fri, 20 Nov 2020 11:53:29 +0100 [thread overview] Message-ID: <20201120105329.GB18581@kozik-lap> (raw) In-Reply-To: <20201120101112.31819-3-alice.guo@nxp.com> On Fri, Nov 20, 2020 at 06:11:11PM +0800, Alice Guo wrote: > In order to be able to use NVMEM APIs to read soc unique ID, add the > nvmem data cell and name for nvmem-cells to the "soc" node, and add a > nvmem node which provides soc unique ID to efuse@30350000. > > v2: remove the subject prefix "LF-2571-3" > v3: convert register addresses and sizes to hex > v4: delete "stuff" in subject and commit message, add detailed > description > > Signed-off-by: Alice Guo <alice.guo@nxp.com> > --- > arch/arm64/boot/dts/freescale/imx8mm.dtsi | 6 ++++++ > arch/arm64/boot/dts/freescale/imx8mn.dtsi | 6 ++++++ > arch/arm64/boot/dts/freescale/imx8mp.dtsi | 6 ++++++ > arch/arm64/boot/dts/freescale/imx8mq.dtsi | 6 ++++++ > 4 files changed, 24 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi > index d457ce815e68..0e0edd5db07b 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi > @@ -261,6 +261,8 @@ > #address-cells = <1>; > #size-cells = <1>; > ranges = <0x0 0x0 0x0 0x3e000000>; > + nvmem-cells = <&imx8mm_uid>; > + nvmem-cell-names = "soc_unique_id"; > > aips1: bus@30000000 { > compatible = "fsl,aips-bus", "simple-bus"; > @@ -518,6 +520,10 @@ > #address-cells = <1>; > #size-cells = <1>; > > + imx8mm_uid: unique_id@410 { Any reason why device node uses underscore, not a hyphen/dash? Other fields are proper (it's also naming convention of DT spec and dtc W=2 will point it). Best regards, Krzysztof > + reg = <0x4 0x8>; > + }; > + > cpu_speed_grade: speed-grade@10 { > reg = <0x10 4>; > };
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org> To: Alice Guo <alice.guo@nxp.com> Cc: devicetree@vger.kernel.org, peng.fan@nxp.com, s.hauer@pengutronix.de, linux-kernel@vger.kernel.org, robh+dt@kernel.org, linux-imx@nxp.com, shawnguo@kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v4 3/4] arm64: dts: imx8m: add NVMEM provider and consumer to read soc unique ID Date: Fri, 20 Nov 2020 11:53:29 +0100 [thread overview] Message-ID: <20201120105329.GB18581@kozik-lap> (raw) In-Reply-To: <20201120101112.31819-3-alice.guo@nxp.com> On Fri, Nov 20, 2020 at 06:11:11PM +0800, Alice Guo wrote: > In order to be able to use NVMEM APIs to read soc unique ID, add the > nvmem data cell and name for nvmem-cells to the "soc" node, and add a > nvmem node which provides soc unique ID to efuse@30350000. > > v2: remove the subject prefix "LF-2571-3" > v3: convert register addresses and sizes to hex > v4: delete "stuff" in subject and commit message, add detailed > description > > Signed-off-by: Alice Guo <alice.guo@nxp.com> > --- > arch/arm64/boot/dts/freescale/imx8mm.dtsi | 6 ++++++ > arch/arm64/boot/dts/freescale/imx8mn.dtsi | 6 ++++++ > arch/arm64/boot/dts/freescale/imx8mp.dtsi | 6 ++++++ > arch/arm64/boot/dts/freescale/imx8mq.dtsi | 6 ++++++ > 4 files changed, 24 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi > index d457ce815e68..0e0edd5db07b 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi > @@ -261,6 +261,8 @@ > #address-cells = <1>; > #size-cells = <1>; > ranges = <0x0 0x0 0x0 0x3e000000>; > + nvmem-cells = <&imx8mm_uid>; > + nvmem-cell-names = "soc_unique_id"; > > aips1: bus@30000000 { > compatible = "fsl,aips-bus", "simple-bus"; > @@ -518,6 +520,10 @@ > #address-cells = <1>; > #size-cells = <1>; > > + imx8mm_uid: unique_id@410 { Any reason why device node uses underscore, not a hyphen/dash? Other fields are proper (it's also naming convention of DT spec and dtc W=2 will point it). Best regards, Krzysztof > + reg = <0x4 0x8>; > + }; > + > cpu_speed_grade: speed-grade@10 { > reg = <0x10 4>; > }; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-11-20 10:53 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-11-20 10:11 [PATCH v4 1/4] dt-bindings: soc: imx8m: add DT Binding doc for soc unique ID Alice Guo 2020-11-20 10:11 ` Alice Guo 2020-11-20 10:11 ` [PATCH v4 2/4] arm64: dts: imx8m: add SoC ID compatible Alice Guo 2020-11-20 10:11 ` Alice Guo 2020-11-20 10:11 ` [PATCH v4 3/4] arm64: dts: imx8m: add NVMEM provider and consumer to read soc unique ID Alice Guo 2020-11-20 10:11 ` Alice Guo 2020-11-20 10:53 ` Krzysztof Kozlowski [this message] 2020-11-20 10:53 ` Krzysztof Kozlowski 2020-11-20 10:11 ` [PATCH v4 4/4] soc: imx8m: change to use platform driver Alice Guo 2020-11-20 10:11 ` Alice Guo 2020-11-20 10:46 ` Krzysztof Kozlowski 2020-11-20 10:46 ` Krzysztof Kozlowski 2021-03-29 9:08 ` regression due to soc_device_match not handling defer (Was: [PATCH v4 4/4] soc: imx8m: change to use platform driver) Dominique MARTINET 2021-03-29 9:08 ` Dominique MARTINET 2021-03-30 2:41 ` [EXT] " Alice Guo (OSS) 2021-03-30 2:41 ` Alice Guo (OSS) 2021-04-15 1:27 ` Dominique MARTINET 2021-04-15 1:27 ` Dominique MARTINET 2021-04-15 1:33 ` Peng Fan 2021-04-15 1:33 ` Peng Fan 2021-06-24 10:36 ` Lucas Stach 2021-06-24 10:36 ` Lucas Stach 2021-06-29 2:39 ` Peng Fan (OSS) 2021-06-29 2:39 ` Peng Fan (OSS) 2020-11-20 10:50 ` [PATCH v4 1/4] dt-bindings: soc: imx8m: add DT Binding doc for soc unique ID Krzysztof Kozlowski 2020-11-20 10:50 ` Krzysztof Kozlowski 2020-11-23 4:45 ` [EXT] " Alice Guo 2020-11-23 4:45 ` Alice Guo 2020-11-23 9:04 ` Krzysztof Kozlowski 2020-11-23 9:04 ` Krzysztof Kozlowski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201120105329.GB18581@kozik-lap \ --to=krzk@kernel.org \ --cc=alice.guo@nxp.com \ --cc=devicetree@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=peng.fan@nxp.com \ --cc=robh+dt@kernel.org \ --cc=s.hauer@pengutronix.de \ --cc=shawnguo@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.