From: Alice Guo <alice.guo@nxp.com> To: Krzysztof Kozlowski <krzk@kernel.org> Cc: "robh+dt@kernel.org" <robh+dt@kernel.org>, "shawnguo@kernel.org" <shawnguo@kernel.org>, "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>, dl-linux-imx <linux-imx@nxp.com>, Peng Fan <peng.fan@nxp.com>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org> Subject: RE: [EXT] Re: [PATCH v4 1/4] dt-bindings: soc: imx8m: add DT Binding doc for soc unique ID Date: Mon, 23 Nov 2020 04:45:13 +0000 [thread overview] Message-ID: <DBBPR04MB606015EDBC99EF83B434D71AE2FC0@DBBPR04MB6060.eurprd04.prod.outlook.com> (raw) In-Reply-To: <20201120105045.GA18581@kozik-lap> > -----Original Message----- > From: Krzysztof Kozlowski <krzk@kernel.org> > Sent: 2020年11月20日 18:51 > To: Alice Guo <alice.guo@nxp.com> > Cc: robh+dt@kernel.org; shawnguo@kernel.org; s.hauer@pengutronix.de; > dl-linux-imx <linux-imx@nxp.com>; Peng Fan <peng.fan@nxp.com>; > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; > linux-arm-kernel@lists.infradead.org > Subject: [EXT] Re: [PATCH v4 1/4] dt-bindings: soc: imx8m: add DT Binding doc > for soc unique ID > > Caution: EXT Email > > On Fri, Nov 20, 2020 at 06:11:09PM +0800, Alice Guo wrote: > > Add DT Binding doc for the Unique ID of i.MX 8M series. > > > > v2: remove the subject prefix "LF-2571-1" > > v3: put it into Documentation/devicetree/bindings/arm/fsl.yaml > > modify the description of nvmem-cells > > use "make ARCH=arm64 dtbs_check" to test it and fix errors > > v4: use allOf to limit new version DTS files for i.MX8M to include > > "fsl,imx8mm/n/p/q-soc", nvmem-cells and nvmem-cells-names > > > > Signed-off-by: Alice Guo <alice.guo@nxp.com> > > --- > > .../devicetree/bindings/arm/fsl.yaml | 51 > +++++++++++++++++++ > > 1 file changed, 51 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml > > b/Documentation/devicetree/bindings/arm/fsl.yaml > > index 67980dcef66d..d8048323a290 100644 > > --- a/Documentation/devicetree/bindings/arm/fsl.yaml > > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml > > @@ -918,6 +918,57 @@ properties: > > - fsl,s32v234-evb # S32V234-EVB2 Customer > Evaluation Board > > - const: fsl,s32v234 > > > > + soc: > > + type: object > > + properties: > > + compatible: > > + oneOf: > > + - description: new version compatible for i.MX8M SoCs > > + items: > > + - enum: > > + - fsl,imx8mm-soc > > + - fsl,imx8mn-soc > > + - fsl,imx8mp-soc > > + - fsl,imx8mq-soc > > + - const: simple-bus > > + > > + - description: old version compatible for i.MX8M SoCs > > + items: > > + - const: simple-bus > > + > > + nvmem-cells: > > + maxItems: 1 > > + description: Phandle to the SOC Unique ID provided by a nvmem > > + node > > + > > + nvmem-cells-names: > > + const: soc_unique_id > > + > > + allOf: > > Nothing changed here comparing to previous version. Still does not work. > > The allOf should not be part of soc node because the "if" below won't match. > Instead, it should be against root node. > > Best regards, > Krzysztof I'm sorry to disturb you. I don't very clear about the grammar rules of yaml, so don't know how to make allOf be part of root node. If allof is part of root node, how does it specify the soc node? The following is my change which is definitely wrong. soc: properties: compatible: - description: new version compatible for i.MX8M SoCs items: - enum: - fsl,imx8mm-soc - fsl,imx8mn-soc - fsl,imx8mp-soc - fsl,imx8mq-soc - const: simple-bus nvmem-cells: maxItems: 1 description: Phandle to the SOC Unique ID provided by a nvmem node nvmem-cells-names: const: soc_unique_id allOf: - if: properties: compatible: contains: enum: - fsl,imx8mm - fsl,imx8mn - fsl,imx8mp - fsl,imx8mq then: required: - soc Please give me suggestion. Thank you. Best regards, Alice Guo > > + - if: > > + properties: > > + compatible: > > + contains: > > + enum: > > + - fsl,imx8mm > > + - fsl,imx8mn > > + - fsl,imx8mp > > + - fsl,imx8mq > > + > > + then: > > + properties: > > + compatible: > > + items: > > + - enum: > > + - fsl,imx8mm-soc > > + - fsl,imx8mn-soc > > + - fsl,imx8mp-soc > > + - fsl,imx8mq-soc > > + - const: simple-bus > > + > > + required: > > + - nvmem-cells > > + - nvmem-cells-names > > + > > additionalProperties: true > > > > ... > > -- > > 2.17.1 > >
WARNING: multiple messages have this Message-ID (diff)
From: Alice Guo <alice.guo@nxp.com> To: Krzysztof Kozlowski <krzk@kernel.org> Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, Peng Fan <peng.fan@nxp.com>, "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "robh+dt@kernel.org" <robh+dt@kernel.org>, dl-linux-imx <linux-imx@nxp.com>, "shawnguo@kernel.org" <shawnguo@kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org> Subject: RE: [EXT] Re: [PATCH v4 1/4] dt-bindings: soc: imx8m: add DT Binding doc for soc unique ID Date: Mon, 23 Nov 2020 04:45:13 +0000 [thread overview] Message-ID: <DBBPR04MB606015EDBC99EF83B434D71AE2FC0@DBBPR04MB6060.eurprd04.prod.outlook.com> (raw) In-Reply-To: <20201120105045.GA18581@kozik-lap> > -----Original Message----- > From: Krzysztof Kozlowski <krzk@kernel.org> > Sent: 2020年11月20日 18:51 > To: Alice Guo <alice.guo@nxp.com> > Cc: robh+dt@kernel.org; shawnguo@kernel.org; s.hauer@pengutronix.de; > dl-linux-imx <linux-imx@nxp.com>; Peng Fan <peng.fan@nxp.com>; > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; > linux-arm-kernel@lists.infradead.org > Subject: [EXT] Re: [PATCH v4 1/4] dt-bindings: soc: imx8m: add DT Binding doc > for soc unique ID > > Caution: EXT Email > > On Fri, Nov 20, 2020 at 06:11:09PM +0800, Alice Guo wrote: > > Add DT Binding doc for the Unique ID of i.MX 8M series. > > > > v2: remove the subject prefix "LF-2571-1" > > v3: put it into Documentation/devicetree/bindings/arm/fsl.yaml > > modify the description of nvmem-cells > > use "make ARCH=arm64 dtbs_check" to test it and fix errors > > v4: use allOf to limit new version DTS files for i.MX8M to include > > "fsl,imx8mm/n/p/q-soc", nvmem-cells and nvmem-cells-names > > > > Signed-off-by: Alice Guo <alice.guo@nxp.com> > > --- > > .../devicetree/bindings/arm/fsl.yaml | 51 > +++++++++++++++++++ > > 1 file changed, 51 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml > > b/Documentation/devicetree/bindings/arm/fsl.yaml > > index 67980dcef66d..d8048323a290 100644 > > --- a/Documentation/devicetree/bindings/arm/fsl.yaml > > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml > > @@ -918,6 +918,57 @@ properties: > > - fsl,s32v234-evb # S32V234-EVB2 Customer > Evaluation Board > > - const: fsl,s32v234 > > > > + soc: > > + type: object > > + properties: > > + compatible: > > + oneOf: > > + - description: new version compatible for i.MX8M SoCs > > + items: > > + - enum: > > + - fsl,imx8mm-soc > > + - fsl,imx8mn-soc > > + - fsl,imx8mp-soc > > + - fsl,imx8mq-soc > > + - const: simple-bus > > + > > + - description: old version compatible for i.MX8M SoCs > > + items: > > + - const: simple-bus > > + > > + nvmem-cells: > > + maxItems: 1 > > + description: Phandle to the SOC Unique ID provided by a nvmem > > + node > > + > > + nvmem-cells-names: > > + const: soc_unique_id > > + > > + allOf: > > Nothing changed here comparing to previous version. Still does not work. > > The allOf should not be part of soc node because the "if" below won't match. > Instead, it should be against root node. > > Best regards, > Krzysztof I'm sorry to disturb you. I don't very clear about the grammar rules of yaml, so don't know how to make allOf be part of root node. If allof is part of root node, how does it specify the soc node? The following is my change which is definitely wrong. soc: properties: compatible: - description: new version compatible for i.MX8M SoCs items: - enum: - fsl,imx8mm-soc - fsl,imx8mn-soc - fsl,imx8mp-soc - fsl,imx8mq-soc - const: simple-bus nvmem-cells: maxItems: 1 description: Phandle to the SOC Unique ID provided by a nvmem node nvmem-cells-names: const: soc_unique_id allOf: - if: properties: compatible: contains: enum: - fsl,imx8mm - fsl,imx8mn - fsl,imx8mp - fsl,imx8mq then: required: - soc Please give me suggestion. Thank you. Best regards, Alice Guo > > + - if: > > + properties: > > + compatible: > > + contains: > > + enum: > > + - fsl,imx8mm > > + - fsl,imx8mn > > + - fsl,imx8mp > > + - fsl,imx8mq > > + > > + then: > > + properties: > > + compatible: > > + items: > > + - enum: > > + - fsl,imx8mm-soc > > + - fsl,imx8mn-soc > > + - fsl,imx8mp-soc > > + - fsl,imx8mq-soc > > + - const: simple-bus > > + > > + required: > > + - nvmem-cells > > + - nvmem-cells-names > > + > > additionalProperties: true > > > > ... > > -- > > 2.17.1 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-11-23 4:45 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-11-20 10:11 [PATCH v4 1/4] dt-bindings: soc: imx8m: add DT Binding doc for soc unique ID Alice Guo 2020-11-20 10:11 ` Alice Guo 2020-11-20 10:11 ` [PATCH v4 2/4] arm64: dts: imx8m: add SoC ID compatible Alice Guo 2020-11-20 10:11 ` Alice Guo 2020-11-20 10:11 ` [PATCH v4 3/4] arm64: dts: imx8m: add NVMEM provider and consumer to read soc unique ID Alice Guo 2020-11-20 10:11 ` Alice Guo 2020-11-20 10:53 ` Krzysztof Kozlowski 2020-11-20 10:53 ` Krzysztof Kozlowski 2020-11-20 10:11 ` [PATCH v4 4/4] soc: imx8m: change to use platform driver Alice Guo 2020-11-20 10:11 ` Alice Guo 2020-11-20 10:46 ` Krzysztof Kozlowski 2020-11-20 10:46 ` Krzysztof Kozlowski 2021-03-29 9:08 ` regression due to soc_device_match not handling defer (Was: [PATCH v4 4/4] soc: imx8m: change to use platform driver) Dominique MARTINET 2021-03-29 9:08 ` Dominique MARTINET 2021-03-30 2:41 ` [EXT] " Alice Guo (OSS) 2021-03-30 2:41 ` Alice Guo (OSS) 2021-04-15 1:27 ` Dominique MARTINET 2021-04-15 1:27 ` Dominique MARTINET 2021-04-15 1:33 ` Peng Fan 2021-04-15 1:33 ` Peng Fan 2021-06-24 10:36 ` Lucas Stach 2021-06-24 10:36 ` Lucas Stach 2021-06-29 2:39 ` Peng Fan (OSS) 2021-06-29 2:39 ` Peng Fan (OSS) 2020-11-20 10:50 ` [PATCH v4 1/4] dt-bindings: soc: imx8m: add DT Binding doc for soc unique ID Krzysztof Kozlowski 2020-11-20 10:50 ` Krzysztof Kozlowski 2020-11-23 4:45 ` Alice Guo [this message] 2020-11-23 4:45 ` [EXT] " Alice Guo 2020-11-23 9:04 ` Krzysztof Kozlowski 2020-11-23 9:04 ` Krzysztof Kozlowski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=DBBPR04MB606015EDBC99EF83B434D71AE2FC0@DBBPR04MB6060.eurprd04.prod.outlook.com \ --to=alice.guo@nxp.com \ --cc=devicetree@vger.kernel.org \ --cc=krzk@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=peng.fan@nxp.com \ --cc=robh+dt@kernel.org \ --cc=s.hauer@pengutronix.de \ --cc=shawnguo@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.