Re: [PATCH 01/10] drm/dp_helper: add defines for DP 1.2 and MST support.

From: Jingoo Han <jg1.han@samsung.com>
To: 'Dave Airlie' <airlied@gmail.com>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 01/10] drm/dp_helper: add defines for DP 1.2 and MST support.
Date: Tue, 13 May 2014 17:51:14 +0900	[thread overview]
Message-ID: <002901cf6e88$7f190ef0$7d4b2cd0$%han@samsung.com> (raw)
In-Reply-To: <1399877207-15868-2-git-send-email-airlied@gmail.com>

On Monday, May 12, 2014 3:47 PM, Dave Airlie wrote:
> 
> From: Dave Airlie <airlied@redhat.com>
> 
> This just adds the defines from the DP 1.2 spec, which we
> will use later.
> 
> Signed-off-by: Dave Airlie <airlied@redhat.com>
> ---
>  include/drm/drm_dp_helper.h | 78 +++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 78 insertions(+)
> 
> diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
> index cfcacec..879836d 100644
> --- a/include/drm/drm_dp_helper.h
> +++ b/include/drm/drm_dp_helper.h
> @@ -37,6 +37,7 @@
>   * eDP: Embedded DisplayPort version 1
>   * DPI: DisplayPort Interoperability Guideline v1.1a
>   * 1.2: DisplayPort 1.2
> + * MST: Multistream Transport - part of DP 1.2a
>   *
>   * 1.2 formally includes both eDP and DPI definitions.
>   */

[.....]

> +# define DP_MCCS_IRQ			    (1 << 3)
> +# define DP_DOWN_REP_MSG_RDY		    (1 << 4) /* DP MST */
> +# define DP_UP_REQ_MSG_RDY		    (1 << 5) /* DP MST */

[.....]

> 
> +#define DP_PAYLOAD_TABLE_UPDATE_STATUS      0x2c0   /* 1.2 MST */

Hi Dave Airlie,

What is the difference between 'DP MST' and '1.2 MST'?
If there is no difference, would you use the same comment
as below?

+# define DP_DOWN_REP_MSG_RDY		    (1 << 4) /* 1.2 MST */
+# define DP_UP_REQ_MSG_RDY		    (1 << 5) /* 1.2 MST */

Best regards,
Jingoo Han

[.....]