Re: [PATCH 05/10] drm: add a path blob property

From: Thierry Reding <thierry.reding@gmail.com>
To: Dave Airlie <airlied@gmail.com>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 05/10] drm: add a path blob property
Date: Tue, 13 May 2014 10:25:36 +0200	[thread overview]
Message-ID: <20140513082535.GI6754@ulmo> (raw)
In-Reply-To: <1399877207-15868-6-git-send-email-airlied@gmail.com>

[-- Attachment #1.1: Type: text/plain, Size: 1147 bytes --]

On Mon, May 12, 2014 at 04:46:42PM +1000, Dave Airlie wrote:
> From: Dave Airlie <airlied@redhat.com>
> 
> This property will be used by the MST code to provide userspace
> with a path to parse so it can recognise connectors around hotplugs.
> 
> Signed-off-by: Dave Airlie <airlied@redhat.com>
> ---
>  drivers/gpu/drm/drm_crtc.c | 26 ++++++++++++++++++++++++++
>  include/drm/drm_crtc.h     |  5 +++++
>  2 files changed, 31 insertions(+)

The documentation for this property is missing. =)

> diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
[...]
> +int drm_mode_connector_set_path_property(struct drm_connector *connector,
> +					 char *path)

"const char *path"?

> +{
> +	struct drm_device *dev = connector->dev;
> +	int ret, size;
> +	size = strlen(path) + 1;

At the risk of sounding pedantic: strlen() returns size_t, not int. But
I see that drm_property_create_blob() uses int as the type for the
length argument, so there's an inconsistency either way. I'll go prepare
a patch to fix that inconsistency and see if anybody else is equally
pedantic and willing to apply it.

Thierry

[-- Attachment #1.2: Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx