From: Dave Airlie <airlied@gmail.com>
To: David Herrmann <dh.herrmann@gmail.com>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 09/10] i915: add DP 1.2 MST support (v0.3)
Date: Wed, 14 May 2014 10:03:53 +1000 [thread overview]
Message-ID: <CAPM=9tyfX6qeiCNHXgsOxZVLsVMykmN-E9fC4HE6W5wNbz42Cw@mail.gmail.com> (raw)
In-Reply-To: <CANq1E4S2gNm6D10ZQLNnOpj==VfwrwQR0hHHFzDDZznARsBAEA@mail.gmail.com>
>
> So we leak all dynamically created objects? There's no
> kfree(intel_connector) here and we cannot add it because
> drm_mode_object_find() is not ref-counted. So we keep the connector in
> the mode_group and wait until the final drm_mode_config_cleanup()? But
> drm_connector_cleanup() already removes the connector from the
> mode-group, so we eventually leak the object.
>
Seems like freeing it should be fine, it was just an oversight,
Since any objects you get with find are only valid under mode_config.mutex,
yes some drivers mess this up, but they should be fixed.
Dave.
next prev parent reply other threads:[~2014-05-14 0:03 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-12 6:46 [RFC] DisplayPort MST v0.3 Dave Airlie
2014-05-12 6:46 ` [PATCH 01/10] drm/dp_helper: add defines for DP 1.2 and MST support Dave Airlie
2014-05-13 8:51 ` Jingoo Han
2014-05-12 6:46 ` [PATCH 02/10] drm: add DP MST encoder type Dave Airlie
2014-05-12 6:46 ` [PATCH 03/10] drm/i915: add some registers need for displayport MST support Dave Airlie
2014-05-12 6:46 ` [PATCH 04/10] drm/crtc: add interface to reinitialise the legacy mode group Dave Airlie
2014-05-13 8:26 ` Thierry Reding
2014-05-13 10:15 ` Daniel Vetter
2014-05-12 6:46 ` [PATCH 05/10] drm: add a path blob property Dave Airlie
2014-05-13 8:25 ` Thierry Reding
2014-05-12 6:46 ` [PATCH 06/10] drm/helper: add Displayport multi-stream helper (v0.3) Dave Airlie
2014-05-12 6:46 ` [PATCH 07/10] i915: split some DP modesetting code into a separate function Dave Airlie
2014-05-12 6:46 ` [PATCH 08/10] drm/i915: check connector->encoder before using it Dave Airlie
2014-05-12 6:46 ` [PATCH 09/10] i915: add DP 1.2 MST support (v0.3) Dave Airlie
2014-05-13 7:18 ` David Herrmann
2014-05-14 0:03 ` Dave Airlie [this message]
2014-05-14 6:05 ` David Herrmann
2014-05-14 8:23 ` Daniel Vetter
2014-05-12 6:46 ` [PATCH 10/10] i915: mst topology dumper in debugfs Dave Airlie
2014-05-13 8:33 ` Thierry Reding
2014-05-13 10:18 ` Daniel Vetter
2014-05-13 10:40 ` Thierry Reding
2014-05-12 8:25 ` [RFC] DisplayPort MST v0.3 Dave Airlie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPM=9tyfX6qeiCNHXgsOxZVLsVMykmN-E9fC4HE6W5wNbz42Cw@mail.gmail.com' \
--to=airlied@gmail.com \
--cc=dh.herrmann@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.