Re: [PATCH 10/10] i915: mst topology dumper in debugfs

From: Daniel Vetter <daniel@ffwll.ch>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 10/10] i915: mst topology dumper in debugfs
Date: Tue, 13 May 2014 12:18:35 +0200	[thread overview]
Message-ID: <20140513101835.GB3908@phenom.ffwll.local> (raw)
In-Reply-To: <20140513083326.GK6754@ulmo>

On Tue, May 13, 2014 at 10:33:27AM +0200, Thierry Reding wrote:
> On Mon, May 12, 2014 at 04:46:47PM +1000, Dave Airlie wrote:
> [...]
> > @@ -3813,6 +3838,7 @@ static const struct drm_info_list i915_debugfs_list[] = {
> >  	{"i915_pc8_status", i915_pc8_status, 0},
> >  	{"i915_power_domain_info", i915_power_domain_info, 0},
> >  	{"i915_display_info", i915_display_info, 0},
> > +	{"i915_dp_mst_info", i915_dp_mst_info, 0},
> 
> This isn't really specific to this patch, but I've been thinking for a
> while if perhaps it would be a good idea to try to unify debugfs across
> drivers to some degree. What I mean by that is try to use common names
> for files with similar functionality. Off the top of my head I think a
> couple of drivers expose a list of framebuffers via debugfs, mostly
> using duplicated code and different file names. Sharing the code would
> of course be easy, but I think there may be some advantage to keeping
> the names consistent as well.

Imo our current approach of having seq_file helpers in libraries that
drivers can use works well. At least with i915 we often want to add some
more driver-private state to dumps (e.g. for framebuffers), so extracting
more than what's already extracted is probably hard to do.

But I guess we could add some common files with e.g. just the core
framebuffer stuff to all drivers. Not terribly motivated myself though
since i915 has it all already ;-)
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch