From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> To: Kathiravan T <quic_kathirav@quicinc.com>, krzysztof.kozlowski@linaro.org, agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, mturquette@baylibre.com, sboyd@kernel.org, linus.walleij@linaro.org, catalin.marinas@arm.com, will@kernel.org, shawnguo@kernel.org, arnd@arndb.de, marcel.ziswiler@toradex.com, nfraprado@collabora.com, robimarko@gmail.com, quic_gurus@quicinc.com, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: quic_varada@quicinc.com, quic_srichara@quicinc.com Subject: Re: [PATCH V3 4/9] dt-bindings: clock: Add Qualcomm IPQ5332 GCC Date: Mon, 6 Feb 2023 11:52:06 +0200 [thread overview] Message-ID: <03d6c92a-c9f3-915c-218a-14ff5c5250d2@linaro.org> (raw) In-Reply-To: <20230206071217.29313-5-quic_kathirav@quicinc.com> On 06/02/2023 09:12, Kathiravan T wrote: > Add binding for the Qualcomm IPQ5332 Global Clock Controller. > > Signed-off-by: Kathiravan T <quic_kathirav@quicinc.com> > --- > Changes in V3: > - Actually I missed to remove the clocks in V2 which are supposed to > be removed. In V3 I have removed those and they are > GCC_APSS_AHB_CLK, GCC_APSS_AHB_CLK_SRC, GCC_APSS_AXI_CLK > - For the same, didn't add the Reviewed-By tags from Stephen and > Krzysztof > > Changes in V2: > - property 'clocks' is marked required > - Renamed the include file name to match with compatible > > .../bindings/clock/qcom,ipq5332-gcc.yaml | 61 +++ > include/dt-bindings/clock/qcom,ipq5332-gcc.h | 356 ++++++++++++++++++ > 2 files changed, 417 insertions(+) > create mode 100644 Documentation/devicetree/bindings/clock/qcom,ipq5332-gcc.yaml > create mode 100644 include/dt-bindings/clock/qcom,ipq5332-gcc.h > > diff --git a/Documentation/devicetree/bindings/clock/qcom,ipq5332-gcc.yaml b/Documentation/devicetree/bindings/clock/qcom,ipq5332-gcc.yaml > new file mode 100644 > index 000000000000..961311af400c > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/qcom,ipq5332-gcc.yaml > @@ -0,0 +1,61 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/clock/qcom,ipq5332-gcc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm Global Clock & Reset Controller on IPQ5332 > + > +maintainers: > + - Stephen Boyd <sboyd@kernel.org> > + > +description: | > + Qualcomm global clock control module provides the clocks, resets and power > + domains on IPQ5332. > + > + See also:: include/dt-bindings/clock/qcom,gcc-ipq5332.h > + > +allOf: > + - $ref: qcom,gcc.yaml# > + > +properties: > + compatible: > + const: qcom,ipq5332-gcc > + > + clocks: > + items: > + - description: Board XO clock source > + - description: Sleep clock source > + - description: PCIE 2lane PHY pipe clock source > + - description: PCIE 2lane x1 PHY pipe clock source (For second lane) > + - description: USB PCIE wrapper pipe clock source > + > + clock-names: > + items: > + - const: xo > + - const: sleep_clk > + - const: pcie_2lane_phy_pipe_clk > + - const: pcie_2lane_phy_pipe_clk_x1 > + - const: usb_pcie_wrapper_pipe_clk pcie3x1_0_pipe_clk_src, pcie3x1_1_pipe_clk_src, pcie3x2_pipe_clk_src usb0_pipe_clk_src are missing. > + > +required: > + - compatible > + - clocks > + > +unevaluatedProperties: false > + > +examples: > + - | > + clock-controller@1800000 { > + compatible = "qcom,ipq5332-gcc"; > + reg = <0x01800000 0x80000>; > + clocks = <&xo_board>, > + <&sleep_clk>, > + <&pcie_2lane_phy_pipe_clk>, > + <&pcie_2lane_phy_pipe_clk_x1>, > + <&usb_pcie_wrapper_pipe_clk>; > + #clock-cells = <1>; > + #power-domain-cells = <1>; > + #reset-cells = <1>; > + }; > +... -- With best wishes Dmitry
WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> To: Kathiravan T <quic_kathirav@quicinc.com>, krzysztof.kozlowski@linaro.org, agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, mturquette@baylibre.com, sboyd@kernel.org, linus.walleij@linaro.org, catalin.marinas@arm.com, will@kernel.org, shawnguo@kernel.org, arnd@arndb.de, marcel.ziswiler@toradex.com, nfraprado@collabora.com, robimarko@gmail.com, quic_gurus@quicinc.com, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: quic_varada@quicinc.com, quic_srichara@quicinc.com Subject: Re: [PATCH V3 4/9] dt-bindings: clock: Add Qualcomm IPQ5332 GCC Date: Mon, 6 Feb 2023 11:52:06 +0200 [thread overview] Message-ID: <03d6c92a-c9f3-915c-218a-14ff5c5250d2@linaro.org> (raw) In-Reply-To: <20230206071217.29313-5-quic_kathirav@quicinc.com> On 06/02/2023 09:12, Kathiravan T wrote: > Add binding for the Qualcomm IPQ5332 Global Clock Controller. > > Signed-off-by: Kathiravan T <quic_kathirav@quicinc.com> > --- > Changes in V3: > - Actually I missed to remove the clocks in V2 which are supposed to > be removed. In V3 I have removed those and they are > GCC_APSS_AHB_CLK, GCC_APSS_AHB_CLK_SRC, GCC_APSS_AXI_CLK > - For the same, didn't add the Reviewed-By tags from Stephen and > Krzysztof > > Changes in V2: > - property 'clocks' is marked required > - Renamed the include file name to match with compatible > > .../bindings/clock/qcom,ipq5332-gcc.yaml | 61 +++ > include/dt-bindings/clock/qcom,ipq5332-gcc.h | 356 ++++++++++++++++++ > 2 files changed, 417 insertions(+) > create mode 100644 Documentation/devicetree/bindings/clock/qcom,ipq5332-gcc.yaml > create mode 100644 include/dt-bindings/clock/qcom,ipq5332-gcc.h > > diff --git a/Documentation/devicetree/bindings/clock/qcom,ipq5332-gcc.yaml b/Documentation/devicetree/bindings/clock/qcom,ipq5332-gcc.yaml > new file mode 100644 > index 000000000000..961311af400c > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/qcom,ipq5332-gcc.yaml > @@ -0,0 +1,61 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/clock/qcom,ipq5332-gcc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm Global Clock & Reset Controller on IPQ5332 > + > +maintainers: > + - Stephen Boyd <sboyd@kernel.org> > + > +description: | > + Qualcomm global clock control module provides the clocks, resets and power > + domains on IPQ5332. > + > + See also:: include/dt-bindings/clock/qcom,gcc-ipq5332.h > + > +allOf: > + - $ref: qcom,gcc.yaml# > + > +properties: > + compatible: > + const: qcom,ipq5332-gcc > + > + clocks: > + items: > + - description: Board XO clock source > + - description: Sleep clock source > + - description: PCIE 2lane PHY pipe clock source > + - description: PCIE 2lane x1 PHY pipe clock source (For second lane) > + - description: USB PCIE wrapper pipe clock source > + > + clock-names: > + items: > + - const: xo > + - const: sleep_clk > + - const: pcie_2lane_phy_pipe_clk > + - const: pcie_2lane_phy_pipe_clk_x1 > + - const: usb_pcie_wrapper_pipe_clk pcie3x1_0_pipe_clk_src, pcie3x1_1_pipe_clk_src, pcie3x2_pipe_clk_src usb0_pipe_clk_src are missing. > + > +required: > + - compatible > + - clocks > + > +unevaluatedProperties: false > + > +examples: > + - | > + clock-controller@1800000 { > + compatible = "qcom,ipq5332-gcc"; > + reg = <0x01800000 0x80000>; > + clocks = <&xo_board>, > + <&sleep_clk>, > + <&pcie_2lane_phy_pipe_clk>, > + <&pcie_2lane_phy_pipe_clk_x1>, > + <&usb_pcie_wrapper_pipe_clk>; > + #clock-cells = <1>; > + #power-domain-cells = <1>; > + #reset-cells = <1>; > + }; > +... -- With best wishes Dmitry _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-02-06 9:53 UTC|newest] Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-02-06 7:12 [PATCH V3 0/9] Add minimal boot support for IPQ5332 Kathiravan T 2023-02-06 7:12 ` Kathiravan T 2023-02-06 7:12 ` [PATCH V3 1/9] dt-bindings: pinctrl: qcom: add IPQ5332 pinctrl Kathiravan T 2023-02-06 7:12 ` Kathiravan T 2023-02-06 8:26 ` Krzysztof Kozlowski 2023-02-06 8:26 ` Krzysztof Kozlowski 2023-02-06 7:12 ` [PATCH V3 2/9] pinctrl: qcom: Introduce IPQ5332 TLMM driver Kathiravan T 2023-02-06 7:12 ` Kathiravan T 2023-02-07 3:34 ` Bjorn Andersson 2023-02-07 3:34 ` Bjorn Andersson 2023-02-06 7:12 ` [PATCH V3 3/9] clk: qcom: Add STROMER PLUS PLL type for IPQ5332 Kathiravan T 2023-02-06 7:12 ` Kathiravan T 2023-02-06 7:12 ` [PATCH V3 4/9] dt-bindings: clock: Add Qualcomm IPQ5332 GCC Kathiravan T 2023-02-06 7:12 ` Kathiravan T 2023-02-06 8:26 ` Krzysztof Kozlowski 2023-02-06 8:26 ` Krzysztof Kozlowski 2023-02-06 9:52 ` Dmitry Baryshkov [this message] 2023-02-06 9:52 ` Dmitry Baryshkov 2023-02-07 4:26 ` Kathiravan T 2023-02-07 4:26 ` Kathiravan T 2023-02-07 10:05 ` Dmitry Baryshkov 2023-02-07 10:05 ` Dmitry Baryshkov 2023-02-06 7:12 ` [PATCH V3 5/9] clk: qcom: add Global Clock controller (GCC) driver for IPQ5332 SoC Kathiravan T 2023-02-06 9:52 ` Dmitry Baryshkov 2023-02-06 9:56 ` Dmitry Baryshkov 2023-02-06 9:56 ` Dmitry Baryshkov 2023-02-07 4:29 ` Kathiravan T 2023-02-07 4:29 ` Kathiravan T 2023-02-07 3:41 ` Bjorn Andersson 2023-02-07 3:41 ` Bjorn Andersson 2023-02-07 4:31 ` Kathiravan T 2023-02-07 4:31 ` Kathiravan T 2023-02-06 7:12 ` [PATCH V3 6/9] dt-bindings: qcom: add ipq5332 boards Kathiravan T 2023-02-06 7:12 ` Kathiravan T 2023-02-06 8:27 ` Krzysztof Kozlowski 2023-02-06 8:27 ` Krzysztof Kozlowski 2023-02-06 7:12 ` [PATCH V3 7/9] dt-bindings: firmware: qcom,scm: document IPQ5332 SCM Kathiravan T 2023-02-06 7:12 ` Kathiravan T 2023-02-06 7:12 ` [PATCH V3 8/9] arm64: dts: qcom: add IPQ5332 SoC and MI01.2 board support Kathiravan T 2023-02-06 7:12 ` Kathiravan T 2023-02-06 7:12 ` [PATCH V3 9/9] arm64: defconfig: Enable IPQ5332 SoC base configs Kathiravan T 2023-02-06 7:12 ` Kathiravan T 2023-02-06 9:53 ` Dmitry Baryshkov 2023-02-06 9:53 ` Dmitry Baryshkov 2023-02-06 11:25 ` [PATCH V3 0/9] Add minimal boot support for IPQ5332 Linus Walleij 2023-02-06 11:25 ` Linus Walleij 2023-02-06 11:42 ` Kathiravan T 2023-02-06 11:42 ` Kathiravan T
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=03d6c92a-c9f3-915c-218a-14ff5c5250d2@linaro.org \ --to=dmitry.baryshkov@linaro.org \ --cc=agross@kernel.org \ --cc=andersson@kernel.org \ --cc=arnd@arndb.de \ --cc=catalin.marinas@arm.com \ --cc=devicetree@vger.kernel.org \ --cc=konrad.dybcio@linaro.org \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=krzysztof.kozlowski@linaro.org \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=marcel.ziswiler@toradex.com \ --cc=mturquette@baylibre.com \ --cc=nfraprado@collabora.com \ --cc=quic_gurus@quicinc.com \ --cc=quic_kathirav@quicinc.com \ --cc=quic_srichara@quicinc.com \ --cc=quic_varada@quicinc.com \ --cc=robh+dt@kernel.org \ --cc=robimarko@gmail.com \ --cc=sboyd@kernel.org \ --cc=shawnguo@kernel.org \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.