From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: "Mahapatra, Chandrabhanu" <cmahapatra@ti.com>
Cc: linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org
Subject: Re: [PATCH V3 2/3] OMAPDSS: Cleanup DSSDBG with dynamic pr_debug function
Date: Fri, 28 Sep 2012 11:37:47 +0000 [thread overview]
Message-ID: <1348832267.2437.25.camel@deskari> (raw)
In-Reply-To: <CAF0AtAvfnnBzTgPtNBJhxXTp9dZfPQOnotNmCQ+Fz=tkHY65gA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 616 bytes --]
On Fri, 2012-09-28 at 17:00 +0530, Mahapatra, Chandrabhanu wrote:
> > I think you could just do:
> >
> > #ifdef DSS_SUBSYS_NAME
> > #ifdef pr_fmt
> > #undef pr_fmt
> > #endif
> > #define pr_fmt(fmt) DSS_SUBSYS_NAME ": " fmt
> > #endif
> >
> > For the case where there's no DSS_SUBSYS_NAME, there's no need to undef
> > pr_fmt, only to redefine it again back to the original.
> >
> > Tomi
> >
>
> Ok. But I thought it could be more clearer if the definition of pr_fmt
> is more clearer in both the cases, when DSS_SUBSYS_NAME is defined and
> when not.
Ok, then it's fine for me.
Tomi
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: "Mahapatra, Chandrabhanu" <cmahapatra@ti.com>
Cc: linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org
Subject: Re: [PATCH V3 2/3] OMAPDSS: Cleanup DSSDBG with dynamic pr_debug function
Date: Fri, 28 Sep 2012 14:37:47 +0300 [thread overview]
Message-ID: <1348832267.2437.25.camel@deskari> (raw)
In-Reply-To: <CAF0AtAvfnnBzTgPtNBJhxXTp9dZfPQOnotNmCQ+Fz=tkHY65gA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 616 bytes --]
On Fri, 2012-09-28 at 17:00 +0530, Mahapatra, Chandrabhanu wrote:
> > I think you could just do:
> >
> > #ifdef DSS_SUBSYS_NAME
> > #ifdef pr_fmt
> > #undef pr_fmt
> > #endif
> > #define pr_fmt(fmt) DSS_SUBSYS_NAME ": " fmt
> > #endif
> >
> > For the case where there's no DSS_SUBSYS_NAME, there's no need to undef
> > pr_fmt, only to redefine it again back to the original.
> >
> > Tomi
> >
>
> Ok. But I thought it could be more clearer if the definition of pr_fmt
> is more clearer in both the cases, when DSS_SUBSYS_NAME is defined and
> when not.
Ok, then it's fine for me.
Tomi
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-09-28 11:37 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-25 6:03 [PATCH] OMAPDSS: Cleanup DSSDBG with dynamic pr_debug function Chandrabhanu Mahapatra
2012-09-25 6:15 ` Chandrabhanu Mahapatra
2012-09-25 6:24 ` Tomi Valkeinen
2012-09-25 6:24 ` Tomi Valkeinen
2012-09-25 9:30 ` Mahapatra, Chandrabhanu
2012-09-25 9:42 ` Mahapatra, Chandrabhanu
2012-09-25 9:57 ` Tomi Valkeinen
2012-09-25 9:57 ` Tomi Valkeinen
2012-09-26 5:15 ` [PATCH V2 0/2] OMAPDSS: Enable dynamic debug printing Chandrabhanu Mahapatra
2012-09-26 5:27 ` Chandrabhanu Mahapatra
2012-09-26 5:15 ` [PATCH V2 1/2] OMAPDSS: Cleanup DSSDBG with dynamic pr_debug function Chandrabhanu Mahapatra
2012-09-26 5:27 ` Chandrabhanu Mahapatra
2012-09-26 5:16 ` [PATCH V2 2/2] OMAPDSS: Remove dss_debug variable Chandrabhanu Mahapatra
2012-09-26 5:28 ` Chandrabhanu Mahapatra
2012-09-26 14:29 ` [PATCH V2 0/2] OMAPDSS: Enable dynamic debug printing Tomi Valkeinen
2012-09-26 14:29 ` Tomi Valkeinen
2012-09-27 10:50 ` Mahapatra, Chandrabhanu
2012-09-27 10:50 ` Mahapatra, Chandrabhanu
2012-09-27 11:01 ` Tomi Valkeinen
2012-09-27 11:01 ` Tomi Valkeinen
2012-09-28 10:23 ` [PATCH V3 0/3] " Chandrabhanu Mahapatra
2012-09-28 10:35 ` Chandrabhanu Mahapatra
2012-09-28 10:23 ` [PATCH V3 1/3] OMAPDSS: Move definition of DEBUG flag to Makefile Chandrabhanu Mahapatra
2012-09-28 10:35 ` Chandrabhanu Mahapatra
2012-09-28 10:23 ` [PATCH V3 2/3] OMAPDSS: Cleanup DSSDBG with dynamic pr_debug function Chandrabhanu Mahapatra
2012-09-28 10:35 ` Chandrabhanu Mahapatra
2012-09-28 11:22 ` Tomi Valkeinen
2012-09-28 11:22 ` Tomi Valkeinen
2012-09-28 11:30 ` Mahapatra, Chandrabhanu
2012-09-28 11:42 ` Mahapatra, Chandrabhanu
2012-09-28 11:37 ` Tomi Valkeinen [this message]
2012-09-28 11:37 ` Tomi Valkeinen
2012-09-28 10:23 ` [PATCH V3 3/3] OMAPDSS: Remove dss_debug variable Chandrabhanu Mahapatra
2012-09-28 10:35 ` Chandrabhanu Mahapatra
2012-09-28 11:34 ` [PATCH V3 0/3] OMAPDSS: Enable dynamic debug printing Tomi Valkeinen
2012-09-28 11:34 ` Tomi Valkeinen
2012-09-28 12:11 ` Mahapatra, Chandrabhanu
2012-09-28 12:23 ` Mahapatra, Chandrabhanu
2012-09-29 10:49 ` [PATCH V4 0/5] " Chandrabhanu Mahapatra
2012-09-29 10:51 ` Chandrabhanu Mahapatra
2012-09-29 10:49 ` [PATCH V4 1/5] OMAPDSS: Move definition of DEBUG flag to Makefile Chandrabhanu Mahapatra
2012-09-29 10:51 ` Chandrabhanu Mahapatra
2012-09-29 10:49 ` [PATCH V4 2/5] OMAPDSS: Create new debug config options Chandrabhanu Mahapatra
2012-09-29 10:52 ` Chandrabhanu Mahapatra
2012-09-29 15:15 ` Sumit Semwal
2012-09-29 15:27 ` Sumit Semwal
2012-10-01 7:48 ` [PATCH V5 " Chandrabhanu Mahapatra
2012-10-01 7:51 ` Chandrabhanu Mahapatra
2012-09-29 10:49 ` [PATCH V4 3/5] OMAPDSS: Cleanup DSSDBG with dynamic pr_debug function Chandrabhanu Mahapatra
2012-09-29 10:52 ` Chandrabhanu Mahapatra
2012-09-29 10:49 ` [PATCH V4 4/5] OMAPDSS: Replace multi part debug prints with pr_debug Chandrabhanu Mahapatra
2012-09-29 10:52 ` Chandrabhanu Mahapatra
2012-10-05 12:33 ` Tomi Valkeinen
2012-10-05 12:33 ` Tomi Valkeinen
2012-10-10 9:22 ` [PATCH V5 " Chandrabhanu Mahapatra
2012-10-10 9:34 ` Chandrabhanu Mahapatra
2012-09-29 10:49 ` [PATCH V4 5/5] OMAPDSS: Remove dss_debug variable Chandrabhanu Mahapatra
2012-09-29 10:52 ` Chandrabhanu Mahapatra
2012-10-05 12:46 ` [PATCH V4 0/5] OMAPDSS: Enable dynamic debug printing Tomi Valkeinen
2012-10-05 12:46 ` Tomi Valkeinen
2012-10-10 10:26 ` Sumit Semwal
2012-10-10 10:38 ` Sumit Semwal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1348832267.2437.25.camel@deskari \
--to=tomi.valkeinen@ti.com \
--cc=cmahapatra@ti.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.