From: Chandrabhanu Mahapatra <cmahapatra@ti.com>
To: tomi.valkeinen@ti.com
Cc: linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org,
Chandrabhanu Mahapatra <cmahapatra@ti.com>
Subject: [PATCH V3 1/3] OMAPDSS: Move definition of DEBUG flag to Makefile
Date: Fri, 28 Sep 2012 10:35:18 +0000 [thread overview]
Message-ID: <fbaf2825628b01a7b660993a83a8f3de37cfcd04.1348826106.git.cmahapatra@ti.com> (raw)
In-Reply-To: <cover.1348826106.git.cmahapatra@ti.com>
In OMAPDSS the DEBUG flag is set only after the OMAPDSS module is called, for
which the debugging capabilities are available only after its proper
initialization. As a result of which tracking of bugs prior to or during initial
process becomes difficult. So, the definition of DEBUG is being moved to the
corresponding Makefile.
Signed-off-by: Chandrabhanu Mahapatra <cmahapatra@ti.com>
---
drivers/video/omap2/dss/Makefile | 1 +
drivers/video/omap2/dss/dss.h | 4 ----
2 files changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/video/omap2/dss/Makefile b/drivers/video/omap2/dss/Makefile
index 4549869..86493e3 100644
--- a/drivers/video/omap2/dss/Makefile
+++ b/drivers/video/omap2/dss/Makefile
@@ -8,3 +8,4 @@ omapdss-$(CONFIG_OMAP2_DSS_SDI) += sdi.o
omapdss-$(CONFIG_OMAP2_DSS_DSI) += dsi.o
omapdss-$(CONFIG_OMAP4_DSS_HDMI) += hdmi.o \
hdmi_panel.o ti_hdmi_4xxx_ip.o
+ccflags-$(CONFIG_OMAP2_DSS_DEBUG_SUPPORT) += -DDEBUG
diff --git a/drivers/video/omap2/dss/dss.h b/drivers/video/omap2/dss/dss.h
index 6728892..ffbba7e 100644
--- a/drivers/video/omap2/dss/dss.h
+++ b/drivers/video/omap2/dss/dss.h
@@ -23,10 +23,6 @@
#ifndef __OMAP2_DSS_H
#define __OMAP2_DSS_H
-#ifdef CONFIG_OMAP2_DSS_DEBUG_SUPPORT
-#define DEBUG
-#endif
-
#ifdef DEBUG
extern bool dss_debug;
#ifdef DSS_SUBSYS_NAME
--
1.7.10
WARNING: multiple messages have this Message-ID (diff)
From: Chandrabhanu Mahapatra <cmahapatra@ti.com>
To: tomi.valkeinen@ti.com
Cc: linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org,
Chandrabhanu Mahapatra <cmahapatra@ti.com>
Subject: [PATCH V3 1/3] OMAPDSS: Move definition of DEBUG flag to Makefile
Date: Fri, 28 Sep 2012 15:53:18 +0530 [thread overview]
Message-ID: <fbaf2825628b01a7b660993a83a8f3de37cfcd04.1348826106.git.cmahapatra@ti.com> (raw)
In-Reply-To: <cover.1348826106.git.cmahapatra@ti.com>
In OMAPDSS the DEBUG flag is set only after the OMAPDSS module is called, for
which the debugging capabilities are available only after its proper
initialization. As a result of which tracking of bugs prior to or during initial
process becomes difficult. So, the definition of DEBUG is being moved to the
corresponding Makefile.
Signed-off-by: Chandrabhanu Mahapatra <cmahapatra@ti.com>
---
drivers/video/omap2/dss/Makefile | 1 +
drivers/video/omap2/dss/dss.h | 4 ----
2 files changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/video/omap2/dss/Makefile b/drivers/video/omap2/dss/Makefile
index 4549869..86493e3 100644
--- a/drivers/video/omap2/dss/Makefile
+++ b/drivers/video/omap2/dss/Makefile
@@ -8,3 +8,4 @@ omapdss-$(CONFIG_OMAP2_DSS_SDI) += sdi.o
omapdss-$(CONFIG_OMAP2_DSS_DSI) += dsi.o
omapdss-$(CONFIG_OMAP4_DSS_HDMI) += hdmi.o \
hdmi_panel.o ti_hdmi_4xxx_ip.o
+ccflags-$(CONFIG_OMAP2_DSS_DEBUG_SUPPORT) += -DDEBUG
diff --git a/drivers/video/omap2/dss/dss.h b/drivers/video/omap2/dss/dss.h
index 6728892..ffbba7e 100644
--- a/drivers/video/omap2/dss/dss.h
+++ b/drivers/video/omap2/dss/dss.h
@@ -23,10 +23,6 @@
#ifndef __OMAP2_DSS_H
#define __OMAP2_DSS_H
-#ifdef CONFIG_OMAP2_DSS_DEBUG_SUPPORT
-#define DEBUG
-#endif
-
#ifdef DEBUG
extern bool dss_debug;
#ifdef DSS_SUBSYS_NAME
--
1.7.10
next prev parent reply other threads:[~2012-09-28 10:35 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-25 6:03 [PATCH] OMAPDSS: Cleanup DSSDBG with dynamic pr_debug function Chandrabhanu Mahapatra
2012-09-25 6:15 ` Chandrabhanu Mahapatra
2012-09-25 6:24 ` Tomi Valkeinen
2012-09-25 6:24 ` Tomi Valkeinen
2012-09-25 9:30 ` Mahapatra, Chandrabhanu
2012-09-25 9:42 ` Mahapatra, Chandrabhanu
2012-09-25 9:57 ` Tomi Valkeinen
2012-09-25 9:57 ` Tomi Valkeinen
2012-09-26 5:15 ` [PATCH V2 0/2] OMAPDSS: Enable dynamic debug printing Chandrabhanu Mahapatra
2012-09-26 5:27 ` Chandrabhanu Mahapatra
2012-09-26 5:15 ` [PATCH V2 1/2] OMAPDSS: Cleanup DSSDBG with dynamic pr_debug function Chandrabhanu Mahapatra
2012-09-26 5:27 ` Chandrabhanu Mahapatra
2012-09-26 5:16 ` [PATCH V2 2/2] OMAPDSS: Remove dss_debug variable Chandrabhanu Mahapatra
2012-09-26 5:28 ` Chandrabhanu Mahapatra
2012-09-26 14:29 ` [PATCH V2 0/2] OMAPDSS: Enable dynamic debug printing Tomi Valkeinen
2012-09-26 14:29 ` Tomi Valkeinen
2012-09-27 10:50 ` Mahapatra, Chandrabhanu
2012-09-27 10:50 ` Mahapatra, Chandrabhanu
2012-09-27 11:01 ` Tomi Valkeinen
2012-09-27 11:01 ` Tomi Valkeinen
2012-09-28 10:23 ` [PATCH V3 0/3] " Chandrabhanu Mahapatra
2012-09-28 10:35 ` Chandrabhanu Mahapatra
2012-09-28 10:23 ` Chandrabhanu Mahapatra [this message]
2012-09-28 10:35 ` [PATCH V3 1/3] OMAPDSS: Move definition of DEBUG flag to Makefile Chandrabhanu Mahapatra
2012-09-28 10:23 ` [PATCH V3 2/3] OMAPDSS: Cleanup DSSDBG with dynamic pr_debug function Chandrabhanu Mahapatra
2012-09-28 10:35 ` Chandrabhanu Mahapatra
2012-09-28 11:22 ` Tomi Valkeinen
2012-09-28 11:22 ` Tomi Valkeinen
2012-09-28 11:30 ` Mahapatra, Chandrabhanu
2012-09-28 11:42 ` Mahapatra, Chandrabhanu
2012-09-28 11:37 ` Tomi Valkeinen
2012-09-28 11:37 ` Tomi Valkeinen
2012-09-28 10:23 ` [PATCH V3 3/3] OMAPDSS: Remove dss_debug variable Chandrabhanu Mahapatra
2012-09-28 10:35 ` Chandrabhanu Mahapatra
2012-09-28 11:34 ` [PATCH V3 0/3] OMAPDSS: Enable dynamic debug printing Tomi Valkeinen
2012-09-28 11:34 ` Tomi Valkeinen
2012-09-28 12:11 ` Mahapatra, Chandrabhanu
2012-09-28 12:23 ` Mahapatra, Chandrabhanu
2012-09-29 10:49 ` [PATCH V4 0/5] " Chandrabhanu Mahapatra
2012-09-29 10:51 ` Chandrabhanu Mahapatra
2012-09-29 10:49 ` [PATCH V4 1/5] OMAPDSS: Move definition of DEBUG flag to Makefile Chandrabhanu Mahapatra
2012-09-29 10:51 ` Chandrabhanu Mahapatra
2012-09-29 10:49 ` [PATCH V4 2/5] OMAPDSS: Create new debug config options Chandrabhanu Mahapatra
2012-09-29 10:52 ` Chandrabhanu Mahapatra
2012-09-29 15:15 ` Sumit Semwal
2012-09-29 15:27 ` Sumit Semwal
2012-10-01 7:48 ` [PATCH V5 " Chandrabhanu Mahapatra
2012-10-01 7:51 ` Chandrabhanu Mahapatra
2012-09-29 10:49 ` [PATCH V4 3/5] OMAPDSS: Cleanup DSSDBG with dynamic pr_debug function Chandrabhanu Mahapatra
2012-09-29 10:52 ` Chandrabhanu Mahapatra
2012-09-29 10:49 ` [PATCH V4 4/5] OMAPDSS: Replace multi part debug prints with pr_debug Chandrabhanu Mahapatra
2012-09-29 10:52 ` Chandrabhanu Mahapatra
2012-10-05 12:33 ` Tomi Valkeinen
2012-10-05 12:33 ` Tomi Valkeinen
2012-10-10 9:22 ` [PATCH V5 " Chandrabhanu Mahapatra
2012-10-10 9:34 ` Chandrabhanu Mahapatra
2012-09-29 10:49 ` [PATCH V4 5/5] OMAPDSS: Remove dss_debug variable Chandrabhanu Mahapatra
2012-09-29 10:52 ` Chandrabhanu Mahapatra
2012-10-05 12:46 ` [PATCH V4 0/5] OMAPDSS: Enable dynamic debug printing Tomi Valkeinen
2012-10-05 12:46 ` Tomi Valkeinen
2012-10-10 10:26 ` Sumit Semwal
2012-10-10 10:38 ` Sumit Semwal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fbaf2825628b01a7b660993a83a8f3de37cfcd04.1348826106.git.cmahapatra@ti.com \
--to=cmahapatra@ti.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.