From: Zubair Lutfullah <zubair.lutfullah@gmail.com> To: jic23@cam.ac.uk, dmitry.torokhov@gmail.com Cc: linux-iio@vger.kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, bigeasy@linutronix.de, gregkh@linuxfoundation.org, Russ.Dill@ti.com Subject: [PATCH 1/4] input: ti_am335x_tsc: correct step mask update after IRQ Date: Tue, 13 Aug 2013 21:05:00 +0100 [thread overview] Message-ID: <1376424303-22740-2-git-send-email-zubair.lutfullah@gmail.com> (raw) In-Reply-To: <1376424303-22740-1-git-send-email-zubair.lutfullah@gmail.com> TSC steps should be enabled again after IRQ routine. This fix ensures they are updated correctly every time. Signed-off-by: Zubair Lutfullah <zubair.lutfullah@gmail.com> --- drivers/input/touchscreen/ti_am335x_tsc.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/input/touchscreen/ti_am335x_tsc.c b/drivers/input/touchscreen/ti_am335x_tsc.c index e1c5300..e165fcb 100644 --- a/drivers/input/touchscreen/ti_am335x_tsc.c +++ b/drivers/input/touchscreen/ti_am335x_tsc.c @@ -52,6 +52,7 @@ struct titsc { u32 config_inp[4]; u32 bit_xp, bit_xn, bit_yp, bit_yn; u32 inp_xp, inp_xn, inp_yp, inp_yn; + u32 step_mask; }; static unsigned int titsc_readl(struct titsc *ts, unsigned int reg) @@ -196,7 +197,8 @@ static void titsc_step_config(struct titsc *ts_dev) /* The steps1 … end and bit 0 for TS_Charge */ stepenable = (1 << (end_step + 2)) - 1; - am335x_tsc_se_set(ts_dev->mfd_tscadc, stepenable); + ts_dev->step_mask = stepenable; + am335x_tsc_se_set(ts_dev->mfd_tscadc, ts_dev->step_mask); } static void titsc_read_coordinates(struct titsc *ts_dev, @@ -316,7 +318,7 @@ static irqreturn_t titsc_irq(int irq, void *dev) if (irqclr) { titsc_writel(ts_dev, REG_IRQSTATUS, irqclr); - am335x_tsc_se_update(ts_dev->mfd_tscadc); + am335x_tsc_se_set(ts_dev->mfd_tscadc, ts_dev->step_mask); return IRQ_HANDLED; } return IRQ_NONE; -- 1.7.9.5
WARNING: multiple messages have this Message-ID (diff)
From: Zubair Lutfullah <zubair.lutfullah@gmail.com> To: jic23@cam.ac.uk, dmitry.torokhov@gmail.com Cc: linux-iio@vger.kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, bigeasy@linutronix.de, gregkh@linuxfoundation.org, Russ.Dill@ti.com Subject: [PATCH 1/4] input: ti_am335x_tsc: correct step mask update after IRQ Date: Tue, 13 Aug 2013 21:05:00 +0100 [thread overview] Message-ID: <1376424303-22740-2-git-send-email-zubair.lutfullah@gmail.com> (raw) In-Reply-To: <1376424303-22740-1-git-send-email-zubair.lutfullah@gmail.com> TSC steps should be enabled again after IRQ routine. This fix ensures they are updated correctly every time. Signed-off-by: Zubair Lutfullah <zubair.lutfullah@gmail.com> --- drivers/input/touchscreen/ti_am335x_tsc.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/input/touchscreen/ti_am335x_tsc.c b/drivers/input/touchscreen/ti_am335x_tsc.c index e1c5300..e165fcb 100644 --- a/drivers/input/touchscreen/ti_am335x_tsc.c +++ b/drivers/input/touchscreen/ti_am335x_tsc.c @@ -52,6 +52,7 @@ struct titsc { u32 config_inp[4]; u32 bit_xp, bit_xn, bit_yp, bit_yn; u32 inp_xp, inp_xn, inp_yp, inp_yn; + u32 step_mask; }; static unsigned int titsc_readl(struct titsc *ts, unsigned int reg) @@ -196,7 +197,8 @@ static void titsc_step_config(struct titsc *ts_dev) /* The steps1 … end and bit 0 for TS_Charge */ stepenable = (1 << (end_step + 2)) - 1; - am335x_tsc_se_set(ts_dev->mfd_tscadc, stepenable); + ts_dev->step_mask = stepenable; + am335x_tsc_se_set(ts_dev->mfd_tscadc, ts_dev->step_mask); } static void titsc_read_coordinates(struct titsc *ts_dev, @@ -316,7 +318,7 @@ static irqreturn_t titsc_irq(int irq, void *dev) if (irqclr) { titsc_writel(ts_dev, REG_IRQSTATUS, irqclr); - am335x_tsc_se_update(ts_dev->mfd_tscadc); + am335x_tsc_se_set(ts_dev->mfd_tscadc, ts_dev->step_mask); return IRQ_HANDLED; } return IRQ_NONE; -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-08-13 20:06 UTC|newest] Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-08-13 20:04 [PATCH 0/4] iio: input: ti_am335x_adc: Add continuous sampling support round 5 Zubair Lutfullah 2013-08-13 20:05 ` Zubair Lutfullah [this message] 2013-08-13 20:05 ` [PATCH 1/4] input: ti_am335x_tsc: correct step mask update after IRQ Zubair Lutfullah 2013-08-13 20:05 ` [PATCH 2/4] input: ti_am335x_tsc: Increase sequencer delay time Zubair Lutfullah 2013-08-13 20:05 ` [PATCH 3/4] input: ti_am335x_tsc: Enable shared IRQ for TSC, add overrun and underflow checks Zubair Lutfullah 2013-08-13 20:05 ` Zubair Lutfullah 2013-08-13 20:05 ` [PATCH 4/4] iio: ti_am335x_adc: Add continuous sampling and trigger support Zubair Lutfullah 2013-08-15 11:43 ` Jonathan Cameron 2013-08-15 11:43 ` Jonathan Cameron 2013-08-16 10:07 ` Sebastian Andrzej Siewior 2013-08-16 10:07 ` Sebastian Andrzej Siewior 2013-08-16 10:17 ` Sebastian Andrzej Siewior 2013-08-16 10:17 ` Sebastian Andrzej Siewior 2013-08-16 11:33 ` Jonathan Cameron 2013-08-16 11:33 ` Jonathan Cameron 2013-08-16 10:46 ` Sebastian Andrzej Siewior 2013-08-16 21:21 ` Zubair Lutfullah : 2013-08-17 8:58 ` Zubair Lutfullah : 2013-08-17 8:58 ` Zubair Lutfullah : [not found] ` <520F9395.3050900@kernel.org> 2013-08-17 18:51 ` Zubair Lutfullah : 2013-08-16 12:53 ` Sebastian Andrzej Siewior 2013-08-16 12:53 ` Sebastian Andrzej Siewior 2013-08-16 21:18 ` Zubair Lutfullah : 2013-08-16 13:25 ` Sebastian Andrzej Siewior 2013-08-16 13:25 ` Sebastian Andrzej Siewior 2013-08-16 21:13 ` Zubair Lutfullah : 2013-08-16 14:59 ` Sebastian Andrzej Siewior 2013-08-16 14:59 ` Sebastian Andrzej Siewior 2013-08-16 21:10 ` Zubair Lutfullah : 2013-08-19 17:12 ` Sebastian Andrzej Siewior 2013-08-19 17:12 ` Sebastian Andrzej Siewior 2013-08-20 16:26 ` Zubair Lutfullah : 2013-08-20 16:26 ` Zubair Lutfullah : 2013-08-14 18:57 ` [PATCH 0/4] iio: input: ti_am335x_adc: Add continuous sampling support round 5 Jonathan Cameron 2013-08-14 18:05 ` Sebastian Andrzej Siewior 2013-08-16 21:23 ` Zubair Lutfullah : -- strict thread matches above, loose matches on Subject: below -- 2013-08-13 16:48 [PATCH 0/4] iio: input: ti_am335x_adc: Add continuous sampling support round 4 Zubair Lutfullah 2013-08-13 16:48 ` [PATCH 1/4] input: ti_am335x_tsc: correct step mask update after IRQ Zubair Lutfullah 2013-08-16 8:53 ` Sebastian Andrzej Siewior 2013-08-16 21:42 ` Zubair Lutfullah :
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1376424303-22740-2-git-send-email-zubair.lutfullah@gmail.com \ --to=zubair.lutfullah@gmail.com \ --cc=Russ.Dill@ti.com \ --cc=bigeasy@linutronix.de \ --cc=dmitry.torokhov@gmail.com \ --cc=gregkh@linuxfoundation.org \ --cc=jic23@cam.ac.uk \ --cc=linux-iio@vger.kernel.org \ --cc=linux-input@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.