From: Sebastian Andrzej Siewior <bigeasy@linutronix.de> To: Zubair Lutfullah <zubair.lutfullah@gmail.com> Cc: jic23@cam.ac.uk, dmitry.torokhov@gmail.com, linux-iio@vger.kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org, Russ.Dill@ti.com Subject: Re: [PATCH 4/4] iio: ti_am335x_adc: Add continuous sampling and trigger support Date: Fri, 16 Aug 2013 16:59:49 +0200 [thread overview] Message-ID: <20130816145949.GE1263@linutronix.de> (raw) In-Reply-To: <1376424303-22740-5-git-send-email-zubair.lutfullah@gmail.com> * Zubair Lutfullah | 2013-08-13 21:05:03 [+0100]: >diff --git a/drivers/iio/adc/ti_am335x_adc.c b/drivers/iio/adc/ti_am335x_adc.c >index 3ceac3e..0d7e313 100644 >--- a/drivers/iio/adc/ti_am335x_adc.c >+++ b/drivers/iio/adc/ti_am335x_adc.c … >+static int tiadc_buffer_postdisable(struct iio_dev *indio_dev) >+{ >+ struct tiadc_device *adc_dev = iio_priv(indio_dev); >+ int config; >+ >+ tiadc_step_config(indio_dev); >+ if (adc_dev->mfd_tscadc->tsc_cell == -1) { >+ config = tiadc_readl(adc_dev, REG_CTRL); >+ tiadc_writel(adc_dev, REG_CTRL, (config | CNTRLREG_TSCSSENB)); >+ } This kind of check is bad. The tsc cell may have been created but the driver not enabled or loaded. Further you should document why you need to enable / disable the ADC in this places and only if the TSC part is not active. Sebastian
WARNING: multiple messages have this Message-ID (diff)
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de> To: Zubair Lutfullah <zubair.lutfullah@gmail.com> Cc: jic23@cam.ac.uk, dmitry.torokhov@gmail.com, linux-iio@vger.kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org, Russ.Dill@ti.com Subject: Re: [PATCH 4/4] iio: ti_am335x_adc: Add continuous sampling and trigger support Date: Fri, 16 Aug 2013 16:59:49 +0200 [thread overview] Message-ID: <20130816145949.GE1263@linutronix.de> (raw) In-Reply-To: <1376424303-22740-5-git-send-email-zubair.lutfullah@gmail.com> * Zubair Lutfullah | 2013-08-13 21:05:03 [+0100]: >diff --git a/drivers/iio/adc/ti_am335x_adc.c b/drivers/iio/adc/ti_am335x_adc.c >index 3ceac3e..0d7e313 100644 >--- a/drivers/iio/adc/ti_am335x_adc.c >+++ b/drivers/iio/adc/ti_am335x_adc.c … >+static int tiadc_buffer_postdisable(struct iio_dev *indio_dev) >+{ >+ struct tiadc_device *adc_dev = iio_priv(indio_dev); >+ int config; >+ >+ tiadc_step_config(indio_dev); >+ if (adc_dev->mfd_tscadc->tsc_cell == -1) { >+ config = tiadc_readl(adc_dev, REG_CTRL); >+ tiadc_writel(adc_dev, REG_CTRL, (config | CNTRLREG_TSCSSENB)); >+ } This kind of check is bad. The tsc cell may have been created but the driver not enabled or loaded. Further you should document why you need to enable / disable the ADC in this places and only if the TSC part is not active. Sebastian -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-08-16 14:59 UTC|newest] Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-08-13 20:04 [PATCH 0/4] iio: input: ti_am335x_adc: Add continuous sampling support round 5 Zubair Lutfullah 2013-08-13 20:05 ` [PATCH 1/4] input: ti_am335x_tsc: correct step mask update after IRQ Zubair Lutfullah 2013-08-13 20:05 ` Zubair Lutfullah 2013-08-13 20:05 ` [PATCH 2/4] input: ti_am335x_tsc: Increase sequencer delay time Zubair Lutfullah 2013-08-13 20:05 ` [PATCH 3/4] input: ti_am335x_tsc: Enable shared IRQ for TSC, add overrun and underflow checks Zubair Lutfullah 2013-08-13 20:05 ` Zubair Lutfullah 2013-08-13 20:05 ` [PATCH 4/4] iio: ti_am335x_adc: Add continuous sampling and trigger support Zubair Lutfullah 2013-08-15 11:43 ` Jonathan Cameron 2013-08-15 11:43 ` Jonathan Cameron 2013-08-16 10:07 ` Sebastian Andrzej Siewior 2013-08-16 10:07 ` Sebastian Andrzej Siewior 2013-08-16 10:17 ` Sebastian Andrzej Siewior 2013-08-16 10:17 ` Sebastian Andrzej Siewior 2013-08-16 11:33 ` Jonathan Cameron 2013-08-16 11:33 ` Jonathan Cameron 2013-08-16 10:46 ` Sebastian Andrzej Siewior 2013-08-16 21:21 ` Zubair Lutfullah : 2013-08-17 8:58 ` Zubair Lutfullah : 2013-08-17 8:58 ` Zubair Lutfullah : [not found] ` <520F9395.3050900@kernel.org> 2013-08-17 18:51 ` Zubair Lutfullah : 2013-08-16 12:53 ` Sebastian Andrzej Siewior 2013-08-16 12:53 ` Sebastian Andrzej Siewior 2013-08-16 21:18 ` Zubair Lutfullah : 2013-08-16 13:25 ` Sebastian Andrzej Siewior 2013-08-16 13:25 ` Sebastian Andrzej Siewior 2013-08-16 21:13 ` Zubair Lutfullah : 2013-08-16 14:59 ` Sebastian Andrzej Siewior [this message] 2013-08-16 14:59 ` Sebastian Andrzej Siewior 2013-08-16 21:10 ` Zubair Lutfullah : 2013-08-19 17:12 ` Sebastian Andrzej Siewior 2013-08-19 17:12 ` Sebastian Andrzej Siewior 2013-08-20 16:26 ` Zubair Lutfullah : 2013-08-20 16:26 ` Zubair Lutfullah : 2013-08-14 18:57 ` [PATCH 0/4] iio: input: ti_am335x_adc: Add continuous sampling support round 5 Jonathan Cameron 2013-08-14 18:05 ` Sebastian Andrzej Siewior 2013-08-16 21:23 ` Zubair Lutfullah : -- strict thread matches above, loose matches on Subject: below -- 2013-08-13 16:48 [PATCH 0/4] iio: input: ti_am335x_adc: Add continuous sampling support round 4 Zubair Lutfullah 2013-08-13 16:48 ` [PATCH 4/4] iio: ti_am335x_adc: Add continuous sampling and trigger support Zubair Lutfullah 2013-08-13 17:05 ` Lee Jones 2013-08-13 17:05 ` Lee Jones
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20130816145949.GE1263@linutronix.de \ --to=bigeasy@linutronix.de \ --cc=Russ.Dill@ti.com \ --cc=dmitry.torokhov@gmail.com \ --cc=gregkh@linuxfoundation.org \ --cc=jic23@cam.ac.uk \ --cc=linux-iio@vger.kernel.org \ --cc=linux-input@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=zubair.lutfullah@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.