From: Jonathan Cameron <jic23@kernel.org>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Zubair Lutfullah <zubair.lutfullah@gmail.com>,
jic23@cam.ac.uk, dmitry.torokhov@gmail.com,
linux-iio@vger.kernel.org, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
Russ.Dill@ti.com
Subject: Re: [PATCH 4/4] iio: ti_am335x_adc: Add continuous sampling and trigger support
Date: Fri, 16 Aug 2013 12:33:54 +0100 [thread overview]
Message-ID: <520E0E22.4000403@kernel.org> (raw)
In-Reply-To: <20130816100702.GD26895@linutronix.de>
On 08/16/13 11:07, Sebastian Andrzej Siewior wrote:
> * Jonathan Cameron | 2013-08-15 12:43:02 [+0100]:
>
>> Hi,
> Hi Jonathan,
>
>> Whilst the below review is based on what we have here, I tried to apply it
>> to the latest iio.git togreg branch (which for this driver should be
>> much the same as staging-next and hence linux-next). It's not even
>> close and I can't immediately spot where some of the changes came
>> from. Have I missed a precursor patch or is this based on an
>> older version of this driver?
>
> I took the four patches, checkout iio/fixes-togreg and then
>
> |git am -3 iio.mbox
> |Applying: input: ti_am335x_tsc: correct step mask update after IRQ
> |Applying: input: ti_am335x_tsc: Increase sequencer delay time
> |Applying: input: ti_am335x_tsc: Enable shared IRQ for TSC, add overrun and underflow checks
> |Applying: iio: ti_am335x_adc: Add continuous sampling and trigger support
>
> It did apply with no trouble here.
> Let me look at your comments…
Ah, fixes-togreg is for this cycle, whereas new stuff like this needs
to go on the togreg branch. Hence please rebase on the togreg branch
instead.
That would explain it.
WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Sebastian Andrzej Siewior
<bigeasy-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
Cc: Zubair Lutfullah
<zubair.lutfullah-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
jic23-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org,
dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org,
Russ.Dill-l0cyMroinI0@public.gmane.org
Subject: Re: [PATCH 4/4] iio: ti_am335x_adc: Add continuous sampling and trigger support
Date: Fri, 16 Aug 2013 12:33:54 +0100 [thread overview]
Message-ID: <520E0E22.4000403@kernel.org> (raw)
In-Reply-To: <20130816100702.GD26895-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
On 08/16/13 11:07, Sebastian Andrzej Siewior wrote:
> * Jonathan Cameron | 2013-08-15 12:43:02 [+0100]:
>
>> Hi,
> Hi Jonathan,
>
>> Whilst the below review is based on what we have here, I tried to apply it
>> to the latest iio.git togreg branch (which for this driver should be
>> much the same as staging-next and hence linux-next). It's not even
>> close and I can't immediately spot where some of the changes came
>> from. Have I missed a precursor patch or is this based on an
>> older version of this driver?
>
> I took the four patches, checkout iio/fixes-togreg and then
>
> |git am -3 iio.mbox
> |Applying: input: ti_am335x_tsc: correct step mask update after IRQ
> |Applying: input: ti_am335x_tsc: Increase sequencer delay time
> |Applying: input: ti_am335x_tsc: Enable shared IRQ for TSC, add overrun and underflow checks
> |Applying: iio: ti_am335x_adc: Add continuous sampling and trigger support
>
> It did apply with no trouble here.
> Let me look at your comments…
Ah, fixes-togreg is for this cycle, whereas new stuff like this needs
to go on the togreg branch. Hence please rebase on the togreg branch
instead.
That would explain it.
next prev parent reply other threads:[~2013-08-16 10:34 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-13 20:04 [PATCH 0/4] iio: input: ti_am335x_adc: Add continuous sampling support round 5 Zubair Lutfullah
2013-08-13 20:05 ` [PATCH 1/4] input: ti_am335x_tsc: correct step mask update after IRQ Zubair Lutfullah
2013-08-13 20:05 ` Zubair Lutfullah
2013-08-13 20:05 ` [PATCH 2/4] input: ti_am335x_tsc: Increase sequencer delay time Zubair Lutfullah
2013-08-13 20:05 ` [PATCH 3/4] input: ti_am335x_tsc: Enable shared IRQ for TSC, add overrun and underflow checks Zubair Lutfullah
2013-08-13 20:05 ` Zubair Lutfullah
2013-08-13 20:05 ` [PATCH 4/4] iio: ti_am335x_adc: Add continuous sampling and trigger support Zubair Lutfullah
2013-08-15 11:43 ` Jonathan Cameron
2013-08-15 11:43 ` Jonathan Cameron
2013-08-16 10:07 ` Sebastian Andrzej Siewior
2013-08-16 10:07 ` Sebastian Andrzej Siewior
2013-08-16 10:17 ` Sebastian Andrzej Siewior
2013-08-16 10:17 ` Sebastian Andrzej Siewior
2013-08-16 11:33 ` Jonathan Cameron [this message]
2013-08-16 11:33 ` Jonathan Cameron
2013-08-16 10:46 ` Sebastian Andrzej Siewior
2013-08-16 21:21 ` Zubair Lutfullah :
2013-08-17 8:58 ` Zubair Lutfullah :
2013-08-17 8:58 ` Zubair Lutfullah :
[not found] ` <520F9395.3050900@kernel.org>
2013-08-17 18:51 ` Zubair Lutfullah :
2013-08-16 12:53 ` Sebastian Andrzej Siewior
2013-08-16 12:53 ` Sebastian Andrzej Siewior
2013-08-16 21:18 ` Zubair Lutfullah :
2013-08-16 13:25 ` Sebastian Andrzej Siewior
2013-08-16 13:25 ` Sebastian Andrzej Siewior
2013-08-16 21:13 ` Zubair Lutfullah :
2013-08-16 14:59 ` Sebastian Andrzej Siewior
2013-08-16 14:59 ` Sebastian Andrzej Siewior
2013-08-16 21:10 ` Zubair Lutfullah :
2013-08-19 17:12 ` Sebastian Andrzej Siewior
2013-08-19 17:12 ` Sebastian Andrzej Siewior
2013-08-20 16:26 ` Zubair Lutfullah :
2013-08-20 16:26 ` Zubair Lutfullah :
2013-08-14 18:57 ` [PATCH 0/4] iio: input: ti_am335x_adc: Add continuous sampling support round 5 Jonathan Cameron
2013-08-14 18:05 ` Sebastian Andrzej Siewior
2013-08-16 21:23 ` Zubair Lutfullah :
-- strict thread matches above, loose matches on Subject: below --
2013-08-13 16:48 [PATCH 0/4] iio: input: ti_am335x_adc: Add continuous sampling support round 4 Zubair Lutfullah
2013-08-13 16:48 ` [PATCH 4/4] iio: ti_am335x_adc: Add continuous sampling and trigger support Zubair Lutfullah
2013-08-13 17:05 ` Lee Jones
2013-08-13 17:05 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=520E0E22.4000403@kernel.org \
--to=jic23@kernel.org \
--cc=Russ.Dill@ti.com \
--cc=bigeasy@linutronix.de \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@cam.ac.uk \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zubair.lutfullah@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.