All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vignesh R <vigneshr@ti.com>
To: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>,
	Benoit Cousson <bcousson@baylibre.com>,
	Tony Lindgren <tony@atomide.com>,
	Russell King <linux@arm.linux.org.uk>,
	Jonathan Cameron <jic23@kernel.org>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Hartmut Knaack <knaack.h@gmx.de>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Peter Meerwald <pmeerw@pmeerw.net>,
	Samuel Ortiz <sameo@linux.intel.com>,
	Lee Jones <lee.jones@linaro.org>, Felipe Balbi <balbi@ti.com>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	Jan Kardell <jan.kardell@telliq.com>,
	Paul Gortmaker <paul.gortmaker@windriver.com>,
	Brad Griffis <bgriffis@ti.com>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <linux-omap@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-iio@vger.kernel.org>, <linux-input@vger.kernel.org>,
	Vignesh R <vigneshr@ti.com>
Subject: [PATCH 4/4] input: touchscreen: ti_am335x_tsc: Use charge delay DT parameter
Date: Mon, 27 Oct 2014 16:38:31 +0530	[thread overview]
Message-ID: <1414408111-2631-5-git-send-email-vigneshr@ti.com> (raw)
In-Reply-To: <1414408111-2631-1-git-send-email-vigneshr@ti.com>

This patch reads charge delay from tsc DT node and writes to
REG_CHARGEDELAY register. If the charge delay is not specified in DT
then default value of 0xB000(CHARGEDLY_OPENDLY) is used.

Signed-off-by: Vignesh R <vigneshr@ti.com>
---
 drivers/input/touchscreen/ti_am335x_tsc.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/drivers/input/touchscreen/ti_am335x_tsc.c b/drivers/input/touchscreen/ti_am335x_tsc.c
index 483fd97c0e0c..20ce76b1b6e7 100644
--- a/drivers/input/touchscreen/ti_am335x_tsc.c
+++ b/drivers/input/touchscreen/ti_am335x_tsc.c
@@ -52,6 +52,7 @@ struct titsc {
 	u32			bit_xp, bit_xn, bit_yp, bit_yn;
 	u32			inp_xp, inp_xn, inp_yp, inp_yn;
 	u32			step_mask;
+	u32			charge_delay;
 };
 
 static unsigned int titsc_readl(struct titsc *ts, unsigned int reg)
@@ -177,7 +178,7 @@ static void titsc_step_config(struct titsc *ts_dev)
 
 	config = titsc_readl(ts_dev, REG_IDLECONFIG);
 	titsc_writel(ts_dev, REG_CHARGECONFIG, config);
-	titsc_writel(ts_dev, REG_CHARGEDELAY, CHARGEDLY_OPENDLY);
+	titsc_writel(ts_dev, REG_CHARGEDELAY, ts_dev->charge_delay);
 
 	/* coordinate_readouts + 1 ... coordinate_readouts + 2 is for Z */
 	config = STEPCONFIG_MODE_HWSYNC |
@@ -361,6 +362,11 @@ static int titsc_parse_dt(struct platform_device *pdev,
 	if (err < 0)
 		return err;
 
+	err = of_property_read_u32(node, "ti,charge-delay",
+				   &ts_dev->charge_delay);
+	if (err < 0)
+		ts_dev->charge_delay = CHARGEDLY_OPENDLY;
+
 	return of_property_read_u32_array(node, "ti,wire-config",
 			ts_dev->config_inp, ARRAY_SIZE(ts_dev->config_inp));
 }
-- 
1.9.1


WARNING: multiple messages have this Message-ID (diff)
From: Vignesh R <vigneshr@ti.com>
To: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>,
	Benoit Cousson <bcousson@baylibre.com>,
	Tony Lindgren <tony@atomide.com>,
	Russell King <linux@arm.linux.org.uk>,
	Jonathan Cameron <jic23@kernel.org>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Hartmut Knaack <knaack.h@gmx.de>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Peter Meerwald <pmeerw@pmeerw.net>,
	Samuel Ortiz <sameo@linux.intel.com>,
	Lee Jones <lee.jones@linaro.org>, Felipe Balbi <balbi@ti.com>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	Jan Kardell <jan.kardell@telliq.com>,
	Paul Gortmaker <paul.gortmaker@windriver.com>,
	Brad Griffis <bgriffis@ti.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-iio@vger.kernel.org, linux-input@vger.kernel.org,
	Vignesh R <vigneshr@ti.com>
Subject: [PATCH 4/4] input: touchscreen: ti_am335x_tsc: Use charge delay DT parameter
Date: Mon, 27 Oct 2014 16:38:31 +0530	[thread overview]
Message-ID: <1414408111-2631-5-git-send-email-vigneshr@ti.com> (raw)
In-Reply-To: <1414408111-2631-1-git-send-email-vigneshr@ti.com>

This patch reads charge delay from tsc DT node and writes to
REG_CHARGEDELAY register. If the charge delay is not specified in DT
then default value of 0xB000(CHARGEDLY_OPENDLY) is used.

Signed-off-by: Vignesh R <vigneshr@ti.com>
---
 drivers/input/touchscreen/ti_am335x_tsc.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/drivers/input/touchscreen/ti_am335x_tsc.c b/drivers/input/touchscreen/ti_am335x_tsc.c
index 483fd97c0e0c..20ce76b1b6e7 100644
--- a/drivers/input/touchscreen/ti_am335x_tsc.c
+++ b/drivers/input/touchscreen/ti_am335x_tsc.c
@@ -52,6 +52,7 @@ struct titsc {
 	u32			bit_xp, bit_xn, bit_yp, bit_yn;
 	u32			inp_xp, inp_xn, inp_yp, inp_yn;
 	u32			step_mask;
+	u32			charge_delay;
 };
 
 static unsigned int titsc_readl(struct titsc *ts, unsigned int reg)
@@ -177,7 +178,7 @@ static void titsc_step_config(struct titsc *ts_dev)
 
 	config = titsc_readl(ts_dev, REG_IDLECONFIG);
 	titsc_writel(ts_dev, REG_CHARGECONFIG, config);
-	titsc_writel(ts_dev, REG_CHARGEDELAY, CHARGEDLY_OPENDLY);
+	titsc_writel(ts_dev, REG_CHARGEDELAY, ts_dev->charge_delay);
 
 	/* coordinate_readouts + 1 ... coordinate_readouts + 2 is for Z */
 	config = STEPCONFIG_MODE_HWSYNC |
@@ -361,6 +362,11 @@ static int titsc_parse_dt(struct platform_device *pdev,
 	if (err < 0)
 		return err;
 
+	err = of_property_read_u32(node, "ti,charge-delay",
+				   &ts_dev->charge_delay);
+	if (err < 0)
+		ts_dev->charge_delay = CHARGEDLY_OPENDLY;
+
 	return of_property_read_u32_array(node, "ti,wire-config",
 			ts_dev->config_inp, ARRAY_SIZE(ts_dev->config_inp));
 }
-- 
1.9.1

WARNING: multiple messages have this Message-ID (diff)
From: vigneshr@ti.com (Vignesh R)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/4] input: touchscreen: ti_am335x_tsc: Use charge delay DT parameter
Date: Mon, 27 Oct 2014 16:38:31 +0530	[thread overview]
Message-ID: <1414408111-2631-5-git-send-email-vigneshr@ti.com> (raw)
In-Reply-To: <1414408111-2631-1-git-send-email-vigneshr@ti.com>

This patch reads charge delay from tsc DT node and writes to
REG_CHARGEDELAY register. If the charge delay is not specified in DT
then default value of 0xB000(CHARGEDLY_OPENDLY) is used.

Signed-off-by: Vignesh R <vigneshr@ti.com>
---
 drivers/input/touchscreen/ti_am335x_tsc.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/drivers/input/touchscreen/ti_am335x_tsc.c b/drivers/input/touchscreen/ti_am335x_tsc.c
index 483fd97c0e0c..20ce76b1b6e7 100644
--- a/drivers/input/touchscreen/ti_am335x_tsc.c
+++ b/drivers/input/touchscreen/ti_am335x_tsc.c
@@ -52,6 +52,7 @@ struct titsc {
 	u32			bit_xp, bit_xn, bit_yp, bit_yn;
 	u32			inp_xp, inp_xn, inp_yp, inp_yn;
 	u32			step_mask;
+	u32			charge_delay;
 };
 
 static unsigned int titsc_readl(struct titsc *ts, unsigned int reg)
@@ -177,7 +178,7 @@ static void titsc_step_config(struct titsc *ts_dev)
 
 	config = titsc_readl(ts_dev, REG_IDLECONFIG);
 	titsc_writel(ts_dev, REG_CHARGECONFIG, config);
-	titsc_writel(ts_dev, REG_CHARGEDELAY, CHARGEDLY_OPENDLY);
+	titsc_writel(ts_dev, REG_CHARGEDELAY, ts_dev->charge_delay);
 
 	/* coordinate_readouts + 1 ... coordinate_readouts + 2 is for Z */
 	config = STEPCONFIG_MODE_HWSYNC |
@@ -361,6 +362,11 @@ static int titsc_parse_dt(struct platform_device *pdev,
 	if (err < 0)
 		return err;
 
+	err = of_property_read_u32(node, "ti,charge-delay",
+				   &ts_dev->charge_delay);
+	if (err < 0)
+		ts_dev->charge_delay = CHARGEDLY_OPENDLY;
+
 	return of_property_read_u32_array(node, "ti,wire-config",
 			ts_dev->config_inp, ARRAY_SIZE(ts_dev->config_inp));
 }
-- 
1.9.1

  parent reply	other threads:[~2014-10-27 11:10 UTC|newest]

Thread overview: 86+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-27 11:08 [PATCH 0/4] Touchscreen performance related fixes Vignesh R
2014-10-27 11:08 ` Vignesh R
2014-10-27 11:08 ` Vignesh R
2014-10-27 11:08 ` [PATCH 1/4] input: touchscreen: ti_am335x_tsc Interchange touchscreen and ADC steps Vignesh R
2014-10-27 11:08   ` Vignesh R
2014-10-27 11:08   ` Vignesh R
2014-10-31 21:03   ` Hartmut Knaack
2014-10-31 21:03     ` Hartmut Knaack
2014-10-31 21:03     ` Hartmut Knaack
2014-11-07  5:48     ` Vignesh R
2014-11-07  5:48       ` Vignesh R
2014-11-07  5:48       ` Vignesh R
2014-11-06 14:19   ` Richard Cochran
2014-11-06 14:19     ` Richard Cochran
2014-11-06 14:19     ` Richard Cochran
2014-11-07  5:34     ` Vignesh R
2014-11-07  5:34       ` Vignesh R
2014-11-07  5:34       ` Vignesh R
2014-11-07  8:00       ` Richard Cochran
2014-11-07  8:00         ` Richard Cochran
2014-11-07  8:00         ` Richard Cochran
2014-11-10 10:46         ` Vignesh R
2014-11-10 10:46           ` Vignesh R
2014-11-10 10:46           ` Vignesh R
2014-11-07 10:17       ` Richard Cochran
2014-11-07 10:17         ` Richard Cochran
2014-11-07 10:17         ` Richard Cochran
2014-10-27 11:08 ` [PATCH 2/4] input: touchscreen: ti_am335x_tsc: Remove udelay in interrupt handler Vignesh R
2014-10-27 11:08   ` Vignesh R
2014-10-27 11:08   ` Vignesh R
2014-11-03 15:05   ` Lee Jones
2014-11-03 15:05     ` Lee Jones
2014-11-03 15:05     ` Lee Jones
2014-11-07  5:48     ` Vignesh R
2014-11-07  5:48       ` Vignesh R
2014-11-07  5:48       ` Vignesh R
2014-10-27 11:08 ` [PATCH 3/4] arm: boot: dts: am335x-evm: Make charge delay a DT parameter for tsc Vignesh R
2014-10-27 11:08   ` Vignesh R
2014-10-27 11:08   ` Vignesh R
2014-10-31 21:09   ` Hartmut Knaack
2014-10-31 21:09     ` Hartmut Knaack
2014-11-07  5:48     ` Vignesh R
2014-11-07  5:48       ` Vignesh R
2014-11-07  5:48       ` Vignesh R
2014-10-27 11:08 ` Vignesh R [this message]
2014-10-27 11:08   ` [PATCH 4/4] input: touchscreen: ti_am335x_tsc: Use charge delay DT parameter Vignesh R
2014-10-27 11:08   ` Vignesh R
2014-10-27 17:34 ` [PATCH 0/4] Touchscreen performance related fixes Sebastian Andrzej Siewior
2014-10-27 17:34   ` Sebastian Andrzej Siewior
2014-10-27 19:02   ` Griffis, Brad
2014-10-27 19:02     ` Griffis, Brad
2014-10-27 19:02     ` Griffis, Brad
2014-10-27 19:02     ` Griffis, Brad
2014-11-03 12:17     ` Sebastian Andrzej Siewior
2014-11-03 12:17       ` Sebastian Andrzej Siewior
2014-11-03 12:17       ` Sebastian Andrzej Siewior
2014-11-04 11:44       ` Vignesh R
2014-11-04 11:44         ` Vignesh R
2014-11-04 11:44         ` Vignesh R
2014-11-04 11:44         ` Vignesh R
2014-11-04 12:37         ` Sebastian Andrzej Siewior
2014-11-04 12:37           ` Sebastian Andrzej Siewior
2014-11-04 12:37           ` Sebastian Andrzej Siewior
2014-11-04 12:37           ` Sebastian Andrzej Siewior
2014-11-05 12:08           ` Vignesh R
2014-11-05 12:08             ` Vignesh R
2014-11-05 12:08             ` Vignesh R
2014-11-05 12:08             ` Vignesh R
2014-11-17 12:18           ` Vignesh R
2014-11-17 12:18             ` Vignesh R
2014-11-17 12:18             ` Vignesh R
2014-11-03 18:09 ` Richard Cochran
2014-11-03 18:09   ` Richard Cochran
2014-11-03 18:09   ` Richard Cochran
2014-11-06  7:42   ` Vignesh R
2014-11-06  7:42     ` Vignesh R
2014-11-06  7:42     ` Vignesh R
2014-11-12 13:00     ` Johannes Pointner
2014-11-12 13:00       ` Johannes Pointner
2014-11-12 13:00       ` Johannes Pointner
2014-11-13 12:23       ` Vignesh R
2014-11-13 12:23         ` Vignesh R
2014-11-13 12:23         ` Vignesh R
2014-11-17 11:39         ` Vignesh R
2014-11-17 11:39           ` Vignesh R
2014-11-17 11:39           ` Vignesh R

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1414408111-2631-5-git-send-email-vigneshr@ti.com \
    --to=vigneshr@ti.com \
    --cc=balbi@ti.com \
    --cc=bcousson@baylibre.com \
    --cc=bgriffis@ti.com \
    --cc=bigeasy@linutronix.de \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=jan.kardell@telliq.com \
    --cc=jic23@kernel.org \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=paul.gortmaker@windriver.com \
    --cc=pawel.moll@arm.com \
    --cc=pmeerw@pmeerw.net \
    --cc=robh+dt@kernel.org \
    --cc=sameo@linux.intel.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.