From: Richard Cochran <richardcochran@gmail.com>
To: Vignesh R <vigneshr@ti.com>
Cc: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Benoit Cousson <bcousson@baylibre.com>,
Tony Lindgren <tony@atomide.com>,
Russell King <linux@arm.linux.org.uk>,
Jonathan Cameron <jic23@kernel.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
devicetree@vger.kernel.org, Lars-Peter Clausen <lars@metafoo.de>,
Samuel Ortiz <sameo@linux.intel.com>,
Jan Kardell <jan.kardell@telliq.com>,
linux-iio@vger.kernel.org,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Felipe Balbi <balbi@ti.com>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
Peter Meerwald <pmeerw@pmeerw.net>,
Hartmut Knaack <knaack.h@gmx.de>,
linux-omap@vger.kernel.org, Lee Jones <lee.jones@linaro.org>,
linux-arm-kernel@lists.infradead.org,
Brad Griffis <bgriffis@ti.com>
Subject: Re: [PATCH 1/4] input: touchscreen: ti_am335x_tsc Interchange touchscreen and ADC steps
Date: Fri, 7 Nov 2014 09:00:34 +0100 [thread overview]
Message-ID: <20141107080033.GA6455@netboy> (raw)
In-Reply-To: <545C59CD.3070707@ti.com>
On Fri, Nov 07, 2014 at 11:04:05AM +0530, Vignesh R wrote:
>
> Currently, there is too much noise in the TSC hardware that is being
> removed by delta filtering.
The so called "filter" was only programmed because the fifo entries
were being mixed up. Sebastian fixed that.
> I tested TSC unit by removing filtering
> logic, the performance was not at all satisfactory. The cursor jumps
> wayward and smooth circles cannot be drawn. Looks like delta filtering
> cannot be removed as of now. May be I will try and address it in future.
The "filter" code is nonsensical. It picks the two values in seqeunce
that are closest to one and another. How is that supposed to work?
Did you look at the "noise"? What kind of properties did you see?
A median filter makes more sense. Or sort, remove outliers, and
average. But choosing the two closest in series is silly.
Thanks,
Richard
WARNING: multiple messages have this Message-ID (diff)
From: Richard Cochran <richardcochran@gmail.com>
To: Vignesh R <vigneshr@ti.com>
Cc: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Benoit Cousson <bcousson@baylibre.com>,
Tony Lindgren <tony@atomide.com>,
Russell King <linux@arm.linux.org.uk>,
Jonathan Cameron <jic23@kernel.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
devicetree@vger.kernel.org, Lars-Peter Clausen <lars@metafoo.de>,
Samuel Ortiz <sameo@linux.intel.com>,
Jan Kardell <jan.kardell@telliq.com>,
linux-iio@vger.kernel.org,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Felipe Balbi <balbi@ti.com>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
Peter Meerwald <pmeerw@pmeerw.net>,
Hartmut Knaack <knaack.h@gmx.de>,
linux-omap@vger.kernel.org, Lee Jones <lee.jones@linaro.org>,
linux-arm
Subject: Re: [PATCH 1/4] input: touchscreen: ti_am335x_tsc Interchange touchscreen and ADC steps
Date: Fri, 7 Nov 2014 09:00:34 +0100 [thread overview]
Message-ID: <20141107080033.GA6455@netboy> (raw)
In-Reply-To: <545C59CD.3070707@ti.com>
On Fri, Nov 07, 2014 at 11:04:05AM +0530, Vignesh R wrote:
>
> Currently, there is too much noise in the TSC hardware that is being
> removed by delta filtering.
The so called "filter" was only programmed because the fifo entries
were being mixed up. Sebastian fixed that.
> I tested TSC unit by removing filtering
> logic, the performance was not at all satisfactory. The cursor jumps
> wayward and smooth circles cannot be drawn. Looks like delta filtering
> cannot be removed as of now. May be I will try and address it in future.
The "filter" code is nonsensical. It picks the two values in seqeunce
that are closest to one and another. How is that supposed to work?
Did you look at the "noise"? What kind of properties did you see?
A median filter makes more sense. Or sort, remove outliers, and
average. But choosing the two closest in series is silly.
Thanks,
Richard
WARNING: multiple messages have this Message-ID (diff)
From: richardcochran@gmail.com (Richard Cochran)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] input: touchscreen: ti_am335x_tsc Interchange touchscreen and ADC steps
Date: Fri, 7 Nov 2014 09:00:34 +0100 [thread overview]
Message-ID: <20141107080033.GA6455@netboy> (raw)
In-Reply-To: <545C59CD.3070707@ti.com>
On Fri, Nov 07, 2014 at 11:04:05AM +0530, Vignesh R wrote:
>
> Currently, there is too much noise in the TSC hardware that is being
> removed by delta filtering.
The so called "filter" was only programmed because the fifo entries
were being mixed up. Sebastian fixed that.
> I tested TSC unit by removing filtering
> logic, the performance was not at all satisfactory. The cursor jumps
> wayward and smooth circles cannot be drawn. Looks like delta filtering
> cannot be removed as of now. May be I will try and address it in future.
The "filter" code is nonsensical. It picks the two values in seqeunce
that are closest to one and another. How is that supposed to work?
Did you look at the "noise"? What kind of properties did you see?
A median filter makes more sense. Or sort, remove outliers, and
average. But choosing the two closest in series is silly.
Thanks,
Richard
next prev parent reply other threads:[~2014-11-07 8:00 UTC|newest]
Thread overview: 86+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-27 11:08 [PATCH 0/4] Touchscreen performance related fixes Vignesh R
2014-10-27 11:08 ` Vignesh R
2014-10-27 11:08 ` Vignesh R
2014-10-27 11:08 ` [PATCH 1/4] input: touchscreen: ti_am335x_tsc Interchange touchscreen and ADC steps Vignesh R
2014-10-27 11:08 ` Vignesh R
2014-10-27 11:08 ` Vignesh R
2014-10-31 21:03 ` Hartmut Knaack
2014-10-31 21:03 ` Hartmut Knaack
2014-10-31 21:03 ` Hartmut Knaack
2014-11-07 5:48 ` Vignesh R
2014-11-07 5:48 ` Vignesh R
2014-11-07 5:48 ` Vignesh R
2014-11-06 14:19 ` Richard Cochran
2014-11-06 14:19 ` Richard Cochran
2014-11-06 14:19 ` Richard Cochran
2014-11-07 5:34 ` Vignesh R
2014-11-07 5:34 ` Vignesh R
2014-11-07 5:34 ` Vignesh R
2014-11-07 8:00 ` Richard Cochran [this message]
2014-11-07 8:00 ` Richard Cochran
2014-11-07 8:00 ` Richard Cochran
2014-11-10 10:46 ` Vignesh R
2014-11-10 10:46 ` Vignesh R
2014-11-10 10:46 ` Vignesh R
2014-11-07 10:17 ` Richard Cochran
2014-11-07 10:17 ` Richard Cochran
2014-11-07 10:17 ` Richard Cochran
2014-10-27 11:08 ` [PATCH 2/4] input: touchscreen: ti_am335x_tsc: Remove udelay in interrupt handler Vignesh R
2014-10-27 11:08 ` Vignesh R
2014-10-27 11:08 ` Vignesh R
2014-11-03 15:05 ` Lee Jones
2014-11-03 15:05 ` Lee Jones
2014-11-03 15:05 ` Lee Jones
2014-11-07 5:48 ` Vignesh R
2014-11-07 5:48 ` Vignesh R
2014-11-07 5:48 ` Vignesh R
2014-10-27 11:08 ` [PATCH 3/4] arm: boot: dts: am335x-evm: Make charge delay a DT parameter for tsc Vignesh R
2014-10-27 11:08 ` Vignesh R
2014-10-27 11:08 ` Vignesh R
2014-10-31 21:09 ` Hartmut Knaack
2014-10-31 21:09 ` Hartmut Knaack
2014-11-07 5:48 ` Vignesh R
2014-11-07 5:48 ` Vignesh R
2014-11-07 5:48 ` Vignesh R
2014-10-27 11:08 ` [PATCH 4/4] input: touchscreen: ti_am335x_tsc: Use charge delay DT parameter Vignesh R
2014-10-27 11:08 ` Vignesh R
2014-10-27 11:08 ` Vignesh R
2014-10-27 17:34 ` [PATCH 0/4] Touchscreen performance related fixes Sebastian Andrzej Siewior
2014-10-27 17:34 ` Sebastian Andrzej Siewior
2014-10-27 19:02 ` Griffis, Brad
2014-10-27 19:02 ` Griffis, Brad
2014-10-27 19:02 ` Griffis, Brad
2014-10-27 19:02 ` Griffis, Brad
2014-11-03 12:17 ` Sebastian Andrzej Siewior
2014-11-03 12:17 ` Sebastian Andrzej Siewior
2014-11-03 12:17 ` Sebastian Andrzej Siewior
2014-11-04 11:44 ` Vignesh R
2014-11-04 11:44 ` Vignesh R
2014-11-04 11:44 ` Vignesh R
2014-11-04 11:44 ` Vignesh R
2014-11-04 12:37 ` Sebastian Andrzej Siewior
2014-11-04 12:37 ` Sebastian Andrzej Siewior
2014-11-04 12:37 ` Sebastian Andrzej Siewior
2014-11-04 12:37 ` Sebastian Andrzej Siewior
2014-11-05 12:08 ` Vignesh R
2014-11-05 12:08 ` Vignesh R
2014-11-05 12:08 ` Vignesh R
2014-11-05 12:08 ` Vignesh R
2014-11-17 12:18 ` Vignesh R
2014-11-17 12:18 ` Vignesh R
2014-11-17 12:18 ` Vignesh R
2014-11-03 18:09 ` Richard Cochran
2014-11-03 18:09 ` Richard Cochran
2014-11-03 18:09 ` Richard Cochran
2014-11-06 7:42 ` Vignesh R
2014-11-06 7:42 ` Vignesh R
2014-11-06 7:42 ` Vignesh R
2014-11-12 13:00 ` Johannes Pointner
2014-11-12 13:00 ` Johannes Pointner
2014-11-12 13:00 ` Johannes Pointner
2014-11-13 12:23 ` Vignesh R
2014-11-13 12:23 ` Vignesh R
2014-11-13 12:23 ` Vignesh R
2014-11-17 11:39 ` Vignesh R
2014-11-17 11:39 ` Vignesh R
2014-11-17 11:39 ` Vignesh R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141107080033.GA6455@netboy \
--to=richardcochran@gmail.com \
--cc=balbi@ti.com \
--cc=bcousson@baylibre.com \
--cc=bgriffis@ti.com \
--cc=bigeasy@linutronix.de \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jan.kardell@telliq.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=paul.gortmaker@windriver.com \
--cc=pawel.moll@arm.com \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
--cc=sameo@linux.intel.com \
--cc=tony@atomide.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.