From: Rob Herring <robh@kernel.org> To: Russell King <linux@arm.linux.org.uk>, linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org, arm@kernel.org, Rob Herring <robh@kernel.org>, David Airlie <airlied@linux.ie>, dri-devel@lists.freedesktop.org Subject: [PATCH 06/15] gpu/drm: kill off set_irq_flags usage Date: Tue, 9 Jun 2015 13:26:32 -0500 [thread overview] Message-ID: <1433874401-27161-7-git-send-email-robh@kernel.org> (raw) In-Reply-To: <1433874401-27161-1-git-send-email-robh@kernel.org> set_irq_flags is ARM specific with custom flags which have genirq equivalents. Convert drivers to use the genirq interfaces directly, so we can kill off set_irq_flags. The translation of flags is as follows: IRQF_VALID -> !IRQ_NOREQUEST IRQF_PROBE -> !IRQ_NOPROBE IRQF_NOAUTOEN -> IRQ_NOAUTOEN For IRQs managed by an irqdomain, the irqdomain core code handles clearing and setting IRQ_NOREQUEST already, so there is no need to do this in .map() functions and we can simply remove the set_irq_flags calls. Some users also set IRQ_NOPROBE and this has been maintained although it is not clear that is really needed. There appears to be a great deal of blind copy and paste of this code. Signed-off-by: Rob Herring <robh@kernel.org> Cc: David Airlie <airlied@linux.ie> Cc: dri-devel@lists.freedesktop.org --- drivers/gpu/drm/msm/mdp/mdp5/mdp5_irq.c | 1 - drivers/gpu/ipu-v3/ipu-common.c | 3 +-- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/msm/mdp/mdp5/mdp5_irq.c b/drivers/gpu/drm/msm/mdp/mdp5/mdp5_irq.c index 33bd4c6..9a6a747 100644 --- a/drivers/gpu/drm/msm/mdp/mdp5/mdp5_irq.c +++ b/drivers/gpu/drm/msm/mdp/mdp5/mdp5_irq.c @@ -165,7 +165,6 @@ static int mdp5_hw_irqdomain_map(struct irq_domain *d, irq_set_chip_and_handler(irq, &mdp5_hw_irq_chip, handle_level_irq); irq_set_chip_data(irq, mdp5_kms); - set_irq_flags(irq, IRQF_VALID); return 0; } diff --git a/drivers/gpu/ipu-v3/ipu-common.c b/drivers/gpu/ipu-v3/ipu-common.c index 67bab5c..eb95c94 100644 --- a/drivers/gpu/ipu-v3/ipu-common.c +++ b/drivers/gpu/ipu-v3/ipu-common.c @@ -1099,8 +1099,7 @@ static int ipu_irq_init(struct ipu_soc *ipu) } ret = irq_alloc_domain_generic_chips(ipu->domain, 32, 1, "IPU", - handle_level_irq, 0, - IRQF_VALID, 0); + handle_level_irq, 0, 0, 0); if (ret < 0) { dev_err(ipu->dev, "failed to alloc generic irq chips\n"); irq_domain_remove(ipu->domain); -- 2.1.0
WARNING: multiple messages have this Message-ID (diff)
From: robh@kernel.org (Rob Herring) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 06/15] gpu/drm: kill off set_irq_flags usage Date: Tue, 9 Jun 2015 13:26:32 -0500 [thread overview] Message-ID: <1433874401-27161-7-git-send-email-robh@kernel.org> (raw) In-Reply-To: <1433874401-27161-1-git-send-email-robh@kernel.org> set_irq_flags is ARM specific with custom flags which have genirq equivalents. Convert drivers to use the genirq interfaces directly, so we can kill off set_irq_flags. The translation of flags is as follows: IRQF_VALID -> !IRQ_NOREQUEST IRQF_PROBE -> !IRQ_NOPROBE IRQF_NOAUTOEN -> IRQ_NOAUTOEN For IRQs managed by an irqdomain, the irqdomain core code handles clearing and setting IRQ_NOREQUEST already, so there is no need to do this in .map() functions and we can simply remove the set_irq_flags calls. Some users also set IRQ_NOPROBE and this has been maintained although it is not clear that is really needed. There appears to be a great deal of blind copy and paste of this code. Signed-off-by: Rob Herring <robh@kernel.org> Cc: David Airlie <airlied@linux.ie> Cc: dri-devel at lists.freedesktop.org --- drivers/gpu/drm/msm/mdp/mdp5/mdp5_irq.c | 1 - drivers/gpu/ipu-v3/ipu-common.c | 3 +-- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/msm/mdp/mdp5/mdp5_irq.c b/drivers/gpu/drm/msm/mdp/mdp5/mdp5_irq.c index 33bd4c6..9a6a747 100644 --- a/drivers/gpu/drm/msm/mdp/mdp5/mdp5_irq.c +++ b/drivers/gpu/drm/msm/mdp/mdp5/mdp5_irq.c @@ -165,7 +165,6 @@ static int mdp5_hw_irqdomain_map(struct irq_domain *d, irq_set_chip_and_handler(irq, &mdp5_hw_irq_chip, handle_level_irq); irq_set_chip_data(irq, mdp5_kms); - set_irq_flags(irq, IRQF_VALID); return 0; } diff --git a/drivers/gpu/ipu-v3/ipu-common.c b/drivers/gpu/ipu-v3/ipu-common.c index 67bab5c..eb95c94 100644 --- a/drivers/gpu/ipu-v3/ipu-common.c +++ b/drivers/gpu/ipu-v3/ipu-common.c @@ -1099,8 +1099,7 @@ static int ipu_irq_init(struct ipu_soc *ipu) } ret = irq_alloc_domain_generic_chips(ipu->domain, 32, 1, "IPU", - handle_level_irq, 0, - IRQF_VALID, 0); + handle_level_irq, 0, 0, 0); if (ret < 0) { dev_err(ipu->dev, "failed to alloc generic irq chips\n"); irq_domain_remove(ipu->domain); -- 2.1.0
next prev parent reply other threads:[~2015-06-09 18:27 UTC|newest] Thread overview: 112+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-06-09 18:26 [PATCH 00/15] Kill off set_irq_flags Rob Herring 2015-06-09 18:26 ` Rob Herring 2015-06-09 18:26 ` [PATCH 01/15] ARM: kill off set_irq_flags usage Rob Herring 2015-06-09 18:26 ` Rob Herring 2015-06-09 18:26 ` Rob Herring 2015-06-12 9:30 ` Krzysztof Kozlowski 2015-06-12 9:30 ` Krzysztof Kozlowski 2015-06-12 14:05 ` Hans Ulli Kroll 2015-06-12 14:05 ` Hans Ulli Kroll 2015-06-12 14:05 ` Hans Ulli Kroll 2015-06-12 14:35 ` Rob Herring 2015-06-12 14:35 ` Rob Herring 2015-06-12 14:35 ` Rob Herring 2015-06-12 16:23 ` Hans Ulli Kroll 2015-06-12 16:23 ` Hans Ulli Kroll 2015-06-12 16:23 ` Hans Ulli Kroll 2015-06-13 11:32 ` Wan ZongShun 2015-06-13 11:32 ` Wan ZongShun 2015-06-13 11:32 ` Wan ZongShun 2015-06-09 18:26 ` [PATCH 02/15] regmap: " Rob Herring 2015-06-09 18:26 ` Rob Herring 2015-06-09 19:12 ` Mark Brown 2015-06-09 19:12 ` Mark Brown 2015-06-09 21:27 ` Russell King - ARM Linux 2015-06-09 21:27 ` Russell King - ARM Linux 2015-06-09 23:20 ` Mark Brown 2015-06-09 23:20 ` Mark Brown 2015-06-09 18:26 ` [PATCH 03/15] clk: " Rob Herring 2015-06-09 18:26 ` Rob Herring 2015-06-09 18:44 ` Boris Brezillon 2015-06-09 18:44 ` Boris Brezillon 2015-06-09 18:52 ` Stephen Boyd 2015-06-09 18:52 ` Stephen Boyd 2015-06-09 18:26 ` [PATCH 04/15] dma: " Rob Herring 2015-06-09 18:26 ` Rob Herring 2015-06-09 18:26 ` [PATCH 05/15] gpio: " Rob Herring 2015-06-09 18:26 ` Rob Herring [not found] ` <1433874401-27161-6-git-send-email-robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> 2015-06-10 12:43 ` Linus Walleij 2015-06-10 12:43 ` Linus Walleij 2015-06-10 12:43 ` Linus Walleij 2015-06-09 18:26 ` Rob Herring [this message] 2015-06-09 18:26 ` [PATCH 06/15] gpu/drm: " Rob Herring 2015-06-09 18:26 ` [PATCH 07/15] irqchip: " Rob Herring 2015-06-09 18:26 ` Rob Herring 2015-06-10 17:13 ` Rob Herring 2015-06-10 17:13 ` Rob Herring 2015-06-10 17:13 ` Rob Herring 2015-06-09 18:26 ` [PATCH 08/15] memory: " Rob Herring 2015-06-09 18:26 ` Rob Herring 2015-06-09 18:26 ` Rob Herring 2015-06-11 12:18 ` Roger Quadros 2015-06-11 12:18 ` Roger Quadros 2015-06-11 12:18 ` Roger Quadros 2015-06-11 13:17 ` Rob Herring 2015-06-11 13:17 ` Rob Herring 2015-06-11 13:17 ` Rob Herring 2015-06-11 14:00 ` Roger Quadros 2015-06-11 14:00 ` Roger Quadros 2015-06-11 14:00 ` Roger Quadros 2015-06-09 18:26 ` [PATCH 09/15] mfd: " Rob Herring 2015-06-09 18:26 ` Rob Herring 2015-06-10 12:43 ` Linus Walleij 2015-06-10 12:43 ` Linus Walleij 2015-06-10 12:43 ` Linus Walleij 2015-06-11 8:51 ` Lee Jones 2015-06-11 8:51 ` Lee Jones 2015-06-09 18:26 ` [PATCH 10/15] PCI: " Rob Herring 2015-06-09 18:26 ` Rob Herring 2015-06-09 18:26 ` Rob Herring 2015-06-18 16:59 ` Bjorn Helgaas 2015-06-18 16:59 ` Bjorn Helgaas 2015-06-18 16:59 ` Bjorn Helgaas 2015-06-18 20:08 ` Rob Herring 2015-06-18 20:08 ` Rob Herring 2015-06-18 20:08 ` Rob Herring 2015-06-18 20:10 ` Bjorn Helgaas 2015-06-18 20:10 ` Bjorn Helgaas 2015-06-18 20:10 ` Bjorn Helgaas 2015-06-09 18:26 ` [PATCH 11/15] pinctrl: " Rob Herring 2015-06-09 18:26 ` Rob Herring 2015-06-10 12:42 ` Linus Walleij 2015-06-10 12:42 ` Linus Walleij 2015-06-10 12:42 ` Linus Walleij 2015-06-09 18:26 ` [PATCH 12/15] SH: " Rob Herring 2015-06-09 18:26 ` Rob Herring 2015-06-09 18:26 ` Rob Herring 2015-07-07 0:53 ` Simon Horman 2015-07-07 0:53 ` Simon Horman 2015-07-07 0:53 ` Simon Horman 2015-07-07 1:55 ` Simon Horman 2015-07-07 1:55 ` Simon Horman 2015-07-07 1:55 ` Simon Horman 2015-07-07 14:38 ` Rob Herring 2015-07-07 14:38 ` Rob Herring 2015-07-07 14:38 ` Rob Herring 2015-07-08 1:04 ` Simon Horman 2015-07-08 1:04 ` Simon Horman 2015-07-08 1:04 ` Simon Horman 2015-06-09 18:26 ` [PATCH 13/15] tty/serial: " Rob Herring 2015-06-09 18:26 ` Rob Herring 2015-06-09 18:26 ` [PATCH 14/15] ARM: remove ununsed set_irq_flags Rob Herring 2015-06-09 18:26 ` Rob Herring 2015-06-09 18:26 ` [PATCH 15/15] arm64: " Rob Herring 2015-06-09 18:26 ` Rob Herring 2015-06-10 16:56 ` Catalin Marinas 2015-06-10 16:56 ` Catalin Marinas 2015-06-09 20:28 ` [PATCH 00/15] Kill off set_irq_flags Russell King - ARM Linux 2015-06-09 20:28 ` Russell King - ARM Linux 2015-06-09 21:23 ` Rob Herring 2015-06-09 21:23 ` Rob Herring 2015-06-10 23:32 ` Kevin Hilman 2015-06-10 23:32 ` Kevin Hilman
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1433874401-27161-7-git-send-email-robh@kernel.org \ --to=robh@kernel.org \ --cc=airlied@linux.ie \ --cc=arm@kernel.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux@arm.linux.org.uk \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.