From: Mark Brown <broonie@kernel.org>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Rob Herring <robh@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, arm@kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH 02/15] regmap: kill off set_irq_flags usage
Date: Wed, 10 Jun 2015 00:20:29 +0100 [thread overview]
Message-ID: <20150609232029.GB14071@sirena.org.uk> (raw)
In-Reply-To: <20150609212709.GJ7557@n2100.arm.linux.org.uk>
[-- Attachment #1: Type: text/plain, Size: 886 bytes --]
On Tue, Jun 09, 2015 at 10:27:09PM +0100, Russell King - ARM Linux wrote:
> It's because there exist platforms where specific IRQs are permanently
> asserted, and unexpectedly claiming such an interrupt (eg, through IRQ
> probing) would lock the system - at least before we ended up with the
> detection in genirq (which has its roots in the ARM code.)
Ah, yes - now I remember. I just had a vauge recollection of broken
probing.
> I'd suggest people think carefully about applying these patches. They
> have only been around for a matter of hours, so to rush to apply them
> when they haven't been revewied as a whole to assess whether the approach
> is the right one is rather hasty.
I'm fairly comfortable with the patch for regmap as that code is
architecture neutral, should already have been consistent and the
non-ARM path has definitely been tested (I've done it myself).
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: broonie@kernel.org (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 02/15] regmap: kill off set_irq_flags usage
Date: Wed, 10 Jun 2015 00:20:29 +0100 [thread overview]
Message-ID: <20150609232029.GB14071@sirena.org.uk> (raw)
In-Reply-To: <20150609212709.GJ7557@n2100.arm.linux.org.uk>
On Tue, Jun 09, 2015 at 10:27:09PM +0100, Russell King - ARM Linux wrote:
> It's because there exist platforms where specific IRQs are permanently
> asserted, and unexpectedly claiming such an interrupt (eg, through IRQ
> probing) would lock the system - at least before we ended up with the
> detection in genirq (which has its roots in the ARM code.)
Ah, yes - now I remember. I just had a vauge recollection of broken
probing.
> I'd suggest people think carefully about applying these patches. They
> have only been around for a matter of hours, so to rush to apply them
> when they haven't been revewied as a whole to assess whether the approach
> is the right one is rather hasty.
I'm fairly comfortable with the patch for regmap as that code is
architecture neutral, should already have been consistent and the
non-ARM path has definitely been tested (I've done it myself).
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150610/2c153884/attachment.sig>
next prev parent reply other threads:[~2015-06-09 23:21 UTC|newest]
Thread overview: 112+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-09 18:26 [PATCH 00/15] Kill off set_irq_flags Rob Herring
2015-06-09 18:26 ` Rob Herring
2015-06-09 18:26 ` [PATCH 01/15] ARM: kill off set_irq_flags usage Rob Herring
2015-06-09 18:26 ` Rob Herring
2015-06-09 18:26 ` Rob Herring
2015-06-12 9:30 ` Krzysztof Kozlowski
2015-06-12 9:30 ` Krzysztof Kozlowski
2015-06-12 14:05 ` Hans Ulli Kroll
2015-06-12 14:05 ` Hans Ulli Kroll
2015-06-12 14:05 ` Hans Ulli Kroll
2015-06-12 14:35 ` Rob Herring
2015-06-12 14:35 ` Rob Herring
2015-06-12 14:35 ` Rob Herring
2015-06-12 16:23 ` Hans Ulli Kroll
2015-06-12 16:23 ` Hans Ulli Kroll
2015-06-12 16:23 ` Hans Ulli Kroll
2015-06-13 11:32 ` Wan ZongShun
2015-06-13 11:32 ` Wan ZongShun
2015-06-13 11:32 ` Wan ZongShun
2015-06-09 18:26 ` [PATCH 02/15] regmap: " Rob Herring
2015-06-09 18:26 ` Rob Herring
2015-06-09 19:12 ` Mark Brown
2015-06-09 19:12 ` Mark Brown
2015-06-09 21:27 ` Russell King - ARM Linux
2015-06-09 21:27 ` Russell King - ARM Linux
2015-06-09 23:20 ` Mark Brown [this message]
2015-06-09 23:20 ` Mark Brown
2015-06-09 18:26 ` [PATCH 03/15] clk: " Rob Herring
2015-06-09 18:26 ` Rob Herring
2015-06-09 18:44 ` Boris Brezillon
2015-06-09 18:44 ` Boris Brezillon
2015-06-09 18:52 ` Stephen Boyd
2015-06-09 18:52 ` Stephen Boyd
2015-06-09 18:26 ` [PATCH 04/15] dma: " Rob Herring
2015-06-09 18:26 ` Rob Herring
2015-06-09 18:26 ` [PATCH 05/15] gpio: " Rob Herring
2015-06-09 18:26 ` Rob Herring
[not found] ` <1433874401-27161-6-git-send-email-robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2015-06-10 12:43 ` Linus Walleij
2015-06-10 12:43 ` Linus Walleij
2015-06-10 12:43 ` Linus Walleij
2015-06-09 18:26 ` [PATCH 06/15] gpu/drm: " Rob Herring
2015-06-09 18:26 ` Rob Herring
2015-06-09 18:26 ` [PATCH 07/15] irqchip: " Rob Herring
2015-06-09 18:26 ` Rob Herring
2015-06-10 17:13 ` Rob Herring
2015-06-10 17:13 ` Rob Herring
2015-06-10 17:13 ` Rob Herring
2015-06-09 18:26 ` [PATCH 08/15] memory: " Rob Herring
2015-06-09 18:26 ` Rob Herring
2015-06-09 18:26 ` Rob Herring
2015-06-11 12:18 ` Roger Quadros
2015-06-11 12:18 ` Roger Quadros
2015-06-11 12:18 ` Roger Quadros
2015-06-11 13:17 ` Rob Herring
2015-06-11 13:17 ` Rob Herring
2015-06-11 13:17 ` Rob Herring
2015-06-11 14:00 ` Roger Quadros
2015-06-11 14:00 ` Roger Quadros
2015-06-11 14:00 ` Roger Quadros
2015-06-09 18:26 ` [PATCH 09/15] mfd: " Rob Herring
2015-06-09 18:26 ` Rob Herring
2015-06-10 12:43 ` Linus Walleij
2015-06-10 12:43 ` Linus Walleij
2015-06-10 12:43 ` Linus Walleij
2015-06-11 8:51 ` Lee Jones
2015-06-11 8:51 ` Lee Jones
2015-06-09 18:26 ` [PATCH 10/15] PCI: " Rob Herring
2015-06-09 18:26 ` Rob Herring
2015-06-09 18:26 ` Rob Herring
2015-06-18 16:59 ` Bjorn Helgaas
2015-06-18 16:59 ` Bjorn Helgaas
2015-06-18 16:59 ` Bjorn Helgaas
2015-06-18 20:08 ` Rob Herring
2015-06-18 20:08 ` Rob Herring
2015-06-18 20:08 ` Rob Herring
2015-06-18 20:10 ` Bjorn Helgaas
2015-06-18 20:10 ` Bjorn Helgaas
2015-06-18 20:10 ` Bjorn Helgaas
2015-06-09 18:26 ` [PATCH 11/15] pinctrl: " Rob Herring
2015-06-09 18:26 ` Rob Herring
2015-06-10 12:42 ` Linus Walleij
2015-06-10 12:42 ` Linus Walleij
2015-06-10 12:42 ` Linus Walleij
2015-06-09 18:26 ` [PATCH 12/15] SH: " Rob Herring
2015-06-09 18:26 ` Rob Herring
2015-06-09 18:26 ` Rob Herring
2015-07-07 0:53 ` Simon Horman
2015-07-07 0:53 ` Simon Horman
2015-07-07 0:53 ` Simon Horman
2015-07-07 1:55 ` Simon Horman
2015-07-07 1:55 ` Simon Horman
2015-07-07 1:55 ` Simon Horman
2015-07-07 14:38 ` Rob Herring
2015-07-07 14:38 ` Rob Herring
2015-07-07 14:38 ` Rob Herring
2015-07-08 1:04 ` Simon Horman
2015-07-08 1:04 ` Simon Horman
2015-07-08 1:04 ` Simon Horman
2015-06-09 18:26 ` [PATCH 13/15] tty/serial: " Rob Herring
2015-06-09 18:26 ` Rob Herring
2015-06-09 18:26 ` [PATCH 14/15] ARM: remove ununsed set_irq_flags Rob Herring
2015-06-09 18:26 ` Rob Herring
2015-06-09 18:26 ` [PATCH 15/15] arm64: " Rob Herring
2015-06-09 18:26 ` Rob Herring
2015-06-10 16:56 ` Catalin Marinas
2015-06-10 16:56 ` Catalin Marinas
2015-06-09 20:28 ` [PATCH 00/15] Kill off set_irq_flags Russell King - ARM Linux
2015-06-09 20:28 ` Russell King - ARM Linux
2015-06-09 21:23 ` Rob Herring
2015-06-09 21:23 ` Rob Herring
2015-06-10 23:32 ` Kevin Hilman
2015-06-10 23:32 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150609232029.GB14071@sirena.org.uk \
--to=broonie@kernel.org \
--cc=arm@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.