From: Simon Horman <horms@verge.net.au>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 12/15] SH: kill off set_irq_flags usage
Date: Tue, 07 Jul 2015 01:55:03 +0000 [thread overview]
Message-ID: <20150707015503.GA23941@verge.net.au> (raw)
In-Reply-To: <20150707005338.GG13326@verge.net.au>
On Tue, Jul 07, 2015 at 09:53:39AM +0900, Simon Horman wrote:
> On Tue, Jun 09, 2015 at 01:26:38PM -0500, Rob Herring wrote:
> > set_irq_flags is ARM specific with custom flags which have genirq
> > equivalents. Convert drivers to use the genirq interfaces directly, so we
> > can kill off set_irq_flags. The translation of flags is as follows:
> >
> > IRQF_VALID -> !IRQ_NOREQUEST
> > IRQF_PROBE -> !IRQ_NOPROBE
> > IRQF_NOAUTOEN -> IRQ_NOAUTOEN
> >
> > For IRQs managed by an irqdomain, the irqdomain core code handles clearing
> > and setting IRQ_NOREQUEST already, so there is no need to do this in
> > .map() functions and we can simply remove the set_irq_flags calls. Some
> > users also set IRQ_NOPROBE and this has been maintained although it is not
> > clear that is really needed. There appears to be a great deal of blind
> > copy and paste of this code.
> >
> > Signed-off-by: Rob Herring <robh@kernel.org>
> > Cc: Simon Horman <horms@verge.net.au>
> > Cc: Magnus Damm <magnus.damm@gmail.com>
> > Cc: linux-sh@vger.kernel.org
>
> I am trusting the description above coupled with the comments in
> the original code (that this patch removes). Assuming those ducks are
> aligned:
>
> Acked-by: Simon Horman <horms+renesas@verge.net.au>
As I usually take patches for drivers/sh/ (there have not been many of late)
please let me know if you would like me to pick up this change.
Also, a very minor nit, the prefix for patches to this file is usually
'sh:' rather than 'SH:'.
>
> > ---
> > drivers/sh/intc/internals.h | 10 +---------
> > 1 file changed, 1 insertion(+), 9 deletions(-)
> >
> > diff --git a/drivers/sh/intc/internals.h b/drivers/sh/intc/internals.h
> > index 7dff08e..897ffb1 100644
> > --- a/drivers/sh/intc/internals.h
> > +++ b/drivers/sh/intc/internals.h
> > @@ -99,15 +99,7 @@ static inline struct intc_desc_int *get_intc_desc(unsigned int irq)
> > */
> > static inline void activate_irq(int irq)
> > {
> > -#ifdef CONFIG_ARM
> > - /* ARM requires an extra step to clear IRQ_NOREQUEST, which it
> > - * sets on behalf of every irq_chip. Also sets IRQ_NOPROBE.
> > - */
> > - set_irq_flags(irq, IRQF_VALID);
> > -#else
> > - /* same effect on other architectures */
> > - irq_set_noprobe(irq);
> > -#endif
> > + irq_clear_status_flags(irq, IRQ_NOREQUEST | IRQ_NOPROBE);
> > }
> >
> > static inline int intc_handle_int_cmp(const void *a, const void *b)
> > --
> > 2.1.0
> >
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@verge.net.au>
To: Rob Herring <robh@kernel.org>
Cc: Russell King <linux@arm.linux.org.uk>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, arm@kernel.org,
Magnus Damm <magnus.damm@gmail.com>,
linux-sh@vger.kernel.org
Subject: Re: [PATCH 12/15] SH: kill off set_irq_flags usage
Date: Tue, 7 Jul 2015 10:55:03 +0900 [thread overview]
Message-ID: <20150707015503.GA23941@verge.net.au> (raw)
In-Reply-To: <20150707005338.GG13326@verge.net.au>
On Tue, Jul 07, 2015 at 09:53:39AM +0900, Simon Horman wrote:
> On Tue, Jun 09, 2015 at 01:26:38PM -0500, Rob Herring wrote:
> > set_irq_flags is ARM specific with custom flags which have genirq
> > equivalents. Convert drivers to use the genirq interfaces directly, so we
> > can kill off set_irq_flags. The translation of flags is as follows:
> >
> > IRQF_VALID -> !IRQ_NOREQUEST
> > IRQF_PROBE -> !IRQ_NOPROBE
> > IRQF_NOAUTOEN -> IRQ_NOAUTOEN
> >
> > For IRQs managed by an irqdomain, the irqdomain core code handles clearing
> > and setting IRQ_NOREQUEST already, so there is no need to do this in
> > .map() functions and we can simply remove the set_irq_flags calls. Some
> > users also set IRQ_NOPROBE and this has been maintained although it is not
> > clear that is really needed. There appears to be a great deal of blind
> > copy and paste of this code.
> >
> > Signed-off-by: Rob Herring <robh@kernel.org>
> > Cc: Simon Horman <horms@verge.net.au>
> > Cc: Magnus Damm <magnus.damm@gmail.com>
> > Cc: linux-sh@vger.kernel.org
>
> I am trusting the description above coupled with the comments in
> the original code (that this patch removes). Assuming those ducks are
> aligned:
>
> Acked-by: Simon Horman <horms+renesas@verge.net.au>
As I usually take patches for drivers/sh/ (there have not been many of late)
please let me know if you would like me to pick up this change.
Also, a very minor nit, the prefix for patches to this file is usually
'sh:' rather than 'SH:'.
>
> > ---
> > drivers/sh/intc/internals.h | 10 +---------
> > 1 file changed, 1 insertion(+), 9 deletions(-)
> >
> > diff --git a/drivers/sh/intc/internals.h b/drivers/sh/intc/internals.h
> > index 7dff08e..897ffb1 100644
> > --- a/drivers/sh/intc/internals.h
> > +++ b/drivers/sh/intc/internals.h
> > @@ -99,15 +99,7 @@ static inline struct intc_desc_int *get_intc_desc(unsigned int irq)
> > */
> > static inline void activate_irq(int irq)
> > {
> > -#ifdef CONFIG_ARM
> > - /* ARM requires an extra step to clear IRQ_NOREQUEST, which it
> > - * sets on behalf of every irq_chip. Also sets IRQ_NOPROBE.
> > - */
> > - set_irq_flags(irq, IRQF_VALID);
> > -#else
> > - /* same effect on other architectures */
> > - irq_set_noprobe(irq);
> > -#endif
> > + irq_clear_status_flags(irq, IRQ_NOREQUEST | IRQ_NOPROBE);
> > }
> >
> > static inline int intc_handle_int_cmp(const void *a, const void *b)
> > --
> > 2.1.0
> >
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
WARNING: multiple messages have this Message-ID (diff)
From: horms@verge.net.au (Simon Horman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 12/15] SH: kill off set_irq_flags usage
Date: Tue, 7 Jul 2015 10:55:03 +0900 [thread overview]
Message-ID: <20150707015503.GA23941@verge.net.au> (raw)
In-Reply-To: <20150707005338.GG13326@verge.net.au>
On Tue, Jul 07, 2015 at 09:53:39AM +0900, Simon Horman wrote:
> On Tue, Jun 09, 2015 at 01:26:38PM -0500, Rob Herring wrote:
> > set_irq_flags is ARM specific with custom flags which have genirq
> > equivalents. Convert drivers to use the genirq interfaces directly, so we
> > can kill off set_irq_flags. The translation of flags is as follows:
> >
> > IRQF_VALID -> !IRQ_NOREQUEST
> > IRQF_PROBE -> !IRQ_NOPROBE
> > IRQF_NOAUTOEN -> IRQ_NOAUTOEN
> >
> > For IRQs managed by an irqdomain, the irqdomain core code handles clearing
> > and setting IRQ_NOREQUEST already, so there is no need to do this in
> > .map() functions and we can simply remove the set_irq_flags calls. Some
> > users also set IRQ_NOPROBE and this has been maintained although it is not
> > clear that is really needed. There appears to be a great deal of blind
> > copy and paste of this code.
> >
> > Signed-off-by: Rob Herring <robh@kernel.org>
> > Cc: Simon Horman <horms@verge.net.au>
> > Cc: Magnus Damm <magnus.damm@gmail.com>
> > Cc: linux-sh at vger.kernel.org
>
> I am trusting the description above coupled with the comments in
> the original code (that this patch removes). Assuming those ducks are
> aligned:
>
> Acked-by: Simon Horman <horms+renesas@verge.net.au>
As I usually take patches for drivers/sh/ (there have not been many of late)
please let me know if you would like me to pick up this change.
Also, a very minor nit, the prefix for patches to this file is usually
'sh:' rather than 'SH:'.
>
> > ---
> > drivers/sh/intc/internals.h | 10 +---------
> > 1 file changed, 1 insertion(+), 9 deletions(-)
> >
> > diff --git a/drivers/sh/intc/internals.h b/drivers/sh/intc/internals.h
> > index 7dff08e..897ffb1 100644
> > --- a/drivers/sh/intc/internals.h
> > +++ b/drivers/sh/intc/internals.h
> > @@ -99,15 +99,7 @@ static inline struct intc_desc_int *get_intc_desc(unsigned int irq)
> > */
> > static inline void activate_irq(int irq)
> > {
> > -#ifdef CONFIG_ARM
> > - /* ARM requires an extra step to clear IRQ_NOREQUEST, which it
> > - * sets on behalf of every irq_chip. Also sets IRQ_NOPROBE.
> > - */
> > - set_irq_flags(irq, IRQF_VALID);
> > -#else
> > - /* same effect on other architectures */
> > - irq_set_noprobe(irq);
> > -#endif
> > + irq_clear_status_flags(irq, IRQ_NOREQUEST | IRQ_NOPROBE);
> > }
> >
> > static inline int intc_handle_int_cmp(const void *a, const void *b)
> > --
> > 2.1.0
> >
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2015-07-07 1:55 UTC|newest]
Thread overview: 112+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-09 18:26 [PATCH 00/15] Kill off set_irq_flags Rob Herring
2015-06-09 18:26 ` Rob Herring
2015-06-09 18:26 ` [PATCH 01/15] ARM: kill off set_irq_flags usage Rob Herring
2015-06-09 18:26 ` Rob Herring
2015-06-09 18:26 ` Rob Herring
2015-06-12 9:30 ` Krzysztof Kozlowski
2015-06-12 9:30 ` Krzysztof Kozlowski
2015-06-12 14:05 ` Hans Ulli Kroll
2015-06-12 14:05 ` Hans Ulli Kroll
2015-06-12 14:05 ` Hans Ulli Kroll
2015-06-12 14:35 ` Rob Herring
2015-06-12 14:35 ` Rob Herring
2015-06-12 14:35 ` Rob Herring
2015-06-12 16:23 ` Hans Ulli Kroll
2015-06-12 16:23 ` Hans Ulli Kroll
2015-06-12 16:23 ` Hans Ulli Kroll
2015-06-13 11:32 ` Wan ZongShun
2015-06-13 11:32 ` Wan ZongShun
2015-06-13 11:32 ` Wan ZongShun
2015-06-09 18:26 ` [PATCH 02/15] regmap: " Rob Herring
2015-06-09 18:26 ` Rob Herring
2015-06-09 19:12 ` Mark Brown
2015-06-09 19:12 ` Mark Brown
2015-06-09 21:27 ` Russell King - ARM Linux
2015-06-09 21:27 ` Russell King - ARM Linux
2015-06-09 23:20 ` Mark Brown
2015-06-09 23:20 ` Mark Brown
2015-06-09 18:26 ` [PATCH 03/15] clk: " Rob Herring
2015-06-09 18:26 ` Rob Herring
2015-06-09 18:44 ` Boris Brezillon
2015-06-09 18:44 ` Boris Brezillon
2015-06-09 18:52 ` Stephen Boyd
2015-06-09 18:52 ` Stephen Boyd
2015-06-09 18:26 ` [PATCH 04/15] dma: " Rob Herring
2015-06-09 18:26 ` Rob Herring
2015-06-09 18:26 ` [PATCH 05/15] gpio: " Rob Herring
2015-06-09 18:26 ` Rob Herring
[not found] ` <1433874401-27161-6-git-send-email-robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2015-06-10 12:43 ` Linus Walleij
2015-06-10 12:43 ` Linus Walleij
2015-06-10 12:43 ` Linus Walleij
2015-06-09 18:26 ` [PATCH 06/15] gpu/drm: " Rob Herring
2015-06-09 18:26 ` Rob Herring
2015-06-09 18:26 ` [PATCH 07/15] irqchip: " Rob Herring
2015-06-09 18:26 ` Rob Herring
2015-06-10 17:13 ` Rob Herring
2015-06-10 17:13 ` Rob Herring
2015-06-10 17:13 ` Rob Herring
2015-06-09 18:26 ` [PATCH 08/15] memory: " Rob Herring
2015-06-09 18:26 ` Rob Herring
2015-06-09 18:26 ` Rob Herring
2015-06-11 12:18 ` Roger Quadros
2015-06-11 12:18 ` Roger Quadros
2015-06-11 12:18 ` Roger Quadros
2015-06-11 13:17 ` Rob Herring
2015-06-11 13:17 ` Rob Herring
2015-06-11 13:17 ` Rob Herring
2015-06-11 14:00 ` Roger Quadros
2015-06-11 14:00 ` Roger Quadros
2015-06-11 14:00 ` Roger Quadros
2015-06-09 18:26 ` [PATCH 09/15] mfd: " Rob Herring
2015-06-09 18:26 ` Rob Herring
2015-06-10 12:43 ` Linus Walleij
2015-06-10 12:43 ` Linus Walleij
2015-06-10 12:43 ` Linus Walleij
2015-06-11 8:51 ` Lee Jones
2015-06-11 8:51 ` Lee Jones
2015-06-09 18:26 ` [PATCH 10/15] PCI: " Rob Herring
2015-06-09 18:26 ` Rob Herring
2015-06-09 18:26 ` Rob Herring
2015-06-18 16:59 ` Bjorn Helgaas
2015-06-18 16:59 ` Bjorn Helgaas
2015-06-18 16:59 ` Bjorn Helgaas
2015-06-18 20:08 ` Rob Herring
2015-06-18 20:08 ` Rob Herring
2015-06-18 20:08 ` Rob Herring
2015-06-18 20:10 ` Bjorn Helgaas
2015-06-18 20:10 ` Bjorn Helgaas
2015-06-18 20:10 ` Bjorn Helgaas
2015-06-09 18:26 ` [PATCH 11/15] pinctrl: " Rob Herring
2015-06-09 18:26 ` Rob Herring
2015-06-10 12:42 ` Linus Walleij
2015-06-10 12:42 ` Linus Walleij
2015-06-10 12:42 ` Linus Walleij
2015-06-09 18:26 ` [PATCH 12/15] SH: " Rob Herring
2015-06-09 18:26 ` Rob Herring
2015-06-09 18:26 ` Rob Herring
2015-07-07 0:53 ` Simon Horman
2015-07-07 0:53 ` Simon Horman
2015-07-07 0:53 ` Simon Horman
2015-07-07 1:55 ` Simon Horman [this message]
2015-07-07 1:55 ` Simon Horman
2015-07-07 1:55 ` Simon Horman
2015-07-07 14:38 ` Rob Herring
2015-07-07 14:38 ` Rob Herring
2015-07-07 14:38 ` Rob Herring
2015-07-08 1:04 ` Simon Horman
2015-07-08 1:04 ` Simon Horman
2015-07-08 1:04 ` Simon Horman
2015-06-09 18:26 ` [PATCH 13/15] tty/serial: " Rob Herring
2015-06-09 18:26 ` Rob Herring
2015-06-09 18:26 ` [PATCH 14/15] ARM: remove ununsed set_irq_flags Rob Herring
2015-06-09 18:26 ` Rob Herring
2015-06-09 18:26 ` [PATCH 15/15] arm64: " Rob Herring
2015-06-09 18:26 ` Rob Herring
2015-06-10 16:56 ` Catalin Marinas
2015-06-10 16:56 ` Catalin Marinas
2015-06-09 20:28 ` [PATCH 00/15] Kill off set_irq_flags Russell King - ARM Linux
2015-06-09 20:28 ` Russell King - ARM Linux
2015-06-09 21:23 ` Rob Herring
2015-06-09 21:23 ` Rob Herring
2015-06-10 23:32 ` Kevin Hilman
2015-06-10 23:32 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150707015503.GA23941@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.