From: leilk liu <leilk.liu@mediatek.com>
To: Jonas Gorski <jogo@openwrt.org>
Cc: Mark Brown <broonie@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
<linux-spi@vger.kernel.org>, <linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH v4 1/3] dt-binding: spi: Mediatek: Document devicetree bindings for spi bus
Date: Fri, 31 Jul 2015 10:41:11 +0800 [thread overview]
Message-ID: <1438310471.24722.4.camel@mhfsdcap03> (raw)
In-Reply-To: <CAOiHx=k_0vdE=_gYO7v+-dSNJ+OsxHAjoPNs0esRuOYo6gUcmA@mail.gmail.com>
Hi Jonas,
On Thu, 2015-07-30 at 21:27 +0200, Jonas Gorski wrote:
> Hi,
>
> On Wed, Jul 29, 2015 at 1:04 PM, Leilk Liu <leilk.liu@mediatek.com> wrote:
> > Signed-off-by: Leilk Liu <leilk.liu@mediatek.com>
> > ---
> > .../devicetree/bindings/spi/spi-mt65xx.txt | 38 ++++++++++++++++++++++
> > 1 file changed, 38 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/spi/spi-mt65xx.txt
> >
> > diff --git a/Documentation/devicetree/bindings/spi/spi-mt65xx.txt b/Documentation/devicetree/bindings/spi/spi-mt65xx.txt
> > new file mode 100644
> > index 0000000..f8005d6
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/spi/spi-mt65xx.txt
> > @@ -0,0 +1,38 @@
> > +MTK SPI device
>
> You are calling it "MediaTek SPI controller" in the Kconfig entry, so
> you should call it that here as well.
>
OK, I will fix it.
> > +
> > +Required properties:
> > +- compatible: should be one of the following.
> > + - mediatek,mt8173-spi: for mt8173 platforms
> > + - mediatek,mt8135-spi: for mt8135 platforms
> > + - mediatek,mt6589-spi: for mt6589 platforms
> > +
> > +- #address-cells: should be 1.
> > +
> > +- #size-cells: should be 0.
> > +
> > +- reg: Address and length of the register set for the device
> > +
> > +- interrupts: Should contain spi interrupt
> > +
> > +- clocks: phandles to input clocks.
> > +
> > +- clock-names: tuple listing input clock names.
> > + Required elements: "main"
> > +
> > +- pad-select: should specify spi pad used, only required for MT8173.
> > + This value should be 0~3.
>
> As already commented on the v3, this is a vendor property, and must
> have a vendor prefix, so it must be called "mediatek,pad-select".
>
OK, I will fix it on the next version.
> > +
> > +Example:
> > +
> > +- SoC Specific Portion:
> > +spi: spi@1100a000 {
> > + compatible = "mediatek,mt8173-spi";
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + reg = <0 0x1100a000 0 0x1000>;
> > + interrupts = <GIC_SPI 110 IRQ_TYPE_LEVEL_LOW>;
> > + clocks = <&pericfg CLK_PERI_SPI0>;
> > + clock-names = "main";
> > + pad-select = <0>;
> > + status = "disabled";
> > +};
>
>
> Jonas
WARNING: multiple messages have this Message-ID (diff)
From: leilk liu <leilk.liu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
To: Jonas Gorski <jogo-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
Cc: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Matthias Brugger
<matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH v4 1/3] dt-binding: spi: Mediatek: Document devicetree bindings for spi bus
Date: Fri, 31 Jul 2015 10:41:11 +0800 [thread overview]
Message-ID: <1438310471.24722.4.camel@mhfsdcap03> (raw)
In-Reply-To: <CAOiHx=k_0vdE=_gYO7v+-dSNJ+OsxHAjoPNs0esRuOYo6gUcmA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
Hi Jonas,
On Thu, 2015-07-30 at 21:27 +0200, Jonas Gorski wrote:
> Hi,
>
> On Wed, Jul 29, 2015 at 1:04 PM, Leilk Liu <leilk.liu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org> wrote:
> > Signed-off-by: Leilk Liu <leilk.liu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
> > ---
> > .../devicetree/bindings/spi/spi-mt65xx.txt | 38 ++++++++++++++++++++++
> > 1 file changed, 38 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/spi/spi-mt65xx.txt
> >
> > diff --git a/Documentation/devicetree/bindings/spi/spi-mt65xx.txt b/Documentation/devicetree/bindings/spi/spi-mt65xx.txt
> > new file mode 100644
> > index 0000000..f8005d6
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/spi/spi-mt65xx.txt
> > @@ -0,0 +1,38 @@
> > +MTK SPI device
>
> You are calling it "MediaTek SPI controller" in the Kconfig entry, so
> you should call it that here as well.
>
OK, I will fix it.
> > +
> > +Required properties:
> > +- compatible: should be one of the following.
> > + - mediatek,mt8173-spi: for mt8173 platforms
> > + - mediatek,mt8135-spi: for mt8135 platforms
> > + - mediatek,mt6589-spi: for mt6589 platforms
> > +
> > +- #address-cells: should be 1.
> > +
> > +- #size-cells: should be 0.
> > +
> > +- reg: Address and length of the register set for the device
> > +
> > +- interrupts: Should contain spi interrupt
> > +
> > +- clocks: phandles to input clocks.
> > +
> > +- clock-names: tuple listing input clock names.
> > + Required elements: "main"
> > +
> > +- pad-select: should specify spi pad used, only required for MT8173.
> > + This value should be 0~3.
>
> As already commented on the v3, this is a vendor property, and must
> have a vendor prefix, so it must be called "mediatek,pad-select".
>
OK, I will fix it on the next version.
> > +
> > +Example:
> > +
> > +- SoC Specific Portion:
> > +spi: spi@1100a000 {
> > + compatible = "mediatek,mt8173-spi";
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + reg = <0 0x1100a000 0 0x1000>;
> > + interrupts = <GIC_SPI 110 IRQ_TYPE_LEVEL_LOW>;
> > + clocks = <&pericfg CLK_PERI_SPI0>;
> > + clock-names = "main";
> > + pad-select = <0>;
> > + status = "disabled";
> > +};
>
>
> Jonas
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: leilk liu <leilk.liu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
To: Jonas Gorski <jogo-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
Cc: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Matthias Brugger
<matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
<linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
<linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
Subject: Re: [PATCH v4 1/3] dt-binding: spi: Mediatek: Document devicetree bindings for spi bus
Date: Fri, 31 Jul 2015 10:41:11 +0800 [thread overview]
Message-ID: <1438310471.24722.4.camel@mhfsdcap03> (raw)
In-Reply-To: <CAOiHx=k_0vdE=_gYO7v+-dSNJ+OsxHAjoPNs0esRuOYo6gUcmA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
Hi Jonas,
On Thu, 2015-07-30 at 21:27 +0200, Jonas Gorski wrote:
> Hi,
>
> On Wed, Jul 29, 2015 at 1:04 PM, Leilk Liu <leilk.liu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org> wrote:
> > Signed-off-by: Leilk Liu <leilk.liu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
> > ---
> > .../devicetree/bindings/spi/spi-mt65xx.txt | 38 ++++++++++++++++++++++
> > 1 file changed, 38 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/spi/spi-mt65xx.txt
> >
> > diff --git a/Documentation/devicetree/bindings/spi/spi-mt65xx.txt b/Documentation/devicetree/bindings/spi/spi-mt65xx.txt
> > new file mode 100644
> > index 0000000..f8005d6
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/spi/spi-mt65xx.txt
> > @@ -0,0 +1,38 @@
> > +MTK SPI device
>
> You are calling it "MediaTek SPI controller" in the Kconfig entry, so
> you should call it that here as well.
>
OK, I will fix it.
> > +
> > +Required properties:
> > +- compatible: should be one of the following.
> > + - mediatek,mt8173-spi: for mt8173 platforms
> > + - mediatek,mt8135-spi: for mt8135 platforms
> > + - mediatek,mt6589-spi: for mt6589 platforms
> > +
> > +- #address-cells: should be 1.
> > +
> > +- #size-cells: should be 0.
> > +
> > +- reg: Address and length of the register set for the device
> > +
> > +- interrupts: Should contain spi interrupt
> > +
> > +- clocks: phandles to input clocks.
> > +
> > +- clock-names: tuple listing input clock names.
> > + Required elements: "main"
> > +
> > +- pad-select: should specify spi pad used, only required for MT8173.
> > + This value should be 0~3.
>
> As already commented on the v3, this is a vendor property, and must
> have a vendor prefix, so it must be called "mediatek,pad-select".
>
OK, I will fix it on the next version.
> > +
> > +Example:
> > +
> > +- SoC Specific Portion:
> > +spi: spi@1100a000 {
> > + compatible = "mediatek,mt8173-spi";
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + reg = <0 0x1100a000 0 0x1000>;
> > + interrupts = <GIC_SPI 110 IRQ_TYPE_LEVEL_LOW>;
> > + clocks = <&pericfg CLK_PERI_SPI0>;
> > + clock-names = "main";
> > + pad-select = <0>;
> > + status = "disabled";
> > +};
>
>
> Jonas
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: leilk.liu@mediatek.com (leilk liu)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 1/3] dt-binding: spi: Mediatek: Document devicetree bindings for spi bus
Date: Fri, 31 Jul 2015 10:41:11 +0800 [thread overview]
Message-ID: <1438310471.24722.4.camel@mhfsdcap03> (raw)
In-Reply-To: <CAOiHx=k_0vdE=_gYO7v+-dSNJ+OsxHAjoPNs0esRuOYo6gUcmA@mail.gmail.com>
Hi Jonas,
On Thu, 2015-07-30 at 21:27 +0200, Jonas Gorski wrote:
> Hi,
>
> On Wed, Jul 29, 2015 at 1:04 PM, Leilk Liu <leilk.liu@mediatek.com> wrote:
> > Signed-off-by: Leilk Liu <leilk.liu@mediatek.com>
> > ---
> > .../devicetree/bindings/spi/spi-mt65xx.txt | 38 ++++++++++++++++++++++
> > 1 file changed, 38 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/spi/spi-mt65xx.txt
> >
> > diff --git a/Documentation/devicetree/bindings/spi/spi-mt65xx.txt b/Documentation/devicetree/bindings/spi/spi-mt65xx.txt
> > new file mode 100644
> > index 0000000..f8005d6
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/spi/spi-mt65xx.txt
> > @@ -0,0 +1,38 @@
> > +MTK SPI device
>
> You are calling it "MediaTek SPI controller" in the Kconfig entry, so
> you should call it that here as well.
>
OK, I will fix it.
> > +
> > +Required properties:
> > +- compatible: should be one of the following.
> > + - mediatek,mt8173-spi: for mt8173 platforms
> > + - mediatek,mt8135-spi: for mt8135 platforms
> > + - mediatek,mt6589-spi: for mt6589 platforms
> > +
> > +- #address-cells: should be 1.
> > +
> > +- #size-cells: should be 0.
> > +
> > +- reg: Address and length of the register set for the device
> > +
> > +- interrupts: Should contain spi interrupt
> > +
> > +- clocks: phandles to input clocks.
> > +
> > +- clock-names: tuple listing input clock names.
> > + Required elements: "main"
> > +
> > +- pad-select: should specify spi pad used, only required for MT8173.
> > + This value should be 0~3.
>
> As already commented on the v3, this is a vendor property, and must
> have a vendor prefix, so it must be called "mediatek,pad-select".
>
OK, I will fix it on the next version.
> > +
> > +Example:
> > +
> > +- SoC Specific Portion:
> > +spi: spi at 1100a000 {
> > + compatible = "mediatek,mt8173-spi";
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + reg = <0 0x1100a000 0 0x1000>;
> > + interrupts = <GIC_SPI 110 IRQ_TYPE_LEVEL_LOW>;
> > + clocks = <&pericfg CLK_PERI_SPI0>;
> > + clock-names = "main";
> > + pad-select = <0>;
> > + status = "disabled";
> > +};
>
>
> Jonas
next prev parent reply other threads:[~2015-07-31 2:41 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-29 11:04 [PATCH v4 0/3] Add Mediatek SPI bus driver Leilk Liu
2015-07-29 11:04 ` Leilk Liu
2015-07-29 11:04 ` Leilk Liu
2015-07-29 11:04 ` Leilk Liu
2015-07-29 11:04 ` [PATCH v4 1/3] dt-binding: spi: Mediatek: Document devicetree bindings for spi bus Leilk Liu
2015-07-29 11:04 ` Leilk Liu
2015-07-29 11:04 ` Leilk Liu
2015-07-30 19:27 ` Jonas Gorski
2015-07-30 19:27 ` Jonas Gorski
2015-07-30 19:27 ` Jonas Gorski
2015-07-31 2:41 ` leilk liu [this message]
2015-07-31 2:41 ` leilk liu
2015-07-31 2:41 ` leilk liu
2015-07-31 2:41 ` leilk liu
2015-08-04 17:42 ` Mark Brown
2015-08-04 17:42 ` Mark Brown
2015-08-04 17:42 ` Mark Brown
2015-08-06 1:45 ` leilk liu
2015-08-06 1:45 ` leilk liu
2015-08-06 1:45 ` leilk liu
2015-08-06 1:45 ` leilk liu
2015-07-29 11:04 ` [PATCH v4 2/3] spi: mediatek: Add spi bus for Mediatek MT8173 Leilk Liu
2015-07-29 11:04 ` Leilk Liu
2015-07-29 11:04 ` Leilk Liu
2015-07-29 11:04 ` Leilk Liu
2015-07-29 11:04 ` [PATCH v4 3/3] arm64: dts: Add spi bus dts Leilk Liu
2015-07-29 11:04 ` Leilk Liu
2015-07-29 11:04 ` Leilk Liu
2015-07-30 19:29 ` [PATCH v4 0/3] Add Mediatek SPI bus driver Jonas Gorski
2015-07-30 19:29 ` Jonas Gorski
2015-07-30 19:29 ` Jonas Gorski
2015-07-31 2:44 ` leilk liu
2015-07-31 2:44 ` leilk liu
2015-07-31 2:44 ` leilk liu
2015-07-31 2:44 ` leilk liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1438310471.24722.4.camel@mhfsdcap03 \
--to=leilk.liu@mediatek.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jogo@openwrt.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.