All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonas Gorski <jogo@openwrt.org>
To: Leilk Liu <leilk.liu@mediatek.com>
Cc: Mark Brown <broonie@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	linux-spi@vger.kernel.org, linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v4 0/3] Add Mediatek SPI bus driver
Date: Thu, 30 Jul 2015 21:29:28 +0200	[thread overview]
Message-ID: <CAOiHx=nfrx4pm91MYcpn_jx3UMtpJD8nt9ptmKSFQA5YEsDL4A@mail.gmail.com> (raw)
In-Reply-To: <1438167874-1305-1-git-send-email-leilk.liu@mediatek.com>

Hi,

On Wed, Jul 29, 2015 at 1:04 PM, Leilk Liu <leilk.liu@mediatek.com> wrote:
> Change in v4:
> 1. fix Mark Brown review comment.

You should say what you actually fixed/changed, not just that you
changed something. Also the individual patches should contain
changelogs as well (under the tear-off line (--), so one knows if
something was changed between
versions.


Jonas

WARNING: multiple messages have this Message-ID (diff)
From: jogo@openwrt.org (Jonas Gorski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 0/3] Add Mediatek SPI bus driver
Date: Thu, 30 Jul 2015 21:29:28 +0200	[thread overview]
Message-ID: <CAOiHx=nfrx4pm91MYcpn_jx3UMtpJD8nt9ptmKSFQA5YEsDL4A@mail.gmail.com> (raw)
In-Reply-To: <1438167874-1305-1-git-send-email-leilk.liu@mediatek.com>

Hi,

On Wed, Jul 29, 2015 at 1:04 PM, Leilk Liu <leilk.liu@mediatek.com> wrote:
> Change in v4:
> 1. fix Mark Brown review comment.

You should say what you actually fixed/changed, not just that you
changed something. Also the individual patches should contain
changelogs as well (under the tear-off line (--), so one knows if
something was changed between
versions.


Jonas

  parent reply	other threads:[~2015-07-30 19:29 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-29 11:04 [PATCH v4 0/3] Add Mediatek SPI bus driver Leilk Liu
2015-07-29 11:04 ` Leilk Liu
2015-07-29 11:04 ` Leilk Liu
2015-07-29 11:04 ` Leilk Liu
2015-07-29 11:04 ` [PATCH v4 1/3] dt-binding: spi: Mediatek: Document devicetree bindings for spi bus Leilk Liu
2015-07-29 11:04   ` Leilk Liu
2015-07-29 11:04   ` Leilk Liu
2015-07-30 19:27   ` Jonas Gorski
2015-07-30 19:27     ` Jonas Gorski
2015-07-30 19:27     ` Jonas Gorski
2015-07-31  2:41     ` leilk liu
2015-07-31  2:41       ` leilk liu
2015-07-31  2:41       ` leilk liu
2015-07-31  2:41       ` leilk liu
2015-08-04 17:42   ` Mark Brown
2015-08-04 17:42     ` Mark Brown
2015-08-04 17:42     ` Mark Brown
2015-08-06  1:45     ` leilk liu
2015-08-06  1:45       ` leilk liu
2015-08-06  1:45       ` leilk liu
2015-08-06  1:45       ` leilk liu
2015-07-29 11:04 ` [PATCH v4 2/3] spi: mediatek: Add spi bus for Mediatek MT8173 Leilk Liu
2015-07-29 11:04   ` Leilk Liu
2015-07-29 11:04   ` Leilk Liu
2015-07-29 11:04   ` Leilk Liu
2015-07-29 11:04 ` [PATCH v4 3/3] arm64: dts: Add spi bus dts Leilk Liu
2015-07-29 11:04   ` Leilk Liu
2015-07-29 11:04   ` Leilk Liu
2015-07-30 19:29 ` Jonas Gorski [this message]
2015-07-30 19:29   ` [PATCH v4 0/3] Add Mediatek SPI bus driver Jonas Gorski
2015-07-30 19:29   ` Jonas Gorski
2015-07-31  2:44   ` leilk liu
2015-07-31  2:44     ` leilk liu
2015-07-31  2:44     ` leilk liu
2015-07-31  2:44     ` leilk liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAOiHx=nfrx4pm91MYcpn_jx3UMtpJD8nt9ptmKSFQA5YEsDL4A@mail.gmail.com' \
    --to=jogo@openwrt.org \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=leilk.liu@mediatek.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=matthias.bgg@gmail.com \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.