From: leilk liu <leilk.liu@mediatek.com>
To: Mark Brown <broonie@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-spi@vger.kernel.org>, <linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH v4 1/3] dt-binding: spi: Mediatek: Document devicetree bindings for spi bus
Date: Thu, 6 Aug 2015 09:45:40 +0800 [thread overview]
Message-ID: <1438825540.2163.5.camel@mhfsdcap03> (raw)
In-Reply-To: <20150804174226.GE20873@sirena.org.uk>
On Tue, 2015-08-04 at 18:42 +0100, Mark Brown wrote:
> On Wed, Jul 29, 2015 at 07:04:32PM +0800, Leilk Liu wrote:
> > Signed-off-by: Leilk Liu <leilk.liu@mediatek.com>
>
> Please use subject lines reflecting the style for the subsystem so
> people can spot if patches are relevant to them.
>
OK, I will change the title to "spi: Mediatek: Document devicetree
bindings for spi bus".
> > +- clocks: phandles to input clocks.
> > +
> > +- clock-names: tuple listing input clock names.
> > + Required elements: "main"
>
> ...and there are no optional values?
>
clock tree provides some source clocks, CLK_PERI_SPI0 is the default
one. I will support optional values on the next version.
> > +- pad-select: should specify spi pad used, only required for MT8173.
> > + This value should be 0~3.
>
> What do the values 0-3 mean? I guess it's the value for some register
> or other part of the device, the binding should say so people can go and
> check the datasheet, schematic or whatever to figure out what to set.
>
> This property should be optional, not required
OK, I will explain what the values 0-3 mean.
WARNING: multiple messages have this Message-ID (diff)
From: leilk liu <leilk.liu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
To: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Matthias Brugger
<matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH v4 1/3] dt-binding: spi: Mediatek: Document devicetree bindings for spi bus
Date: Thu, 6 Aug 2015 09:45:40 +0800 [thread overview]
Message-ID: <1438825540.2163.5.camel@mhfsdcap03> (raw)
In-Reply-To: <20150804174226.GE20873-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
On Tue, 2015-08-04 at 18:42 +0100, Mark Brown wrote:
> On Wed, Jul 29, 2015 at 07:04:32PM +0800, Leilk Liu wrote:
> > Signed-off-by: Leilk Liu <leilk.liu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
>
> Please use subject lines reflecting the style for the subsystem so
> people can spot if patches are relevant to them.
>
OK, I will change the title to "spi: Mediatek: Document devicetree
bindings for spi bus".
> > +- clocks: phandles to input clocks.
> > +
> > +- clock-names: tuple listing input clock names.
> > + Required elements: "main"
>
> ...and there are no optional values?
>
clock tree provides some source clocks, CLK_PERI_SPI0 is the default
one. I will support optional values on the next version.
> > +- pad-select: should specify spi pad used, only required for MT8173.
> > + This value should be 0~3.
>
> What do the values 0-3 mean? I guess it's the value for some register
> or other part of the device, the binding should say so people can go and
> check the datasheet, schematic or whatever to figure out what to set.
>
> This property should be optional, not required
OK, I will explain what the values 0-3 mean.
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: leilk liu <leilk.liu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
To: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Matthias Brugger
<matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
<linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
<linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
Subject: Re: [PATCH v4 1/3] dt-binding: spi: Mediatek: Document devicetree bindings for spi bus
Date: Thu, 6 Aug 2015 09:45:40 +0800 [thread overview]
Message-ID: <1438825540.2163.5.camel@mhfsdcap03> (raw)
In-Reply-To: <20150804174226.GE20873-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
On Tue, 2015-08-04 at 18:42 +0100, Mark Brown wrote:
> On Wed, Jul 29, 2015 at 07:04:32PM +0800, Leilk Liu wrote:
> > Signed-off-by: Leilk Liu <leilk.liu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
>
> Please use subject lines reflecting the style for the subsystem so
> people can spot if patches are relevant to them.
>
OK, I will change the title to "spi: Mediatek: Document devicetree
bindings for spi bus".
> > +- clocks: phandles to input clocks.
> > +
> > +- clock-names: tuple listing input clock names.
> > + Required elements: "main"
>
> ...and there are no optional values?
>
clock tree provides some source clocks, CLK_PERI_SPI0 is the default
one. I will support optional values on the next version.
> > +- pad-select: should specify spi pad used, only required for MT8173.
> > + This value should be 0~3.
>
> What do the values 0-3 mean? I guess it's the value for some register
> or other part of the device, the binding should say so people can go and
> check the datasheet, schematic or whatever to figure out what to set.
>
> This property should be optional, not required
OK, I will explain what the values 0-3 mean.
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: leilk.liu@mediatek.com (leilk liu)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 1/3] dt-binding: spi: Mediatek: Document devicetree bindings for spi bus
Date: Thu, 6 Aug 2015 09:45:40 +0800 [thread overview]
Message-ID: <1438825540.2163.5.camel@mhfsdcap03> (raw)
In-Reply-To: <20150804174226.GE20873@sirena.org.uk>
On Tue, 2015-08-04 at 18:42 +0100, Mark Brown wrote:
> On Wed, Jul 29, 2015 at 07:04:32PM +0800, Leilk Liu wrote:
> > Signed-off-by: Leilk Liu <leilk.liu@mediatek.com>
>
> Please use subject lines reflecting the style for the subsystem so
> people can spot if patches are relevant to them.
>
OK, I will change the title to "spi: Mediatek: Document devicetree
bindings for spi bus".
> > +- clocks: phandles to input clocks.
> > +
> > +- clock-names: tuple listing input clock names.
> > + Required elements: "main"
>
> ...and there are no optional values?
>
clock tree provides some source clocks, CLK_PERI_SPI0 is the default
one. I will support optional values on the next version.
> > +- pad-select: should specify spi pad used, only required for MT8173.
> > + This value should be 0~3.
>
> What do the values 0-3 mean? I guess it's the value for some register
> or other part of the device, the binding should say so people can go and
> check the datasheet, schematic or whatever to figure out what to set.
>
> This property should be optional, not required
OK, I will explain what the values 0-3 mean.
next prev parent reply other threads:[~2015-08-06 1:45 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-29 11:04 [PATCH v4 0/3] Add Mediatek SPI bus driver Leilk Liu
2015-07-29 11:04 ` Leilk Liu
2015-07-29 11:04 ` Leilk Liu
2015-07-29 11:04 ` Leilk Liu
2015-07-29 11:04 ` [PATCH v4 1/3] dt-binding: spi: Mediatek: Document devicetree bindings for spi bus Leilk Liu
2015-07-29 11:04 ` Leilk Liu
2015-07-29 11:04 ` Leilk Liu
2015-07-30 19:27 ` Jonas Gorski
2015-07-30 19:27 ` Jonas Gorski
2015-07-30 19:27 ` Jonas Gorski
2015-07-31 2:41 ` leilk liu
2015-07-31 2:41 ` leilk liu
2015-07-31 2:41 ` leilk liu
2015-07-31 2:41 ` leilk liu
2015-08-04 17:42 ` Mark Brown
2015-08-04 17:42 ` Mark Brown
2015-08-04 17:42 ` Mark Brown
2015-08-06 1:45 ` leilk liu [this message]
2015-08-06 1:45 ` leilk liu
2015-08-06 1:45 ` leilk liu
2015-08-06 1:45 ` leilk liu
2015-07-29 11:04 ` [PATCH v4 2/3] spi: mediatek: Add spi bus for Mediatek MT8173 Leilk Liu
2015-07-29 11:04 ` Leilk Liu
2015-07-29 11:04 ` Leilk Liu
2015-07-29 11:04 ` Leilk Liu
2015-07-29 11:04 ` [PATCH v4 3/3] arm64: dts: Add spi bus dts Leilk Liu
2015-07-29 11:04 ` Leilk Liu
2015-07-29 11:04 ` Leilk Liu
2015-07-30 19:29 ` [PATCH v4 0/3] Add Mediatek SPI bus driver Jonas Gorski
2015-07-30 19:29 ` Jonas Gorski
2015-07-30 19:29 ` Jonas Gorski
2015-07-31 2:44 ` leilk liu
2015-07-31 2:44 ` leilk liu
2015-07-31 2:44 ` leilk liu
2015-07-31 2:44 ` leilk liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1438825540.2163.5.camel@mhfsdcap03 \
--to=leilk.liu@mediatek.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.