From: "Verma, Vishal L" <vishal.l.verma@intel.com>
To: "jmoyer@redhat.com" <jmoyer@redhat.com>
Cc: "Wilcox, Matthew R" <matthew.r.wilcox@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"hch@infradead.org" <hch@infradead.org>,
"linux-nvdimm@ml01.01.org" <linux-nvdimm@ml01.01.org>,
"xfs@oss.sgi.com" <xfs@oss.sgi.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"axboe@fb.com" <axboe@fb.com>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>,
"david@fromorbit.com" <david@fromorbit.com>,
"jack@suse.cz" <jack@suse.cz>
Subject: Re: [PATCH v2 5/5] dax: handle media errors in dax_do_io
Date: Fri, 15 Apr 2016 16:54:48 +0000 [thread overview]
Message-ID: <1460739288.3012.3.camel@intel.com> (raw)
In-Reply-To: <x49twj26edj.fsf@segfault.boston.devel.redhat.com>
On Fri, 2016-04-15 at 12:11 -0400, Jeff Moyer wrote:
> Vishal Verma <vishal.l.verma@intel.com> writes:
>
> >
> > dax_do_io (called for read() or write() for a dax file system) may
> > fail
> > in the presence of bad blocks or media errors. Since we expect that
> > a
> > write should clear media errors on nvdimms, make dax_do_io fall
> > back to
> > the direct_IO path, which will send down a bio to the driver, which
> > can
> > then attempt to clear the error.
> [snip]
>
> >
> > + if (IS_DAX(inode)) {
> > + ret = dax_do_io(iocb, inode, iter, offset,
> > blkdev_get_block,
> > NULL, DIO_SKIP_DIO_COUNT);
> > - return __blockdev_direct_IO(iocb, inode, I_BDEV(inode),
> > iter, offset,
> > + if (ret == -EIO && (iov_iter_rw(iter) == WRITE))
> > + ret_saved = ret;
> > + else
> > + return ret;
> > + }
> > +
> > + ret = __blockdev_direct_IO(iocb, inode, I_BDEV(inode),
> > iter, offset,
> > blkdev_get_block, NULL, NULL,
> > DIO_SKIP_DIO_COUNT);
> > + if (ret < 0 && ret_saved)
> > + return ret_saved;
> > +
> Hmm, did you just break async DIO? I think you did! :)
> __blockdev_direct_IO can return -EIOCBQUEUED, and you've now turned
> that
> into -EIO. Really, I don't see a reason to save that first
> -EIO. The
> same applies to all instances in this patch.
The reason I saved it was if __blockdev_direct_IO fails for some
reason, we should return the original cause o the error, which was an
EIO.. i.e. we shouldn't be hiding the EIO if the direct_IO fails with
something else..
But, how does _EIOCBQUEUED work? Maybe we need an exception for it?
Thanks,
-Vishal
WARNING: multiple messages have this Message-ID (diff)
From: "Verma, Vishal L" <vishal.l.verma@intel.com>
To: "jmoyer@redhat.com" <jmoyer@redhat.com>
Cc: "Wilcox, Matthew R" <matthew.r.wilcox@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"hch@infradead.org" <hch@infradead.org>,
"linux-nvdimm@ml01.01.org" <linux-nvdimm@ml01.01.org>,
"xfs@oss.sgi.com" <xfs@oss.sgi.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"axboe@fb.com" <axboe@fb.com>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>,
"david@fromorbit.com" <david@fromorbit.com>,
"jack@suse.cz" <jack@suse.cz>
Subject: Re: [PATCH v2 5/5] dax: handle media errors in dax_do_io
Date: Fri, 15 Apr 2016 16:54:48 +0000 [thread overview]
Message-ID: <1460739288.3012.3.camel@intel.com> (raw)
In-Reply-To: <x49twj26edj.fsf@segfault.boston.devel.redhat.com>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1779 bytes --]
On Fri, 2016-04-15 at 12:11 -0400, Jeff Moyer wrote:
> Vishal Verma <vishal.l.verma@intel.com> writes:
>
> >
> > dax_do_io (called for read() or write() for a dax file system) may
> > fail
> > in the presence of bad blocks or media errors. Since we expect that
> > a
> > write should clear media errors on nvdimms, make dax_do_io fall
> > back to
> > the direct_IO path, which will send down a bio to the driver, which
> > can
> > then attempt to clear the error.
> [snip]
>
> >
> > + if (IS_DAX(inode)) {
> > + ret = dax_do_io(iocb, inode, iter, offset,
> > blkdev_get_block,
> > Â NULL, DIO_SKIP_DIO_COUNT);
> > - return __blockdev_direct_IO(iocb, inode, I_BDEV(inode),
> > iter, offset,
> > + if (ret == -EIO && (iov_iter_rw(iter) == WRITE))
> > + ret_saved = ret;
> > + else
> > + return ret;
> > + }
> > +
> > + ret = __blockdev_direct_IO(iocb, inode, I_BDEV(inode),
> > iter, offset,
> > Â Â Â Â Â blkdev_get_block, NULL, NULL,
> > Â Â Â Â Â DIO_SKIP_DIO_COUNT);
> > + if (ret < 0 && ret_saved)
> > + return ret_saved;
> > +
> Hmm, did you just break async DIO?  I think you did!  :)
> __blockdev_direct_IO can return -EIOCBQUEUED, and you've now turned
> that
> into -EIO.  Really, I don't see a reason to save that first
> -EIO.  The
> same applies to all instances in this patch.
The reason I saved it was if __blockdev_direct_IO fails for some
reason, we should return the original cause o the error, which was an
EIO.. i.e. we shouldn't be hiding the EIO if the direct_IO fails with
something else..
But, how does _EIOCBQUEUED work? Maybe we need an exception for it?Â
Thanks,
-VishalN‹§²æìr¸›zǧu©ž²Æ {\b†éì¹»\x1c®&Þ–)îÆi¢žØ^n‡r¶‰šŽŠÝ¢j$½§$¢¸\x05¢¹¨è§~Š'.)îÄÃ,yèm¶ŸÿÃ\f%Š{±šj+ƒðèž×¦j)Z†·Ÿ
WARNING: multiple messages have this Message-ID (diff)
From: "Verma, Vishal L" <vishal.l.verma@intel.com>
To: "jmoyer@redhat.com" <jmoyer@redhat.com>
Cc: "hch@infradead.org" <hch@infradead.org>,
"jack@suse.cz" <jack@suse.cz>, "axboe@fb.com" <axboe@fb.com>,
"linux-nvdimm@ml01.01.org" <linux-nvdimm@ml01.01.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"xfs@oss.sgi.com" <xfs@oss.sgi.com>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"Wilcox, Matthew R" <matthew.r.wilcox@intel.com>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>,
"viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH v2 5/5] dax: handle media errors in dax_do_io
Date: Fri, 15 Apr 2016 16:54:48 +0000 [thread overview]
Message-ID: <1460739288.3012.3.camel@intel.com> (raw)
In-Reply-To: <x49twj26edj.fsf@segfault.boston.devel.redhat.com>
On Fri, 2016-04-15 at 12:11 -0400, Jeff Moyer wrote:
> Vishal Verma <vishal.l.verma@intel.com> writes:
>
> >
> > dax_do_io (called for read() or write() for a dax file system) may
> > fail
> > in the presence of bad blocks or media errors. Since we expect that
> > a
> > write should clear media errors on nvdimms, make dax_do_io fall
> > back to
> > the direct_IO path, which will send down a bio to the driver, which
> > can
> > then attempt to clear the error.
> [snip]
>
> >
> > + if (IS_DAX(inode)) {
> > + ret = dax_do_io(iocb, inode, iter, offset,
> > blkdev_get_block,
> > NULL, DIO_SKIP_DIO_COUNT);
> > - return __blockdev_direct_IO(iocb, inode, I_BDEV(inode),
> > iter, offset,
> > + if (ret == -EIO && (iov_iter_rw(iter) == WRITE))
> > + ret_saved = ret;
> > + else
> > + return ret;
> > + }
> > +
> > + ret = __blockdev_direct_IO(iocb, inode, I_BDEV(inode),
> > iter, offset,
> > blkdev_get_block, NULL, NULL,
> > DIO_SKIP_DIO_COUNT);
> > + if (ret < 0 && ret_saved)
> > + return ret_saved;
> > +
> Hmm, did you just break async DIO? I think you did! :)
> __blockdev_direct_IO can return -EIOCBQUEUED, and you've now turned
> that
> into -EIO. Really, I don't see a reason to save that first
> -EIO. The
> same applies to all instances in this patch.
The reason I saved it was if __blockdev_direct_IO fails for some
reason, we should return the original cause o the error, which was an
EIO.. i.e. we shouldn't be hiding the EIO if the direct_IO fails with
something else..
But, how does _EIOCBQUEUED work? Maybe we need an exception for it?
Thanks,
-Vishal
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2016-04-15 16:54 UTC|newest]
Thread overview: 216+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-30 1:59 [PATCH v2 0/5] dax: handling of media errors Vishal Verma
2016-03-30 1:59 ` Vishal Verma
2016-03-30 1:59 ` Vishal Verma
2016-03-30 1:59 ` Vishal Verma
2016-03-30 1:59 ` [PATCH v2 1/5] block, dax: pass blk_dax_ctl through to drivers Vishal Verma
2016-03-30 1:59 ` Vishal Verma
2016-03-30 1:59 ` Vishal Verma
2016-03-30 1:59 ` Vishal Verma
2016-03-30 4:19 ` kbuild test robot
2016-03-30 4:19 ` kbuild test robot
2016-03-30 4:19 ` kbuild test robot
2016-03-30 4:19 ` kbuild test robot
2016-04-15 14:55 ` Jeff Moyer
2016-04-15 14:55 ` Jeff Moyer
2016-04-15 14:55 ` Jeff Moyer
2016-03-30 1:59 ` [PATCH v2 2/5] dax: fallback from pmd to pte on error Vishal Verma
2016-03-30 1:59 ` Vishal Verma
2016-03-30 1:59 ` Vishal Verma
2016-03-30 1:59 ` Vishal Verma
2016-03-30 1:59 ` Vishal Verma
2016-04-15 14:55 ` Jeff Moyer
2016-04-15 14:55 ` Jeff Moyer
2016-04-15 14:55 ` Jeff Moyer
2016-03-30 1:59 ` [PATCH v2 3/5] dax: enable dax in the presence of known media errors (badblocks) Vishal Verma
2016-03-30 1:59 ` Vishal Verma
2016-03-30 1:59 ` Vishal Verma
2016-03-30 1:59 ` Vishal Verma
2016-04-15 14:56 ` Jeff Moyer
2016-04-15 14:56 ` Jeff Moyer
2016-04-15 14:56 ` Jeff Moyer
2016-03-30 1:59 ` [PATCH v2 4/5] dax: use sb_issue_zerout instead of calling dax_clear_sectors Vishal Verma
2016-03-30 1:59 ` Vishal Verma
2016-03-30 1:59 ` Vishal Verma
2016-03-30 1:59 ` Vishal Verma
2016-04-15 15:18 ` Jeff Moyer
2016-04-15 15:18 ` Jeff Moyer
2016-04-15 15:18 ` Jeff Moyer
2016-03-30 1:59 ` [PATCH v2 5/5] dax: handle media errors in dax_do_io Vishal Verma
2016-03-30 1:59 ` Vishal Verma
2016-03-30 1:59 ` Vishal Verma
2016-03-30 1:59 ` Vishal Verma
2016-03-30 3:00 ` kbuild test robot
2016-03-30 3:00 ` kbuild test robot
2016-03-30 3:00 ` kbuild test robot
2016-03-30 3:00 ` kbuild test robot
2016-03-30 3:00 ` kbuild test robot
2016-03-30 3:00 ` kbuild test robot
2016-03-30 6:34 ` Christoph Hellwig
2016-03-30 6:34 ` Christoph Hellwig
2016-03-30 6:34 ` Christoph Hellwig
2016-03-30 6:54 ` Vishal Verma
2016-03-30 6:54 ` Vishal Verma
2016-03-30 6:54 ` Vishal Verma
2016-03-30 6:56 ` Christoph Hellwig
2016-03-30 6:56 ` Christoph Hellwig
2016-03-30 6:56 ` Christoph Hellwig
2016-04-15 16:11 ` Jeff Moyer
2016-04-15 16:11 ` Jeff Moyer
2016-04-15 16:11 ` Jeff Moyer
2016-04-15 16:54 ` Verma, Vishal L [this message]
2016-04-15 16:54 ` Verma, Vishal L
2016-04-15 16:54 ` Verma, Vishal L
2016-04-15 17:11 ` Jeff Moyer
2016-04-15 17:11 ` Jeff Moyer
2016-04-15 17:11 ` Jeff Moyer
2016-04-15 17:11 ` Jeff Moyer
2016-04-15 17:37 ` Verma, Vishal L
2016-04-15 17:37 ` Verma, Vishal L
2016-04-15 17:57 ` Dan Williams
2016-04-15 17:57 ` Dan Williams
2016-04-15 17:57 ` Dan Williams
2016-04-15 18:06 ` Jeff Moyer
2016-04-15 18:06 ` Jeff Moyer
2016-04-15 18:06 ` Jeff Moyer
2016-04-15 18:06 ` Jeff Moyer
2016-04-15 18:17 ` Dan Williams
2016-04-15 18:17 ` Dan Williams
2016-04-15 18:17 ` Dan Williams
2016-04-15 18:24 ` Jeff Moyer
2016-04-15 18:24 ` Jeff Moyer
2016-04-15 18:24 ` Jeff Moyer
2016-04-15 18:24 ` Jeff Moyer
2016-04-15 18:56 ` Dan Williams
2016-04-15 18:56 ` Dan Williams
2016-04-15 18:56 ` Dan Williams
2016-04-15 19:13 ` Jeff Moyer
2016-04-15 19:13 ` Jeff Moyer
2016-04-15 19:13 ` Jeff Moyer
2016-04-15 19:13 ` Jeff Moyer
2016-04-15 19:01 ` Toshi Kani
2016-04-15 19:01 ` Toshi Kani
2016-04-15 19:01 ` Toshi Kani
2016-04-15 19:01 ` Toshi Kani
2016-04-15 19:08 ` Toshi Kani
2016-04-15 19:08 ` Toshi Kani
2016-04-15 19:08 ` Toshi Kani
2016-04-15 19:08 ` Toshi Kani
2016-04-20 20:59 ` Christoph Hellwig
2016-04-20 20:59 ` Christoph Hellwig
2016-04-20 20:59 ` Christoph Hellwig
2016-04-23 18:08 ` Verma, Vishal L
2016-04-23 18:08 ` Verma, Vishal L
2016-04-25 8:31 ` hch
2016-04-25 8:31 ` hch
2016-04-25 8:31 ` hch
2016-04-25 15:32 ` Jeff Moyer
2016-04-25 15:32 ` Jeff Moyer
2016-04-25 15:32 ` Jeff Moyer
2016-04-25 15:32 ` Jeff Moyer
2016-04-26 8:32 ` hch
2016-04-26 8:32 ` hch
2016-04-26 8:32 ` hch
2016-04-25 17:14 ` Verma, Vishal L
2016-04-25 17:14 ` Verma, Vishal L
2016-04-25 17:21 ` Dan Williams
2016-04-25 17:21 ` Dan Williams
2016-04-25 17:21 ` Dan Williams
2016-04-25 23:25 ` Dave Chinner
2016-04-25 23:25 ` Dave Chinner
2016-04-25 23:25 ` Dave Chinner
2016-04-25 23:25 ` Dave Chinner
2016-04-25 23:25 ` Dave Chinner
2016-04-25 23:34 ` Darrick J. Wong
2016-04-25 23:34 ` Darrick J. Wong
2016-04-25 23:34 ` Darrick J. Wong
2016-04-25 23:34 ` Darrick J. Wong
2016-04-25 23:34 ` Darrick J. Wong
2016-04-25 23:43 ` Dan Williams
2016-04-25 23:43 ` Dan Williams
2016-04-25 23:43 ` Dan Williams
2016-04-26 0:11 ` Dave Chinner
2016-04-26 0:11 ` Dave Chinner
2016-04-26 0:11 ` Dave Chinner
2016-04-26 1:45 ` Dan Williams
2016-04-26 1:45 ` Dan Williams
2016-04-26 1:45 ` Dan Williams
2016-04-26 2:56 ` Dave Chinner
2016-04-26 2:56 ` Dave Chinner
2016-04-26 2:56 ` Dave Chinner
2016-04-26 4:18 ` Dan Williams
2016-04-26 4:18 ` Dan Williams
2016-04-26 4:18 ` Dan Williams
2016-04-26 8:27 ` Dave Chinner
2016-04-26 8:27 ` Dave Chinner
2016-04-26 8:27 ` Dave Chinner
2016-04-26 14:59 ` Dan Williams
2016-04-26 14:59 ` Dan Williams
2016-04-26 14:59 ` Dan Williams
2016-04-26 15:31 ` Jan Kara
2016-04-26 15:31 ` Jan Kara
2016-04-26 15:31 ` Jan Kara
2016-04-26 17:16 ` Dan Williams
2016-04-26 17:16 ` Dan Williams
2016-04-26 17:16 ` Dan Williams
2016-04-25 23:53 ` Verma, Vishal L
2016-04-25 23:53 ` Verma, Vishal L
2016-04-25 23:53 ` Verma, Vishal L
2016-04-26 0:41 ` Dave Chinner
2016-04-26 0:41 ` Dave Chinner
2016-04-26 0:41 ` Dave Chinner
2016-04-26 0:41 ` Dave Chinner
2016-04-26 0:41 ` Dave Chinner
2016-04-26 14:58 ` Vishal Verma
2016-04-26 14:58 ` Vishal Verma
2016-04-26 14:58 ` Vishal Verma
2016-04-26 14:58 ` Vishal Verma
2016-05-02 15:18 ` Jeff Moyer
2016-05-02 15:18 ` Jeff Moyer
2016-05-02 15:18 ` Jeff Moyer
2016-05-02 15:18 ` Jeff Moyer
2016-05-02 17:53 ` Dan Williams
2016-05-02 17:53 ` Dan Williams
2016-05-02 17:53 ` Dan Williams
2016-05-03 0:42 ` Dave Chinner
2016-05-03 0:42 ` Dave Chinner
2016-05-03 0:42 ` Dave Chinner
2016-05-03 1:26 ` Rudoff, Andy
2016-05-03 1:26 ` Rudoff, Andy
2016-05-03 2:49 ` Dave Chinner
2016-05-03 2:49 ` Dave Chinner
2016-05-03 2:49 ` Dave Chinner
2016-05-03 18:30 ` Rudoff, Andy
2016-05-03 18:30 ` Rudoff, Andy
2016-05-03 18:30 ` Rudoff, Andy
2016-05-04 1:36 ` Dave Chinner
2016-05-04 1:36 ` Dave Chinner
2016-05-04 1:36 ` Dave Chinner
2016-05-02 23:04 ` Dave Chinner
2016-05-02 23:04 ` Dave Chinner
2016-05-02 23:04 ` Dave Chinner
2016-05-02 23:04 ` Dave Chinner
2016-05-02 23:04 ` Dave Chinner
2016-05-02 23:17 ` Verma, Vishal L
2016-05-02 23:17 ` Verma, Vishal L
2016-05-02 23:25 ` Dan Williams
2016-05-02 23:25 ` Dan Williams
2016-05-02 23:25 ` Dan Williams
2016-05-03 1:51 ` Dave Chinner
2016-05-03 1:51 ` Dave Chinner
2016-05-03 1:51 ` Dave Chinner
2016-05-03 17:28 ` Dan Williams
2016-05-03 17:28 ` Dan Williams
2016-05-03 17:28 ` Dan Williams
2016-05-04 3:18 ` Dave Chinner
2016-05-04 3:18 ` Dave Chinner
2016-05-04 3:18 ` Dave Chinner
2016-05-04 5:05 ` Dan Williams
2016-05-04 5:05 ` Dan Williams
2016-05-04 5:05 ` Dan Williams
2016-04-26 8:33 ` hch
2016-04-26 8:33 ` hch
2016-04-26 8:33 ` hch
2016-04-26 15:01 ` Vishal Verma
2016-04-26 15:01 ` Vishal Verma
2016-04-26 15:01 ` Vishal Verma
2016-04-26 15:01 ` Vishal Verma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1460739288.3012.3.camel@intel.com \
--to=vishal.l.verma@intel.com \
--cc=akpm@linux-foundation.org \
--cc=axboe@fb.com \
--cc=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=jmoyer@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@ml01.01.org \
--cc=matthew.r.wilcox@intel.com \
--cc=viro@zeniv.linux.org.uk \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.