From: Dan Williams <dan.j.williams@intel.com>
To: Jeff Moyer <jmoyer@redhat.com>
Cc: "Verma, Vishal L" <vishal.l.verma@intel.com>,
"hch@infradead.org" <hch@infradead.org>,
"jack@suse.cz" <jack@suse.cz>, "axboe@fb.com" <axboe@fb.com>,
"linux-nvdimm@ml01.01.org" <linux-nvdimm@ml01.01.org>,
"david@fromorbit.com" <david@fromorbit.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"xfs@oss.sgi.com" <xfs@oss.sgi.com>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>,
"Wilcox, Matthew R" <matthew.r.wilcox@intel.com>
Subject: Re: [PATCH v2 5/5] dax: handle media errors in dax_do_io
Date: Fri, 15 Apr 2016 11:17:39 -0700 [thread overview]
Message-ID: <CAPcyv4hRQj2ZsFj7Xa_=OwcHrzP9_5yUpt3LQ+bPH4PcLe7UCQ@mail.gmail.com> (raw)
In-Reply-To: <x49lh4e6928.fsf@segfault.boston.devel.redhat.com>
On Fri, Apr 15, 2016 at 11:06 AM, Jeff Moyer <jmoyer@redhat.com> wrote:
> Dan Williams <dan.j.williams@intel.com> writes:
>
>>>> There's a lot of special casing here, so you might consider adding
>>>> comments.
>>>
>>> Correct - maybe we should reconsider wrapper-izing this? :)
>>
>> Another option is just to skip dax_do_io() and this special casing
>> fallback entirely if errors are present. I.e. only attempt dax_do_io
>> when: IS_DAX() && gendisk->bb && bb->count == 0.
>
> So, if there's an error anywhere on the device, penalize all I/O (not
> just writes, and not just on sectors that are bad)? I'm not sure that's
> a great plan, either.
>
If errors are rare how much are we actually losing in practice?
Moreover, we're going to do the full badblocks lookup anyway when we
call ->direct_access(). If we had that information earlier we can
avoid this fallback dance.
WARNING: multiple messages have this Message-ID (diff)
From: Dan Williams <dan.j.williams@intel.com>
To: Jeff Moyer <jmoyer@redhat.com>
Cc: "Verma, Vishal L" <vishal.l.verma@intel.com>,
"hch@infradead.org" <hch@infradead.org>,
"jack@suse.cz" <jack@suse.cz>, "axboe@fb.com" <axboe@fb.com>,
"linux-nvdimm@ml01.01.org" <linux-nvdimm@ml01.01.org>,
"david@fromorbit.com" <david@fromorbit.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"xfs@oss.sgi.com" <xfs@oss.sgi.com>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>,
"Wilcox, Matthew R" <matthew.r.wilcox@intel.com>
Subject: Re: [PATCH v2 5/5] dax: handle media errors in dax_do_io
Date: Fri, 15 Apr 2016 11:17:39 -0700 [thread overview]
Message-ID: <CAPcyv4hRQj2ZsFj7Xa_=OwcHrzP9_5yUpt3LQ+bPH4PcLe7UCQ@mail.gmail.com> (raw)
In-Reply-To: <x49lh4e6928.fsf@segfault.boston.devel.redhat.com>
On Fri, Apr 15, 2016 at 11:06 AM, Jeff Moyer <jmoyer@redhat.com> wrote:
> Dan Williams <dan.j.williams@intel.com> writes:
>
>>>> There's a lot of special casing here, so you might consider adding
>>>> comments.
>>>
>>> Correct - maybe we should reconsider wrapper-izing this? :)
>>
>> Another option is just to skip dax_do_io() and this special casing
>> fallback entirely if errors are present. I.e. only attempt dax_do_io
>> when: IS_DAX() && gendisk->bb && bb->count == 0.
>
> So, if there's an error anywhere on the device, penalize all I/O (not
> just writes, and not just on sectors that are bad)? I'm not sure that's
> a great plan, either.
>
If errors are rare how much are we actually losing in practice?
Moreover, we're going to do the full badblocks lookup anyway when we
call ->direct_access(). If we had that information earlier we can
avoid this fallback dance.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Dan Williams <dan.j.williams@intel.com>
To: Jeff Moyer <jmoyer@redhat.com>
Cc: "axboe@fb.com" <axboe@fb.com>, "jack@suse.cz" <jack@suse.cz>,
"Verma, Vishal L" <vishal.l.verma@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"xfs@oss.sgi.com" <xfs@oss.sgi.com>,
"hch@infradead.org" <hch@infradead.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>,
"linux-nvdimm@ml01.01.org" <linux-nvdimm@ml01.01.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>,
"Wilcox, Matthew R" <matthew.r.wilcox@intel.com>
Subject: Re: [PATCH v2 5/5] dax: handle media errors in dax_do_io
Date: Fri, 15 Apr 2016 11:17:39 -0700 [thread overview]
Message-ID: <CAPcyv4hRQj2ZsFj7Xa_=OwcHrzP9_5yUpt3LQ+bPH4PcLe7UCQ@mail.gmail.com> (raw)
In-Reply-To: <x49lh4e6928.fsf@segfault.boston.devel.redhat.com>
On Fri, Apr 15, 2016 at 11:06 AM, Jeff Moyer <jmoyer@redhat.com> wrote:
> Dan Williams <dan.j.williams@intel.com> writes:
>
>>>> There's a lot of special casing here, so you might consider adding
>>>> comments.
>>>
>>> Correct - maybe we should reconsider wrapper-izing this? :)
>>
>> Another option is just to skip dax_do_io() and this special casing
>> fallback entirely if errors are present. I.e. only attempt dax_do_io
>> when: IS_DAX() && gendisk->bb && bb->count == 0.
>
> So, if there's an error anywhere on the device, penalize all I/O (not
> just writes, and not just on sectors that are bad)? I'm not sure that's
> a great plan, either.
>
If errors are rare how much are we actually losing in practice?
Moreover, we're going to do the full badblocks lookup anyway when we
call ->direct_access(). If we had that information earlier we can
avoid this fallback dance.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2016-04-15 18:17 UTC|newest]
Thread overview: 216+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-30 1:59 [PATCH v2 0/5] dax: handling of media errors Vishal Verma
2016-03-30 1:59 ` Vishal Verma
2016-03-30 1:59 ` Vishal Verma
2016-03-30 1:59 ` Vishal Verma
2016-03-30 1:59 ` [PATCH v2 1/5] block, dax: pass blk_dax_ctl through to drivers Vishal Verma
2016-03-30 1:59 ` Vishal Verma
2016-03-30 1:59 ` Vishal Verma
2016-03-30 1:59 ` Vishal Verma
2016-03-30 4:19 ` kbuild test robot
2016-03-30 4:19 ` kbuild test robot
2016-03-30 4:19 ` kbuild test robot
2016-03-30 4:19 ` kbuild test robot
2016-04-15 14:55 ` Jeff Moyer
2016-04-15 14:55 ` Jeff Moyer
2016-04-15 14:55 ` Jeff Moyer
2016-03-30 1:59 ` [PATCH v2 2/5] dax: fallback from pmd to pte on error Vishal Verma
2016-03-30 1:59 ` Vishal Verma
2016-03-30 1:59 ` Vishal Verma
2016-03-30 1:59 ` Vishal Verma
2016-03-30 1:59 ` Vishal Verma
2016-04-15 14:55 ` Jeff Moyer
2016-04-15 14:55 ` Jeff Moyer
2016-04-15 14:55 ` Jeff Moyer
2016-03-30 1:59 ` [PATCH v2 3/5] dax: enable dax in the presence of known media errors (badblocks) Vishal Verma
2016-03-30 1:59 ` Vishal Verma
2016-03-30 1:59 ` Vishal Verma
2016-03-30 1:59 ` Vishal Verma
2016-04-15 14:56 ` Jeff Moyer
2016-04-15 14:56 ` Jeff Moyer
2016-04-15 14:56 ` Jeff Moyer
2016-03-30 1:59 ` [PATCH v2 4/5] dax: use sb_issue_zerout instead of calling dax_clear_sectors Vishal Verma
2016-03-30 1:59 ` Vishal Verma
2016-03-30 1:59 ` Vishal Verma
2016-03-30 1:59 ` Vishal Verma
2016-04-15 15:18 ` Jeff Moyer
2016-04-15 15:18 ` Jeff Moyer
2016-04-15 15:18 ` Jeff Moyer
2016-03-30 1:59 ` [PATCH v2 5/5] dax: handle media errors in dax_do_io Vishal Verma
2016-03-30 1:59 ` Vishal Verma
2016-03-30 1:59 ` Vishal Verma
2016-03-30 1:59 ` Vishal Verma
2016-03-30 3:00 ` kbuild test robot
2016-03-30 3:00 ` kbuild test robot
2016-03-30 3:00 ` kbuild test robot
2016-03-30 3:00 ` kbuild test robot
2016-03-30 3:00 ` kbuild test robot
2016-03-30 3:00 ` kbuild test robot
2016-03-30 6:34 ` Christoph Hellwig
2016-03-30 6:34 ` Christoph Hellwig
2016-03-30 6:34 ` Christoph Hellwig
2016-03-30 6:54 ` Vishal Verma
2016-03-30 6:54 ` Vishal Verma
2016-03-30 6:54 ` Vishal Verma
2016-03-30 6:56 ` Christoph Hellwig
2016-03-30 6:56 ` Christoph Hellwig
2016-03-30 6:56 ` Christoph Hellwig
2016-04-15 16:11 ` Jeff Moyer
2016-04-15 16:11 ` Jeff Moyer
2016-04-15 16:11 ` Jeff Moyer
2016-04-15 16:54 ` Verma, Vishal L
2016-04-15 16:54 ` Verma, Vishal L
2016-04-15 16:54 ` Verma, Vishal L
2016-04-15 17:11 ` Jeff Moyer
2016-04-15 17:11 ` Jeff Moyer
2016-04-15 17:11 ` Jeff Moyer
2016-04-15 17:11 ` Jeff Moyer
2016-04-15 17:37 ` Verma, Vishal L
2016-04-15 17:37 ` Verma, Vishal L
2016-04-15 17:57 ` Dan Williams
2016-04-15 17:57 ` Dan Williams
2016-04-15 17:57 ` Dan Williams
2016-04-15 18:06 ` Jeff Moyer
2016-04-15 18:06 ` Jeff Moyer
2016-04-15 18:06 ` Jeff Moyer
2016-04-15 18:06 ` Jeff Moyer
2016-04-15 18:17 ` Dan Williams [this message]
2016-04-15 18:17 ` Dan Williams
2016-04-15 18:17 ` Dan Williams
2016-04-15 18:24 ` Jeff Moyer
2016-04-15 18:24 ` Jeff Moyer
2016-04-15 18:24 ` Jeff Moyer
2016-04-15 18:24 ` Jeff Moyer
2016-04-15 18:56 ` Dan Williams
2016-04-15 18:56 ` Dan Williams
2016-04-15 18:56 ` Dan Williams
2016-04-15 19:13 ` Jeff Moyer
2016-04-15 19:13 ` Jeff Moyer
2016-04-15 19:13 ` Jeff Moyer
2016-04-15 19:13 ` Jeff Moyer
2016-04-15 19:01 ` Toshi Kani
2016-04-15 19:01 ` Toshi Kani
2016-04-15 19:01 ` Toshi Kani
2016-04-15 19:01 ` Toshi Kani
2016-04-15 19:08 ` Toshi Kani
2016-04-15 19:08 ` Toshi Kani
2016-04-15 19:08 ` Toshi Kani
2016-04-15 19:08 ` Toshi Kani
2016-04-20 20:59 ` Christoph Hellwig
2016-04-20 20:59 ` Christoph Hellwig
2016-04-20 20:59 ` Christoph Hellwig
2016-04-23 18:08 ` Verma, Vishal L
2016-04-23 18:08 ` Verma, Vishal L
2016-04-25 8:31 ` hch
2016-04-25 8:31 ` hch
2016-04-25 8:31 ` hch
2016-04-25 15:32 ` Jeff Moyer
2016-04-25 15:32 ` Jeff Moyer
2016-04-25 15:32 ` Jeff Moyer
2016-04-25 15:32 ` Jeff Moyer
2016-04-26 8:32 ` hch
2016-04-26 8:32 ` hch
2016-04-26 8:32 ` hch
2016-04-25 17:14 ` Verma, Vishal L
2016-04-25 17:14 ` Verma, Vishal L
2016-04-25 17:21 ` Dan Williams
2016-04-25 17:21 ` Dan Williams
2016-04-25 17:21 ` Dan Williams
2016-04-25 23:25 ` Dave Chinner
2016-04-25 23:25 ` Dave Chinner
2016-04-25 23:25 ` Dave Chinner
2016-04-25 23:25 ` Dave Chinner
2016-04-25 23:25 ` Dave Chinner
2016-04-25 23:34 ` Darrick J. Wong
2016-04-25 23:34 ` Darrick J. Wong
2016-04-25 23:34 ` Darrick J. Wong
2016-04-25 23:34 ` Darrick J. Wong
2016-04-25 23:34 ` Darrick J. Wong
2016-04-25 23:43 ` Dan Williams
2016-04-25 23:43 ` Dan Williams
2016-04-25 23:43 ` Dan Williams
2016-04-26 0:11 ` Dave Chinner
2016-04-26 0:11 ` Dave Chinner
2016-04-26 0:11 ` Dave Chinner
2016-04-26 1:45 ` Dan Williams
2016-04-26 1:45 ` Dan Williams
2016-04-26 1:45 ` Dan Williams
2016-04-26 2:56 ` Dave Chinner
2016-04-26 2:56 ` Dave Chinner
2016-04-26 2:56 ` Dave Chinner
2016-04-26 4:18 ` Dan Williams
2016-04-26 4:18 ` Dan Williams
2016-04-26 4:18 ` Dan Williams
2016-04-26 8:27 ` Dave Chinner
2016-04-26 8:27 ` Dave Chinner
2016-04-26 8:27 ` Dave Chinner
2016-04-26 14:59 ` Dan Williams
2016-04-26 14:59 ` Dan Williams
2016-04-26 14:59 ` Dan Williams
2016-04-26 15:31 ` Jan Kara
2016-04-26 15:31 ` Jan Kara
2016-04-26 15:31 ` Jan Kara
2016-04-26 17:16 ` Dan Williams
2016-04-26 17:16 ` Dan Williams
2016-04-26 17:16 ` Dan Williams
2016-04-25 23:53 ` Verma, Vishal L
2016-04-25 23:53 ` Verma, Vishal L
2016-04-25 23:53 ` Verma, Vishal L
2016-04-26 0:41 ` Dave Chinner
2016-04-26 0:41 ` Dave Chinner
2016-04-26 0:41 ` Dave Chinner
2016-04-26 0:41 ` Dave Chinner
2016-04-26 0:41 ` Dave Chinner
2016-04-26 14:58 ` Vishal Verma
2016-04-26 14:58 ` Vishal Verma
2016-04-26 14:58 ` Vishal Verma
2016-04-26 14:58 ` Vishal Verma
2016-05-02 15:18 ` Jeff Moyer
2016-05-02 15:18 ` Jeff Moyer
2016-05-02 15:18 ` Jeff Moyer
2016-05-02 15:18 ` Jeff Moyer
2016-05-02 17:53 ` Dan Williams
2016-05-02 17:53 ` Dan Williams
2016-05-02 17:53 ` Dan Williams
2016-05-03 0:42 ` Dave Chinner
2016-05-03 0:42 ` Dave Chinner
2016-05-03 0:42 ` Dave Chinner
2016-05-03 1:26 ` Rudoff, Andy
2016-05-03 1:26 ` Rudoff, Andy
2016-05-03 2:49 ` Dave Chinner
2016-05-03 2:49 ` Dave Chinner
2016-05-03 2:49 ` Dave Chinner
2016-05-03 18:30 ` Rudoff, Andy
2016-05-03 18:30 ` Rudoff, Andy
2016-05-03 18:30 ` Rudoff, Andy
2016-05-04 1:36 ` Dave Chinner
2016-05-04 1:36 ` Dave Chinner
2016-05-04 1:36 ` Dave Chinner
2016-05-02 23:04 ` Dave Chinner
2016-05-02 23:04 ` Dave Chinner
2016-05-02 23:04 ` Dave Chinner
2016-05-02 23:04 ` Dave Chinner
2016-05-02 23:04 ` Dave Chinner
2016-05-02 23:17 ` Verma, Vishal L
2016-05-02 23:17 ` Verma, Vishal L
2016-05-02 23:25 ` Dan Williams
2016-05-02 23:25 ` Dan Williams
2016-05-02 23:25 ` Dan Williams
2016-05-03 1:51 ` Dave Chinner
2016-05-03 1:51 ` Dave Chinner
2016-05-03 1:51 ` Dave Chinner
2016-05-03 17:28 ` Dan Williams
2016-05-03 17:28 ` Dan Williams
2016-05-03 17:28 ` Dan Williams
2016-05-04 3:18 ` Dave Chinner
2016-05-04 3:18 ` Dave Chinner
2016-05-04 3:18 ` Dave Chinner
2016-05-04 5:05 ` Dan Williams
2016-05-04 5:05 ` Dan Williams
2016-05-04 5:05 ` Dan Williams
2016-04-26 8:33 ` hch
2016-04-26 8:33 ` hch
2016-04-26 8:33 ` hch
2016-04-26 15:01 ` Vishal Verma
2016-04-26 15:01 ` Vishal Verma
2016-04-26 15:01 ` Vishal Verma
2016-04-26 15:01 ` Vishal Verma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPcyv4hRQj2ZsFj7Xa_=OwcHrzP9_5yUpt3LQ+bPH4PcLe7UCQ@mail.gmail.com' \
--to=dan.j.williams@intel.com \
--cc=akpm@linux-foundation.org \
--cc=axboe@fb.com \
--cc=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=jmoyer@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@ml01.01.org \
--cc=matthew.r.wilcox@intel.com \
--cc=viro@zeniv.linux.org.uk \
--cc=vishal.l.verma@intel.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.