From: Jeff Moyer <jmoyer@redhat.com>
To: Vishal Verma <vishal.l.verma@intel.com>
Cc: linux-nvdimm@ml01.01.org, Jens Axboe <axboe@fb.com>,
Jan Kara <jack@suse.cz>,
Andrew Morton <akpm@linux-foundation.org>,
Christoph Hellwig <hch@infradead.org>,
Dave Chinner <david@fromorbit.com>,
linux-kernel@vger.kernel.org, xfs@oss.sgi.com,
linux-block@vger.kernel.org, linux-mm@kvack.org,
Matthew Wilcox <matthew.r.wilcox@intel.com>,
linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH v2 2/5] dax: fallback from pmd to pte on error
Date: Fri, 15 Apr 2016 10:55:43 -0400 [thread overview]
Message-ID: <x497ffy7wgg.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <1459303190-20072-3-git-send-email-vishal.l.verma@intel.com> (Vishal Verma's message of "Tue, 29 Mar 2016 19:59:47 -0600")
Vishal Verma <vishal.l.verma@intel.com> writes:
> From: Dan Williams <dan.j.williams@intel.com>
>
> In preparation for consulting a badblocks list in pmem_direct_access(),
> teach dax_pmd_fault() to fallback rather than fail immediately upon
> encountering an error. The thought being that reducing the span of the
> dax request may avoid the error region.
>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Reviewed-by: Jeff Moyer <jmoyer@redhat.com>
> ---
> fs/dax.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/dax.c b/fs/dax.c
> index 90322eb..ec6417b 100644
> --- a/fs/dax.c
> +++ b/fs/dax.c
> @@ -945,8 +945,8 @@ int __dax_pmd_fault(struct vm_area_struct *vma, unsigned long address,
> long length = dax_map_atomic(bdev, &dax);
>
> if (length < 0) {
> - result = VM_FAULT_SIGBUS;
> - goto out;
> + dax_pmd_dbg(&bh, address, "dax-error fallback");
> + goto fallback;
> }
> if (length < PMD_SIZE) {
> dax_pmd_dbg(&bh, address, "dax-length too small");
WARNING: multiple messages have this Message-ID (diff)
From: Jeff Moyer <jmoyer@redhat.com>
To: Vishal Verma <vishal.l.verma@intel.com>
Cc: linux-nvdimm@ml01.01.org, Jens Axboe <axboe@fb.com>,
Jan Kara <jack@suse.cz>,
Andrew Morton <akpm@linux-foundation.org>,
Christoph Hellwig <hch@infradead.org>,
Dave Chinner <david@fromorbit.com>,
linux-kernel@vger.kernel.org, xfs@oss.sgi.com,
linux-block@vger.kernel.org, linux-mm@kvack.org,
Matthew Wilcox <matthew.r.wilcox@intel.com>,
linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH v2 2/5] dax: fallback from pmd to pte on error
Date: Fri, 15 Apr 2016 10:55:43 -0400 [thread overview]
Message-ID: <x497ffy7wgg.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <1459303190-20072-3-git-send-email-vishal.l.verma@intel.com> (Vishal Verma's message of "Tue, 29 Mar 2016 19:59:47 -0600")
Vishal Verma <vishal.l.verma@intel.com> writes:
> From: Dan Williams <dan.j.williams@intel.com>
>
> In preparation for consulting a badblocks list in pmem_direct_access(),
> teach dax_pmd_fault() to fallback rather than fail immediately upon
> encountering an error. The thought being that reducing the span of the
> dax request may avoid the error region.
>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Reviewed-by: Jeff Moyer <jmoyer@redhat.com>
> ---
> fs/dax.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/dax.c b/fs/dax.c
> index 90322eb..ec6417b 100644
> --- a/fs/dax.c
> +++ b/fs/dax.c
> @@ -945,8 +945,8 @@ int __dax_pmd_fault(struct vm_area_struct *vma, unsigned long address,
> long length = dax_map_atomic(bdev, &dax);
>
> if (length < 0) {
> - result = VM_FAULT_SIGBUS;
> - goto out;
> + dax_pmd_dbg(&bh, address, "dax-error fallback");
> + goto fallback;
> }
> if (length < PMD_SIZE) {
> dax_pmd_dbg(&bh, address, "dax-length too small");
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Jeff Moyer <jmoyer@redhat.com>
To: Vishal Verma <vishal.l.verma@intel.com>
Cc: Christoph Hellwig <hch@infradead.org>, Jan Kara <jack@suse.cz>,
linux-nvdimm@ml01.01.org, linux-kernel@vger.kernel.org,
xfs@oss.sgi.com, Jens Axboe <axboe@fb.com>,
linux-mm@kvack.org, linux-block@vger.kernel.org,
Matthew Wilcox <matthew.r.wilcox@intel.com>,
linux-fsdevel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
linux-ext4@vger.kernel.org, Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH v2 2/5] dax: fallback from pmd to pte on error
Date: Fri, 15 Apr 2016 10:55:43 -0400 [thread overview]
Message-ID: <x497ffy7wgg.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <1459303190-20072-3-git-send-email-vishal.l.verma@intel.com> (Vishal Verma's message of "Tue, 29 Mar 2016 19:59:47 -0600")
Vishal Verma <vishal.l.verma@intel.com> writes:
> From: Dan Williams <dan.j.williams@intel.com>
>
> In preparation for consulting a badblocks list in pmem_direct_access(),
> teach dax_pmd_fault() to fallback rather than fail immediately upon
> encountering an error. The thought being that reducing the span of the
> dax request may avoid the error region.
>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Reviewed-by: Jeff Moyer <jmoyer@redhat.com>
> ---
> fs/dax.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/dax.c b/fs/dax.c
> index 90322eb..ec6417b 100644
> --- a/fs/dax.c
> +++ b/fs/dax.c
> @@ -945,8 +945,8 @@ int __dax_pmd_fault(struct vm_area_struct *vma, unsigned long address,
> long length = dax_map_atomic(bdev, &dax);
>
> if (length < 0) {
> - result = VM_FAULT_SIGBUS;
> - goto out;
> + dax_pmd_dbg(&bh, address, "dax-error fallback");
> + goto fallback;
> }
> if (length < PMD_SIZE) {
> dax_pmd_dbg(&bh, address, "dax-length too small");
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2016-04-15 14:55 UTC|newest]
Thread overview: 216+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-30 1:59 [PATCH v2 0/5] dax: handling of media errors Vishal Verma
2016-03-30 1:59 ` Vishal Verma
2016-03-30 1:59 ` Vishal Verma
2016-03-30 1:59 ` Vishal Verma
2016-03-30 1:59 ` [PATCH v2 1/5] block, dax: pass blk_dax_ctl through to drivers Vishal Verma
2016-03-30 1:59 ` Vishal Verma
2016-03-30 1:59 ` Vishal Verma
2016-03-30 1:59 ` Vishal Verma
2016-03-30 4:19 ` kbuild test robot
2016-03-30 4:19 ` kbuild test robot
2016-03-30 4:19 ` kbuild test robot
2016-03-30 4:19 ` kbuild test robot
2016-04-15 14:55 ` Jeff Moyer
2016-04-15 14:55 ` Jeff Moyer
2016-04-15 14:55 ` Jeff Moyer
2016-03-30 1:59 ` [PATCH v2 2/5] dax: fallback from pmd to pte on error Vishal Verma
2016-03-30 1:59 ` Vishal Verma
2016-03-30 1:59 ` Vishal Verma
2016-03-30 1:59 ` Vishal Verma
2016-03-30 1:59 ` Vishal Verma
2016-04-15 14:55 ` Jeff Moyer [this message]
2016-04-15 14:55 ` Jeff Moyer
2016-04-15 14:55 ` Jeff Moyer
2016-03-30 1:59 ` [PATCH v2 3/5] dax: enable dax in the presence of known media errors (badblocks) Vishal Verma
2016-03-30 1:59 ` Vishal Verma
2016-03-30 1:59 ` Vishal Verma
2016-03-30 1:59 ` Vishal Verma
2016-04-15 14:56 ` Jeff Moyer
2016-04-15 14:56 ` Jeff Moyer
2016-04-15 14:56 ` Jeff Moyer
2016-03-30 1:59 ` [PATCH v2 4/5] dax: use sb_issue_zerout instead of calling dax_clear_sectors Vishal Verma
2016-03-30 1:59 ` Vishal Verma
2016-03-30 1:59 ` Vishal Verma
2016-03-30 1:59 ` Vishal Verma
2016-04-15 15:18 ` Jeff Moyer
2016-04-15 15:18 ` Jeff Moyer
2016-04-15 15:18 ` Jeff Moyer
2016-03-30 1:59 ` [PATCH v2 5/5] dax: handle media errors in dax_do_io Vishal Verma
2016-03-30 1:59 ` Vishal Verma
2016-03-30 1:59 ` Vishal Verma
2016-03-30 1:59 ` Vishal Verma
2016-03-30 3:00 ` kbuild test robot
2016-03-30 3:00 ` kbuild test robot
2016-03-30 3:00 ` kbuild test robot
2016-03-30 3:00 ` kbuild test robot
2016-03-30 3:00 ` kbuild test robot
2016-03-30 3:00 ` kbuild test robot
2016-03-30 6:34 ` Christoph Hellwig
2016-03-30 6:34 ` Christoph Hellwig
2016-03-30 6:34 ` Christoph Hellwig
2016-03-30 6:54 ` Vishal Verma
2016-03-30 6:54 ` Vishal Verma
2016-03-30 6:54 ` Vishal Verma
2016-03-30 6:56 ` Christoph Hellwig
2016-03-30 6:56 ` Christoph Hellwig
2016-03-30 6:56 ` Christoph Hellwig
2016-04-15 16:11 ` Jeff Moyer
2016-04-15 16:11 ` Jeff Moyer
2016-04-15 16:11 ` Jeff Moyer
2016-04-15 16:54 ` Verma, Vishal L
2016-04-15 16:54 ` Verma, Vishal L
2016-04-15 16:54 ` Verma, Vishal L
2016-04-15 17:11 ` Jeff Moyer
2016-04-15 17:11 ` Jeff Moyer
2016-04-15 17:11 ` Jeff Moyer
2016-04-15 17:11 ` Jeff Moyer
2016-04-15 17:37 ` Verma, Vishal L
2016-04-15 17:37 ` Verma, Vishal L
2016-04-15 17:57 ` Dan Williams
2016-04-15 17:57 ` Dan Williams
2016-04-15 17:57 ` Dan Williams
2016-04-15 18:06 ` Jeff Moyer
2016-04-15 18:06 ` Jeff Moyer
2016-04-15 18:06 ` Jeff Moyer
2016-04-15 18:06 ` Jeff Moyer
2016-04-15 18:17 ` Dan Williams
2016-04-15 18:17 ` Dan Williams
2016-04-15 18:17 ` Dan Williams
2016-04-15 18:24 ` Jeff Moyer
2016-04-15 18:24 ` Jeff Moyer
2016-04-15 18:24 ` Jeff Moyer
2016-04-15 18:24 ` Jeff Moyer
2016-04-15 18:56 ` Dan Williams
2016-04-15 18:56 ` Dan Williams
2016-04-15 18:56 ` Dan Williams
2016-04-15 19:13 ` Jeff Moyer
2016-04-15 19:13 ` Jeff Moyer
2016-04-15 19:13 ` Jeff Moyer
2016-04-15 19:13 ` Jeff Moyer
2016-04-15 19:01 ` Toshi Kani
2016-04-15 19:01 ` Toshi Kani
2016-04-15 19:01 ` Toshi Kani
2016-04-15 19:01 ` Toshi Kani
2016-04-15 19:08 ` Toshi Kani
2016-04-15 19:08 ` Toshi Kani
2016-04-15 19:08 ` Toshi Kani
2016-04-15 19:08 ` Toshi Kani
2016-04-20 20:59 ` Christoph Hellwig
2016-04-20 20:59 ` Christoph Hellwig
2016-04-20 20:59 ` Christoph Hellwig
2016-04-23 18:08 ` Verma, Vishal L
2016-04-23 18:08 ` Verma, Vishal L
2016-04-25 8:31 ` hch
2016-04-25 8:31 ` hch
2016-04-25 8:31 ` hch
2016-04-25 15:32 ` Jeff Moyer
2016-04-25 15:32 ` Jeff Moyer
2016-04-25 15:32 ` Jeff Moyer
2016-04-25 15:32 ` Jeff Moyer
2016-04-26 8:32 ` hch
2016-04-26 8:32 ` hch
2016-04-26 8:32 ` hch
2016-04-25 17:14 ` Verma, Vishal L
2016-04-25 17:14 ` Verma, Vishal L
2016-04-25 17:21 ` Dan Williams
2016-04-25 17:21 ` Dan Williams
2016-04-25 17:21 ` Dan Williams
2016-04-25 23:25 ` Dave Chinner
2016-04-25 23:25 ` Dave Chinner
2016-04-25 23:25 ` Dave Chinner
2016-04-25 23:25 ` Dave Chinner
2016-04-25 23:25 ` Dave Chinner
2016-04-25 23:34 ` Darrick J. Wong
2016-04-25 23:34 ` Darrick J. Wong
2016-04-25 23:34 ` Darrick J. Wong
2016-04-25 23:34 ` Darrick J. Wong
2016-04-25 23:34 ` Darrick J. Wong
2016-04-25 23:43 ` Dan Williams
2016-04-25 23:43 ` Dan Williams
2016-04-25 23:43 ` Dan Williams
2016-04-26 0:11 ` Dave Chinner
2016-04-26 0:11 ` Dave Chinner
2016-04-26 0:11 ` Dave Chinner
2016-04-26 1:45 ` Dan Williams
2016-04-26 1:45 ` Dan Williams
2016-04-26 1:45 ` Dan Williams
2016-04-26 2:56 ` Dave Chinner
2016-04-26 2:56 ` Dave Chinner
2016-04-26 2:56 ` Dave Chinner
2016-04-26 4:18 ` Dan Williams
2016-04-26 4:18 ` Dan Williams
2016-04-26 4:18 ` Dan Williams
2016-04-26 8:27 ` Dave Chinner
2016-04-26 8:27 ` Dave Chinner
2016-04-26 8:27 ` Dave Chinner
2016-04-26 14:59 ` Dan Williams
2016-04-26 14:59 ` Dan Williams
2016-04-26 14:59 ` Dan Williams
2016-04-26 15:31 ` Jan Kara
2016-04-26 15:31 ` Jan Kara
2016-04-26 15:31 ` Jan Kara
2016-04-26 17:16 ` Dan Williams
2016-04-26 17:16 ` Dan Williams
2016-04-26 17:16 ` Dan Williams
2016-04-25 23:53 ` Verma, Vishal L
2016-04-25 23:53 ` Verma, Vishal L
2016-04-25 23:53 ` Verma, Vishal L
2016-04-26 0:41 ` Dave Chinner
2016-04-26 0:41 ` Dave Chinner
2016-04-26 0:41 ` Dave Chinner
2016-04-26 0:41 ` Dave Chinner
2016-04-26 0:41 ` Dave Chinner
2016-04-26 14:58 ` Vishal Verma
2016-04-26 14:58 ` Vishal Verma
2016-04-26 14:58 ` Vishal Verma
2016-04-26 14:58 ` Vishal Verma
2016-05-02 15:18 ` Jeff Moyer
2016-05-02 15:18 ` Jeff Moyer
2016-05-02 15:18 ` Jeff Moyer
2016-05-02 15:18 ` Jeff Moyer
2016-05-02 17:53 ` Dan Williams
2016-05-02 17:53 ` Dan Williams
2016-05-02 17:53 ` Dan Williams
2016-05-03 0:42 ` Dave Chinner
2016-05-03 0:42 ` Dave Chinner
2016-05-03 0:42 ` Dave Chinner
2016-05-03 1:26 ` Rudoff, Andy
2016-05-03 1:26 ` Rudoff, Andy
2016-05-03 2:49 ` Dave Chinner
2016-05-03 2:49 ` Dave Chinner
2016-05-03 2:49 ` Dave Chinner
2016-05-03 18:30 ` Rudoff, Andy
2016-05-03 18:30 ` Rudoff, Andy
2016-05-03 18:30 ` Rudoff, Andy
2016-05-04 1:36 ` Dave Chinner
2016-05-04 1:36 ` Dave Chinner
2016-05-04 1:36 ` Dave Chinner
2016-05-02 23:04 ` Dave Chinner
2016-05-02 23:04 ` Dave Chinner
2016-05-02 23:04 ` Dave Chinner
2016-05-02 23:04 ` Dave Chinner
2016-05-02 23:04 ` Dave Chinner
2016-05-02 23:17 ` Verma, Vishal L
2016-05-02 23:17 ` Verma, Vishal L
2016-05-02 23:25 ` Dan Williams
2016-05-02 23:25 ` Dan Williams
2016-05-02 23:25 ` Dan Williams
2016-05-03 1:51 ` Dave Chinner
2016-05-03 1:51 ` Dave Chinner
2016-05-03 1:51 ` Dave Chinner
2016-05-03 17:28 ` Dan Williams
2016-05-03 17:28 ` Dan Williams
2016-05-03 17:28 ` Dan Williams
2016-05-04 3:18 ` Dave Chinner
2016-05-04 3:18 ` Dave Chinner
2016-05-04 3:18 ` Dave Chinner
2016-05-04 5:05 ` Dan Williams
2016-05-04 5:05 ` Dan Williams
2016-05-04 5:05 ` Dan Williams
2016-04-26 8:33 ` hch
2016-04-26 8:33 ` hch
2016-04-26 8:33 ` hch
2016-04-26 15:01 ` Vishal Verma
2016-04-26 15:01 ` Vishal Verma
2016-04-26 15:01 ` Vishal Verma
2016-04-26 15:01 ` Vishal Verma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=x497ffy7wgg.fsf@segfault.boston.devel.redhat.com \
--to=jmoyer@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=axboe@fb.com \
--cc=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=linux-block@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@ml01.01.org \
--cc=matthew.r.wilcox@intel.com \
--cc=viro@zeniv.linux.org.uk \
--cc=vishal.l.verma@intel.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.