From: Dave Martin <Dave.Martin@arm.com> To: linux-arm-kernel@lists.infradead.org Cc: "Catalin Marinas" <catalin.marinas@arm.com>, "Will Deacon" <will.deacon@arm.com>, "Ard Biesheuvel" <ard.biesheuvel@linaro.org>, "Alex Bennée" <alex.bennee@linaro.org>, "Szabolcs Nagy" <szabolcs.nagy@arm.com>, "Richard Sandiford" <richard.sandiford@arm.com>, kvmarm@lists.cs.columbia.edu, libc-alpha@sourceware.org, linux-arch@vger.kernel.org Subject: [PATCH v2 04/28] arm64: Port deprecated instruction emulation to new sysctl interface Date: Thu, 31 Aug 2017 18:00:36 +0100 [thread overview] Message-ID: <1504198860-12951-5-git-send-email-Dave.Martin@arm.com> (raw) In-Reply-To: <1504198860-12951-1-git-send-email-Dave.Martin@arm.com> Currently, armv8_deprected.c takes charge of the "abi" sysctl directory, which makes life difficult for other code that wants to register sysctls in the same directory. There is a "new" [1] sysctl registration interface that removes the need to define ctl_tables for parent directories explicitly, which is ideal here. This patch ports register_insn_emulation_sysctl() over to the register_sysctl() interface and removes the redundant ctl_table for "abi". Signed-off-by: Dave Martin <Dave.Martin@arm.com> Reviewed-by: Alex Bennée <alex.bennee@linaro.org> [1] fea478d4101a (sysctl: Add register_sysctl for normal sysctl users) The commit message notes an intent to port users of the pre-existing interfaces over to register_sysctl(), though the number of users of the new interface currently appears negligible. --- arch/arm64/kernel/armv8_deprecated.c | 15 +++------------ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/arch/arm64/kernel/armv8_deprecated.c b/arch/arm64/kernel/armv8_deprecated.c index f0e6d71..e15eb2d 100644 --- a/arch/arm64/kernel/armv8_deprecated.c +++ b/arch/arm64/kernel/armv8_deprecated.c @@ -228,15 +228,7 @@ static int emulation_proc_handler(struct ctl_table *table, int write, return ret; } -static struct ctl_table ctl_abi[] = { - { - .procname = "abi", - .mode = 0555, - }, - { } -}; - -static void __init register_insn_emulation_sysctl(struct ctl_table *table) +static void __init register_insn_emulation_sysctl(void) { unsigned long flags; int i = 0; @@ -262,8 +254,7 @@ static void __init register_insn_emulation_sysctl(struct ctl_table *table) } raw_spin_unlock_irqrestore(&insn_emulation_lock, flags); - table->child = insns_sysctl; - register_sysctl_table(table); + register_sysctl("abi", insns_sysctl); } /* @@ -644,7 +635,7 @@ static int __init armv8_deprecated_init(void) cpuhp_setup_state_nocalls(CPUHP_AP_ARM64_ISNDEP_STARTING, "arm64/isndep:starting", run_all_insn_set_hw_mode, NULL); - register_insn_emulation_sysctl(ctl_abi); + register_insn_emulation_sysctl(); return 0; } -- 2.1.4
WARNING: multiple messages have this Message-ID (diff)
From: Dave.Martin@arm.com (Dave Martin) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 04/28] arm64: Port deprecated instruction emulation to new sysctl interface Date: Thu, 31 Aug 2017 18:00:36 +0100 [thread overview] Message-ID: <1504198860-12951-5-git-send-email-Dave.Martin@arm.com> (raw) In-Reply-To: <1504198860-12951-1-git-send-email-Dave.Martin@arm.com> Currently, armv8_deprected.c takes charge of the "abi" sysctl directory, which makes life difficult for other code that wants to register sysctls in the same directory. There is a "new" [1] sysctl registration interface that removes the need to define ctl_tables for parent directories explicitly, which is ideal here. This patch ports register_insn_emulation_sysctl() over to the register_sysctl() interface and removes the redundant ctl_table for "abi". Signed-off-by: Dave Martin <Dave.Martin@arm.com> Reviewed-by: Alex Benn?e <alex.bennee@linaro.org> [1] fea478d4101a (sysctl: Add register_sysctl for normal sysctl users) The commit message notes an intent to port users of the pre-existing interfaces over to register_sysctl(), though the number of users of the new interface currently appears negligible. --- arch/arm64/kernel/armv8_deprecated.c | 15 +++------------ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/arch/arm64/kernel/armv8_deprecated.c b/arch/arm64/kernel/armv8_deprecated.c index f0e6d71..e15eb2d 100644 --- a/arch/arm64/kernel/armv8_deprecated.c +++ b/arch/arm64/kernel/armv8_deprecated.c @@ -228,15 +228,7 @@ static int emulation_proc_handler(struct ctl_table *table, int write, return ret; } -static struct ctl_table ctl_abi[] = { - { - .procname = "abi", - .mode = 0555, - }, - { } -}; - -static void __init register_insn_emulation_sysctl(struct ctl_table *table) +static void __init register_insn_emulation_sysctl(void) { unsigned long flags; int i = 0; @@ -262,8 +254,7 @@ static void __init register_insn_emulation_sysctl(struct ctl_table *table) } raw_spin_unlock_irqrestore(&insn_emulation_lock, flags); - table->child = insns_sysctl; - register_sysctl_table(table); + register_sysctl("abi", insns_sysctl); } /* @@ -644,7 +635,7 @@ static int __init armv8_deprecated_init(void) cpuhp_setup_state_nocalls(CPUHP_AP_ARM64_ISNDEP_STARTING, "arm64/isndep:starting", run_all_insn_set_hw_mode, NULL); - register_insn_emulation_sysctl(ctl_abi); + register_insn_emulation_sysctl(); return 0; } -- 2.1.4
next prev parent reply other threads:[~2017-08-31 17:01 UTC|newest] Thread overview: 224+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-08-31 17:00 [PATCH v2 00/28] ARM Scalable Vector Extension (SVE) Dave Martin 2017-08-31 17:00 ` Dave Martin 2017-08-31 17:00 ` [PATCH v2 01/28] regset: Add support for dynamically sized regsets Dave Martin 2017-08-31 17:00 ` Dave Martin 2017-08-31 17:00 ` [PATCH v2 02/28] arm64: KVM: Hide unsupported AArch64 CPU features from guests Dave Martin 2017-08-31 17:00 ` Dave Martin 2017-09-13 14:37 ` Alex Bennée 2017-09-13 14:37 ` Alex Bennée 2017-09-13 14:37 ` Alex Bennée 2017-09-15 0:04 ` Dave Martin 2017-09-15 0:04 ` Dave Martin 2017-08-31 17:00 ` [PATCH v2 03/28] arm64: efi: Add missing Kconfig dependency on KERNEL_MODE_NEON Dave Martin 2017-08-31 17:00 ` Dave Martin 2017-08-31 17:00 ` Dave Martin [this message] 2017-08-31 17:00 ` [PATCH v2 04/28] arm64: Port deprecated instruction emulation to new sysctl interface Dave Martin 2017-08-31 17:00 ` [PATCH v2 05/28] arm64: fpsimd: Simplify uses of {set,clear}_ti_thread_flag() Dave Martin 2017-08-31 17:00 ` [PATCH v2 05/28] arm64: fpsimd: Simplify uses of {set, clear}_ti_thread_flag() Dave Martin 2017-08-31 17:00 ` [PATCH v2 06/28] arm64/sve: System register and exception syndrome definitions Dave Martin 2017-08-31 17:00 ` Dave Martin 2017-09-13 14:48 ` Alex Bennée 2017-09-13 14:48 ` Alex Bennée 2017-09-13 14:48 ` Alex Bennée 2017-08-31 17:00 ` [PATCH v2 07/28] arm64/sve: Low-level SVE architectural state manipulation functions Dave Martin 2017-08-31 17:00 ` Dave Martin 2017-09-13 15:39 ` Alex Bennée 2017-09-13 15:39 ` Alex Bennée 2017-09-13 15:39 ` Alex Bennée 2017-08-31 17:00 ` [PATCH v2 08/28] arm64/sve: Kconfig update and conditional compilation support Dave Martin 2017-08-31 17:00 ` Dave Martin 2017-08-31 17:00 ` [PATCH v2 09/28] arm64/sve: Signal frame and context structure definition Dave Martin 2017-08-31 17:00 ` Dave Martin 2017-09-13 13:36 ` Catalin Marinas 2017-09-13 13:36 ` Catalin Marinas 2017-09-13 21:33 ` Dave Martin 2017-09-13 21:33 ` Dave Martin 2017-08-31 17:00 ` [PATCH v2 10/28] arm64/sve: Low-level CPU setup Dave Martin 2017-08-31 17:00 ` Dave Martin 2017-09-13 13:32 ` Catalin Marinas 2017-09-13 13:32 ` Catalin Marinas 2017-09-13 19:21 ` Dave Martin 2017-09-13 19:21 ` Dave Martin 2017-09-13 19:21 ` Dave Martin 2017-10-05 10:47 ` Dave Martin 2017-10-05 10:47 ` Dave Martin 2017-10-05 11:04 ` Suzuki K Poulose 2017-10-05 11:04 ` Suzuki K Poulose 2017-10-05 11:22 ` Dave Martin 2017-10-05 11:22 ` Dave Martin 2017-08-31 17:00 ` [PATCH v2 11/28] arm64/sve: Core task context handling Dave Martin 2017-08-31 17:00 ` Dave Martin 2017-09-13 14:33 ` Catalin Marinas 2017-09-13 14:33 ` Catalin Marinas 2017-09-14 19:55 ` Dave Martin 2017-09-14 19:55 ` Dave Martin 2017-09-20 13:58 ` Catalin Marinas 2017-09-20 13:58 ` Catalin Marinas 2017-10-03 11:11 ` Dave Martin 2017-10-03 11:11 ` Dave Martin 2017-10-04 17:29 ` Catalin Marinas 2017-10-04 17:29 ` Catalin Marinas 2017-10-03 11:33 ` Dave Martin 2017-10-03 11:33 ` Dave Martin 2017-10-05 11:28 ` Catalin Marinas 2017-10-05 11:28 ` Catalin Marinas 2017-10-06 13:10 ` Dave Martin 2017-10-06 13:10 ` Dave Martin 2017-10-06 13:36 ` Catalin Marinas 2017-10-06 13:36 ` Catalin Marinas 2017-10-06 15:15 ` Dave Martin 2017-10-06 15:15 ` Dave Martin 2017-10-06 15:33 ` Catalin Marinas 2017-10-06 15:33 ` Catalin Marinas 2017-09-13 17:26 ` Catalin Marinas 2017-09-13 17:26 ` Catalin Marinas 2017-09-13 19:17 ` Dave Martin 2017-09-13 19:17 ` Dave Martin 2017-09-13 22:21 ` Catalin Marinas 2017-09-13 22:21 ` Catalin Marinas 2017-09-14 19:40 ` Dave Martin 2017-09-14 19:40 ` Dave Martin 2017-09-19 17:13 ` Catalin Marinas 2017-09-19 17:13 ` Catalin Marinas 2017-08-31 17:00 ` [PATCH v2 12/28] arm64/sve: Support vector length resetting for new processes Dave Martin 2017-08-31 17:00 ` Dave Martin 2017-09-14 8:47 ` Alex Bennée 2017-09-14 8:47 ` Alex Bennée 2017-09-14 8:47 ` Alex Bennée 2017-08-31 17:00 ` [PATCH v2 13/28] arm64/sve: Signal handling support Dave Martin 2017-08-31 17:00 ` Dave Martin 2017-09-14 9:30 ` Alex Bennée 2017-09-14 9:30 ` Alex Bennée 2017-09-14 9:30 ` Alex Bennée 2017-08-31 17:00 ` [PATCH v2 14/28] arm64/sve: Backend logic for setting the vector length Dave Martin 2017-08-31 17:00 ` Dave Martin 2017-09-13 17:29 ` Catalin Marinas 2017-09-13 17:29 ` Catalin Marinas 2017-09-13 19:06 ` Dave Martin 2017-09-13 19:06 ` Dave Martin 2017-09-13 22:11 ` Catalin Marinas 2017-09-13 22:11 ` Catalin Marinas 2017-10-05 16:42 ` Dave Martin 2017-10-05 16:42 ` Dave Martin 2017-10-05 16:53 ` Catalin Marinas 2017-10-05 16:53 ` Catalin Marinas 2017-10-05 17:04 ` Dave Martin 2017-10-05 17:04 ` Dave Martin 2017-09-20 10:57 ` Alan Hayward 2017-09-20 10:57 ` Alan Hayward 2017-09-20 10:59 ` Alan Hayward 2017-09-20 10:59 ` Alan Hayward 2017-09-20 11:09 ` Dave Martin 2017-09-20 11:09 ` Dave Martin 2017-09-20 18:08 ` Alan Hayward 2017-09-20 18:08 ` Alan Hayward 2017-09-21 11:19 ` Dave Martin 2017-09-21 11:19 ` Dave Martin 2017-09-21 11:57 ` Alan Hayward 2017-09-21 11:57 ` Alan Hayward 2017-08-31 17:00 ` [PATCH v2 15/28] arm64: cpufeature: Move sys_caps_initialised declarations Dave Martin 2017-08-31 17:00 ` Dave Martin 2017-09-14 9:33 ` Alex Bennée 2017-09-14 9:33 ` Alex Bennée 2017-09-14 9:33 ` Alex Bennée 2017-09-14 9:35 ` Suzuki K Poulose 2017-09-14 9:35 ` Suzuki K Poulose 2017-08-31 17:00 ` [PATCH v2 16/28] arm64/sve: Probe SVE capabilities and usable vector lengths Dave Martin 2017-08-31 17:00 ` Dave Martin 2017-09-14 9:45 ` Alex Bennée 2017-09-14 9:45 ` Alex Bennée 2017-09-14 9:45 ` Alex Bennée 2017-09-28 14:22 ` Dave Martin 2017-09-28 14:22 ` Dave Martin 2017-09-28 17:32 ` Alex Bennée 2017-09-28 17:32 ` Alex Bennée 2017-09-28 17:32 ` Alex Bennée 2017-08-31 17:00 ` [PATCH v2 17/28] arm64/sve: Preserve SVE registers around kernel-mode NEON use Dave Martin 2017-08-31 17:00 ` Dave Martin 2017-09-14 10:52 ` Alex Bennée 2017-09-14 10:52 ` Alex Bennée 2017-09-14 10:52 ` Alex Bennée 2017-08-31 17:00 ` [PATCH v2 18/28] arm64/sve: Preserve SVE registers around EFI runtime service calls Dave Martin 2017-08-31 17:00 ` Dave Martin 2017-08-31 17:00 ` Dave Martin 2017-09-14 11:01 ` Alex Bennée 2017-09-14 11:01 ` Alex Bennée 2017-09-14 11:01 ` Alex Bennée 2017-08-31 17:00 ` [PATCH v2 19/28] arm64/sve: ptrace and ELF coredump support Dave Martin 2017-08-31 17:00 ` Dave Martin 2017-09-06 16:21 ` Okamoto, Takayuki 2017-09-06 16:21 ` Okamoto, Takayuki 2017-09-06 18:16 ` Dave Martin 2017-09-06 18:16 ` Dave Martin 2017-09-07 5:11 ` Okamoto, Takayuki 2017-09-07 5:11 ` Okamoto, Takayuki 2017-09-07 5:11 ` Okamoto, Takayuki 2017-09-08 13:11 ` Dave Martin 2017-09-08 13:11 ` Dave Martin 2017-09-14 12:57 ` Alex Bennée 2017-09-14 12:57 ` Alex Bennée 2017-09-14 12:57 ` Alex Bennée 2017-09-28 14:57 ` Dave Martin 2017-09-28 14:57 ` Dave Martin 2017-09-29 12:46 ` Dave Martin 2017-09-29 12:46 ` Dave Martin 2017-08-31 17:00 ` [PATCH v2 20/28] arm64/sve: Add prctl controls for userspace vector length management Dave Martin 2017-08-31 17:00 ` Dave Martin 2017-09-14 13:02 ` Alex Bennée 2017-09-14 13:02 ` Alex Bennée 2017-09-14 13:02 ` Alex Bennée 2017-08-31 17:00 ` [PATCH v2 21/28] arm64/sve: Add sysctl to set the default vector length for new processes Dave Martin 2017-08-31 17:00 ` Dave Martin 2017-09-14 13:05 ` Alex Bennée 2017-09-14 13:05 ` Alex Bennée 2017-09-14 13:05 ` Alex Bennée 2017-08-31 17:00 ` [PATCH v2 22/28] arm64/sve: KVM: Prevent guests from using SVE Dave Martin 2017-08-31 17:00 ` Dave Martin 2017-09-14 13:28 ` Alex Bennée 2017-09-14 13:28 ` Alex Bennée 2017-09-14 13:28 ` Alex Bennée 2017-08-31 17:00 ` [PATCH v2 23/28] arm64/sve: KVM: Treat guest SVE use as undefined instruction execution Dave Martin 2017-08-31 17:00 ` Dave Martin 2017-09-14 13:30 ` Alex Bennée 2017-09-14 13:30 ` Alex Bennée 2017-09-14 13:30 ` Alex Bennée 2017-09-14 13:31 ` Alex Bennée 2017-09-14 13:31 ` Alex Bennée 2017-09-14 13:31 ` Alex Bennée 2017-09-29 13:00 ` Dave Martin 2017-09-29 13:00 ` Dave Martin 2017-09-29 14:43 ` Alex Bennée 2017-09-29 14:43 ` Alex Bennée 2017-09-29 14:43 ` Alex Bennée 2017-08-31 17:00 ` [PATCH v2 24/28] arm64/sve: KVM: Hide SVE from CPU features exposed to guests Dave Martin 2017-08-31 17:00 ` Dave Martin 2017-09-14 13:32 ` Alex Bennée 2017-09-14 13:32 ` Alex Bennée 2017-09-14 13:32 ` Alex Bennée 2017-08-31 17:00 ` [PATCH v2 25/28] arm64/sve: Detect SVE and activate runtime support Dave Martin 2017-08-31 17:00 ` Dave Martin 2017-08-31 17:00 ` [PATCH v2 26/28] arm64/sve: Add documentation Dave Martin 2017-08-31 17:00 ` Dave Martin 2017-10-05 16:39 ` Szabolcs Nagy 2017-10-05 16:39 ` Szabolcs Nagy 2017-10-05 17:02 ` Dave Martin 2017-10-05 17:02 ` Dave Martin 2017-10-06 15:43 ` Szabolcs Nagy 2017-10-06 15:43 ` Szabolcs Nagy 2017-10-06 17:37 ` Dave Martin 2017-10-06 17:37 ` Dave Martin 2017-10-09 9:34 ` Alex Bennée 2017-10-09 9:34 ` Alex Bennée 2017-10-09 9:34 ` Alex Bennée 2017-10-09 9:49 ` Dave Martin 2017-10-09 9:49 ` Dave Martin 2017-10-09 14:07 ` Alex Bennée 2017-10-09 14:07 ` Alex Bennée 2017-10-09 14:07 ` Alex Bennée 2017-10-09 16:20 ` Dave Martin 2017-10-09 16:20 ` Dave Martin 2017-08-31 17:00 ` [RFC PATCH v2 27/28] arm64: signal: Report signal frame size to userspace via auxv Dave Martin 2017-08-31 17:00 ` Dave Martin 2017-08-31 17:00 ` Dave Martin 2017-08-31 17:01 ` [RFC PATCH v2 28/28] arm64/sve: signal: Include SVE when computing AT_MINSIGSTKSZ Dave Martin 2017-08-31 17:01 ` Dave Martin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1504198860-12951-5-git-send-email-Dave.Martin@arm.com \ --to=dave.martin@arm.com \ --cc=alex.bennee@linaro.org \ --cc=ard.biesheuvel@linaro.org \ --cc=catalin.marinas@arm.com \ --cc=kvmarm@lists.cs.columbia.edu \ --cc=libc-alpha@sourceware.org \ --cc=linux-arch@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=richard.sandiford@arm.com \ --cc=szabolcs.nagy@arm.com \ --cc=will.deacon@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.