From: Andrew Murray <andrew.murray@arm.com>
To: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Will Deacon <will.deacon@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Thomas Gleixner <tglx@linutronix.de>,
Borislav Petkov <bp@alien8.de>,
x86@kernel.org
Cc: linux-alpha@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 00/10] perf/core: Generalise event exclusion checking
Date: Fri, 16 Nov 2018 10:24:03 +0000 [thread overview]
Message-ID: <1542363853-13849-1-git-send-email-andrew.murray@arm.com> (raw)
Many PMU drivers do not have the capability to exclude counting events
that occur in specific contexts such as idle, kernel, guest, etc. These
drivers indicate this by returning an error in their event_init upon
testing the events attribute flags.
However this approach requires that each time a new event modifier is
added to perf, all the perf drivers need to be modified to indicate that
they don't support the attribute. This results in additional boiler-plate
code common to many drivers that needs to be maintained. An example of
this is the addition of exclude_host and exclude_guest in 2011 yet many
PMU drivers do not support this or indicate an error on events that make
use of it.
This patch generalises the test for exclusion and updates PMU drivers to
use it. This is a functional change as some PMU drivers will now correctly
report that they don't support certain events whereas they previously did.
An alternative approach might have been to provide a static perf_event_attr
with exclusion events set such that each PMU driver could compare against
(see ref [1]) - however this is less readable. A longer term approach may
instead be for PMU's to advertise their capabilities on registration.
All drivers touched by this patchset have been compile tested.
[1] https://lore.kernel.org/patchwork/patch/325116/
~
Andrew Murray (10):
perf/core: Add macro to test for event exclusion flags
arm: perf/core: generalise event exclusion checking with perf macro
arm: perf: add additional validation to set_event_filter
powerpc: perf/core: generalise event exclusion checking with perf
macro
powerpc/pmu/fsl: add additional validation to event_init
alpha: perf/core: generalise event exclusion checking with perf macro
x86: perf/core: generalise event exclusion checking with perf macro
perf/core: Remove unused perf_flags
drivers/perf: perf/core: generalise event exclusion checking with perf
macro
perf/doc: update design.txt for exclude_{host|guest} flags
arch/alpha/kernel/perf_event.c | 4 +---
arch/arm/kernel/perf_event_v7.c | 2 ++
arch/arm/mach-imx/mmdc.c | 8 +-------
arch/arm/mm/cache-l2x0-pmu.c | 7 +------
arch/powerpc/perf/core-fsl-emb.c | 2 ++
arch/powerpc/perf/hv-24x7.c | 7 +------
arch/powerpc/perf/hv-gpci.c | 7 +------
arch/powerpc/perf/imc-pmu.c | 14 ++------------
arch/x86/events/amd/ibs.c | 11 +----------
arch/x86/events/amd/iommu.c | 3 +--
arch/x86/events/amd/power.c | 8 +-------
arch/x86/events/amd/uncore.c | 3 +--
arch/x86/events/intel/cstate.c | 7 +------
arch/x86/events/intel/rapl.c | 7 +------
arch/x86/events/intel/uncore.c | 3 +--
arch/x86/events/intel/uncore_snb.c | 7 +------
arch/x86/events/msr.c | 7 +------
drivers/perf/arm-cci.c | 7 +------
drivers/perf/arm-ccn.c | 5 +----
drivers/perf/arm_dsu_pmu.c | 7 +------
drivers/perf/arm_pmu.c | 9 +--------
drivers/perf/hisilicon/hisi_uncore_pmu.c | 7 +------
drivers/perf/qcom_l2_pmu.c | 3 +--
drivers/perf/qcom_l3_pmu.c | 3 +--
drivers/perf/xgene_pmu.c | 3 +--
include/linux/perf_event.h | 9 +++++++++
include/uapi/linux/perf_event.h | 2 --
tools/include/uapi/linux/perf_event.h | 2 --
tools/perf/design.txt | 4 ++++
29 files changed, 41 insertions(+), 127 deletions(-)
--
2.7.4
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Murray <andrew.murray@arm.com>
To: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Will Deacon <will.deacon@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Thomas Gleixner <tglx@linutronix.de>,
Borislav Petkov <bp@alien8.de>,
x86@kernel.org
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-alpha@vger.kernel.org
Subject: [PATCH 00/10] perf/core: Generalise event exclusion checking
Date: Fri, 16 Nov 2018 10:24:03 +0000 [thread overview]
Message-ID: <1542363853-13849-1-git-send-email-andrew.murray@arm.com> (raw)
Many PMU drivers do not have the capability to exclude counting events
that occur in specific contexts such as idle, kernel, guest, etc. These
drivers indicate this by returning an error in their event_init upon
testing the events attribute flags.
However this approach requires that each time a new event modifier is
added to perf, all the perf drivers need to be modified to indicate that
they don't support the attribute. This results in additional boiler-plate
code common to many drivers that needs to be maintained. An example of
this is the addition of exclude_host and exclude_guest in 2011 yet many
PMU drivers do not support this or indicate an error on events that make
use of it.
This patch generalises the test for exclusion and updates PMU drivers to
use it. This is a functional change as some PMU drivers will now correctly
report that they don't support certain events whereas they previously did.
An alternative approach might have been to provide a static perf_event_attr
with exclusion events set such that each PMU driver could compare against
(see ref [1]) - however this is less readable. A longer term approach may
instead be for PMU's to advertise their capabilities on registration.
All drivers touched by this patchset have been compile tested.
[1] https://lore.kernel.org/patchwork/patch/325116/
~
Andrew Murray (10):
perf/core: Add macro to test for event exclusion flags
arm: perf/core: generalise event exclusion checking with perf macro
arm: perf: add additional validation to set_event_filter
powerpc: perf/core: generalise event exclusion checking with perf
macro
powerpc/pmu/fsl: add additional validation to event_init
alpha: perf/core: generalise event exclusion checking with perf macro
x86: perf/core: generalise event exclusion checking with perf macro
perf/core: Remove unused perf_flags
drivers/perf: perf/core: generalise event exclusion checking with perf
macro
perf/doc: update design.txt for exclude_{host|guest} flags
arch/alpha/kernel/perf_event.c | 4 +---
arch/arm/kernel/perf_event_v7.c | 2 ++
arch/arm/mach-imx/mmdc.c | 8 +-------
arch/arm/mm/cache-l2x0-pmu.c | 7 +------
arch/powerpc/perf/core-fsl-emb.c | 2 ++
arch/powerpc/perf/hv-24x7.c | 7 +------
arch/powerpc/perf/hv-gpci.c | 7 +------
arch/powerpc/perf/imc-pmu.c | 14 ++------------
arch/x86/events/amd/ibs.c | 11 +----------
arch/x86/events/amd/iommu.c | 3 +--
arch/x86/events/amd/power.c | 8 +-------
arch/x86/events/amd/uncore.c | 3 +--
arch/x86/events/intel/cstate.c | 7 +------
arch/x86/events/intel/rapl.c | 7 +------
arch/x86/events/intel/uncore.c | 3 +--
arch/x86/events/intel/uncore_snb.c | 7 +------
arch/x86/events/msr.c | 7 +------
drivers/perf/arm-cci.c | 7 +------
drivers/perf/arm-ccn.c | 5 +----
drivers/perf/arm_dsu_pmu.c | 7 +------
drivers/perf/arm_pmu.c | 9 +--------
drivers/perf/hisilicon/hisi_uncore_pmu.c | 7 +------
drivers/perf/qcom_l2_pmu.c | 3 +--
drivers/perf/qcom_l3_pmu.c | 3 +--
drivers/perf/xgene_pmu.c | 3 +--
include/linux/perf_event.h | 9 +++++++++
include/uapi/linux/perf_event.h | 2 --
tools/include/uapi/linux/perf_event.h | 2 --
tools/perf/design.txt | 4 ++++
29 files changed, 41 insertions(+), 127 deletions(-)
--
2.7.4
WARNING: multiple messages have this Message-ID (diff)
From: andrew.murray@arm.com (Andrew Murray)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 00/10] perf/core: Generalise event exclusion checking
Date: Fri, 16 Nov 2018 10:24:03 +0000 [thread overview]
Message-ID: <1542363853-13849-1-git-send-email-andrew.murray@arm.com> (raw)
Many PMU drivers do not have the capability to exclude counting events
that occur in specific contexts such as idle, kernel, guest, etc. These
drivers indicate this by returning an error in their event_init upon
testing the events attribute flags.
However this approach requires that each time a new event modifier is
added to perf, all the perf drivers need to be modified to indicate that
they don't support the attribute. This results in additional boiler-plate
code common to many drivers that needs to be maintained. An example of
this is the addition of exclude_host and exclude_guest in 2011 yet many
PMU drivers do not support this or indicate an error on events that make
use of it.
This patch generalises the test for exclusion and updates PMU drivers to
use it. This is a functional change as some PMU drivers will now correctly
report that they don't support certain events whereas they previously did.
An alternative approach might have been to provide a static perf_event_attr
with exclusion events set such that each PMU driver could compare against
(see ref [1]) - however this is less readable. A longer term approach may
instead be for PMU's to advertise their capabilities on registration.
All drivers touched by this patchset have been compile tested.
[1] https://lore.kernel.org/patchwork/patch/325116/
~
Andrew Murray (10):
perf/core: Add macro to test for event exclusion flags
arm: perf/core: generalise event exclusion checking with perf macro
arm: perf: add additional validation to set_event_filter
powerpc: perf/core: generalise event exclusion checking with perf
macro
powerpc/pmu/fsl: add additional validation to event_init
alpha: perf/core: generalise event exclusion checking with perf macro
x86: perf/core: generalise event exclusion checking with perf macro
perf/core: Remove unused perf_flags
drivers/perf: perf/core: generalise event exclusion checking with perf
macro
perf/doc: update design.txt for exclude_{host|guest} flags
arch/alpha/kernel/perf_event.c | 4 +---
arch/arm/kernel/perf_event_v7.c | 2 ++
arch/arm/mach-imx/mmdc.c | 8 +-------
arch/arm/mm/cache-l2x0-pmu.c | 7 +------
arch/powerpc/perf/core-fsl-emb.c | 2 ++
arch/powerpc/perf/hv-24x7.c | 7 +------
arch/powerpc/perf/hv-gpci.c | 7 +------
arch/powerpc/perf/imc-pmu.c | 14 ++------------
arch/x86/events/amd/ibs.c | 11 +----------
arch/x86/events/amd/iommu.c | 3 +--
arch/x86/events/amd/power.c | 8 +-------
arch/x86/events/amd/uncore.c | 3 +--
arch/x86/events/intel/cstate.c | 7 +------
arch/x86/events/intel/rapl.c | 7 +------
arch/x86/events/intel/uncore.c | 3 +--
arch/x86/events/intel/uncore_snb.c | 7 +------
arch/x86/events/msr.c | 7 +------
drivers/perf/arm-cci.c | 7 +------
drivers/perf/arm-ccn.c | 5 +----
drivers/perf/arm_dsu_pmu.c | 7 +------
drivers/perf/arm_pmu.c | 9 +--------
drivers/perf/hisilicon/hisi_uncore_pmu.c | 7 +------
drivers/perf/qcom_l2_pmu.c | 3 +--
drivers/perf/qcom_l3_pmu.c | 3 +--
drivers/perf/xgene_pmu.c | 3 +--
include/linux/perf_event.h | 9 +++++++++
include/uapi/linux/perf_event.h | 2 --
tools/include/uapi/linux/perf_event.h | 2 --
tools/perf/design.txt | 4 ++++
29 files changed, 41 insertions(+), 127 deletions(-)
--
2.7.4
next reply other threads:[~2018-11-16 10:24 UTC|newest]
Thread overview: 92+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-16 10:24 Andrew Murray [this message]
2018-11-16 10:24 ` [PATCH 00/10] perf/core: Generalise event exclusion checking Andrew Murray
2018-11-16 10:24 ` Andrew Murray
2018-11-16 10:24 ` [PATCH 01/10] perf/core: Add macro to test for event exclusion flags Andrew Murray
2018-11-16 10:24 ` Andrew Murray
2018-11-16 10:24 ` Andrew Murray
2018-11-19 12:58 ` Peter Zijlstra
2018-11-19 12:58 ` Peter Zijlstra
2018-11-19 12:58 ` Peter Zijlstra
2018-11-19 12:58 ` Peter Zijlstra
2018-11-19 16:01 ` Mark Rutland
2018-11-19 16:01 ` Mark Rutland
2018-11-19 16:01 ` Mark Rutland
2018-11-20 11:28 ` Michael Ellerman
2018-11-20 11:28 ` Michael Ellerman
2018-11-20 11:28 ` Michael Ellerman
2018-11-23 14:32 ` Andrew Murray
2018-11-23 14:32 ` Andrew Murray
2018-11-23 14:32 ` Andrew Murray
2018-11-16 10:24 ` [PATCH 02/10] arm: perf/core: generalise event exclusion checking with perf macro Andrew Murray
2018-11-16 10:24 ` Andrew Murray
2018-11-16 10:24 ` Andrew Murray
2018-11-16 10:24 ` [PATCH 03/10] arm: perf: add additional validation to set_event_filter Andrew Murray
2018-11-16 10:24 ` Andrew Murray
2018-11-16 10:24 ` Andrew Murray
2018-11-16 10:24 ` [PATCH 04/10] powerpc: perf/core: generalise event exclusion checking with perf macro Andrew Murray
2018-11-16 10:24 ` Andrew Murray
2018-11-16 10:24 ` Andrew Murray
2018-11-20 11:21 ` Michael Ellerman
2018-11-20 11:21 ` Michael Ellerman
2018-11-20 11:21 ` Michael Ellerman
2018-11-16 10:24 ` [PATCH 05/10] powerpc/pmu/fsl: add additional validation to event_init Andrew Murray
2018-11-16 10:24 ` Andrew Murray
2018-11-16 10:24 ` Andrew Murray
2018-11-16 10:24 ` [PATCH 06/10] alpha: perf/core: generalise event exclusion checking with perf macro Andrew Murray
2018-11-16 10:24 ` Andrew Murray
2018-11-16 10:24 ` Andrew Murray
2018-11-16 10:24 ` [PATCH 07/10] x86: " Andrew Murray
2018-11-16 10:24 ` Andrew Murray
2018-11-16 10:24 ` Andrew Murray
2018-11-16 10:24 ` [PATCH 08/10] perf/core: Remove unused perf_flags Andrew Murray
2018-11-16 10:24 ` Andrew Murray
2018-11-16 10:24 ` Andrew Murray
2018-11-16 10:24 ` [PATCH 09/10] drivers/perf: perf/core: generalise event exclusion checking with perf macro Andrew Murray
2018-11-16 10:24 ` Andrew Murray
2018-11-16 10:24 ` Andrew Murray
2018-11-19 16:03 ` Mark Rutland
2018-11-19 16:03 ` Mark Rutland
2018-11-19 16:03 ` Mark Rutland
2018-11-23 14:31 ` Andrew Murray
2018-11-23 14:31 ` Andrew Murray
2018-11-23 14:31 ` Andrew Murray
2018-11-16 10:24 ` [PATCH 10/10] perf/doc: update design.txt for exclude_{host|guest} flags Andrew Murray
2018-11-16 10:24 ` Andrew Murray
2018-11-16 10:24 ` Andrew Murray
2018-11-20 11:31 ` Michael Ellerman
2018-11-20 11:31 ` Michael Ellerman
2018-11-20 11:31 ` Michael Ellerman
2018-11-20 13:32 ` Andrew Murray
2018-11-20 13:32 ` Andrew Murray
2018-11-20 13:32 ` Andrew Murray
2018-12-11 11:06 ` Michael Ellerman
2018-12-11 11:06 ` Michael Ellerman
2018-12-11 11:06 ` Michael Ellerman
2018-12-11 11:06 ` Michael Ellerman
2018-12-11 13:59 ` Andrew Murray
2018-12-11 13:59 ` Andrew Murray
2018-12-11 13:59 ` Andrew Murray
2018-12-12 4:48 ` Michael Ellerman
2018-12-12 4:48 ` Michael Ellerman
2018-12-12 4:48 ` Michael Ellerman
2018-12-12 4:48 ` Michael Ellerman
2018-12-12 8:07 ` Christoffer Dall
2018-12-12 8:07 ` Christoffer Dall
2018-12-12 8:07 ` Christoffer Dall
2018-12-12 17:08 ` Andrew Murray
2018-12-12 17:08 ` Andrew Murray
2018-12-12 17:08 ` Andrew Murray
2018-11-19 13:08 ` [PATCH 00/10] perf/core: Generalise event exclusion checking Peter Zijlstra
2018-11-19 13:08 ` Peter Zijlstra
2018-11-19 13:08 ` Peter Zijlstra
2018-11-19 13:08 ` Peter Zijlstra
2018-11-22 12:21 ` Andrew Murray
2018-11-22 12:21 ` Andrew Murray
2018-11-22 12:21 ` Andrew Murray
2018-11-22 12:26 ` Peter Zijlstra
2018-11-22 12:26 ` Peter Zijlstra
2018-11-22 12:26 ` Peter Zijlstra
2018-11-22 12:26 ` Peter Zijlstra
2018-11-22 12:59 ` Andrew Murray
2018-11-22 12:59 ` Andrew Murray
2018-11-22 12:59 ` Andrew Murray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1542363853-13849-1-git-send-email-andrew.murray@arm.com \
--to=andrew.murray@arm.com \
--cc=acme@kernel.org \
--cc=benh@kernel.crashing.org \
--cc=bp@alien8.de \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=tglx@linutronix.de \
--cc=will.deacon@arm.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.